Commit Graph

6667 Commits

Author SHA1 Message Date
Vinit Nayak
da9213791e Ensure null elements aren't added to TaskView shortcut list
Bug: 234874147
Change-Id: I5ed84fdc64128264e5808b7d3b019c47e3740469
2022-06-06 09:18:42 -07:00
Jeff Chang
5ee83f3b5e Show split option without consider the "Lock task mode"
wm-core supports split-screen and lock-task mode work together now.
This CL enables the split-option to allow users to enjoy the
split-screen experience.

Bug: 199342537
Test: Options show up as expected
Change-Id: I38f58dec2985eaaabdbed1fdeeeece2d6e59945f
2022-06-06 14:47:47 +08:00
TreeHugger Robot
5b765189e2 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: 774c53f919
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: If494d52f37fd556dca2fd6960bb69490c812e5fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:26:26 +00:00
TreeHugger Robot
c012085c6c Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev 2022-06-04 01:38:29 +00:00
Tony Wickham
8d72018a87 Don't allow swiping to HintState if we're already in HintState
Context: there was a bug where you could get stuck in HintState if you
did the following (timing is critical):
1. Short swipe from nav region towards HintState, but not far enough or
   fast enough to commit before letting go; this cancels the state
   animation, returning towards Normal (but, crucially, StateManager
   still has state set as Hint)
2. While previous animation is animating back to Normal, swipe up again,
   but this time faster/farther to actually reach Hint; this time, the
   animation does go towards Hint, but gets stuck there. The reason it
   gets stuck is because StateManager thinks we're already in Hint from
   step 1, so doesn't call onStateTransitionEnd(Hint) in step 2. Thus,
   we never get QuickstepLauncher#onStateSetEnd(Hint), which is what we
   rely on to return to Normal.

The simple fix is to prevent the second swipe in the first place.

Test: short swipe followed immediately by fast fling from nav region on home successfully stays in Normal state intead of getting stuck in HintState
Test:
NexusLauncherOutOfProcTests: com.google.android.apps.nexuslauncher.TaplTestsNexus
Fixes: 228276181
Change-Id: I54c371c8518a9a220e75c98003331b552d8bf8af
2022-06-03 14:56:04 -07:00
Ats Jenk
e048af300b Merge "Enable bubbles home gesture by default" into tm-qpr-dev 2022-06-03 18:46:20 +00:00
Vinit Nayak
690645b62e Remove old split screen overview related code
Bug: 233006032
Change-Id: I294dcde586da135af3bb33400e65d5f47edca3d8
2022-06-03 16:39:49 +00:00
Ats Jenk
daccf18be1 Enable bubbles home gesture by default
Update feature flag for bubbles home gesture handling to be on by
default.

Bug: 170163464
Test: manually verified that home gesture feature is enabled on a a fresh build
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble
Change-Id: Ie6bdea919dfaf6448b3c57756cd06993a6a60ce7
2022-06-02 17:05:36 -07:00
Jon Miranda
46ecc0ca08 Pause expensive view updates before setting hw/sw layers.
Prevents widgets from updating mid animation.
Also pauses view updates during app close animation.

Bug: 220939231
Bug: 230617085
Bug: 226171754
Test: manual

Change-Id: I0138d57e6a7b2c22fd9a029e971b3e27c7e9f22e
2022-06-02 12:21:01 -07:00
Jerry Chang
202f45166d Fix Flicker of inner corners in split screen when quick switching to
Update divider bar visibility immediately when quick switching to split
pair

Fix: 234609814
Test: manual check quick switch with split pair
Change-Id: I4fc36302763bc0a7de9caca0ab370e3cedc18076
2022-06-02 03:53:19 +00:00
Vinit Nayak
28036435b6 Refactor TaskShortcutFactory to return List of SystemShortcuts
* Remove ENABLE_SPLIT_SELECT feature flag
* Remove unused SystemUiProxy methods

Bug: 233006032
Test: Options show up as expected
Change-Id: I9b98d962db79363a20ad41faa15404f1c156b9ec
2022-06-01 16:27:04 -07:00
Winson Chung
c9e64b3c47 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853 am: 95afbb9982
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I276ce54df65697b0778c29864a8620733b6e0cbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:55:52 +00:00
Winson Chung
238f380853 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev 2022-06-01 22:06:48 +00:00
Luca Zuccarini
728e234120 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: 9e50fc0ade
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: I8cf3773dff04ced9335355f9f99311df1a9bd97f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:17:35 +00:00
Jeremy Sim
0183476559 Merge "Remove deprecated verticalBar layout in Overview" into tm-qpr-dev 2022-06-01 02:55:47 +00:00
Winson Chung
7ca87c785a Ignore pinned tasks for purposes of gesture nav
Bug: 234170890
Test: Enter content pip, swipe up and see if a duplicate stub taskview
      is created
Change-Id: I62a994749fcaeff48901410ede26b848fa15b830
2022-05-31 23:32:26 +00:00
Jeremy Sim
3c2c3f1aea Remove deprecated verticalBar layout in Overview
Removes code that was intended for a now-deprecated layout style in Overview. See ag/18386646 for an example of an issue caused by this.

Bug: 232298587
Test: Manual on 3 devices
Change-Id: Icfd40e1e5a99cf5821b1c46357db58a31daaa835
2022-05-31 22:02:57 +00:00
Luca Zuccarini
a36af25ab7 Remove workspace fade from ALL_APPS > NORMAL transition.
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.

Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
2022-05-31 15:46:28 +00:00
Wei Sheng Shih
4cd75a1aae Merge "Cancel the recents animation for locked gesture[2/2]" into tm-qpr-dev 2022-05-30 01:48:07 +00:00
TreeHugger Robot
db9a5bb80b Merge "Use DeviceProfile.widthPx to initialize Taskbar touchableRegion" into tm-dev am: 192b3c3118 am: a947c74b11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18634727

Change-Id: I9246c6ca0df462853195bf11d29dc210bcc9fa55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-28 00:05:16 +00:00
Alex Chau
4eebbac3b7 Use DeviceProfile.widthPx to initialize Taskbar touchableRegion
- TaskbarDraglayer.width isn't initialize when Taskbar is recreated before layout, so use DeviceProfile.widthPx instead
- Also listen for DeviceProfile change in TaskbarInsetsController to update Taskbar touchableRegion

Fix: 233316713
Test: Switch to 3 button, nav button works. Swtich to gesture nav, taskbar icon can be tapped
Test: Rotate deice, whole Taskbar should still be touchable
Change-Id: I29ff86fd8616a620f98d9b5438cc586bd69fac33
2022-05-27 18:35:26 +01:00
Brian Isganitis
deaf8985f6 Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev 2022-05-27 17:25:16 +00:00
Vinit Nayak
1eb79473aa Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc am: e9e0800fd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508

Change-Id: I7b4afd0d4eae8853e15c06c8f7f6472ef5035bf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 03:29:15 +00:00
Vinit Nayak
e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Andy Wickham
a1ec03bdfe [conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Ic7e380e21342011afcbd1ada0eb453dc83eff4be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 23:31:31 +00:00
Vinit Nayak
f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham
4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brian Isganitis
afd72f0726 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
(cherry picked from commit a9a78117c7)
2022-05-26 17:21:50 +00:00
Alex Chau
56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00
Jeremy Sim
a930633884 Merge "Fix Overview screenshot bug in fake landscape" into tm-qpr-dev 2022-05-26 01:02:20 +00:00
Sunny Goyal
6d6defb472 Merge "Creating the transaction on the UI thread" into tm-dev am: 279911fafc am: f6df7d76ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18591002

Change-Id: I833d70f3d0fa24020ef6eed3394f3c84e6afb5c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 23:11:01 +00:00
Jeremy Sim
aba72f50b9 Fix Overview screenshot bug in fake landscape
Fixes an issue where the user would not be able to take a screenshot through the Overview menu when:
1) the task thumbnail was in LiveTile mode and
2) the phone was in fake landscape.

The issue arose because all Overview menu items, upon selection, were forcing LiveTile to end immediately, even before running the onClick method of each menu item. In the case of screenshots, this resulted in the onClick method being unable to take a screenshot because LiveTile was already ended.

This fix prevents Overview menu items from always forcing LiveTile to end, instead allowing each onClick method to determine its own order of operations and end LiveTile when appropriate. The functionality of all other current menu items (Select, Split, etc) should not be affected by this change.

Fixes: 231047451
Test: Manual
Change-Id: Ibfc79a114718fc4674dc434a907044184c7f5dd0
2022-05-25 15:48:59 -07:00
Sunny Goyal
279911fafc Merge "Creating the transaction on the UI thread" into tm-dev 2022-05-25 22:24:04 +00:00
Brian Isganitis
0bc68242ee Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-qpr-dev 2022-05-25 20:27:21 +00:00
TreeHugger Robot
6687578d1e Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev am: 9557b10c59 am: 60273b856b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18400686

Change-Id: I8a842caecf2b929ddadf765137bf0d36465032c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 19:42:31 +00:00
TreeHugger Robot
9557b10c59 Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev 2022-05-25 18:48:17 +00:00
TreeHugger Robot
8398c12649 Merge "Update vibrations in the All set page to match the SUW welcome page." into tm-qpr-dev 2022-05-25 18:30:06 +00:00
Brian Isganitis
a9a78117c7 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
2022-05-25 18:11:51 +00:00
Vinit Nayak
ac8c6f817b Merge "Hide taskviews when animating to split" into tm-qpr-dev 2022-05-25 17:19:03 +00:00
Schneider Victor-tulias
3efef1ce5a Attempt to preload the Launcher activity when the user reaches the All Set Page.
Preloading the Launcher activity once the user reaches the SUW All Set app allows for a smoother first reveal transition. Refactored TIS and TISBinder to make this possible.

Fixes: 226726244
Test: factory reset and flashed a build onto a pixel 6 pro
Change-Id: I1be3383bafdde17b951329de4c7d6b87affd210c
2022-05-25 10:02:20 -07:00
Alex Chau
e2e1509d55 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869)
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-25 10:53:29 +00:00
wilsonshih
2b06fa518b Cancel the recents animation for locked gesture[2/2]
When device is locked and going to finish the recents animation,
instead of start home activity, calling
finishRunningRecentsAnimation directly so core and shell does not need
to handle another transition.

Bug: 230582311
Test: enable shell transition. Start showWhenLocked activity while
keyguard showing. Scroll up to dismiss the activity and verify the
activity and home shall be stopped and only keyguard remains on the
screen.
Also verify entering recents works fine when device is unlocked.

Change-Id: Ic76f81efcaa8ed00d5af1475259ec16659f6b568
2022-05-25 12:57:32 +08:00
Sunny Goyal
cdc111a158 Creating the transaction on the UI thread
This avoids the error when the transaction is created after
the surface is released. In case the surface is released after
transaction object is created, the apply() call simply ignores
that error, whereas previously the transactionCreation will throw
an error

Bug: 231889963
Test: Verified by manually releasing the surface that there is no crash
Change-Id: I9a4b9ca0be2ed687b2fc692570415256e3e479f7
2022-05-24 17:14:44 -07:00
Andy Wickham
2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Sunny Goyal
51cbd323e2 Merge "Avoiding updating task via scroll if RectF spring animation is running" into tm-dev am: 689b000316 am: 57a956911c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18561212

Change-Id: I63c8780cd914488282f1159037e3d6e31bbd87da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 22:15:02 +00:00
Vinit Nayak
7608cfd628 Hide taskviews when animating to split
* Move FloatingTaskView to drag layer to
keep it from showing up on top of the
TaskMenuView that is animating to a close

Bug: 232804154
Change-Id: Ifaa3286c48509d1f60a559bb4d318988a1d30679
2022-05-24 18:41:42 +00:00
Schneider Victor-tulias
2edbe23513 Update vibrations in the All set page to match the SUW welcome page.
Fixes: 211844049
Test: opened the all set page on different devices, tested with different supported vibration effects
Change-Id: I0b86dae3bec28ff56a3a23f9bb65dcbdb1b27325
2022-05-24 18:30:11 +00:00
Sunny Goyal
4a35dd4f0d Do not launch home disambiguation screen when home is not known
Bug: 233071361
Test: Verified on device
Change-Id: I54e71e19363920b0778c328dc391575d0921f304
2022-05-23 23:30:58 +00:00
Jeremy Sim
b0cce86385 Implement non-disappearing View for split staging instructions
The instructions for how to perform a splitscreen operation, previously conveyed through a disappearing Toast, are now conveyed through a custom View object.

Fixes: 219987907
Test: Manual
Change-Id: Iff2bb6e334e0325e8a091d76a5f9b8767071365f
2022-05-23 21:23:22 +00:00
Sunny Goyal
617f9fae3d Avoiding updating task via scroll if RectF spring animation is running
Bug: 231333965
Test: Verified no update at the end of home transition
Change-Id: I2a106f4d7661f9d409425ce2ed755e74e1abe14b
2022-05-23 10:13:10 -07:00