Commit Graph

2350 Commits

Author SHA1 Message Date
Merissa Mitchell
e7b6888a36 Merge "Move AllAppsButton placement for desktop environment." into tm-qpr-dev 2022-10-26 03:17:01 +00:00
Sunny Goyal
3912808183 Merge "Merging MultiValueAlpha with MultiPropertyFactory" into tm-qpr-dev 2022-10-25 21:39:11 +00:00
Merissa Tan
fcb9cb7664 Move AllAppsButton placement for desktop environment.
On desktop environment, we want the AllAppsButton to be on the left side
of the taskbar instead of the hotseat, but retain the functionality of
the button.

Bug: 251372204
Test: Manual
Change-Id: Ia2c95a20583cb98785ab6f8c719559d93982c06f
2022-10-25 14:26:07 -07:00
Jon Miranda
184a04266d Add transient taskbar UI
This change is only for the visual appearance of the
transient taskbar.

Bug: 252905206
Test: manual
Change-Id: I4990b20b39089a0c27ec2a72dd3010cf64ddba1d
2022-10-25 13:46:19 -07:00
Sihua Ma
4421353ce8 Merge "Get rid of setInteractionHandler call to the host in launcher" into tm-qpr-dev 2022-10-25 02:44:16 +00:00
Sihua Ma
8ca56fe1cd Get rid of setInteractionHandler call to the host in launcher
Bug: 235358918
Test: N/A
Change-Id: I0defac1831825bf0a13a601dd1502b4ca022bc2e
2022-10-24 14:56:11 -07:00
Sunny Goyal
d859060860 Merging MultiValueAlpha with MultiPropertyFactory
Bug: 246644619
Test: Presubmi
Change-Id: Id5abc5f3169544656f1139ae17ca59e34ac65dac
2022-10-24 14:38:18 -07:00
TreeHugger Robot
b9bced07c2 Merge "Removing unnecessary RemoteAnimationTargetCompat" into tm-qpr-dev 2022-10-24 21:32:34 +00:00
Sunny Goyal
8a11443333 Removing unnecessary RemoteAnimationTargetCompat
Merged-In: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
Bug: 221961069
Test: Presubmit
Change-Id: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
2022-10-24 17:17:36 +00:00
Mady Mellor
b5c2565447 Merge "Hide launcher when freeform tasks are visible" into tm-qpr-dev 2022-10-24 16:04:59 +00:00
Vinit Nayak
cb26c1a245 Merge "Use updateButtonLayoutSpacing() for all states" into tm-qpr-dev 2022-10-21 20:32:10 +00:00
Schneider Victor-tulias
ee0bc03d58 Decrease TAPL All Apps scrolling flakiness
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.

Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
2022-10-21 12:12:38 -07:00
Sunny Goyal
415fe0c183 Merge "Optimizing some icon generation code:" into tm-qpr-dev 2022-10-21 18:27:54 +00:00
Mady Mellor
9a90c2d521 Hide launcher when freeform tasks are visible
This CL introduces a new controller to manage the visibility of the
launcher workspace when desktop mode is active and freeform tasks
are visible.

This controller will be notified when the sysui state flag related
to freeform task visibility is changed.

The controller will modify the workspace visibility as well as
the flags on the activity indicating if it's been paused / resumed
based on freeform tasks being visible or not.

Bug: 245569277
Test: manual -  enable desktop mode and open some freeform tasks
             => observe that the contents of launcher is hidden and
                taskbar shows
             -  remove all of the freeform tasks
             => observe that the contents of launcher reappears along
                with the hotseat.
Change-Id: I378ab97b40cbb954a06f4e2426b195efddad905c
2022-10-21 10:06:54 -07:00
Vinit Nayak
2a2fbfe319 Use updateButtonLayoutSpacing() for all states
* During a merge conflict we prevented
updateButtonLayoutSpacing() from running if device was
in setup mode, however the code that does setup layout
is in there.

Fixes: 254589281
Test: Went through setup, back button shows up
where expected

Change-Id: Ib496bfc0e3ac9023a9fc5071867c3779721ab8ab
2022-10-20 23:11:33 -07:00
Sukesh Ram
aee55077cc Fix crash on long press of prediction row icons
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.

Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
Merged-In: I9a4679ba82cacb5e2648481274876dbfc95d80ce
2022-10-20 18:11:15 +00:00
Sunny Goyal
fc1928e324 Optimizing some icon generation code:
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
2022-10-20 10:40:54 -07:00
Thales Lima
a64a914ddf Calculate taskbar content size for edu
Using the value calculated in layout was not working because TaskbarView onLayout() was being called after TaskbarEduView onMeasure(). Now uses the same value on all orientations based on taskbar icon size.

Fixes: 252945031
Test: manual
Change-Id: Ib6914901638c82f3b3ec4c9b86f6c20e84d34d0f
2022-10-20 11:48:06 +01:00
TreeHugger Robot
8a40f0557b Merge "Remove redundant createAdapter override." into tm-qpr-dev 2022-10-20 04:57:15 +00:00
Brian Isganitis
9ca7744877 Remove redundant createAdapter override.
It is the same as ActivityAllAppsContainerView#createAdapter, so it can
be cleaned up.

Test: Manual
Fix: 254545341
Change-Id: Ib23369a53c8c0a1f8f05b671526eb82a07b6f0e3
2022-10-20 00:41:59 +00:00
Sunny Goyal
d79f84fffe Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev 2022-10-20 00:26:13 +00:00
TreeHugger Robot
913b5afb43 Merge "Decouple taskbar background from overveiw scrim if taskbar is in overview" into tm-qpr-dev 2022-10-19 17:18:25 +00:00
Thales Lima
994b181676 Merge "Remove KtR workaround" into tm-qpr-dev 2022-10-19 14:04:48 +00:00
TreeHugger Robot
c9928a1ddf Merge "Implement overlay window for Taskbar EDU and All Apps." into tm-qpr-dev 2022-10-19 14:01:56 +00:00
Sunny Goyal
dd11f089cc Revert "Revert "Using Transaction directly instead of building s..."
Revert^2 "Removing unused surface transaction wrappers"

2460910c8c454bc2d3c9ae35bd32eeb590851788

Bug: 221961069
Test: Presubmit
Change-Id: I0028c9fe0de6fde6a77de84e4858fda14cd578dd
2022-10-18 16:30:26 +00:00
Alex Chau
950a10738b Fix STATE_DEPTH stuck at 1 after setting wallpaper
- Made BaseDepthController.setDepth/mDepth private, all get/set should be done through STATE_DEPTH or WIDGET_DEPTH
- Generified ClampedDepthProperty into Utilities.ClampedProperty to apply on STATE_DEPTH

Bug: 240580498
Test: Go to walppaper&style, set new wallpaper, then go to widget picker, wallpaper depth should transition smoothly
Change-Id: I53cdedf970fd7ffba6a952c4edf4b34251b01f07
2022-10-18 17:07:17 +01:00
Thales Lima
e9d4044483 Remove KtR workaround
Bug: 229947409
Test: m -j128 Launcher3QuickStep Launcher3QuickStepGo Launcher3 Launcher3Go NexusLauncherRelease NexusLauncherDebug SearchLauncherQuickStep SearchLauncher LauncherGoGoogle
Change-Id: I5792cc6b30dfa856747a1576ef3cb195952c25c7
(cherry picked from commit 51e164688e)
Merged-In: I5792cc6b30dfa856747a1576ef3cb195952c25c7
2022-10-18 13:06:23 +00:00
Vinit Nayak
d6c5147524 Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
Merged-In: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-17 13:59:18 -07:00
Brian Isganitis
2d6371aa34 Implement overlay window for Taskbar EDU and All Apps.
Having EDU in the same window as Taskbar causes it to be above All Apps
and other system views such as the notification tray. This change
refactors the existing All Apps window to accomodate more AFVs so that
EDU can also exist in it.

Demo: http://shortn/_Qcki3gwvf7

Test: Manual
Fix: 232177330
Change-Id: I1bef31d798041a90a0c3e033e71be63898fa5fbc
2022-10-14 22:36:14 +00:00
Sebastián Franco
73b8ee9390 Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev 2022-10-14 20:43:34 +00:00
Alex Chau
47a07bc704 Decouple taskbar background from overveiw scrim if taskbar is in overview
- Removed all forceHideBackground calls if taskbar would be in overview
- Make overview scrim transparent regardless of stash state if taskbar would be in overview

Fix: 234139692
Test: Go to overview from app with ENABLE_TASKBAR_IN_OVERVIEW on/off and taskbar stashed/unstashed
Change-Id: I29e811cb93894e6c9e7a75c0ea493719f15eeccb
2022-10-14 17:45:41 +01:00
TreeHugger Robot
a1734ad12e Merge "Update taskbar state when launcher pauses" into tm-qpr-dev 2022-10-14 03:23:40 +00:00
Alex Chau
41ab3f3e14 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev 2022-10-14 00:31:32 +00:00
Evan Rosky
14145d131a Update taskbar state when launcher pauses
With shell-transit, we need to defer updating state when resumed
(until we commit a transient launch state); however, for pause
this isn't necessary. In fact, now that taskbar exists in overview,
we must update state on-pause since the taskbar is no-longer
already-closed.

Bug: 253473765
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep#testOverview
Change-Id: I347da03a211f5b2685f7b18666b2ebb93a1731ef
2022-10-14 00:11:25 +00:00
Nicolò Mazzucato
4afab0b210 Merge "Cancel unfold animation when rotation changes" into tm-qpr-dev 2022-10-13 23:06:50 +00:00
Nicolo' Mazzucato
74c3a0024b Cancel unfold animation when rotation changes
In DeviceFoldStateProvider.kt, FOLD_UPDATE_FINISH_HALF_OPEN is emitted if the rotation changes while the animation is in progress.

 This targets the case when the device goes to tabletop mode during the transition.

+ Using RotationChangeProvider to fix problems when the new orientation change was received in a background thread unexpectedly. This fixes: (1) wrong launcher icons movement after the rotation, and (2) wrong dark overlay scrim after rotation.

+ Minor formattig fixes by ktfmt

Bug: 241743859
Test: DeviceFoldStateProviderTest && NaturalRotationUnfoldProgressProviderTest && manual stress testing
Change-Id: Iee234e4b832cad8298b69356fce7c14d75e89ccc
2022-10-13 09:16:44 +00:00
Alex Chau
38dae63910 Only support manual stashing while in app
- For taskbar in overview, don't allow stashing

Fix: 253042515
Test: With taskbar in overview, long press do nothing. Taskbar is still stashable in app
Test: Without taskbar in overview, taskbar still transform to nav handle in overview
Change-Id: I8f353a473a8570df72acda2338c4b984a69dc5c0
2022-10-12 18:16:50 +01:00
Sebastian Franco
d468299c0f Moving the class LayoutParams to a file outside CellLayout
I'm moving the LayoutParams to another file to start the decoupling
of the Reorder outside of the CellLayout.

Also, I change the name from LayoutParams to LauncherLayoutParams to prevent confusion with ViewGroup.LayoutParams making it explicit that this are different LayoutParams.

Bug: 188081026
Test: atest ReorderWidget
Change-Id: I92251c5540ffcf5ece7b933e6f6c836eb825c997
2022-10-12 16:14:42 +00:00
TreeHugger Robot
5c4b6b50d7 Merge "First pass at Taskbar layout UI polish for SUW" into tm-qpr-dev 2022-10-12 02:27:37 +00:00
Vinit Nayak
2081742cb7 First pass at Taskbar layout UI polish for SUW
Bug: 231906478
Change-Id: I5d55d1e33f928d4b8034c356565a0f9d8bc5c3fb
2022-10-12 00:04:27 +00:00
Alex Chau
0733ebd3c1 Run setCurrentPage in applyLoadPlan after scroll initialized
- Also combined the 2 setCurrentPage call in applyLoadPlan into 1
- Otherwise setCurrentTask may set to page 1 unexpectedly due to page 0's scroll being invalid and out of range

Bug: 246283207
Bug: 238461210
Test: Split screen with 2 apps, click back, go to overview again, should snap to focsued task
Change-Id: I3b57655c810668fe244659437fbd4a745ca02d21
2022-10-11 12:36:35 +01:00
Alex Chau
86924eed57 Merge "Fix taskbar in overview touch and stash behavior" into tm-qpr-dev 2022-10-10 10:02:12 +00:00
Alex Chau
2e72e4cda6 Fix taskbar in overview touch and stash behavior
- When taskbar is unstashed in Launcher (e.g. overview), make the unstashed height touchable
- When AllApps button is pressed in taskbar overview, also stash taskbar

Bug: 245320601
Test: manual
Change-Id: Iadd0bea13cf9a779c68e953d25f21f663c15865a
2022-10-06 21:37:56 +01:00
Pat Manning
24b9554086 Add logging to help debug flake when swiping home to overview.
Bug: 238461210
Bug: 246283207
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: I8ee9af4f4a331c43761ba3738e12acb376ababc2
(cherry picked from commit 1edba8b0a6)
Merged-In: I8ee9af4f4a331c43761ba3738e12acb376ababc2
2022-10-06 15:37:47 +00:00
Saumya Prakash
9860628fcc Merge "Updated overview exit animation for 3 button navigation" into tm-qpr-dev 2022-10-05 22:02:09 +00:00
Alex Chau
72c08d9255 Set controllersInitialized to false when destroying taskbar controllers
Bug: 250912179
Test: presubmit
Change-Id: I16532e99b8f74542def4283b6cc753673eb5ee2d
2022-10-05 15:46:31 +01:00
Thales Lima
9c32f4c7d8 Merge "Change taskbar edu size to wrap around icons" into tm-qpr-dev 2022-10-05 09:39:46 +00:00
Alex Chau
5e47e78a17 Merge "Taskbar in overview" into tm-qpr-dev 2022-10-05 08:58:31 +00:00
Tracy Zhou
d7a7bfc304 Merge "Remove ENABLE_QUICKSTEP_LIVE_TILE flag" into tm-qpr-dev 2022-10-04 20:02:30 +00:00
Vinit Nayak
188c8916ee Merge "Hide back button if IME shows in SUW" into tm-qpr-dev 2022-10-04 19:01:42 +00:00