Commit Graph

2331 Commits

Author SHA1 Message Date
Schneider Victor-tulias
892ad69191 Merge "Improve test isolation in AbstractLauncherUiTests" into main 2024-10-17 19:22:37 +00:00
Sukesh Ram
fc6cc4e409 Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 324419890
Test: Manual
Change-Id: I54145d07f0699f68c44aaa34e1692c8fe2f7b780
2024-10-16 16:55:45 -07:00
Schneider Victor-Tulias
07669e9575 Improve test isolation in AbstractLauncherUiTests
- Removing suspicious duplicate uses of AbstractLauncherUiTest.initialize to prevent unnecesary launcher restarts
- Adding UiDevice#pressHome to AbstractLauncherUiTests.verifyLauncherState to ensure the next test starts with a known clean state

Flag: EXEMPT test fix
Fixes: 372956489
Test: AbstractLauncherUiTest
Change-Id: Id68ece4ab195a4f6c47aa401eb50a91b8ff70e10
2024-10-16 13:18:36 -04:00
Sunny Goyal
0bf39fdf26 Merge "Removing unnecessary SafeClosable requirement from DaggerSingletonObject" into main 2024-10-14 17:06:13 +00:00
Sunny Goyal
bf9d047b53 Removing unnecessary SafeClosable requirement from DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger
Change-Id: I453159be83e92eee92f5a18cfe0d3ea9a3123f47
2024-10-12 01:26:50 -07:00
Treehugger Robot
99f6d447ea Merge "Cleaning up temporary interfaces which were created for refactoring" into main 2024-10-11 23:02:52 +00:00
Sunny Goyal
43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Federico Baron
f20255fd09 Revert "Demote TaplThemeIconsTest#testShortcutIconWithTheme"
This reverts commit 7672f320e8.

Reason for revert: issue no longer happening

Change-Id: I6dd0b00deb626e0248abc9007c0ae58743931f0c
2024-10-10 18:45:56 +00:00
Sunny Goyal
266f51b488 Converting LauncherModel to kotlin
> This will make it easier to migrate to dagger as it will
  increase the number of constructor parameters significantly

Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: Id06246ec74c678d7614f4c6a798c5644b40a0545
2024-10-10 00:34:12 +00:00
Sunny Goyal
6a207fc4f9 Moving manifest initialization to RoboApplication instead of a separate rule
This makes the behavior same as instrumentation test

Bug: 370080120
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: Id4183c91f3951748b657b583fde8860abe55d3a8
2024-10-08 11:00:22 -07:00
Jagrut Desai
831ca957c0 Merge "Remove unused TestProtocol" into main 2024-10-02 20:51:10 +00:00
Treehugger Robot
3faec179c0 Merge "Add debug memory logs to AbstractLauncherUiTest" into main 2024-10-02 15:39:05 +00:00
Anushree Ganjam
0dc88fece8 Merge "Make InstallSessionHelper injected by Dagger (7/n)" into main 2024-10-02 01:57:48 +00:00
Anushree Ganjam
29e060408f Make InstallSessionHelper injected by Dagger (7/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration

Change-Id: Ib1833436bfd1079ae78f1d865831c1aa8a7a0c41
2024-10-01 12:45:53 -07:00
Schneider Victor-Tulias
63dfd60b23 Add debug memory logs to AbstractLauncherUiTest
Flag: EXEMPT test debug logs
Bug: 365628676
Test: TAPL tests
Change-Id: Ia019bc128b76b9b2d776c54ad93713ae4110b2de
2024-10-01 18:15:13 +00:00
Jagrut Desai
85a8898402 Remove unused TestProtocol
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: Ibe261ec8820f5d6e8415f5085c21a0adfef37462
2024-10-01 09:24:38 -07:00
Treehugger Robot
0c1db56f2f Merge "Requesting ApplicationInfo in cached object" into main 2024-09-28 00:08:58 +00:00
Treehugger Robot
947a932a33 Merge "Cleanup for TAPL Debugging" into main 2024-09-27 21:21:49 +00:00
Sunny Goyal
f7c32a29fd Requesting ApplicationInfo in cached object
Bug: 363324203
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I92f3d3ed8c267b895dc439ba1f01eb67d7f63965
2024-09-27 14:04:16 -07:00
Sunny Goyal
63c24aeacb Merge "Updating IconProvider API to use a single API to load icons" into main 2024-09-27 19:43:54 +00:00
Archisha Baranwal
10467a8cf3 Merge "Adding programmatic provision of WRITE_SECURE_SETTINGS permission to Launcher3Tests." into main 2024-09-27 08:35:45 +00:00
Archisha Baranwal
0d11c4a7ef Adding programmatic provision of WRITE_SECURE_SETTINGS permission to
Launcher3Tests.

Bug: 361222449
Test: atest Launcher3Tests
Flag: EXEMPT test fixes

Change-Id: I4226c4c50047d71a99944fc4e5d70080d134c3d3
2024-09-27 05:53:59 +00:00
Sunny Goyal
a1cebfa0c0 Updating IconProvider API to use a single API to load icons
Bug: 366237794
Test: atest IconProviderTest
Flag: EXEMPT refactor, changes in underlying API

Change-Id: If8c6a4f13de7e7d262ee0b6d0c6897981f75e639
2024-09-26 22:13:11 -07:00
Sukesh Ram
e297bc0c0e Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 326908466
Test: Manual
Change-Id: I01dadc884929a8946f408997ddbcbd0ac4c820ec
2024-09-26 19:44:55 +00:00
Treehugger Robot
9a77922424 Merge "Fix for bug where we don't use default grid on comet, and migrate normally if not in a B&R case" into main 2024-09-25 17:01:54 +00:00
fbaron
b633b9aa2b Fix for bug where we don't use default grid on comet, and migrate normally if not in a B&R case
-The grid migration where we just copy the grid and move everything one row up should only occur in a B&R scenario, so now we add that restriction
-We should default to 4x5 in comet if migrating from a 4x4 grid if the device we're migrating from does not have any other grids saved
-if we have other grids saved, then we'll try using the saved grid if possible. If not possible, we use the default grid for the new device

Bug: 360462379
Test: GridSizeMigrationUtilTest
Flag: EXEMPT bugfix
Change-Id: Ia905081046431c08dc058bd61b2b4ab42dee0506
2024-09-24 16:52:05 -07:00
Sunny Goyal
e1b7ca566e Merge "Moving various application into related methods to a separate class" into main 2024-09-24 22:05:52 +00:00
Sunny Goyal
28d6bbd6b4 Moving various application into related methods to a separate class
> This avoids duplicate RPCs when trying to get multiple properties
  from AppInfo
> This would be used in a followup cl when AppInfo is added to caching
  logic in IconCache

Bug: 366237794
Test: atest ApplicationInfoWrapperTest
Flag: EXEMPT refactor
Change-Id: I55b964d4f8cfa1ff1770e310ac278719495e285d
2024-09-23 22:09:24 -07:00
Sunny Goyal
c3dd1c380f Removing unnecessary package validation during grid migration
package validation happens during loader anyway. And using MATCH_INSTALLED
for checking cross user apps may not work all the time

Bug: 363324203
Test: atest GridSizeMigrationUtilTest
Flag: EXEMPT bug fix
Change-Id: Id36e8fdff132242705ef53c85dc6567fbde5d952
2024-09-23 15:16:37 -07:00
Sebastián Franco
dee300f77d Merge "Removing screen record from TaplWorkProfileTest" into main 2024-09-19 01:44:36 +00:00
Treehugger Robot
98d85d6dc0 Merge "Revert "Add screenrecord to testDragIconToPage2"" into main 2024-09-16 21:50:40 +00:00
Federico Baron
9045632654 Revert "Add screenrecord to testDragIconToPage2"
This reverts commit cf55a30dcf.

Reason for revert: no longer needed

Change-Id: I08a9a0c90e1298d7206c7544de08b557fd89b58e
2024-09-16 20:03:10 +00:00
Sunny Goyal
98001dd1dc Merge "Migrating prediction_undo to aconfig" into main 2024-09-16 17:26:58 +00:00
Sunny Goyal
d94100a223 Migrating prediction_undo to aconfig
Flag: com.android.launcher3.enable_dismiss_prediction_undo
Test: atest SystemShortcutTest
Bug: 270394476
Change-Id: I5daef5d168c301115d860a1ae1d3c96f70a0f18f
2024-09-13 20:21:32 -07:00
Treehugger Robot
e738e4bf07 Merge "Revert "Add screenrecord for testDragAppIcon"" into main 2024-09-14 02:21:30 +00:00
Treehugger Robot
2ff010dfbe Merge "Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"" into main 2024-09-14 02:18:53 +00:00
Federico Baron
c4bb97b64e Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"
This reverts commit 2b724ec00d.

Reason for revert: cleanup

Change-Id: I59140f34ac86ef1d25e707509bd52ddeb3ddf061
2024-09-14 00:13:59 +00:00
Federico Baron
375c88b05e Revert "Add screenrecord for testDragAppIcon"
This reverts commit 701eef07ab.

Reason for revert: cleanup

Change-Id: I489e8e79924c402ed5228781af4bd4065daca42e
2024-09-14 00:13:22 +00:00
fbaron
6a65aebcc6 Add tapl test for isTablet
Bug: 366237798
Test: TaplIsTabletTest
Flag: EXEMPT TEST_ONLY
Change-Id: I806caa5e98b39fc6475c8807003646540f32b509
2024-09-13 11:11:06 -07:00
Sebastian Franco
4e65f94200 Removing screen record from TaplWorkProfileTest
Fix: 322823478
Test: TaplWorkProfileTest
Flag: TEST_ONLY
Change-Id: I4f5b2da8e1909b90146025654d100b9eadd0e577
2024-09-05 11:00:10 -07:00
Sebastian Franco
750e8496ef Reducing the wait time for events for less than the Test timeout
The test timeout is the time the test infraestructure allows a test
to be idle for. Because of it, we don't get the event tiemout error
so reducing the timeout wait will allow us to get the event error.

Bug: 352569050
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: Ic43210a3ca5b5239b1156753bdf8253cd738bdec
2024-09-03 12:55:38 -07:00
Jagrut Desai
a68e4fe0de Merge "Promote TaplAddWidgetTest#testResizeWidget" into main 2024-08-29 22:43:30 +00:00
Jagrut Desai
728096835a Promote TaplAddWidgetTest#testResizeWidget
Test: Presubmit
Bug: 316910614
Flag: TEST_ONLY
Change-Id: Ic4b927f523df7ac531fdbd88670adb12fc43df13
2024-08-29 09:27:57 -07:00
Treehugger Robot
a587ea691e Merge "Promote testUninstallFromWorkspace to presubmit" into main 2024-08-29 00:27:34 +00:00
Vinit Nayak
d42af4b55e Promote testUninstallFromWorkspace to presubmit
Bug: 311099513
Test: None
Flag: EXEMPT bugfix
Change-Id: I28731c173e4cdb473e4fc9fb954a82a5f57c02f5
2024-08-28 15:15:15 -07:00
Sebastian Franco
4bedb18466 Correctly map the drag view position to the Workspace
The drag view needs to be mapped to the drop target which in this
case is the Workspace instead of the CellLayout

Fix: 352569050
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: I233c2b3bf0b8637f80d74d201189b2290ef59c94
2024-08-25 20:41:00 -07:00
Tony Wickham
3a47759619 Merge "Fix Taskbar being visible over Hotseat when recreated in Overview" into main 2024-08-22 18:51:55 +00:00
Tony Wickham
5c32af7e5b Fix Taskbar being visible over Hotseat when recreated in Overview
Debugging locally, it seems there were a couple of state changes
and the last one (which is correct) was getting clobbered by a
previously destroyed instance of TaskbarLauncherStateController.
Fixed this by updating the isDestroyed() call which previously
only checked TaskbarActivityContext to now check
TaskbarLauncherStateController's destroyed state directly. This
is needed because TaskbarLauncherStateController is part of
LauncherTaskbarUIController which can be destroyed independently
of the other Taskbar controllers when Launcher is destroyed.

Also fix a debug log that was not updated long ago in ag/21122190

Flag: EXEMPT bugfix
Test: Go to overview, change Font Scale or Dark Theme from Quick
settings, ensure Taskbar is not visible over Hotseat
Fixes: 302923055

Change-Id: I1299462955b51a2bf931f022177045b1cec039c5
2024-08-21 21:43:54 +00:00
Uwais Ashraf
06ffcf8c61 Merge "Migrate model tests to multivalent" into main 2024-08-21 10:05:40 +00:00
Anushree Ganjam
77aed7422a Dismiss the setup wizard for both presubmit and post submit tests.
In the past we have faced setup wizard not dismissed issue but eng prod
team has not fixed this issue. See b/309008042 for more details.

Bug: 359658695
Bug: 359658158
Bug: 356695093
Bug: 355718051
Flag: TEST_ONLY
Test: Manual
Change-Id: Ief020483fa167946193875f9d6c089d1cfd55124
2024-08-20 17:07:30 -07:00