Commit Graph

6698 Commits

Author SHA1 Message Date
Jagrut Desai
d8ea04a7f6 Merge "Moving Accessibility Annoucement to Task Closed to onEnd animation callback. Test: Manual Fix: 220198279" into tm-qpr-dev 2023-01-09 16:19:04 +00:00
Vinit Nayak
72b186aefd Merge "Improves overview split adjacent launch animation" into tm-qpr-dev 2023-01-07 00:36:16 +00:00
Schneider Victor-tulias
53808c3ed8 Merge "Fix NPE from getting swipe pip to home animator finish transation after the surface has been released" into tm-qpr-dev 2023-01-06 18:38:21 +00:00
Vinit Nayak
daffdfa35c Merge "Toggle taskbar button nav assistant availability" into tm-qpr-dev 2023-01-05 21:28:23 +00:00
Vinit Nayak
da2819ed5f Improves overview split adjacent launch animation
* Translation gets scaled along with the parent,
so the secondary thumbnailView which has a translate on
it gets exaggerated as the parent goes to fullscreen
scale.
* Now we inversely scale translationX/Y properties,
however it seems like the interpolation is still slighly
off at the beginning of the animation (or maybe some other
value, such as pivot, etc)

Bug: 260814999
Test: Manually slowed down animation and observed
Change-Id: I831476b4ffb582fecbd166525ceea33623e66bdd
Merged-In: I831476b4ffb582fecbd166525ceea33623e66bdd
2023-01-05 11:54:22 -08:00
TreeHugger Robot
c46b47853b Merge "LauncherTaskbarUIController should only translate nav buttons on inAppProgresst if icon is aligned with hotseat" into tm-qpr-dev 2023-01-05 15:29:05 +00:00
Schneider Victor-tulias
8aa0471591 Merge "Add check for loading ever applied in check for page scrolls initialized" into tm-qpr-dev 2023-01-04 22:08:12 +00:00
Schneider Victor-tulias
d8a07fa030 Fix NPE from getting swipe pip to home animator finish transation after the surface has been released
Fixes: 243154747
Test: programmatically added delay to finish transation later
Change-Id: Ia667372678f2224406147f5659c5fc6f61f270ad
2023-01-04 13:53:37 -08:00
Jagrut Desai
7764627216 Moving Accessibility Annoucement to Task Closed to onEnd animation callback.
Test: Manual
Fix: 220198279

Change-Id: I3d9d522cd81b4873fb4b03671384f23b7bb6777f
2023-01-04 16:18:43 -05:00
Vinit Nayak
0d784ee7fb Toggle taskbar button nav assistant availability
* New signals coming in from Sysui reflect the toggle
in Settings for long pressing on home button to
invoke assistant.

Fixes: 255909545
Test: Manual + added unit test for TaskbarNavButtonController
Change-Id: Ic65a80b0b9697990931b7e89756773fb086cc3bd
2023-01-03 20:07:27 -08:00
Ikram Gabiyev
6d3ad6820d Turn off filter ui if flag is off
Fix a bug in a condition determining when to show
filter ui for a certain taskview, making sure
that the ui is off when the feature flag for
multi-instance is off.

Test: reproduced the steps laid out in the bug

Bug: 264218764
Change-Id: Ie745789ad834d56b79de47e5196737eb08b081fa
2023-01-04 00:16:34 +00:00
Alex Chau
a5c6aad231 LauncherTaskbarUIController should only translate nav buttons on inAppProgresst if icon is aligned with hotseat
Fix: 261364559
Test: Pull notification shade in overview, 3-buttons stay in place
Test: Pull notification shade in home, 3-buttons translated down
Test: Go to -1, 3-buttosn translated down
Test: Go to AllApps, 3-buttons translated down
Test: Go to widget picker, 3-buttons translated down
Change-Id: I53da354266c60e86599011ba3ddd8b44cde70beb
2023-01-03 18:41:21 +00:00
TreeHugger Robot
39688d2d61 Merge "Update taskbar to spec" into tm-qpr-dev 2023-01-03 17:42:41 +00:00
Ikram Gabiyev
231e061ae1 Merge "Filter recents view instances by package name" into tm-qpr-dev 2022-12-29 01:17:42 +00:00
Tony Wickham
2a058f5be1 Update taskbar to spec
- Space between icons is 24dp in all cases (transient, persistent,
  small tablet, large tablet)
- Persistent taskbar icon size remains 44dp, but transient taskbar icon
  sizes have changed slightly: 57dp -> 52dp for large tablets and
  50dp -> 48dp for small tablets
- Also moved all values to quickstep package to avoid confusion

Test: manual, visual
Fixes: 263465844
Change-Id: I563d64dca2d920762233dd6147395c5bba3ffcf3
2022-12-28 18:56:43 +00:00
Luca Zuccarini
2da05f367d Merge "Revert "Update timings for the Home <> All Apps transition."" into tm-qpr-dev 2022-12-28 14:03:58 +00:00
Ikram Gabiyev
448e0ade10 Filter recents view instances by package name
Filter instances of GroupTasks based on package name
as a part of support for multi-instance

Add a feature flag to toggle multi-instance features

See the video below for how to use the demo.
Note: some extra UI elements were added since video
was recorded, but the filtering process is the same.
http://recall/-/da585DRwKRZK3S2xxcQrSm/gW9HZnbCvGyH1DQiVizOW2

See go/multi-instance for more info about the feature

Bug: 253520408

Test: manually tested the instance filtering

Change-Id: I19c947ca353699096388b9fbbdca6d75cb0041a7
2022-12-28 00:10:48 +00:00
Luca Zuccarini
5dd5296527 Merge changes from topic "b/260218332-1" into tm-qpr-dev
* changes:
  Add a CUJ for closing All Apps manually.
  Add Tapl support for swiping from All Apps to Workspace.
2022-12-27 14:27:48 +00:00
Luca Zuccarini
e18ac479e5 Revert "Update timings for the Home <> All Apps transition."
Revert submission 20641089-b/254835725

Reason for revert: b/263221786

Reverted changes: /q/submissionid:20641089-b/254835725

Change-Id: I6aa0955b4ac7ed47ea254514b364b0ab94b632bf
2022-12-27 14:18:05 +00:00
Pat Manning
eef0b1640b Merge "Do not animate moving to rest state on CHANGE_ACTIVE_SCREEN." into tm-qpr-dev 2022-12-22 17:47:57 +00:00
Brandon Dayauon
2d3f189b80 Merge "Move VibratorWrapper to AOSP" into tm-qpr-dev 2022-12-22 08:18:12 +00:00
Tony Wickham
1f155d6fd7 Merge "Adjust taskbar VIS and bottom mandatory gesture insets" into tm-qpr-dev 2022-12-21 23:25:59 +00:00
Luca Zuccarini
d3841f36a1 Add a CUJ for closing All Apps manually.
Bug: 260218332
Test: pending
Change-Id: Iafe3b932aca985fb4585dac46c6eaaa6e88c8dd6
2022-12-21 15:39:51 +00:00
Pat Manning
cc31ba5360 Do not animate moving to rest state on CHANGE_ACTIVE_SCREEN.
Fix: 259380717
Test: manual
Change-Id: Icec103b26603290c7998977fa9c4d89132620a9d
2022-12-21 11:37:47 +00:00
Ats Jenk
ebfe6b6776 Merge "Taskbar fixes when apps move to desktop and back" into tm-qpr-dev 2022-12-20 23:29:26 +00:00
Alex Chau
d79e53a5c8 Merge "Add transientTaskbarMargin above taskbar in overview" into tm-qpr-dev 2022-12-20 18:40:48 +00:00
Ats Jenk
0ea4768a02 Taskbar fixes when apps move to desktop and back
Fixes to taskbar state when tasks are moved to desktop and fullscreen.

When freeform tasks are visible and we start a new task from taskbar, it
first launches in fullscreen. Transition handler in WMSHell switches it
to freeform as needed. This switch causes launcher activity to be paused
and then resumed. Resuming launcher activity while freeform tasks are
visible, puts the launcher into an incorrect state. (Launcher should
appear paused while freeform tasks are visible).

When a freeform task switches to fullscreen, freeform tasks are no
longer visible. This causes us to resume the launcher activity. We
should not do that if a fullscreen task is visible as it puts the
launcher into an incorrect state. It appears resumed even though the
activity is paused. Added a check to DesktopVisibilityController that
checks if the activity is actually resumed before marking it appear as
resumed.

Test: manual, switch a task to freeform, launch another freeform task
  from taskbar, taskbar should continue to be available
Test: manual, switch a task to freeform, switch the task back to
  fullscreen, taskbar should continue to be available
Bug: 261234278

Change-Id: Ia8d208619fabfcc9bffff6d8d227b236cb62a00c
2022-12-20 10:34:07 -08:00
Brandon Dayauon
5a31c9262e Move VibratorWrapper to AOSP
bug: 233751149
test: manually run and presubmit
Change-Id: I89ada0adf7254396238cb96d27bc265e28093f50
2022-12-20 10:27:21 -08:00
Alex Chau
44dd5b7b28 Merge "Only skip stash animation when going to/from Launcher" into tm-qpr-dev 2022-12-20 09:32:04 +00:00
Sihua Ma
04c89fe38e Merge "Add QuickstepWidgetHolder for widget handling" into tm-qpr-dev 2022-12-19 18:22:38 +00:00
Alex Chau
1b276a1ba7 Add transientTaskbarMargin above taskbar in overview
- Also removed transient_taskbar_two_panels_size and use sw720dp override instead, to be consistent with how we handle small vs large tablet in overview
- Also made isTransientTaskbar mockable so we can test that in DeviceProfileDumpTest

Bug: 260596114
Test: DeviceProfileDumpTest
Change-Id: I3c2236b95d91246e9581531478e3c97601cfb2ec
2022-12-19 17:23:27 +00:00
Alex Chau
bd535c46d7 Only skip stash animation when going to/from Launcher
- Added a cehck on chagnedFlags before skipping stash animation, in additional to !isHotseatIconOnTopWhenAligned check

Fix: 262835548
Test: manual
Change-Id: I5a90213bc0b3f34609a074ba887adbf113e04120
2022-12-19 17:16:08 +00:00
Alex Chau
4537638dfd Merge "Polish hotseat and taskbar with 3 buttons" into tm-qpr-dev 2022-12-19 11:37:39 +00:00
Luca Zuccarini
49d07b1688 Merge "Update timings for the Home <> All Apps transition." into tm-qpr-dev 2022-12-19 11:10:14 +00:00
Brian Isganitis
a1808c3e49 Merge "Delay hiding Taskbar EDU until entering home or overview." into tm-qpr-dev 2022-12-18 22:48:39 +00:00
Thales Lima
6a59006592 Polish hotseat and taskbar with 3 buttons
Change margin spaces and logic of how many items the hotseat and taskbar should show.

Fix: 246424857
Test: DeviceProfileDumpTest
Test: HotseatWidthCalculationTest
Change-Id: I8ec71c56a0aa362483c43d6400c762d12cf45f5b
2022-12-17 11:20:21 +00:00
Sihua Ma
1db8bc2467 Add QuickstepWidgetHolder for widget handling
Fix: 235358918
Test: Manual
1. Rebooted the device and verified that widgets are still updating properly
2. Changed the theme from dark to daylight, then from daylight back to dark and verified that widgets are working
3. Kept the device on for several days and verified that widgets are still updating
4. Turn on auto-rotate for the launcher, open any app then exit, verified that widgets will not vanish and reappear
5. Add & remove widgets from the screen, added widgets are still updating

Change-Id: I98ee902f7d16b47bd77626201a4fefc897ba17a0
2022-12-16 11:56:36 -08:00
Alex Chau
2f581b799b Merge "TaskbarViewController should only translate on rotation if icon is aligned with hotseat" into tm-qpr-dev 2022-12-16 19:06:25 +00:00
Jeremy Sim
e8eb4a3c48 Merge "Fix bug with Taskbar second-app-selection animation" into tm-qpr-dev 2022-12-16 18:30:38 +00:00
Alex Chau
98d33cdff9 Merge "Set iconsSizePx of Taskbar's DeviceProfile directly" into tm-qpr-dev 2022-12-16 16:45:21 +00:00
Schneider Victor-tulias
7bb558a57e Add check for loading ever applied in check for page scrolls initialized
When "Don't keep activities" is enabled in developer settings, the RecentsView gets re-initialized every home gesture. The home animation can often finish before the load plan ever gets applied, so the page scrolls can be used before the RecentsView has had a chance to add all its TaskViews and recalculate its page scroll.

Fixes: 249020573
Test: launched an app and went home
Change-Id: I83ca9de60b50693f7a22b08534ec36973cd6a0fc
2022-12-16 03:12:58 -08:00
Tony Wickham
c6a7ba8163 Adjust taskbar VIS and bottom mandatory gesture insets
- ITYPE_BOTTOM_MANDATORY_GESTURES should always be > 0  in gesture
  navigation mode, but before we were setting it equal to tappableHeight
  which is 0 if the taskbar is stashed. Fixed it to be contentHeight
  instead.
- Updated VIS insets to only override them to be 0 for tappableElement,
  not for others like navigationBars. We still only override this for
  gesture navigation; 3 button mode will continue reporting the same as
  we report to the underlying apps.

Test: manually with 3 button mode, gesture nav mode with taskbar
stashed/unstashed; checked that TaskbarInsetsController dump looks as
expected, and that behaviors like Assistant and IME look correct
Flag: none
Fixes: 262516176

Change-Id: I5a1cdf5a9956777d3189ef6042493e2f5aa9b162
2022-12-15 22:28:40 +00:00
Alex Chau
adbbc2f7fa TaskbarViewController should only translate on rotation if icon is aligned with hotseat
Fix: 254191175
Test: With 3 button, rotate at home and overview, nav button are at expected position. Repeat with TASKBAR_IN_OVERVIEW flag off.
Change-Id: I1e629e6be92c4793d3dfdb0dac60c3bfce886e7a
2022-12-15 22:04:16 +00:00
Alex Chau
a68164d89e Set iconsSizePx of Taskbar's DeviceProfile directly
- After ag/20691430, iconScale no longer scale app icons (I should rename it later, after QPR2), so we'll need to set the desired iconSize directly for Taskbar's DeviceProfile
- Extracted setting iconSizePx and testSizePx out of updateIconSize, as they are no longer affected by scaling. This allows TaskbarActivityContext to set desired iconsize and then call updateIconSize

Bug: 256976071
Test: Test Taskbar icon size in different density
Change-Id: I741c178b59e0d8ecb4c63689e68767622329379c
2022-12-15 17:05:12 +00:00
Sunny Goyal
09fab7ee7d Merge "Unifying multiple all-apps implementations" into tm-qpr-dev 2022-12-15 17:03:05 +00:00
Schneider Victor-tulias
85127b4f47 Merge "[DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds." into tm-qpr-dev 2022-12-15 09:42:15 +00:00
Jeremy Sim
768e9ec8c0 Fix bug with Taskbar second-app-selection animation
This patch makes it so that the correct animation will play when the user selects a second app from the Taskbar.

Previously, when the user selected a second app from the Taskbar, an animation would play showing the expansion of the app -- but it would come from the wrong place. The error occurred because when we calculate the animation start position, we assume that the starting view is located in the DragLayer, which fills the whole screen. But in cases where the starting view is located in the Taskbar, the root view is actually the TaskbarDragLayer, which only fills an area on the bottom part of the screen.

Fixed by adding a check to see if the starting view is part of the TaskbarActivityContext, and if so, adding an offset to calculate the correct DragLayer coordinates.

Fixes: 258692761
Test: Manual
Change-Id: I4026676fefe1e4c5cdf9d9a47d95c0d6e64672e8
2022-12-14 17:48:14 -08:00
Brian Isganitis
f5c099b528 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev 2022-12-14 20:25:21 +00:00
Sunny Goyal
adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00
Jon Miranda
a0743cf62c Merge "Taskbar All Apps button visual updates" into tm-qpr-dev 2022-12-14 19:00:18 +00:00