- Added a 6th hotseat icon to the tablet and unfolded foldable
- not animating the previous task view when animating to hotseat from the home step
- updating the first hotseat icon's color and visibility at the correct times
- cross fading the animating task view and hotseat icon's color
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 283967613
Test: ran the tutorial on handheld, tablet and foldable with ENABLE_NEW_GESTURE_NAV_TUTORIAL true and false
Merged-In: I7a76646ca71502e924f45bba76d72be17d31249d
Change-Id: I7a76646ca71502e924f45bba76d72be17d31249d
The lottie animations in the gesture navigation tutorial would get cut
off due to having to crop them to smaller devices. This change uses a
matrix to correctly scale the animation such that the aspect ratio is
maintained.
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 283969417
Test: Went through the tutorial on devices of different sizes and aspect
ratios and ensured that the lottie animation isn't cut off.
Change-Id: I4b4cc9e11a68daef29fa31d6a89a1c9006041937
The lottie animations used for the gesture navigation tutorial are
designed for specific orientations depending on the device. This change
ensures that users are in the correct orientation for their device. For large screen users in portrait mode, we display a prompt to rotate the screen.
Flag: ENABLE_NEW_GESTURE_TUTORIAL
Fix: 277781713
Bug: 276515961
Test: Manually went through the tutorial starting from both
orientations on handheld, foldable, and tablet to ensure that the prompt
was shown and hidden correctly. Also ensured that gestures cannot be
completed in the background while the prompt is being shown.
Change-Id: I86ae566721f240264177ad4ec7fc12e58d1b95cd
putting contents of the suw all set page in a scroll view to fix layout issues in large display/font sizes
Flag: not needed
Fixes: 275018092
Test: launched all set page on smallest and largest display/font sizes on handheld, tablet and foldable
Change-Id: I921b1becfc0627e9b77e467efe309613aa3ca9d0
Remove contentDescription attribute for multi-instance
filter icon ImageView since importantForAccessibility="no"
to avoid talkback noting it instead of the task name itself.
Bug: 280908761
Test: manually reproduce the steps in the bug
Change-Id: Ifdc884537222565fc2e52d5a17272f19a4446f62
- Updated gesture nav edu overview step post-success motion and colors
- Updated gesture nav edu menu done button color and legacy action button color
- Switching light/dark mode when a step is complete started the demonstration animation. fixed this jank
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281764891
Fixes: 283964958
Bug: 279823249
Test: ran full tutorial with ENABLE_NEW_GESTURE_NAV_TUTORIAL enabled and disabled
Change-Id: I9adc05947267ec038b6f374b2a29a5499468883b
- Removed the fake animated taskbar view from the redesigned tutorial flow
- Fixed the hotseat and home icon colors from the overview step
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Fixes: 281121701
Fixes: 283310758
Test: swiped up from home/overview step
Change-Id: Ie659495994f0c935c5b6c6bf1ae534ec51521726
- Updated all redesigned gesture nav menu and tutorial colors to dynamic color spec
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 281764891
Bug: 279823249
Test: launched tutorial menu and tutorial steps
Change-Id: I03532b80c6e14867c1374bbdf9f984c1cece9809
- Fixed back button image padding (and updated all other images to prevent hidden padding)
- fixed done button size
- padding top and bottom insets for status bar and nav bar
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281121442
Fixes: 281121138
Test: launched the tutorial menu on handheld, foldable and tablet, compared before/after pictures
Change-Id: I61bce2fc4a8d3824048229e0d48f9a429c80a204
* BubbleControllers is optionally available (gated behind a flag).
* The bubble bar controllers follow init & onDestroy after the taskbar
controllers.
* Adds the relevant views used by the bubble controllers to the
transient taskbar layout.
Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I685163cdcc912768b1a720952762f4cbc602b14b
For large scaling configurations, the tooltip height can exceed the
available space, which can truncate important content such as the "Done"
button. To mitigate this issue, we should attempt to increase the width
of the tooltip to hopefully free up some height due to the text taking
up fewer lines.
To support dynamic width, each EDU column gets an equal weight in the
ConstraintLayout, but the lottie animations are still constrained to
their original dimensions. If they fill the width, their aspect ratio
will be maintained and we will still have height issues.
Demo: https://screenshot.googleplex.com/6jV6geJFzCYtQ6v.png
Test: Manual (transient and persistent)
Fix: 278761297
Change-Id: I8cc0c4260caef747378954225d8635b2fb8eef52
The redesigned gesture navigation tutorial was using older files for the
mock hotseat when swiping up to home. This adds in the correct files to
align with the design and be consistent with the mobile version of the
tutorial.
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 278790706
Test: Went through the gesture tutorial on small screen and large screen devices.
Change-Id: Ib3cffd1b8b62220ff0b1458e32b3825396cdb6a0
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.
Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
Updated the BorderAnimator to allow it to animate the border outside the view's bounds. This makes it match the specs and makes it more compatible with other animations.
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Test: tried keyboard quick switching on a handheld, foldable and tablet
Fixes: 276336349
Change-Id: I025f8b0f431e78bcb5c7b4b3859a7d6dde5da600
BubbleBarView shows BubbleViews in a bar similar to transient
taskbar. BubbleBarView can be collapsed (bubbles in a stack) or
expanded (bubbles all visible). When expanded, WMShell will be
notified to show the appropriate expanded bubble view (not part of
this CL).
Also creates BubbleControllers which contains BubbleBarViewController
and will eventually contain other controllers related to stashing
for the bubble bar.
Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I990ab3da6614db90ffff8c40281dc7f16b3957f6
test: verified by making sure animation ends at correctly translation, height and width, and correct corner radius for screen size.
flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
bug: 277123609
Change-Id: Icb38de441e12fa0b9ca49e46d71598edbcdfa108
For devices with smaller screens and the largest fonts and display
sizes, the end screen of the gesture navigation tutorial would cut off
the `Done` button at the bottom. This adds margins so that the button
remains visible on the screen.
Screenshot of Pixel 5 with the largest font and display:
https://screenshot.googleplex.com/AU5rYYBisZ9Azbr.png
Fix: 275540512
Test: Went through the tutorial with default and largest font sizes on both smaller devices and tablets to ensure the button is always visible.
Change-Id: I66baf9b9044211550395bb3823797127de5e1f99
This simplifies insets handling for All Apps and EDU, and also fixes
some edge cases with All Apps popup menus. KeyboardQuickSwitchView now
needs to ignore insets since it has a hardcoded top margin,
keyboard_quick_switch_margin_top.
Fix: 276804708
Test: All Apps, EDU, and Quick Switch all have proper insets handling.
Change-Id: I93237a057b4f9ae62f71a70c59a58f3c8401c102
This reverts commit 0263a679f2.
Reason for revert: Trying again to confirm if this was the actual cause of regression
Change-Id: I2a663015d7ecdcf315634d8a976bf8294b58981d
- Added the gesture tutorial menu page (launched using an intent extra)
- tutorial steps now launch the menu when complete if launched from the menu
- the new default set of tutorial steps is home -> back -> overview. this is to handle the case where an intent is launched that is meant to launch the tutorial menu, but ENABLE_NEW_GESTURE_NAV_TUTORIAL is false
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 274463555
Test: Ran the tutorial and menu on a large screen, foldable and phone
Change-Id: I2eb5f658115be4d5ecb0233a8f09d22efe6ebadc
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
sizes
Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
