Commit Graph

12366 Commits

Author SHA1 Message Date
Brian Isganitis
d7dc6ba320 Add tests for TaskbarAllAppsViewController.
Test: TaskbarAllAppsViewControllerTest
Flag: TEST_ONLY
Bug: 346394506
Change-Id: Ie1b6609b243326eb11d03d2ea7b0e98bd60c3a71
2024-09-24 18:51:46 -04:00
Brian Isganitis
78f8d40519 Add tests for TaskbarScrimViewController.
Test: TaskbarScrimViewController
Bug: 346395034
Flag: TEST_ONLY
Change-Id: I418675ba9aeaa645a0b216d237c479ffd640baf9
2024-09-24 18:51:46 -04:00
Brian Isganitis
3231ba01e6 Add tests for TaskbarStashController.
Test: TaskbarStashControllerTest
Bug: 346394503
Flag: TEST_ONLY
Change-Id: I930e745826f2512d04434ad689a3e42cac7e9901
2024-09-24 18:51:46 -04:00
Liran Binyamin
c2c7913134 Merge "Create BubbleBarFlyoutView" into main 2024-09-18 14:21:26 +00:00
Treehugger Robot
10505cdb7e Merge "Revert^2 "Use ConcurrentHashMap to make private maps thread safe"" into main 2024-09-18 12:40:32 +00:00
Uwais Ashraf
4c045988c1 Revert^2 "Use ConcurrentHashMap to make private maps thread safe"
This reverts commit f480cf371a.

Reason for revert: not the cause of b/367736714

Change-Id: If9b400c5474d9ec51f51f1de86c80b9337857fac
2024-09-18 05:47:29 +00:00
Mykola Podolian
13ffcc7242 Merge "Unstash hotseat immediately if go out of the launcher home." into main 2024-09-18 04:17:14 +00:00
mpodolian
bf7a4db0de Unstash hotseat immediately if go out of the launcher home.
When navigation mode is set to 3 buttons, it is possible for user to
click on recent apps button, so for such scenario taskbar should be
immediately un-stashed

Test: Manual
Set 3 buttons navigation mode. Go to Launcher home. Expand bubble bar.
Press recent apps button. Press the home button. Observe hotseat is
visible. Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fX0gSp18Riw8mYYAw0wj8W

Bug: 367488218
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id65fd9add720125a340294311d470f2be50d43f8
2024-09-17 15:47:42 -07:00
Priyanka Advani (xWF)
2a82a901c2 Merge "Revert "Use ConcurrentHashMap to make private maps thread safe"" into main 2024-09-17 20:00:08 +00:00
Priyanka Advani (xWF)
f480cf371a Revert "Use ConcurrentHashMap to make private maps thread safe"
This reverts commit d511538361.

Reason for revert: Droidmonitor created revert due to b/367736714. Will be verifying through ABTD before submission.

Change-Id: I01281bd48c4ba7d07dc0308c504f21aad751ea44
2024-09-17 18:45:46 +00:00
Mykola Podolian
bff3b73c8f Merge "Hide hotseat when bubble bar is expanded." into main 2024-09-17 17:38:33 +00:00
Liran Binyamin
36b5ef2271 Create BubbleBarFlyoutView
Initial version of the flyout view for displaying bubble bar
notification.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I5d0643fe5d2691ad2349b45eaaad6cd2660d9df0
2024-09-17 11:14:54 -04:00
Uwais Ashraf
4cf24115ab Merge "Use ConcurrentHashMap to make private maps thread safe" into main 2024-09-17 14:54:48 +00:00
Uwais Ashraf
d511538361 Use ConcurrentHashMap to make private maps thread safe
Also synchronize listener un/registering to prevent accumulation of listeners

Fix: 365068571
Test: presubmit crash detector not triggered
Test: TaskVisualsChangedDelegateTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ib15f44d8bca0e24173db3a16bc9184e73e30f4b4
2024-09-17 14:54:08 +00:00
Treehugger Robot
25d7972151 Merge "Reland "Separate desktop and fullscreen carousel"" into main 2024-09-17 10:04:51 +00:00
Sunny Goyal
e14032d578 Merge "Cleaning up some enabled features" into main 2024-09-17 03:22:23 +00:00
Treehugger Robot
7b50f9189a Merge "Migrate ENABLE_ALL_APPS_BUTTON_IN_HOTSEAT to launcher.aconfig" into main 2024-09-17 02:44:18 +00:00
Treehugger Robot
a2dd2d2b28 Merge "Fix an issue where the bubble bar was visible after theme change" into main 2024-09-17 02:02:21 +00:00
Mady Mellor
e736b9c0c5 Fix an issue where the bubble bar was visible after theme change
Don't set the alpha to 1 in the drag reset method unless the bar
is actually expanded.

When theme changes, everything gets recreated... so the location of
the bubble bar gets set which triggers drag reset which would make
the bar visible when it shouldn't be.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - have bubbles in app (stashed), change theme, observe
               that bubbles are not visible
             - test dragging bubbles from left  to right via expanded
               view, individual bubble, and collapsed stack
Bug: 358304168 (not exact bug but noted in the video of comment#13)
Change-Id: I291cdb206532efe386684e36a78b9d66018f3cb1
2024-09-16 16:59:09 -07:00
Liran Binyamin
69f4974e24 Hide hotseat when bubble bar is expanded.
Added logic to stash the hotseat when on launcher home screen.

Bug: 280494203
Test: Manual:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fjfjUw296LRXUm9uYqXU4K
all tests in com.android.launcher3.taskbar
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I67b298831eaed9c549a2fae7dc5a0d9fae51f7c4
2024-09-16 15:50:28 -07:00
Jon Miranda
aec1e05be5 Migrate ENABLE_ALL_APPS_BUTTON_IN_HOTSEAT to launcher.aconfig
Flag: com.android.launcher3.enable_all_apps_button_in_hotseat
Test: N/A
Bug: 270393897
Change-Id: Ib62a2f46a440d8f0d3f569c09c4f8754715db4ee
2024-09-16 22:00:39 +00:00
Mykola Podolian
56cda496c6 Merge "Update placement of the nav bar in persistent taskbar for 3 button nav" into main 2024-09-16 21:49:54 +00:00
Ats Jenk
29496de39d Merge "Show bubble bar when hotseat icons are visible" into main 2024-09-16 15:41:03 +00:00
Liran Binyamin
34351f690e Merge "Fix bubble tx when the bar is collapsed" into main 2024-09-16 13:31:56 +00:00
Treehugger Robot
34b535c76d Merge "Don't wait for thumbnails to update if updatedThumbnails are empty" into main 2024-09-16 12:57:12 +00:00
Alex Chau
8b692c356b Don't wait for thumbnails to update if updatedThumbnails are empty
Fix: 366205521
Test: Double tap recents button in -1 screen
Test: RecentsViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I3eb854c8068fe70473bde32c5f7706af8d17a3cf
2024-09-16 10:39:23 +01:00
Treehugger Robot
bacfdcd39a Merge "Add FLAG_DELAY_TASKBAR_BG_TAG to restrict when taskbar bg anim gets delayed." into main 2024-09-14 04:15:31 +00:00
Jon Miranda
86a4b653b9 Add FLAG_DELAY_TASKBAR_BG_TAG to restrict when taskbar bg anim gets delayed.
We set it only when user swipes up to unstash.

Fixes: 360778703
Test: swipe up to home, long click on taskbar icon before it settles
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I24ff466ee6730e3739d85307363567cfa1455cbf
2024-09-13 19:08:46 -07:00
Ats Jenk
61d45eb8d2 Merge changes I3cfdb715,Ic194afdb into main
* changes:
  Fix initial alpha when unstashing bubble bar
  Set additional bubble translation during stash
2024-09-13 22:38:24 +00:00
Treehugger Robot
eb269053ba Merge "Remove unecessary uses of LauncherActivityInterface.INSTANCE" into main 2024-09-13 21:47:40 +00:00
Sunny Goyal
4f9ba255a4 Cleaning up some enabled features
Bug: 270394468
Bug: 270393900
Bug: 270390907
Bug: 270390930
Bug: 270390937
Bug: 270391693
Bug: 270391638
Bug: 270395177
Bug: 270395269
Flag: EXEMPT legacy flags cleanup
        ENABLE_SHOW_KEYBOARD_OPTION_IN_ALL_APPS
        ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
        ENABLE_DEVICE_SEARCH
        ENABLE_HIDE_HEADER
        ENABLE_TWOLINE_ALLAPPS
        IME_STICKY_SNACKBAR_EDU
        FOLDER_NAME_MAJORITY_RANKING
        SCROLL_TOP_TO_RESET
        ENABLE_SEARCH_UNINSTALLED_APPS
        ENABLE_HOME_TRANSITION_LISTENER

Test: Presubmit
Change-Id: Ia392c10fc65616405cc4d4a2b8ed566e3bb7d386
2024-09-13 14:24:27 -07:00
Alex Chau
ca7df57c08 Reland "Separate desktop and fullscreen carousel"
This reverts commit a555f4ca1b, and relands commit 9420ba7515.

- attachAlpha should only be reset in onRecycle, otherwise applyLoadPlan or moveRunningTaskToFront will unexpectedly reset it via resetViewTransforms. This fixes TaplTestsQuickstep.testQuickSwitchFromApp which assert all visible task must be on the left hand side of the screen during swipe up

Fix: 353950224
Change-Id: If1c1524e435c8007844bcd51d8695a6d3b00450b
2024-09-13 22:00:29 +01:00
Liran Binyamin
b30d0b49c7 Fix bubble tx when the bar is collapsed
The previous behavior positioned the second bubble correctly but all
other bubbles behind the second bubble.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 366254467
Test: manual
       - create multiple bubbles in the bubble bar
       - expand and collapse the bubble bar and observe bubbles
         move correctly from right to left when expanding and from
         left to right when collapsing
Change-Id: I1db6daf629826af8d079a27d582e0c7e89fe2289
2024-09-13 16:19:57 -04:00
Ats Jenk
9b4484c974 Show bubble bar when hotseat icons are visible
Fixes a flicker with bubble bar briefly attempting to stash when swiping
up on home screen.
Keeps bubble bar visible when dragging an icon on home screen.

Bug: 365561149
Flag: com.android.wm.shell.enable_bubble_bar
Test: swipe up on home screen, check that bubble bar does not stash
Test: drag a home screen icon, check that bubble bar does not stash
Change-Id: Ic8f4bf6051ed437167f369e8581a631b73e839b2
2024-09-13 11:28:37 -07:00
Ats Jenk
9639315baa Fix initial alpha when unstashing bubble bar
For the stash and unstash animation we use separate timings for the
Bubble views and background. In other animations we animate the entire
bubble bar alpha as one.
To achieve this during unstash animation we set the bubble views and
background alpha to 0. And then set the bar alpha to 1.
Since alpha animation has a delay during unstash, we need to set the
initial values as the start of the entire animation and not just the
alpha part. Otherwise there are flickers in the animation.

We also need to set initial values for the alpha animator that the
AnimatedFloat creates. AnimatedFloat uses the current values as the
start value. If we update it later, the animator was already created and
it won't have an effect. To fix this, we set the start and end values
for the alpha animators created by AnimatedFloat.

Bug: 345488489
Flag: com.android.wm.shell.enable_bubble_bar
Test: slow down animations and unstash bubble bar, check that bubbles
  alpha slowly animates in

Change-Id: I3cfdb715e1703bd2195c809fd77751a216558176
2024-09-13 10:51:11 -07:00
Anushree Ganjam
b41def0366 Merge "Add LauncherAppSingleton & LauncherActivityScope to dagger graph (3/n)" into main 2024-09-13 00:45:28 +00:00
mpodolian
04088ebef7 Update placement of the nav bar in persistent taskbar for 3 button nav
Implemented nav bar placement update to be located opposite to the
bubble bar.
When bubble bar is moved to the other side of the bar, 3 button nav will
swap sides (without animation).
If taskbar has to be repositioned it does that with the animation.

Test: TaskbarViewControllerTest
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id031706183c60cbd9c67537b01530acb43bae614
2024-09-12 16:42:15 -07:00
Sunny Goyal
5ee3d98641 Cleaning up some enabled features
Flag: EXEMPT LEGACY
		CONTINUOUS_VIEW_TREE_CAPTURE
		ALL_APPS_GONE_VISIBILITY
		ENABLE_BACK_SWIPE_HOME_ANIMATION
		ENABLE_DYNAMIC_TASKBAR_THRESHOLDS
		PREEMPTIVE_UNFOLD_ANIMATION_START
		ENABLE_NEW_GESTURE_NAV_TUTORIAL
		ENABLE_ENFORCED_ROUNDED_CORNERS
		ENABLE_TRACKPAD_GESTURE
		ENABLE_KEYBOARD_QUICK_SWITCH
		ENABLE_KEYBOARD_TASKBAR_TOGGLE
		ENABLE_ALL_APPS_RV_PREINFLATION
Test: Presubmit
Bug: 270395171, 291651514, 270393426, 294252473,
     270397209, 270396257, 270393258, 271010401,
     270396844, 281726846, 288161355

Change-Id: I6ef1e12dfc2203a4cca8e91aa291485f1ff24c42
2024-09-12 15:12:08 -07:00
Alex Chau
98af6a906e Merge "Revert "Separate desktop and fullscreen carousel"" into main 2024-09-12 15:50:41 +00:00
Chaitanya Cheemala (xWF)
a555f4ca1b Revert "Separate desktop and fullscreen carousel"
This reverts commit 9420ba7515.

Reason for revert: Likely culprit for b/366196741 and b/366191730

Bug: 353950224
Fix: 366196741
Fix: 366191730
Change-Id: Icc84aaaae1a6bd8b21f059331715fb25163793b8
2024-09-12 15:48:28 +00:00
Treehugger Robot
b6332b9947 Merge "Fixing back animation for container views" into main 2024-09-12 13:57:02 +00:00
Alex Chau
9420ba7515 Separate desktop and fullscreen carousel
- setRunningTaskHidden now changes attachAlpha only, stableAlpha is untouched as part of the attach animation, so both alpha can be set independently without interferring with each other
- During swipe up, hide task of differnt type (fullscreen/desktop) from the carousel, apply unhide when the gesture settles
- Update the min/max alpha calculation when a type of task is hidden from the carousel

Fix: 353950224
Test: Quick switch, swipe up, and scroll in Overview with and without Desktop tile, on phone and tablet
Test: presubmit test on quickswitch and swipe up
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I0a63da3ee3e55f4d1edbc53b2a4c5fccda2af387
2024-09-12 09:30:46 +00:00
Vinay Joglekar
b3189d8404 Merge "Add keyboard navigation for all large tiles" into main 2024-09-12 09:09:02 +00:00
Sunny Goyal
b55d9ca407 Fixing back animation for container views
> Looking up views during back instead of holding the reference
  This allows back animation even if Launcher restarts
> Fixing back animation not working with progressive back
> Fixing container animation overriding Launcher cookie used be gestureNav

Bug: 365866488
Test: Verified manually by enabling flag
Flag: com.android.launcher3.enable_container_return_animations
Change-Id: Ic235b238cca6a31e9a5502200ff6b07c72b4e4d7
2024-09-12 00:51:07 -07:00
Treehugger Robot
206e15b286 Merge "Move DesktopVisibilityController to TouchInteractionService" into main 2024-09-12 02:32:00 +00:00
Ats Jenk
aad71bc532 Set additional bubble translation during stash
Fixes bubbles stash translation not getting cleared up after stash
animation finishes.

Bubbles are clipped using an outline animator during the stash
animation. They need separate translation applied to keep them within
the bounds of the bubble bar that is also shrinking and moving.

Set the translation for the bubbles in the stash controller so we can
reset the translation after the animation has finished.

Bug: 365829293
Flag: com.android.wm.shell.enable_bubble_bar
Test: TransientBubbleStashControllerTest
Test: have bubbles in bubble bar, trigger a new auto expanding bubble,
  check translation for bubbles
Change-Id: Ic194afdb4d650fcd525355d8bae08dd651d1ea05
2024-09-11 16:29:22 -07:00
Treehugger Robot
072d2e46b6 Merge "Cancel the stash animation if the stash controller is destroyed before then" into main 2024-09-11 21:01:36 +00:00
Anushree Ganjam
fbc0f97410 Add LauncherAppSingleton & LauncherActivityScope to dagger graph (3/n)
* Add ApplicationContext qualifier and binding the application context instance so
that this context is available across dagger graph.

* Add QuickStepModule and LoggingModule
* Provide SettingsChangeLogger in dagger way. We are depending on
  MainThreadInitializedObject for cleanup. We need to define a way
  explicitly see how we can destroy singleton objects.

Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration
Change-Id: Ia10cc500edb1d88adcca540119651f59b9bc8dc8
2024-09-11 13:56:23 -07:00
Sunny Goyal
8f8932b0f8 Merge "Adding open/close animartion when launching app-info target" into main 2024-09-11 20:31:34 +00:00
Mady Mellor
f12caec1d0 Merge "Fix the overflow not being added sometimes" into main 2024-09-11 19:21:53 +00:00