- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
similarly
This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.
Reason for revert: Reland previously reverted CL's with fixes
Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
1. Introduce a `groupTask` property to `TaskView` and let all the
`bind` functions take a type of `GroupTask` as the parameter
instead of a `Task`.
2. Then let `RecentsView.removeGroupTaskInternal` take the
`GroupTask` as the parameter instead of a `TaskView`.
3. Caches the `groupTask` before `removeGroupTaskInternal` then
we can avoid the corresponding `deskId` being set to invalid
on `removeViewInLayout` in the main thread, which might happen
before `removeGroupTaskInternal`.
Bug: 408032417
Test: m
Flag: EXEMPT refactor
Change-Id: I51c5b810eb63bc1267b90b915f90164f7ca3cba5
The goal is that eventually remove BaseLauncherActivityTest and
uase LauncherActivityScenarioRule by compositions instead of
using inheritance and move methods that make sense to have in
LauncherActivityScenarioRule and other in utility classes.
Bug: 324261526
Test: All Tests that inherit from BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I1b2f3ed9e9d41a9185711ba682895b0b3fffe2df
The windowing exemptions logic is used for both exempting apps from
opening in desktop but also hiding the entry point so apps cannot be
moved into desktop. However, disabling desktop entry points is not
constrained by the same security restrictions as exempting apps from
opening as freeform in desktop. Instead we should have a separate
heuristic for disabling entry points and forcing to fullscreen.
Flag: EXEMPT Refactoring
Fixes: 407704088
Test: atest NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest.kt,
atest NexusLauncherTests:com.android.quickstep.DisplaySystemShortcutTest.kt
Change-Id: I268566072ca5fba090d05f0202468d086c41a66d
This means that the VMs are created on the bg threads in the ViewPool setup stage rather than at critical points in CUJs.
Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces
Change-Id: I3aab5271d552e5f292533617a6842a046cb43bf1
Revert submission 32704934-model-test-cleanup
Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.
Reverted changes: /q/submissionid:32704934-model-test-cleanup
Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions
Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit
Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
Let `isGestureBlockedTask` return false directly if
`mGestureBlockingTaskId` is not valid. This can avoid
the caller go to create incorrect InputConsumer when
the chekcing `taskId` is also invalid.
Bug: 402218420
Flag: EXEMPT bug fix
Test: m
Change-Id: Ia0cde8ee2b97fc92028458d01487d958f2e87a80
This shows up if the launcher is in a sw600dp-or-greater configuration.
Test: AspectRatioSystemShortcutTests
Test: OverviewMenuImageTest
Test: Manual check on phone, tablet, and inner/outer fold screens.
Flag: com.android.window.flags.universal_resizable_by_default
Bug: 357141415
Change-Id: I1bcbf9299d28ce68cccd636d92ed7195d64736eb
This test is flaky in robolectric but does not repro locally.
Looking at the test it verifies that the animation doesn't get
canceled immediately after it starts. So the scenario here is an
edge case for something that shouldn't happen generally because
the animation is controlled in this class, although theoretically
other classes could obtain a reference to the physics animator and
cancel it directly. But since the test flakes badly, we're better
off without it until it can be fixed.
Bug: 404773413
Flag: EXEMPT test only
Test: atest BubbleBarViewAnimatorTest
Change-Id: I24493b71842a2fe859ffe40b6f375ade7ee8535d
- isHomeAndOverviewSame now returns true for launcher in window
- added isHomeAndOverviewSameActivity to differentiate specifically
when Overview is hosted in the Launcher activity (currently only
used for launcherChildTask handling, which we can clean up in a
follow up change)
- overviewIntent now equals homeIntent for launcher in window
- fixed containerInterface to always use FallbackoverviewInWindow
when overview-in-window is enabled; this means TaskbarManager
gets the proper RecentsViewContainer for creating the correct
TaskbarUIController
- updated getSwipeUpHandlerFactory based on isHomeAndOverviewSame
change above
Fixes: 401382430
Test: InputConsumerUtilsTest, manual
Flag: com.android.launcher3.enable_fallback_overview_in_window
Flag: com.android.launcher3.enable_launcher_overview_in_window
Change-Id: Ie8edd55b47d6438af36b9d2a788d72d69afa02f3
This test is the leading cause of flakiness for the entire suite.
Bug: 404773413
Flag: EXEMPT test-only
Test: BubbleBarViewAnimatorTest
Change-Id: I7c5658ad55aa0e959e068e5979325d1c41d18310
This means we are now testing real objects instead of mocks
Test: TaskbarHoverToolTipControllerTest
Fixes: 346394827
Flag: EXEMPT bugfix
Change-Id: Ib2e7f859432e84eb18c985dd71adaaaf9a513620
The SetFlagsRule was missing in tests.
Flag: EXEMPT Test fix
Fix: 402452969
Test: atest NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Change-Id: I80e4fc311b173e32e2d85849656b837deb903aeb
All input consumers should be associated with display IDs, especially since these are used by TouchInteractionService.onConsumerInactive and they will be using per-display objects.
Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Test: InputConsumerUtilsTest
Change-Id: Ic14121db2361da1f0a819221b85256b1b3926774
Fixing NPW caused by ag/31415696. The recents view container can be null in tearDown
Flag: EXEMPT test fix
Fixes: 399657343
Test: TaplTestsQuickstep
Change-Id: I3665fc4bc131b90b22f43282f0c4e9e1188d0eb4
Add freeform check and update logs
Return early instead of crashing if a launch change is not available
Bug: 395495925
Flag: NONE only adding logs, not change of actual code
Test: DesktopAppLaunchAnimatorHelperTest
Change-Id: I0d51c563a26e7d6020222cb84757e0ea8d561d69
