Commit Graph

9413 Commits

Author SHA1 Message Date
TreeHugger Robot
d5b3a0a099 Merge "Removing explicit target SDK for launcher" into udc-qpr-dev 2023-06-27 22:34:40 +00:00
Jerry Chang
c2bac08fac Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69 am: 71fe404fd1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388

Change-Id: If3b1a1a4bef71e51c70d072f9f4c5c6a03ea78ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 19:10:19 +00:00
Jerry Chang
26d5493e69 Merge "Prevent exception when quick switching between two split pairs" into udc-dev 2023-06-27 17:42:42 +00:00
Mady Mellor
d8cb90f010 Merge changes Iaee9aeb0,I76587cf6 into udc-qpr-dev
* changes:
  Fade the bubble bar arrow in and out when the bubble bar expands and collapses.
  Animate the bubble bar width and the bubbles within it as it expands and collapses.
2023-06-27 17:35:58 +00:00
TreeHugger Robot
796c3bbd02 Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b am: 7733c11623
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397

Change-Id: I5f485e204fa56b319f250a467eb448622be9f01f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 03:54:56 +00:00
TreeHugger Robot
1f3c56af5b Merge "Restore strong reference to animation runner" into udc-dev 2023-06-27 02:13:00 +00:00
Randy Pfohl
2310a890c2 Merge "Updating content description for accessibility no matter the state" into udc-qpr-dev 2023-06-27 01:13:53 +00:00
Winson Chung
6cfe2e6cbe Restore strong reference to animation runner
- The remote animation factory needs to be strongly referenced since
  the only other reference is a weakly held one from
  LauncherAnimationRunner, and if a gc happens in between starting
  the animation and the onAnimationStart() callback, then the
  animation will not play.

Fixes: 284106887
Test: Force a gc after creating a remote app launch animation and ensure
      that the runner still exists when the animation starts

Change-Id: I5f584451b41c666916801b8ea0cb470c7ab9fc51
2023-06-26 23:55:23 +00:00
randypfohl
442b93c9c9 Updating content description for accessibility no matter the state
Test: built and tested locally by opening apps and then turning on talkback to verify content description is set

Bug:280908761

Change-Id: I9ed015bdd375e2cedf5e068a77bd4b4dcb5f9488
2023-06-26 13:24:58 -07:00
Winson Chung
23fb63f09e Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37 am: b578dac96e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649

Change-Id: I3ee6069ad3664c32ed9a042270fc836a59b0a44b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 19:31:58 +00:00
Winson Chung
fa3434fc37 Merge "Fix NPE due to invalid RecentsView access" into udc-dev 2023-06-26 17:47:49 +00:00
Winson Chung
cdf410f134 Fix NPE due to invalid RecentsView access
Fixes: 288829919
Test: N/a, reorganizing code behind null check
Change-Id: I9efe48cab239b521f7e729af06706c352be2499c
2023-06-26 17:47:33 +00:00
Sunny Goyal
b02dafc1d4 Removing explicit target SDK for launcher
> It will automatically target the latest SDK it was compiled with

Bug: 284349887
Test: Presubmit and manual
Flag: N/A
Change-Id: I32629b0dd710c3c04d8f70f988b7279e7cae6731
2023-06-26 10:15:14 -07:00
Schneider Victor-tulias
a4d1e9aa99 Merge "Remove unnecessary method from StatefulActivity" into udc-qpr-dev 2023-06-26 16:41:12 +00:00
Jerry Chang
97eb471f2e Prevent exception when quick switching between two split pairs
When switching in between two split pairs just quick enough, it is
possible to send the second entering split transition while it is
animating the first entering split transition which is merged to a
recents-during-split transition. The split parents might not be
collected into the second transition because the split parents are
already visible at that time, and there is no recents transition to
merge to. So updates to not throwing when there is no split parent when
composing a recents-to-split animation.

Bug: 236226779
Test: repro steps of the bug and the Launcher won't throw
Change-Id: I3a595722721186e8de7d60c9fb8c099ec799804a
2023-06-26 13:49:37 +00:00
Tracy Zhou
e4c55f8811 Merge "Allow trackpad gestures in immersive mode ignoring bar visibility" into udc-qpr-dev 2023-06-23 22:58:53 +00:00
Mady Mellor
122b834637 Add myself as an owner to the bubbles package in launcher
Test: treehugger
Bug: none
Change-Id: I1114a7da8c65b64ebad02ca1e58750e7a7c0a2a1
2023-06-23 11:48:57 -07:00
TreeHugger Robot
434c907531 Merge "Ensure the overflow is added first to the bubble bar" into udc-qpr-dev 2023-06-22 20:06:33 +00:00
Jagrut Desai
ead6a52ccc Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev am: 9f566dec6b am: 74f61b1e5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23734004

Change-Id: Ibd58705593ee94ddc122b7b15111c5ca3692b9dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-22 19:20:08 +00:00
Liran Binyamin
26daeace30 Ensure the overflow is added first to the bubble bar
Previously there was a race between initializing the bubble bar
which creates the overflow and sending an initial bubble state
update event from WMShell. If the event is processed first then
bubbles are added before the overflow.

This change ensures that the overflow is created if needed when
the initial event is sent from WMShell.

Fixes: 288414998
Test: - manual
        - Enable 3 button navigation
        - Create some bubbles
        - Switch to gesture navigation
        - Overflow should be added first (below other bubbles)
Change-Id: Ie001c76a3f587d95021f4b7202492b3071706fd0
2023-06-22 14:09:04 -04:00
Jagrut Desai
9f566dec6b Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev 2023-06-22 18:06:23 +00:00
Schneider Victor-tulias
9c18ce4871 Remove unnecessary method from StatefulActivity
Flag: not needed
Fixes: 284920213
Test: quickly tapped overview button and quickly tapped scrim; added logs to check error case
Change-Id: I6cb66012379d30e8ce91533a9f4350bf309f1341
2023-06-22 17:50:58 +00:00
fbaron
04be6e6874 Update renamed util function M3HCTToColor in launcher code
Bug: 288120001
Test: none
Change-Id: If4c6783472d7fa05a1162e2f176a613d28f7bec3
Merged-In: If4c6783472d7fa05a1162e2f176a613d28f7bec3
2023-06-22 15:35:28 +00:00
Helen Cheuk
622a3eacb3 Merge "Align ClearAllButton to centre when the ENABLE_GRID_ONLY_OVERVIEW is enabled" into udc-qpr-dev 2023-06-22 12:50:54 +00:00
helencheuk
4ecef9aae6 Align ClearAllButton to centre when the ENABLE_GRID_ONLY_OVERVIEW is enabled
Bug: 271570406
Flag: ENABLE_GRID_ONLY_OVERVIEW
Test: Test postponed due to b/288389556
Change-Id: Ifab0705a45cfea45199ed0db69ef7ad20f935023
2023-06-22 10:45:36 +00:00
Schneider Victor-tulias
7a12786c79 Merge "Skip sending user home when the overview command queue is pending." into udc-qpr-dev 2023-06-21 21:50:56 +00:00
Vinit Nayak
bf07480edd Merge "Add logs to RemoteTargetGluer for index exception" into udc-dev am: 8492177884 am: 41733594f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23711381

Change-Id: I69bb76d82630be92abf36e11a3066d9e4cc4482f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 21:38:38 +00:00
Vinit Nayak
8492177884 Merge "Add logs to RemoteTargetGluer for index exception" into udc-dev 2023-06-21 20:37:53 +00:00
Vinit Nayak
aa17ce6274 Merge "Allow starting split from home, selecting second app from overview" into udc-qpr-dev 2023-06-21 18:24:09 +00:00
Schneider Victor-tulias
cb0de75242 Skip sending user home when the overview command queue is pending.
Tapping the overview scrim during an app -> overview transition in 3-button nav can replace that state transition's aniamtion, leaving the device in a broken state. The assumption is that the user did not mean to tap the scrim while quickly tapping the overview button. Skipping the startHome request if the overview command queue is not empty.

Flag: not needed
Fixes: 284920213
Test: quickly tapped overview button and quickly tapped scrim; added logs to check error case
Change-Id: I8fea76d810e550e28a61a4528796b358103cb5b3
2023-06-21 17:53:03 +00:00
Winson Chung
aa4a56aaa1 Merge "Restore specific colors for floating rotation button" into udc-dev am: d827387ffd am: 5c03116eb3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23755143

Change-Id: I0c066b9cba339bf16ae2215cbb527c5e3038a03e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 17:30:02 +00:00
Mateusz Cicheński
e338982c97 Reparent PiP overlay under task as soon as possible
For enter PiP animations started from Launcher, we send the signal to
WMShell to reparent the overlay under task as soon as possible.

This avoids flicker issue caused by race condition of cleaning up the
transition leash before the reparenting was done, which made the issue
of overlay being not attached to anything for few frames.

Bug: 281711939
Test: winscope trace from comment#28, leash follows task
Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ewrarENSYYOmUCa0b3fdtp

Change-Id: Ia16afd49a94d9ba8456287c2cdffb2a84e5a2bc7
Merged-In: Ia16afd49a94d9ba8456287c2cdffb2a84e5a2bc7
2023-06-21 16:51:36 +00:00
Winson Chung
d827387ffd Merge "Restore specific colors for floating rotation button" into udc-dev 2023-06-21 16:06:19 +00:00
Treehugger Robot
41cbb5bc88 Merge "Add detailed exception for snappedIndex == -1 when dismissing tasks" into udc-dev am: dcbe9583fb am: 143e612bc4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23535540

Change-Id: Ie51df96182b138aeda874960da8511eaefab1d15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 12:29:19 +00:00
Treehugger Robot
dcbe9583fb Merge "Add detailed exception for snappedIndex == -1 when dismissing tasks" into udc-dev 2023-06-21 11:00:20 +00:00
Treehugger Robot
ca533b1254 Merge "Simplifying taskbar recreation logic" into udc-qpr-dev 2023-06-21 08:15:10 +00:00
Winson Chung
c27a43ba30 Restore specific colors for floating rotation button
- The rotation button background does not change based on the current
  light/dark mode

Bug: 288126260
Test: Check rotation button color with dark mode enabled/disabled
Change-Id: If4d5edfd4b118e4f16b6d472f206587e7cd61f98
2023-06-20 22:45:25 +00:00
Vinit Nayak
1c81f07eb5 Allow starting split from home, selecting second app from overview
* KI: After entering overview, swiping to exit doesn't
clear split state. That's because LauncherRecentsView#reset()
gets called both when entering and exiting overview.
We'd need to check or pass through what state we're moving to
to determine whether or not actually to reset state in
SplitSelectStateController, or handle that at the gesture level

Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Manual, split paths work w/ and w/o flag enabled
Bug: 276361926
Change-Id: I39391ac5f92b774d8198930829caabe84d950598
2023-06-20 15:17:48 -07:00
Mateusz Cicheński
357f68275c Reparent PiP overlay under task as soon as possible
For enter PiP animations started from Launcher, we send the signal to
WMShell to reparent the overlay under task as soon as possible.

This avoids flicker issue caused by race condition of cleaning up the
transition leash before the reparenting was done, which made the issue
of overlay being not attached to anything for few frames.

Bug: 281711939
Test: winscope trace from comment#28, leash follows task
Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ewrarENSYYOmUCa0b3fdtp

Change-Id: Ia16afd49a94d9ba8456287c2cdffb2a84e5a2bc7
2023-06-20 21:04:24 +00:00
Tracy Zhou
00c2c68ee3 Allow trackpad gestures in immersive mode ignoring bar visibility
For more context of this change, please check out go/trackpad-immersive-mode

Bug: 287813022
Test: Swipe up in sticky immersive mode (e.g. YouTube)
Change-Id: I11986e5db25bb82504644469190354a98403e2c1
2023-06-20 13:57:17 -07:00
Jagrut Desai
bde7e310c5 Merge "Match Navigation Icon Colors Folded/unfolded" into udc-qpr-dev 2023-06-20 20:04:55 +00:00
Alex Chau
8f19421a87 Add detailed exception for snappedIndex == -1 when dismissing tasks
Bug: 269956477
Test: manual
Change-Id: Ia95a3b2ffe5c677af34183639ba8a2742626c340
2023-06-20 19:04:55 +01:00
Andy Wickham
a3808a8e33 Merge "Revert "Switch ScrimView to use view alpha"" into udc-qpr-dev 2023-06-20 17:04:42 +00:00
Randy Pfohl
bdfaf926b4 Merge "Aligning the intialization process with groupedtaskview to set content description Test: built locally, tested against tablet with bluetooth keyboard." into udc-dev am: 6ec21cbe45 am: 7f44f3c6b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23699415

Change-Id: I68ba3799ec44f1910e8ea2327fe5de519ef538c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-20 16:56:14 +00:00
Treehugger Robot
a81e601afc Merge "Don't remove the overflow from the bubble bar" into udc-qpr-dev 2023-06-20 16:29:03 +00:00
Jon Miranda
883ce5f131 Merge "Fade in/out taskbar bg alpha when unstash/stashing." into udc-dev am: 613cc95c8a am: 004ed77d11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23696768

Change-Id: I7ed64a239bff6254151032758bc8ca9cff360c49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-19 06:45:22 +00:00
Randy Pfohl
6ec21cbe45 Merge "Aligning the intialization process with groupedtaskview to set content description Test: built locally, tested against tablet with bluetooth keyboard." into udc-dev 2023-06-16 23:18:02 +00:00
Jagrut Desai
68ca974330 Suspend immersive mode autohide while pending transient taskbar timeout
Test: open Youtube fullscreen video, swipe up on taskbar; ensure taskbar autostashes before immersive mode autohides
Fixes: 260765455
Flag: none
Change-Id: Ic579a20c60949e12ffc7f9548eded52fbdb06e0c
2023-06-16 15:42:57 -07:00
Jagrut Desai
6bf3af0b81 Match Navigation Icon Colors Folded/unfolded
Recently we did color token migration for Taskbar which included navigation icon also, but phones and foldable device can't really adapt to new color tokens because of contrast issue with underlying wallpapers.

As a result, now home screen which default back to balck and white nav icon colors while all apps and in app navigation icon color will be themed to new GM3 Color tokens.

Test: Manual
Bug: 284408922
Flag: Not needed
Change-Id: I8c8ea11ebb7237885ae4673fda0409ab463b37db
2023-06-16 20:13:15 +00:00
Liran Binyamin
cd5591a773 Don't remove the overflow from the bubble bar
When a new bubble is added to the bar and we're over the limit
remove the second to last bubble instead of the overflow.

This change also updates the key of the overflow bubble to
match the one in wmshell.

Bug: 287121592
Test: manual - Add 6 bubbles to the bubble bar
             - The overflow bubble should still be there
Change-Id: Ibd3ab73be5d3afb49f771a1925ebda2c45b55136
2023-06-16 14:51:33 -04:00