Commit Graph

6209 Commits

Author SHA1 Message Date
TreeHugger Robot
7d8ba14b3c Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev 2022-09-12 18:30:47 +00:00
Vinit Nayak
f5e5c8e1ce Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev 2022-09-12 18:29:22 +00:00
Sunny Goyal
1eb1124d82 Removing back-button alpha animation code
Back button is only animation in 2-button UI which is not supported anymore

Bug: 246006580
Test: Presubmit
Change-Id: I7385b07272e44c1f9f0488c158e1b4ee67060120
2022-09-09 17:15:24 -07:00
Vinit Nayak
2e4dcb16a7 Place TaskMenuView aligned with secondary split thumbnail
* Use consistent divider calculations in
different methods

Fixes: 245610772
Fixes: 218784487

Test: Open task menu view in split pair in landscape/
seascape/portrait, real and fake.

Change-Id: If1bbc7a0d4f1767584d0fc8cf549130f35b8e4a3
2022-09-09 11:25:08 -07:00
Vinit Nayak
5aa6deff8d Merge "Disable split pair long press smart actions" into tm-qpr-dev 2022-09-08 18:51:05 +00:00
Schneider Victor-tulias
5f4e93d669 Merge "Add STATE_LAUNCHER_DRAWN printing" into tm-qpr-dev 2022-09-08 18:14:20 +00:00
Schneider Victor-tulias
0b828e291c Merge "Finish recents animation to the matching state." into tm-qpr-dev 2022-09-08 18:11:43 +00:00
Ats Jenk
accde3a686 Merge "Filter out active freeform tasks from recents" into tm-qpr-dev 2022-09-08 16:07:19 +00:00
Jeremy Sim
8611800206 Merge "Prevent Overview Actions from appearing during split from home" into tm-qpr-dev 2022-09-08 00:45:41 +00:00
Vinit Nayak
e6c1c0ebf6 Disable split pair long press smart actions
Fixes: 236891562
Test: Long press launches task on split pairs.
Fullscreen overview tasks unchanged.

Change-Id: I5ff5377ddbf2bad60b3158dfef7ed2a8073fa0c4
2022-09-07 16:29:17 -07:00
Schneider Victor-tulias
07211eaed4 Add STATE_LAUNCHER_DRAWN printing
Added loging to only print and/or track multistatecallback states

Bug: 227514916
Test: tried various gestures and printed logs
Change-Id: I487b09ca0660fb385c34b49523a2417f11fcde00
2022-09-07 15:46:49 -07:00
Vinit Nayak
42fd4441a3 Run animation for liveTile before trying to launch it
* If current TaskView is running live tiles, animate directly
when toggling recents button instead of trying to
launch the task

Fixes: 240231324
Test: Launching a single GroupedTaskView from overview
launches as expected in 3 button.
Tested adjacent launches as well.

Change-Id: I6c060d918d3ae08bee9da1ad9507bb25cf445b96
2022-09-07 15:33:35 -07:00
Ats Jenk
461c3b3bd0 Filter out active freeform tasks from recents
Freeform tasks will show up as a separate, single tile in recents.
Filtering them out right now.

Bug: 244348395
Test: atest RecentTasksControllerTest RecentTasksListTest
Change-Id: Ifb197031076a8d8934cea78c6b68cb059477a81a
2022-09-07 15:32:02 -07:00
Jeremy Sim
7af10ad02c Prevent Overview Actions from appearing during split from home
Overview Actions will no longer erroneously appear when initiating a split from home.

The bug occurred because split from home causes an irregular state where the user is in split select, yet there is still a focused (main) task in Overview. Overview Actions did not anticipate this state and had no case to handle it.

Fixed by adding a check to Overview Actions so that they will never show when split selection is active.

Fixes: 244499708
Test: Manual
Change-Id: Idf1762c306dceb5048cefec8fa68ac9ca5468379
2022-09-07 12:13:47 -07:00
Alex Chau
0f1001c7b1 Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev 2022-09-07 13:45:16 +00:00
Alex Chau
e818bcb997 Use real IDP in DeviceProfileTest
- Mock WindowManagerProxy instead of IDP in DeviceProfileTest
- Extracted NavigationMode to standalone class
- Moved parseNavigationMode to WindowManagerProxy so it can be mocked
- Moved DeviceProfileTest to internal repo

Bug: 242086027
Test: DeviceProfileTest
Change-Id: Ia5a43293b1380f04d786d2adf8503cfd10f7674a
2022-09-07 10:35:21 +01:00
Sunny Goyal
7a6c610626 Merge "Moving view capture dump to a service to allow longer timeout" into tm-qpr-dev 2022-09-07 04:47:19 +00:00
Schneider Victor-tulias
2ae4420a12 Merge "Expand on gesture navigation error detection." into tm-qpr-dev 2022-09-06 17:32:02 +00:00
TreeHugger Robot
db32818a4e Merge "Made getOnBoardingPrefs @Nullable & avoid NPE" into tm-qpr-dev 2022-09-06 17:29:28 +00:00
Mateusz Cicheński
77593150da Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev 2022-09-06 16:36:48 +00:00
Alex Chau
4a206837c9 Enable adjacent task animation for grid
- Enable adjacent task animation for grid tasks
- Only parallax for focused task and only when it's fully visible

Bug: 236963497
Test: manual
Change-Id: I6c681e112f3eb2c7075bc98fab405d978f5057d1
2022-09-05 11:09:28 +01:00
Mateusz Cicheński
26db3bb62a The shelf height was mistakenly provided as width, making it equal to 0.
Bug: 244797561
Test: manually
Change-Id: I28e9c34bb0feb643c5d7b652c055d5fdceaec878
2022-09-03 04:33:18 +00:00
Schneider Victor-tulias
7ad70b6066 Expand on gesture navigation error detection.
- Added some missing error detection:
    1. screenshot capture errors
    2. recents scrolling errors
    3. end-of-gesture callbacks
- Added some more explanation for OverviewInputConsumer selection reason
- Added logging the current task's package name to help identify gestures

Bug: 227514916
Bug: 243471493
Test: Ran launcher, performed multiple gestures and checked logs
Change-Id: I8b10cc75f8640a674c6fed6b06efa4763c9635a2
2022-09-02 15:53:24 -07:00
Jeremy Sim
afff936235 Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev 2022-09-02 20:46:41 +00:00
Tracy Zhou
1649163334 Merge "Do not change layering for non live tile tasks rendering" into tm-qpr-dev 2022-09-02 19:18:22 +00:00
Alex Chau
f28c9f14a4 Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev 2022-09-02 10:06:37 +00:00
Tracy Zhou
668eec1e08 Do not change layering for non live tile tasks rendering
TaskViewSimulator#onBuildTargetParams is called for every single task rendering. Given the layering change doesn't work for the non live tile case (and we shouldn't change the layering in that case anyways), an additional check is added to prevent that from happening

Fixes: 242593058
Test: launch overview from home and app, and make sure that in both cases, task launch animation is intact
Change-Id: Ia242dc767499689547dfa8acae56d39e9b0c3189
2022-09-02 00:43:03 -07:00
Jerry Chang
bf9ce9c096 Support launching a shortcut and a task to split screen
Fix: 243101552
Test: long press on a shortcut to enter split screen works
Change-Id: Icaabf2e1c8be086bd1b79e0a2cf05878767caa15
2022-09-02 06:58:08 +00:00
Mateusz Cicheński
f6b782344c Merge "Replace shelf height with keep clear areas registration in Launcher." into tm-qpr-dev 2022-09-02 05:19:13 +00:00
Jeremy Sim
b33471a21f Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect
This commit fixes a bug where the user could cancel animations when transitioning between Launcher states, potentially resulting in a state where Overview elements (task thumbnails etc.) were wrongly hidden or invisible.

The bug occurred because functions such as createInitialSplitSelectAnimation() and createAtomicAnimation() did not carry out any cleanup upon animation failure. This resulted in RecentsView potentially being in a polluted state for the next launch.

Bug was fixed by adding cleanup routines to two onAnimationEnd listeners.

Fixes: 242715097
Test: Manual
Change-Id: I05415ecf515e247aa535e3ca8371e540c3189b01
2022-09-01 20:51:53 -07:00
Hyunyoung Song
c9be6ca870 Merge "Update container for ItemInfo." into tm-qpr-dev 2022-09-01 23:38:36 +00:00
Sukesh Ram
82da9fc5be Made getOnBoardingPrefs @Nullable & avoid NPE
Bug: 236679197
Test: Manual
Change-Id: I3cbb0891cbfcf7cab956a4e05a28dbbcc2b33e19
(cherry picked from commit c0650e7725)
2022-09-01 22:20:35 +00:00
Evan Rosky
eaaf065b73 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev 2022-09-01 21:11:01 +00:00
Alex Chau
3193522616 Change wallpaper depth value in AllApps bottomsheet
- Cap AllApps wallpaper zoom to workspaceContentScale rather than all the way to max depth (config_wallpaperMaxScale)
- Changed both workspace scale and depth interpolator to correlate with AllApps threshold

Bug: 240580498
Test: manual
Change-Id: I0342a37c72206268dcffc5697a212704a41b020f
2022-09-01 21:26:30 +01:00
Holly Sun
03caf49826 Update container for ItemInfo.
See https://docs.google.com/document/d/1eAxQ9p263FI8-ZdkOsiQoarhpwm9aOdncqfJUD42o1Q/edit?resourcekey=0-GJyyDut-Tfy29akzHyoz0Q for the debugging process.
Test: see video https://drive.google.com/file/d/1qpD7070v0qOaBEuYS0WoZauawyhL54MQ/view
Fix: 234848972

Change-Id: I2ed5d24d11ab2081c6faa5d040d72a9d1646e5ca
2022-09-01 12:10:31 -07:00
Sunny Goyal
f2c6bf8346 Moving view capture dump to a service to allow longer timeout
Bug: 243827665
Test: Verified on device
Change-Id: I7273cc14d86620b52aaf71c7ea293bd643d881f9
2022-09-01 11:57:23 -07:00
Hyunyoung Song
0397cb0ce7 Merge "Fix blurry wallpaper when user locks on all apps surface" into tm-qpr-dev 2022-09-01 15:50:39 +00:00
Pat Manning
e51e6446ad Merge "Undim kids nav icons on a11y focus and click." into tm-qpr-dev 2022-09-01 14:01:57 +00:00
Pat Manning
a3ebbbeba5 Merge "Update grouped task view thumbnail splash interpolation to match regular task." into tm-qpr-dev 2022-09-01 13:30:33 +00:00
Pat Manning
401f6bb0d4 Undim kids nav icons on a11y focus and click.
Fix: 241298057
Test: manual
Change-Id: I9a330bde4641a01b4d19dc83c8f25f56a69328c8
2022-09-01 12:42:04 +01:00
hyunyoungs
91ca748819 Fix blurry wallpaper when user locks on all apps surface
Bug: 242746421
Test: manual

TL;DR;;
setState toState= NORMAL called when locking screen on ALLAPPS screen
but mSurface==null
hence depth is not reset to NORMAL state

Change-Id: I26a37f7de8b0ecd481b36eebf07e1b79f8b0035c
2022-08-31 22:05:45 -07:00
Tony Wickham
d833fe4a12 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev
* changes:
  Fix taskbar stash state not persisting properly across recreate
  Add support to Tapl to recreateTaskbar
  Don't rely on QuickstepLauncher instance for tests
2022-09-01 00:52:54 +00:00
Evan Rosky
10c1c017c9 Only animate to hotseat when launcher is on home screen
Was assuming that resume == home-screen; however, in shell
transitions, launcher is resumed while overview is active,
so make sure it is both resumed AND "isTaskbarAligned"
before making the to-hotseat animation

Bug: 241800590
Test: Open an app, long-press taskbar to stash, long-press again
      to unstash
Change-Id: I117afcb006c363e50205f27f014ffc30d6f2896a
2022-08-31 22:53:02 +00:00
Pat Manning
038e112e9d Update grouped task view thumbnail splash interpolation to match regular task.
Follow-up to ag/19730966

Fix: 244433374
Test: follow up after b/238405972
Change-Id: I5c3c05dd51234b568e8f99c075e0f3384bca4741
2022-08-31 18:10:11 +01:00
Brian Isganitis
5166c5da3f Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-qpr-dev 2022-08-31 02:14:38 +00:00
TreeHugger Robot
bcbba897fc Merge "Add app predictions to secondary display app drawer & fix tab UI." into tm-qpr-dev 2022-08-31 00:01:21 +00:00
Schneider Victor-tulias
ff5ad47a06 Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev 2022-08-30 22:42:46 +00:00
Sukesh Ram
1b4869fcbc Add app predictions to secondary display app drawer & fix tab UI.
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
(cherry picked from commit 9e5fe63a22)
Merged-In: I2f45a4b30964b365bf149e8864a3af2ea909a237
2022-08-30 22:30:03 +00:00
Brian Isganitis
c043d45c42 Snap to last task if swiping down at a greater Y than X velocity.
If you swipe down slightly diagonally, it will almost always be treated as a swipe to the next task rather than a return to the current task. If we are swiping down and the Y velocity is grater, we should snap to the current task instead.

Test: Manually in fully gestural mode.
Bug: 222117127
Change-Id: I8c3cd483f7ceefe0de1e24b6e98918b12428ed10
2022-08-30 20:59:40 +00:00
Tony Wickham
e74569e935 Fix taskbar stash state not persisting properly across recreate
Because we check supportsVisualStashing() in
TaskbarStashController#init(), we need to avoid using
TaskbarUIController to provide that value since TaskbarUIController
isn't initialized until a bit later than the other controllers. So I
moved the logic from supportsVisualStashing() back to
TaskbarStashController, but still allow TaskbarUIController to override
it (e.g. for DesktopTaskbarUIController).

After that fix, I noticed that force stopping launcher (to test the fix)
would briefly show the taskbar background before resetting the stashed
state. This is also due to LauncherTaskbarUIController not being ready
immediately, since that's what sets FLAG_IN_APP due to launcher being
paused. To work around this, I set FLAG_IN_APP to true by default in
TaskbarStashController#init(), since that is the most common case, and
taskbar background/stashed handle isn't shown on home anyway.

Test: Force stop launcher while taskbar is stashed, verify it recreates
as stashed without background flicker; same when changing wallpaper
color on home or in app; also tested when taskbar isn't stashed and in 3
button mode for good measure
Test: testHideTaskbarPersistsOnRecreate
Fixes: 235986838

Change-Id: Ie55bd70e8288d5ad7433dde970f18c176831d747
2022-08-30 13:42:04 -07:00