Commit Graph

243 Commits

Author SHA1 Message Date
vadimt
d4c90e12e9 Freezing all apps updates during certain tests
This CL adds a very low risk because most (but not all) changes affect
only Launcher behavior during the test.

This should fix a lab-only flake when all apps keeps changing while
the test is working with it.

Example: test figures out which icon to click, by the moment it clicks
there, there is another icon there, or the icon is under the search box,
and clicking opens IME.

Switching test devices to airplane mode didn't help. The earlier change
that prevents popup menu cancellation is not general enough.

Now the tests are given an API to explicitly freeze and unfreeze
all-apps, which should be a final solution.

Bug: 132900132
Bug: 133765434
Change-Id: I8b81cc9be004482beb6cdcdd05406e2d9b4c7629
2019-06-06 11:10:56 -07:00
vadimt
3ca5280186 Fixing All Apps's getting stuck in a non-updating state
Normally, if all apps is open, and an app installs/uninstalls/updates,
All Apps will immediately reflect this.

However, depending on something subtle in the intensity of the swipe
gesture that brought All Apps, all apps will freeze, and won't update.

This frozen state will go away after scrolling in all apps, iteration
with an icon and, generally, any tap interaction with All Apps.
Otherwise, it will stay until it's closed and opened again via a gesture
with a different pattern.

The reason is in the code that freezes All Apps updates during user
interactions with all apps.

For example, during scrolls. Or while the user holds an icon, expecting
to see a context menu; in this case an update would cause the menu to
not appear, which is somewhat annoying.

The motivation to add this code was to solve a category of lab-only
flakes when a context menu couldn't open because the lab device was busy
with post-flash activities.

The code incorrectly assumed that after ACTION_DOWN, we are guaranteed
to get either UP or CANCEL, which is wrong.

It's after *consumed* ACTION_DOWN that we'll get these events.

The fix still solves the user's and tests' problems that the code was
supposed to solve.

Bug: 134442147
Change-Id: I9db74a33ecf93b1dc6bc69df301f7f542dea2a40
2019-06-03 18:35:52 -07:00
TreeHugger Robot
f54839bf35 Merge "Remove unnecessary dispatchInsets routing" into ub-launcher3-qt-dev 2019-05-24 00:31:18 +00:00
Sunny Goyal
ab3963ddcf Moving TestInformationProvider to Launcher3 so that it can be used for
testing Launcher3 without quickstep

Also keeping the provider as disabled until needed

Change-Id: Ib5f459e02ae551724b390f3b74f43d601568d749
2019-05-23 14:02:33 -07:00
Adam Cohen
a09cfe2340 Fix issue where AllAppsContainerView was blocking touches to part of the home screen
=> After the scrubber was engaged, it would continue to intercept touches forever
   (seems like a long standing issue)
=> Also fixed issue where the All Apps scrubber could be engaged from the Home / Overview
   states

b/133265591
b/132716177

Change-Id: I8c7b9d45be65216f2f1a69f69ab1636accd812c0
2019-05-22 14:21:12 -07:00
Sunny Goyal
2524b82369 Remove unnecessary dispatchInsets routing
Insets are dispatched to all views. We never consume the insets and
let each view decide what to do with it.
Also fixing scrim in all-apps when in full-gesture navigation

Change-Id: Ib1c6bef5b32aac0c6ea03078b5138d2d0408c6d8
2019-05-21 15:58:44 -07:00
vadimt
24d31d4b6e Disabling updating All Apps during a long-press recognition
This is supposed to eliminate test flakes in the lab.

When an app gets updated while all apps is opened, all-apps will be
re-laid-out.

If the layout happens while we are recognizing a long-press on an app
icon in all Apps, the long-press won't be recognized.

In the lab, this happened so frequently that it caused considerable
flakiness. Even after we started running tests in airplane mode, this
still keeps happening. The bug refers an example with airplane mode on.

The fix will be also mildly beneficial for users.

Bug: 132177321
Change-Id: Ie7c7473fe94b8af83f04cd719286bae69e2d9de0
2019-05-09 15:48:32 -07:00
Govinda Wasserman
c06e151e0f Makes Launcher hide the all apps content and scrim on assistant visible.
This hides the quick search bar and the suggested apps. Visibility is
unchanged when the all apps view is fully expanded.

Test: Tested locally
Change-Id: I6bc453b5ad89ca3d1280957e595bf2a3f074a72d
BUG:129755311
FIX:129755311
(cherry picked from commit 917af755e4)
2019-04-23 17:20:37 +00:00
Sunny Goyal
33611be973 Removing Launcher dependency in search box layout
Bug: 118758696
Change-Id: Id918c44b8bd2a97ab577481b7584afbe56e8a591
2018-11-20 13:53:33 -08:00
arangelov
ad78305862 Highlight work tab when user already in All Apps after creating WP.
When a user created a work profile and was already in the All Apps
view, the work tab was not highlighted, because the logic for that
was only in AllAppsContainerView#onScrollUpEnd(). This CL
highlights the tab when the user has resumed and the All Apps view
is expanded.

Bug: 79242814
Test: Manual
Change-Id: I40af0d513c95f8084e21f4e276e9f56bcb06555e
2018-08-17 20:28:52 +01:00
Vadim Tryshev
b6398a1eb8 Sharing protocol constants between Launcher and TAPL
Bug: 110103162
Test: TaplTests
Change-Id: I5b2a2b8576a7a6ea4a156f00858711496d6b5bba
2018-08-14 19:53:43 -07:00
Sunny Goyal
d230307a95 Migrating to android-x
Change-Id: I9a774152d13a541e8496dd84f2469bfed407f86d
2018-08-14 15:22:12 -07:00
Vadim Tryshev
dc755e718d Started converting Launcher to be gesture-stable
All tests keep passing.

WorkTabTest.workTabExists was made gesture-stable. There is no need to
use TAPL, as the point is not to check answering to gestures, but to
check presence of tabs, which is better to do using launcher internal
state. (It still fails if run as a part of all tests, presumably,
because after Launcher's start, changes in user configuration are not
recognized, so I've commented the failing part)

Bug: 110103162
Test: Run all tests
Change-Id: Ic30b8e8475d16cee3880332f12311a44ddfa26cb
2018-08-14 10:29:57 -07:00
Vadim Tryshev
ff3fa34a7a Fixing scrolling up in App Apps.
Done by scrolling only when scroll position is not zero. This way, the
scroll gesture can't close All Apps.

Bug: 110103162
Test: TaplTests suite
Change-Id: Icfe47d2bcc0210ae221df169d6c35cd1be10ff86
2018-08-02 14:15:05 -07:00
Jon Miranda
3c71c6a564 Fix bug where QSB gets clipped when flinging All Apps open.
Bug: 77538324
Change-Id: I3e40346559fd3b7010d92d28e12efcf2d8581640
2018-06-15 11:19:32 -07:00
Jon Miranda
b8ca1aa7ee Add hard clip for overscrolled children to not be visible above QSB.
We lose the RecyclerView fading edge, but this is the simplest/less risky
solution.

Change-Id: I7aa39a33678ed8a9b9cf9f17c9ad8c14707b0299
2018-06-15 09:26:57 -07:00
Sunny Goyal
c82c6396e9 Moving clear all button inside the recents view
Bug: 72222505
Bug: 109828536

Change-Id: I843b79db3e47abc2c41ed78f186b9c941941ddef
2018-06-11 13:51:03 -07:00
Jon Miranda
012d39a0e9 Fix crash caused by removing update listener in update listener.
Bug: 80236772
Test: Fling all apps open, and catch it before it reaches the top
Change-Id: I082a26b97afb7dbc162758ff9654e4a3707f9d7e
2018-05-25 10:41:16 -07:00
Jon Miranda
1d19e2f152 Start springs for All Apps when user flings up.
Bug: 77695481
Change-Id: Ifecfbbb89601947118f620f522662aee8a61946e
2018-05-23 09:13:07 -07:00
Sunny Goyal
927447e71d Chaniging all-apps scrim
> Converting the scrim to View, to better avoid overdraw
> Overview and Spring loaded state have different scrim alpha
> When going from overview to all-apps, there is a color scrim drawn over the overview panel.
  The slef color is merged with this color to prevent overdraw, and the remaining screen is drawn
  with a cut-out round rect path

Bug: 79111591
Change-Id: I26801fde13dd6adb4b06110bbe8087e35cc31847
2018-05-08 08:29:43 -07:00
android-build-team Robot
4d9c414cdb Merge "Bound overscroll shift amount to avoid content from drawing on top (Y-val) of the QSB." into ub-launcher3-edmonton 2018-05-01 21:07:59 +00:00
Jon Miranda
5916709219 Bound overscroll shift amount to avoid content from drawing on top (Y-val)
of the QSB.

Bug: 77538324
Change-Id: Idabc4365c5fe5cb1894fa0eb84ea9309b85f99a3
2018-05-01 13:57:33 -07:00
Sunny Goyal
36d090df67 Adding a round rect background for the self in Overview
Bug: 78771910
Change-Id: I71460a284ed185e82d66fe65104402fb99d6b312
2018-04-30 15:37:39 -07:00
Sunny Goyal
033e614127 Fixing crash when changing state while all-apps is not complete bound
Change-Id: I564501244cb1478195e5d226da295c13269ff524
2018-03-21 18:05:15 -07:00
Sunny Goyal
7185dd63eb Changing the overviewState to show appsearch and floating header
Change-Id: I2cfd61cfc9978e4c8e4520f0f7217e49e7344c79
2018-03-19 20:02:34 -07:00
Tony Mak
98f7350f8f Fix accessiblity issue around work tab
1. Instead of always announcing "Apps list", we now announce
"personal apps list" and "work apps list" if tab is there.
2. Fix an issue that "personal" and "work" are announced twice.
3. Work footer is now announced as a group

FIX: 71703082

Change-Id: I0240bc04df09a5599540cfe67f0f48156f285548
2018-03-14 17:32:18 +00:00
Sunny Goyal
8a2a63b3f0 Moving click and long click handling for items from launcher to separate class
Change-Id: I1d12862205f7fa7f3671ff351e66dba58bb430e2
2018-03-08 15:21:42 -08:00
Mario Bertschler
14a89262f1 Using edge effect to trigger spring animation for all apps.
Bug: 72811152
Bug: 72059944

Change-Id: Ied7b51caa2fb48a2fda126d59e4eaf6a35edded3
2018-03-08 11:16:53 -08:00
Sunny Goyal
3661bfac0b Fixing fast scroller touch handling in all-apps and widget sheet
Also removing scrim view, instead drawing the scrim manually

Bug: 73085356
Change-Id: I188c6c9b1685e22d5d97b38dd5d3e960b655c9ba
2018-03-06 11:41:43 -08:00
Sunny Goyal
d912e3f82a Merge "Simplifying all-apps search box" into ub-launcher3-master 2018-03-06 00:12:59 +00:00
Sunny Goyal
726bee7d5d Removing click-feedback shadow generation logic in BubbleTextView
Instead of animating the shadow, animating the icon scale. This avoids
unnecessary bitmap creating at app-launch and also plays nice with the
app-launch transition

Change-Id: I1d3d24bc7212a6d659855ff1002a45388e269e52
2018-03-05 14:56:38 -08:00
Sunny Goyal
dbd6bb348c Simplifying all-apps search box
> Giving the search box a solid background so that it work fine with scrolling
> bottom shadow logic for search box

Bug: 73085356
Change-Id: Ie4dc4922be39ffd8e2d562becedbd4c6f820e6c9
2018-03-01 15:58:11 -08:00
Sunny Goyal
6639a5dfe0 Updating the scrim and landscpae ui
> Instead of views, using a custom class to draw the color scrims
> All-apps has full screen UI
> Quickstep does not have search box in landscape

Bug: 73085356
Change-Id: I360a78a2ade0134daad29fe712796cd39a381fbb
2018-03-01 11:23:46 -08:00
Sunny Goyal
0bd7f4f2dc Using paged view for all-apps tabs
Bug: 72811152
Change-Id: I0cca426d935f079c923b93fe3d4399f87778fe95
2018-02-13 09:55:29 -08:00
Sunny Goyal
60180b049e Deferring all app updates until the pending executor is complete.
We were only deferring full apps binds and not partial updates which could cause
the model to go out of sync with Launcher.

Bug: 72051234
Change-Id: I20db0e86aadd1e6a518237026f6dfb03e469eb87
2018-02-07 15:55:58 -08:00
Sunny Goyal
ee047871eb Removing unnecessary view inflation
Using a predefined height for app icons, and for everything else,
inflating it on demand

Change-Id: I7520802f30d2111d63fe336b09f6264201cdea61
2018-02-06 11:00:09 -08:00
TreeHugger Robot
0ad5131d77 Merge "Removing support for app prediction from Launcher3" into ub-launcher3-master 2018-02-06 00:55:56 +00:00
Sunny Goyal
fde5505d02 Handling configuration changes
> Adding a listener for device profile changes
> Updating various controllers instead of recreating them
> Clearing all-apps icon

Bug: 71709920
Change-Id: Ief7db199eb7494ebd8fb433198f333cd2e8e661d
2018-02-01 14:47:08 -08:00
Sunny Goyal
c94cfc052c Merge "Initial changes for handling configuration changes dynamically" into ub-launcher3-master 2018-02-01 21:35:10 +00:00
TreeHugger Robot
6a22996244 Merge "Highlight the tab for the first time" into ub-launcher3-master 2018-02-01 17:28:56 +00:00
Sunny Goyal
f8d56fc8a1 Initial changes for handling configuration changes dynamically
Bug: 71709920
Change-Id: I88cf2229dea28d01c13a5a76d2290e91b07d095e
2018-01-31 15:20:30 -08:00
Sunny Goyal
b1d222e9a7 Removing support for app prediction from Launcher3
Derivative projects can extend the FloatingHeader to add support
to custom content in all-apps screen.

Change-Id: I4e29221a72e5a077a756713a6774cda7ecde8f1b
2018-01-30 20:53:11 -08:00
Sunny Goyal
426345bfc4 Adding AppsStore for handling various app updates
Change-Id: Ia2242ce583576ace0924ef7142793ba37f4adcb9
2018-01-25 15:19:29 -08:00
TreeHugger Robot
04ff8b1ca6 Merge "Fix work tab is gone when leaving search mode" into ub-launcher3-master 2018-01-18 23:31:55 +00:00
Tony Mak
cad08fb661 Highlight the tab for the first time
FIXES: 71748023

Change-Id: I051789172a1869ceb950eb5dbbf15e3eeb60ed64
2018-01-18 13:55:33 +00:00
TreeHugger Robot
fddaaca841 Merge "Update apps icon in prediction apps row when apps are updated" into ub-launcher3-master 2018-01-18 10:45:12 +00:00
TreeHugger Robot
d811d99daf Merge "Fix for badge updates in PredictionRowView" into ub-launcher3-master 2018-01-16 23:01:12 +00:00
Mario Bertschler
62d2db1d60 Fix for badge updates in PredictionRowView
Bug: 72054359
Change-Id: I6d435c380d182ba99f9627c049f7f36ad331ee1d
2018-01-16 14:49:51 -08:00
Sunny Goyal
12069e6cbf Removing some device profile dependencies in view contructors
Bug: 71709920
Change-Id: I13e33dceaeff71e3fb7bbb93f24be69c17d6da96
2018-01-16 14:17:47 -08:00
Tony Mak
faaf5a5399 Update apps icon in prediction apps row when apps are updated
Fix: 70717710

Change-Id: I89540893ca3c8c4eae3f47bc07c3deade135e5c3
2018-01-15 14:08:48 +00:00