Commit Graph

2345 Commits

Author SHA1 Message Date
Federico Baron
b986ac5398 Merge "Resolve issue where incorrect grid migration logic was used when migrating to strictly taller new grid" into main 2024-11-08 16:42:03 +00:00
fbaron
3c8a6c6914 Resolve issue where incorrect grid migration logic was used when migrating to strictly taller new grid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I615c2ada4a2275899c08f8b40589c53c9e1dff84
2024-11-07 22:22:35 -08:00
Sunny Goyal
8bbe47c31b Moving Wait to kotlin
Making LauncherInstrumentation optional and removing some reduntant constants.
This allows less dependency on AbstractLauncherUITest

Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I7cf78d6acc5fef0359dee141a06fd51ff9d4f5a8
2024-11-07 13:51:27 -08:00
Brandon Dayauon
270e1c3dc4 Merge changes from topic "implementWorkSchedulerViewAndUpdateColorsOfFab" into main
* changes:
  Make sure work button is collapsed when keyboard is up upon going to app drawer
  Implement the work scheduler view and update colors of FAB
2024-11-06 19:57:26 +00:00
Brandon Dayauon
bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Shamali P
ea078cb647 Add a resource override for providing default widgets filter.
The implementation in this CL is no-op i.e. all widgets will be shown

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
Federico Baron
43cc25b64b Merge "Fix grid migration tests with grid migration refactor flag on" into main 2024-10-29 07:01:16 +00:00
Charlie Anderson
b021c32c89 Merge "Fix flagging for LoaderTask broadcast tests and add more coverage" into main 2024-10-28 18:55:43 +00:00
fbaron
22029f6517 Fix grid migration tests with grid migration refactor flag on
Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationDBControllerTest, ValidGridMigrationUnitTest
Change-Id: I2dceb5f9756da7ee7e7ef2d5ec29b3550a51e965
2024-10-28 10:46:17 -07:00
Charlie Anderson
7df6af5831 Fix flagging for LoaderTask broadcast tests and add more coverage
Flag: EXEMPT just tests
Bug: 375674876
Bug: 375704692
Test: LoaderTaskTest and presubmit
Change-Id: Ied00f9282f48ee88949697e5d684c489013e8aeb
2024-10-28 13:15:27 -04:00
Anushree Ganjam
ba8c0a8fbd Merge "Make ApiWrapper to be injected by dagger (12/n)" into main 2024-10-25 19:27:50 +00:00
Anushree Ganjam
ef2c5c0e49 Make ApiWrapper to be injected by dagger (12/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
fbaron
a796d74e36 Refactor grid migration
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately

In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin

Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
2024-10-23 22:26:38 +00:00
Schneider Victor-Tulias
8463dc47eb Generalize ActivityTracker to support RecentsWindowManager
Continued quick switch couldn't work using existing infrastructure until RecentsWindowManager could be properly tracked by ActivityTracker. Refactored ActivityTracker into ContextTracker to support this.

Also refactored ActivityInitListener into ContextInitListener to fit the updated pattern.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366023051
Test: RecentsWindowSwipeHandlerTestCase; Attempted continued quick switch from home and launched app
Change-Id: Ic38ebf3611ef22fbfd1ddeb79d72d8a3621940a0
2024-10-22 15:29:59 -04:00
Schneider Victor-tulias
892ad69191 Merge "Improve test isolation in AbstractLauncherUiTests" into main 2024-10-17 19:22:37 +00:00
Sukesh Ram
fc6cc4e409 Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 324419890
Test: Manual
Change-Id: I54145d07f0699f68c44aaa34e1692c8fe2f7b780
2024-10-16 16:55:45 -07:00
Schneider Victor-Tulias
07669e9575 Improve test isolation in AbstractLauncherUiTests
- Removing suspicious duplicate uses of AbstractLauncherUiTest.initialize to prevent unnecesary launcher restarts
- Adding UiDevice#pressHome to AbstractLauncherUiTests.verifyLauncherState to ensure the next test starts with a known clean state

Flag: EXEMPT test fix
Fixes: 372956489
Test: AbstractLauncherUiTest
Change-Id: Id68ece4ab195a4f6c47aa401eb50a91b8ff70e10
2024-10-16 13:18:36 -04:00
Sunny Goyal
0bf39fdf26 Merge "Removing unnecessary SafeClosable requirement from DaggerSingletonObject" into main 2024-10-14 17:06:13 +00:00
Sunny Goyal
bf9d047b53 Removing unnecessary SafeClosable requirement from DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger
Change-Id: I453159be83e92eee92f5a18cfe0d3ea9a3123f47
2024-10-12 01:26:50 -07:00
Treehugger Robot
99f6d447ea Merge "Cleaning up temporary interfaces which were created for refactoring" into main 2024-10-11 23:02:52 +00:00
Sunny Goyal
43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Federico Baron
f20255fd09 Revert "Demote TaplThemeIconsTest#testShortcutIconWithTheme"
This reverts commit 7672f320e8.

Reason for revert: issue no longer happening

Change-Id: I6dd0b00deb626e0248abc9007c0ae58743931f0c
2024-10-10 18:45:56 +00:00
Sunny Goyal
266f51b488 Converting LauncherModel to kotlin
> This will make it easier to migrate to dagger as it will
  increase the number of constructor parameters significantly

Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: Id06246ec74c678d7614f4c6a798c5644b40a0545
2024-10-10 00:34:12 +00:00
Sunny Goyal
6a207fc4f9 Moving manifest initialization to RoboApplication instead of a separate rule
This makes the behavior same as instrumentation test

Bug: 370080120
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: Id4183c91f3951748b657b583fde8860abe55d3a8
2024-10-08 11:00:22 -07:00
Jagrut Desai
831ca957c0 Merge "Remove unused TestProtocol" into main 2024-10-02 20:51:10 +00:00
Treehugger Robot
3faec179c0 Merge "Add debug memory logs to AbstractLauncherUiTest" into main 2024-10-02 15:39:05 +00:00
Anushree Ganjam
0dc88fece8 Merge "Make InstallSessionHelper injected by Dagger (7/n)" into main 2024-10-02 01:57:48 +00:00
Anushree Ganjam
29e060408f Make InstallSessionHelper injected by Dagger (7/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration

Change-Id: Ib1833436bfd1079ae78f1d865831c1aa8a7a0c41
2024-10-01 12:45:53 -07:00
Schneider Victor-Tulias
63dfd60b23 Add debug memory logs to AbstractLauncherUiTest
Flag: EXEMPT test debug logs
Bug: 365628676
Test: TAPL tests
Change-Id: Ia019bc128b76b9b2d776c54ad93713ae4110b2de
2024-10-01 18:15:13 +00:00
Jagrut Desai
85a8898402 Remove unused TestProtocol
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: Ibe261ec8820f5d6e8415f5085c21a0adfef37462
2024-10-01 09:24:38 -07:00
Treehugger Robot
0c1db56f2f Merge "Requesting ApplicationInfo in cached object" into main 2024-09-28 00:08:58 +00:00
Treehugger Robot
947a932a33 Merge "Cleanup for TAPL Debugging" into main 2024-09-27 21:21:49 +00:00
Sunny Goyal
f7c32a29fd Requesting ApplicationInfo in cached object
Bug: 363324203
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I92f3d3ed8c267b895dc439ba1f01eb67d7f63965
2024-09-27 14:04:16 -07:00
Sunny Goyal
63c24aeacb Merge "Updating IconProvider API to use a single API to load icons" into main 2024-09-27 19:43:54 +00:00
Archisha Baranwal
10467a8cf3 Merge "Adding programmatic provision of WRITE_SECURE_SETTINGS permission to Launcher3Tests." into main 2024-09-27 08:35:45 +00:00
Archisha Baranwal
0d11c4a7ef Adding programmatic provision of WRITE_SECURE_SETTINGS permission to
Launcher3Tests.

Bug: 361222449
Test: atest Launcher3Tests
Flag: EXEMPT test fixes

Change-Id: I4226c4c50047d71a99944fc4e5d70080d134c3d3
2024-09-27 05:53:59 +00:00
Sunny Goyal
a1cebfa0c0 Updating IconProvider API to use a single API to load icons
Bug: 366237794
Test: atest IconProviderTest
Flag: EXEMPT refactor, changes in underlying API

Change-Id: If8c6a4f13de7e7d262ee0b6d0c6897981f75e639
2024-09-26 22:13:11 -07:00
Sukesh Ram
e297bc0c0e Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 326908466
Test: Manual
Change-Id: I01dadc884929a8946f408997ddbcbd0ac4c820ec
2024-09-26 19:44:55 +00:00
Treehugger Robot
9a77922424 Merge "Fix for bug where we don't use default grid on comet, and migrate normally if not in a B&R case" into main 2024-09-25 17:01:54 +00:00
fbaron
b633b9aa2b Fix for bug where we don't use default grid on comet, and migrate normally if not in a B&R case
-The grid migration where we just copy the grid and move everything one row up should only occur in a B&R scenario, so now we add that restriction
-We should default to 4x5 in comet if migrating from a 4x4 grid if the device we're migrating from does not have any other grids saved
-if we have other grids saved, then we'll try using the saved grid if possible. If not possible, we use the default grid for the new device

Bug: 360462379
Test: GridSizeMigrationUtilTest
Flag: EXEMPT bugfix
Change-Id: Ia905081046431c08dc058bd61b2b4ab42dee0506
2024-09-24 16:52:05 -07:00
Sunny Goyal
e1b7ca566e Merge "Moving various application into related methods to a separate class" into main 2024-09-24 22:05:52 +00:00
Sunny Goyal
28d6bbd6b4 Moving various application into related methods to a separate class
> This avoids duplicate RPCs when trying to get multiple properties
  from AppInfo
> This would be used in a followup cl when AppInfo is added to caching
  logic in IconCache

Bug: 366237794
Test: atest ApplicationInfoWrapperTest
Flag: EXEMPT refactor
Change-Id: I55b964d4f8cfa1ff1770e310ac278719495e285d
2024-09-23 22:09:24 -07:00
Sunny Goyal
c3dd1c380f Removing unnecessary package validation during grid migration
package validation happens during loader anyway. And using MATCH_INSTALLED
for checking cross user apps may not work all the time

Bug: 363324203
Test: atest GridSizeMigrationUtilTest
Flag: EXEMPT bug fix
Change-Id: Id36e8fdff132242705ef53c85dc6567fbde5d952
2024-09-23 15:16:37 -07:00
Sebastián Franco
dee300f77d Merge "Removing screen record from TaplWorkProfileTest" into main 2024-09-19 01:44:36 +00:00
Treehugger Robot
98d85d6dc0 Merge "Revert "Add screenrecord to testDragIconToPage2"" into main 2024-09-16 21:50:40 +00:00
Federico Baron
9045632654 Revert "Add screenrecord to testDragIconToPage2"
This reverts commit cf55a30dcf.

Reason for revert: no longer needed

Change-Id: I08a9a0c90e1298d7206c7544de08b557fd89b58e
2024-09-16 20:03:10 +00:00
Sunny Goyal
98001dd1dc Merge "Migrating prediction_undo to aconfig" into main 2024-09-16 17:26:58 +00:00
Sunny Goyal
d94100a223 Migrating prediction_undo to aconfig
Flag: com.android.launcher3.enable_dismiss_prediction_undo
Test: atest SystemShortcutTest
Bug: 270394476
Change-Id: I5daef5d168c301115d860a1ae1d3c96f70a0f18f
2024-09-13 20:21:32 -07:00
Treehugger Robot
e738e4bf07 Merge "Revert "Add screenrecord for testDragAppIcon"" into main 2024-09-14 02:21:30 +00:00
Treehugger Robot
2ff010dfbe Merge "Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"" into main 2024-09-14 02:18:53 +00:00