Commit Graph

3315 Commits

Author SHA1 Message Date
TreeHugger Robot
f58691ae42 Merge "Add ALLOW_SLIPPERY_TOUCHES to make StatusBarTouchController slippery" into sc-dev am: c0231f8d0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16444734

Change-Id: I405e4c79cc91ccbeb0472870ad1395eccaa8b64b
2021-12-23 06:55:10 +00:00
TreeHugger Robot
c0231f8d0f Merge "Add ALLOW_SLIPPERY_TOUCHES to make StatusBarTouchController slippery" into sc-dev 2021-12-23 06:40:12 +00:00
TreeHugger Robot
5181163070 Merge "Fix testStressSwipeToOverview" into sc-dev am: aabead2db8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16471550

Change-Id: Id7353bbafe62f70b0b1659455e731bc3ecf85de2
2021-12-22 20:23:47 +00:00
TreeHugger Robot
925768d35a Merge "Fix issues with starting new recents animation before previous onRecentsAnimationStart" into sc-dev am: 1a453f1547
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16471461

Change-Id: Ia6ddad23a2ebaa5737ffe12ce91501ec23dc8489
2021-12-22 20:23:45 +00:00
TreeHugger Robot
aabead2db8 Merge "Fix testStressSwipeToOverview" into sc-dev 2021-12-22 01:50:59 +00:00
Tony Wickham
f540e5caa2 Fix testStressSwipeToOverview
- Finish recents controller to app rather than to launcher, to ensure taskbar state uses in-app configuration
- Also fix an issue when a gesture completes before onLauncherStart, which happens in 3 button mode. The error I saw in the test was:
java.lang.AssertionError: http://go/tapl test failure: Failed to receive an event for the state change: expected [Overview], actual: [Background, Normal];
Context: want to switch from background to overview, clicking Recents button; now visible state is Background
(This also accurately describes what I saw on the device, where the LauncherState went to Normal but the task was still running in the live tile)

Test: testStressSwipeToOverview
Fixes: 203577620
Change-Id: I19616f7921c9821f1b45a90a3e4bec4fb3b8a9d3
Merged-In: I19616f7921c9821f1b45a90a3e4bec4fb3b8a9d3
(cherry picked from commit ce6bf7dd7f)
2021-12-15 05:45:43 +00:00
Tony Wickham
ee24e46a61 Fix issues with starting new recents animation before previous onRecentsAnimationStart
- Fix logic for canceling animation for continued quick switch, so that this case (starting a new gesture before onRecentsAnimationStart() of the previous gesture) instead goes to the STATE_FINISH_WITH_NO_END flow.
- Update the end target so that we go to that state instead of always overview state if swipe was past the halfway threshold when we call endLauncherTransitionController(). This is specifically so we don't use OverviewInputConsumer on the second gesture, given the first one was canceled and didn't actually go to overview.
- GestureState#isRecentsAnimationRunning() now checks for STATE_RECENTS_ANIMATION_STARTED rather than _INITIALIZED, to be consistent with its javadoc and TaskAnimationManager#isRecentsAnimationRunning(). This also ensures we can correctly calculate continued quick switch (see above).
- Call cleanUpRecentsAnimation() before creating a new one in TaskAnimationManager. This ensures that the previous listener doesn't immediately cleanup the new gesture when it gets onRecentsAnimationCanceled() due to the new recents animation starting.

Test: swipe to home twice from the app, locally ignoring the onRecentsAnimationStart() from the first one, and ensure the second one responds normally
Bug: 193851085
Change-Id: I76e27c96b54293805546c0d6c82e77f975c69d7a
Merged-In: I76e27c96b54293805546c0d6c82e77f975c69d7a
(cherry picked from commit 66ed0ff23e)
2021-12-15 05:44:27 +00:00
Siarhei Vishniakou
81ff81227e Add ALLOW_SLIPPERY_TOUCHES to make StatusBarTouchController slippery
LauncherActivity uses FLAG_SLIPPERY for certain interactions. For
example, when home screen is shown, and the user pulls down from not the
top of the screen, and notification shade is getting displayed, then the
touch should be getting transferred to the NotificationShade using
FLAG_SLIPPERY.

The newly introduced permission is added to launcher in order for this
flag to be applied to the window.

Bug: 206188649
Bug: 157929241
Test: reviewed logs, ensure that NexusLauncherActivity has FLAG_SLIPPERY
Test: re-ran the performance regression test
Change-Id: I8d05fa3663687b5382a59b0d47cdac404844c3b7
2021-12-12 06:22:08 +00:00
Bill Lin
6648ab32bc Merge "Allow One-handed gesture when densityDpi > 600" into sc-qpr1-dev 2021-11-03 00:59:46 +00:00
Bill Lin
2b74e3c290 Allow One-handed gesture when densityDpi > 600
This logic was aim to prevent tablet device enable One-handed gesture
so added displayInfo.densityDpi < DisplayMetrics.DENSITY_600 before.

However, it seems this densityDpi=600 does not able to represent to
tablet device, instead we already have system property
"ro.support_one_handed_mode" which provides feasibility to config false
on tablet project, as the reason we can safe to remove this condition.

Bug: 203936659
Test: adb shell wm density 600 , and observe OHM gesture is available
Test: atest WMShellUnitTests
Change-Id: Ic7ae10e8a47d26b9bb39ab80e22d591d74f89ae5
Merged-In: Ic7ae10e8a47d26b9bb39ab80e22d591d74f89ae5
2021-11-02 02:50:09 +00:00
Vinit Nayak
6434f8eae5 Show all TaskViews when doing seamless overview rotation
* If user is scrolling and rotates overview in fake
landscape, we wouldn't change the alpha to show if it
was hidden previously.
Now we only skip changing the alpha if it's already visible.

Bug: 194715506
Test: Scroll overview in fake landscape and rotate.
No more invisible task.

Change-Id: Idb519125fbb5ec7be33e0d7b6dd313fb4df684db
2021-09-15 19:17:54 +00:00
Samuel Fufa
b5a33b2d34 Merge "Remove HotseatEduActivity from AOSP" into sc-qpr1-dev 2021-09-07 21:55:23 +00:00
Alex Chau
32d872b840 Merge "Only call setCurrentPage in applyLoadPlan if mCurrentPage is outdated" into sc-dev am: 464fc41df7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15742147

Change-Id: I13e5176c8f53e176d8e94f418828452019deb8ff
2021-09-07 17:44:44 +00:00
Tony Wickham
5a36b919b5 Call onUserUnlocked() before adding callbacks
This gives us a chance to initialize things in onUserUnlocked() if we're already unlocked, before doing any other logic that might use those variables.

Test: None (unable to reproduce)
Fixes: 184773649
Change-Id: I72ed91ae6202ec816f9bdceb4d9fd03b9a002816
2021-09-03 22:07:18 +00:00
y
ac68842059 Remove HotseatEduActivity from AOSP
Bug: 191882450
Test: manual
Change-Id: Ic60ef6fec6c3d8162cb3d11b0ed3c9f89f6b5704
2021-09-02 18:18:59 +00:00
Alex Chau
dacb37c143 Only call setCurrentPage in applyLoadPlan if mCurrentPage is outdated
- Apply the same for all 3 setCurrentPage cases as they can all causes page jumping

Bug: 197493120
Test: manual
Change-Id: I5f7013ce3ce4d6fe84c67123618c3bebeeffc43a
Merged-In: I5f7013ce3ce4d6fe84c67123618c3bebeeffc43a
2021-09-02 16:06:44 +00:00
Vadim Caen
84ec20af98 Merge "Disable splash screen for launches from widget." into sc-dev am: 97aaa6e5ae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15685202

Change-Id: Ie2fcf73aaa402706eb369f41c0326c3d641974d5
2021-08-30 16:37:31 +00:00
Vadim Caen
ee44c4dc1e Disable splash screen for launches from widget.
The transition from a widget to the splash screen icon feels
odd because of the difference in shapes. Disable for S and rework that
in T.

Test: Manually tested with clock and Calendar
Bug: 197504657
Change-Id: Ia375885af967d6ad282dcc7325ad905731c8734d
2021-08-27 19:17:03 +02:00
Lucas Dupin
6d7a006302 Constrain scroll amount
Test: scroll vertically and horizontally
Fixes: 196309367
Change-Id: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
Merged-In: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
(cherry picked from commit b259a896f5)
2021-08-25 16:45:20 +00:00
Alex Chau
d688120ee1 Merge "Fix animation problem when swipeing up app to screen edge and release" into sc-qpr1-dev 2021-08-25 09:08:03 +00:00
Lucas Dupin
e3cf162169 Synchronize surface transaction am: 0a2076e8d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15669618

Change-Id: I494543d4183689bfcec9ed4e384be4ad3e660707
2021-08-25 03:35:43 +00:00
Lucas Dupin
0a2076e8d3 Synchronize surface transaction
Until now the SurfaceControl transaction was being applied
asynchronously, which could lead to it being executed out of sync with
launcher drawing.
This became an issue at higher refresh rates, where frames are produced
at a much faster pace.

In order to fix this issue, we can use BLAST transactions, which are
annotated with a frame number.

Test: record video, go through it manually
Fixes: 194320152
Change-Id: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
Merged-In: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
2021-08-24 21:28:50 +00:00
Alex Chau
df2b9e14d6 Fix animation problem when swipeing up app to screen edge and release
- Consider scroll diff between currentPage and primary scroll when calculating adjacent page offset
- Removed setEnableFreeScroll call in onPrepareGestureAnimation that calls setCurrentPage and causes jumping

Fixes: 197012570
Fixes: 195740577
Test: Swipe up from app to end of screen, adjacent task should come from screen edge, and app should snap smoothly to position
Test: Swipe up from app, scroll immediately, free scroll should be enabled
Test: Swipe up immediately after quick switch, task thumbnails are loaded
Change-Id: Id88266634183dfcb18d5ba8a803883b7d6f50ab4
Merged-In: I1964b8c3bd82b22396340d2352833b2aee73a6fc
(cherry picked from commit 8ebd11af14)
2021-08-24 10:11:41 +00:00
Lucas Dupin
f52fb6f632 Act on scrim visibility am: a8382dc052
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15655786

Change-Id: I40626071bdaadd997cc1479118224847b78229d3
2021-08-23 21:34:23 +00:00
Lucas Dupin
a8382dc052 Act on scrim visibility
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.

Fixes: 195365607
Bug: 196403152
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
(cherry picked from commit e4a9469156)
2021-08-23 19:22:02 +00:00
TreeHugger Robot
686d42a1d4 Merge "New app animation specs." into sc-qpr1-dev 2021-08-19 00:45:05 +00:00
Jon Miranda
bda98de9f8 New app animation specs.
- New values and interpolators.

Bug: 173107751
Test: open apps from different parts of the home screen
Change-Id: I81bec0221aec9c04dac0bb3e926c879999699e57
2021-08-18 18:26:46 +00:00
Lucas Dupin
482f983a7b Add depth to -1 screen
Wallpaper will zoom out as you drag the overlay

Test: manually pull overlay
Fixes: 192502999
Change-Id: I9067b70d10497d4e16a5ef601161fbedfa9307e1
Merged-In: I9067b70d10497d4e16a5ef601161fbedfa9307e1
(cherry picked from commit 87d752062e)
2021-08-18 15:34:45 +00:00
TreeHugger Robot
3be0173b14 Merge "Adjust all apps zoom level" into sc-dev am: 6b10f4649c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15530106

Change-Id: Id2a24af3aed6fa4819a2fc46c8a305b06ff31d84
2021-08-12 00:31:19 +00:00
Lucas Dupin
3f6a4e6bf5 Adjust all apps zoom level
The All Apps scrim fades in early, covering part of the zoom animation.
We need to adjust the max zoom in order to make All Apps consistent with
Overview, -1, and Shade.

Test: pull up the all apps drawer
Fixes: 195992422
Change-Id: Ia7bbe17fe7f227dd0a16ba7d21b402cff57176f0
(cherry picked from commit f168bb7aaf)
2021-08-11 15:55:04 +00:00
Thales Lima
931bc2a38e navigation: don't run gesture animation if gestures are not enabled
Makes the animation when using 3 button navigation be closer to what we
have in non fallback mode, also fixing the problem when fallback recents
just started and don't have any views.

Fix 194487871
Test: manual with gestures, 2 button and 3 button nav

Change-Id: If3925d6bef1d14f51b86169d06607786972f5f1f
(cherry picked from commit 8d49c4bb29)
2021-08-11 10:26:22 +00:00
Tony Wickham
0b3b2921c3 Don't recreate touch controllers when ending gesture
Test: swipe up to overview from an app and swipe up to dismiss it during the transition
Bug: 189700453
Change-Id: I303696f90dbb236ea93e06d94a3c92d783850fa4
(cherry picked from commit 0e9ecaeea8)
2021-08-10 23:26:33 +00:00
Tracy Zhou
145bd74749 [DO NOT MERGE] Disable live tile in split mode for S
Recall link: https://recall.googleplex.com/projects/debb8388-5e38-42c5-99ab-20bdfb92d25e/sessions/655af962-b4bd-4dc4-93aa-178852c0d701

Bug: 193991436
Test: enter split screen and swipe up
Change-Id: I7adffcdefb12d225db207542716a436f29df0377
2021-08-03 20:50:27 +00:00
Alex Chau
fb5ae9060d Always treat FallbackRecentsView as visible if isInLiveTileMode is true
- activity.hasBeenResumed is no longer an accurate indicator after live tile has been introduced, indeed it's always false
- Return recentsView regardless if there is a runningTask as well

Bug: 194286330
Test: In fallback Recents with 3 button, tap overview button from home screen, then tap overview button again. Try combination with back and home button
Change-Id: Ib2775a11f5466abc433763f24192e7bfdcf191a2
(cherry picked from commit 455718e842)
2021-07-30 08:22:03 +00:00
Tracy Zhou
6842315605 Clear command queue of OverviewCommandHelper on home tap
Fixes: 194934483
Test: manual
Change-Id: Id83b341245793c38c305e6ada5581ac4e49527a7
Merged-In: Id83b341245793c38c305e6ada5581ac4e49527a7
2021-07-29 19:09:53 +00:00
Tracy Zhou
024749a1e0 Merge "Reset current task and dequeue overview commands when recents animation is cancelled" into sc-dev 2021-07-26 21:17:38 +00:00
Tracy Zhou
94e798bac1 Reset current task and dequeue overview commands when recents animation is cancelled
Fixes: 193925362
Test: manual
Change-Id: I792be003e5aabf34324075829d5381cba591892b
2021-07-26 12:17:01 -07:00
Sunny Goyal
58e81e5da1 Fixing touch events ignored in some cases
Bug: 160218103
Test: Manual
Change-Id: Ifa71e742451acecd8979a6833a202c6189b4df52
2021-07-22 15:27:43 -07:00
Jason Chang
1b3f5d3883 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev 2021-07-22 09:43:13 +00:00
Brian Isganitis
ec4a56a311 Support overriding All Apps EDU animation on drag
Test: Dragging during All Apps EDU animation overrides the animation.
Bug: 160218103
Change-Id: I1c0a2d047bcb43ea7ce30cf87182b392dac313e4
2021-07-21 17:39:00 +00:00
Jason Chang
edc7917521 Fix unable to swipe up to exit one-handed mode under
2 button navigation

Remove redundant condition checking when consuming One-handed mode
gesture events.

Bug: 193761450

Test: manual
Test: atest WMShellUnitTests
Change-Id: Id4687cb579c17d7de1a08b32c003e656cbbce820
2021-07-21 11:54:52 +08:00
Lucas Dupin
ee9099af7f Revert "Apply depth even when surface is null"
This reverts commit a6c38be150.

Fixes: 193333562
Test: manual
Change-Id: I4fae079e0cd056fc800e5a15389f4795c77e17fb
2021-07-20 14:14:50 -07:00
Sunny Goyal
c3f56d7628 Merge "Fixing quickswitch window not properly aligned in split-screen" into sc-dev 2021-07-20 07:03:51 +00:00
Sunny Goyal
a1bed5428d Fixing quickswitch window not properly aligned in split-screen
Bug: 193992000
Test: Manual
Change-Id: Ic37cbc561a0299be1a1c05dfb17bd826c173100e
2021-07-19 17:10:12 -07:00
Jonathan Miranda
8e095ccb05 Merge "Fix notification dot not always being up to date." into sc-dev 2021-07-19 17:45:26 +00:00
Jon Miranda
f8441cc276 Fix notification dot not always being up to date.
- Prediction row views were never updated when notification changes.
- FloatingIconView set the BubbleTextView to force hide dot, but never restored it.
  BubbleTextView is instanceof IconLabelDotView, so its already handled in the end runnable

Bug: 183360736
Test: 1. swipe up to go home such that the closing app has a notification,
         note that the notification dot is properly updated
      2. have all apps open
         make notification update for a predicted app
         ensure dot is properly updated

Change-Id: I35dacf9b71a3d8b8a857be450690d65ea9199bf6
2021-07-16 17:50:56 -07:00
TreeHugger Robot
f054bf5681 Merge "Fixing regression from animation not starting while in overview" into sc-dev 2021-07-16 01:27:02 +00:00
Winson Chung
558b18eb12 Fixing regression from animation not starting while in overview
Bug: 193830420
Test: Open an app in overview, tap on a notification
Change-Id: Ifd9797dc40d9fffbf9603bca98fcb4a4119e0444
2021-07-15 16:17:51 -07:00
Cyrus Boadway
66f1b57815 Merge "Keep transparent drawable for clipping outline during launch animation" into sc-dev 2021-07-15 18:28:29 +00:00
Hongwei Wang
a35d7ec90e Merge "Use display cutout info in auto-enter-pip transition" into sc-dev 2021-07-14 23:52:42 +00:00