The line causes an error in Window Manager. When removed, it doesn't
seem to have an effect for the Wallpaper Picker use case. The preview
render still shows correctly after config changes including rotation
and dark/light theme because the picker restarts and re-requests a
preview.
Flag: NA
Bug: 328089367
Test: manually tested with config changes and different lifecycle cases
Test: manually tested with multi crop flag on and off
Change-Id: Id1bd30c7ab4c50d29622b647bd368aafbd5c043f
Launcher preview could crash when unfolding a foldable device due to the
folded state display id no longer being valid, resulting in getting a
null display. This was leading to an empty preview bundle being
returned, which is unexpected because null is expected in the case of an
exception. Instead of crashing in getDisplayId, it's better to throw an
exception earlier on if the display is null and return null.
Flag: NA
Bug: 326637851
Test: manually verified by testing unfold in WPP in old and new preview
Change-Id: Ibc353d9447a71d33092d96029a812017487d0970
- Adds flag for indicating when we are loading after a restore, separate from the pending restore flag
- Adds many success/failure scenario metrics when loading and binding items
Flag: ACONFIG enable_launcher_br_metrics DEVELOPMENT
Test: locally verified
Bug: 307527314
Change-Id: I9d2660f6d9d7cd5813072201e96b1a64aec4ea4b
Flag: persist.wm.debug.wallpaper_multi_crop
Fix: 292152331
Test: Manual testing, make sure to turn on the flags by running this adb commands
adb shell setprop persist.wm.debug.wallpaper_multi_crop 1
adb shell device_config put customization_picker com.android.wallpaper.multi_crop_preview_ui_flag true
Change-Id: Iba9518e93c09f0f8304cbce4c3bee9f8753cd583
The existing code almost have the avility to use different display
for the preview by providing a different display id, this change
just make sure the InvariantDeviceProfile is created after we
create a new context with the desired display and we need to use
the default display for the SurfaceControlViewHost
Test: Manual testing, changing the display id on FixedWidthDisplayRatioFrameLayout
Bug: 292152331
Change-Id: I450d94a9a3f1a6a7b0c2b0722a11cf335122de05
The LauncherBinder is null in LauncherPreviewRenderer, which was
causing an NPE in LoaderTask.
Bug: 279347305
Test: Used logs to verify that the LauncherPreviewRenderer was actually
loading using the LoaderTask. Most of the time, it does not, so that is
why I didn't catch this before pushing it.
Change-Id: Ic5b45abfdeb73a4bbe1f521ae4d627b6cfcfec54
This reverts commit 9ef41413e0.
Reason for revert: This was the only launcher CL during the time b/280669657 and 280680602 occurred
Change-Id: Id7107f0935f84908ca87e1ae4c62ab05efe41a24
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.
This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.
Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
To calculate the widget scales correctly for the launcher preview in different grids, the span info of the widgets in the launcher is necessary. Querying the launcher widget info in the database and passing it to the preview render.
Test: Verified that no exceptions were happening when changing preview grid layouts
Bug: 228328759
Change-Id: I681d21b176c8fe5208431a79009d9ba8279cda6a
Test: Search bar in wallpaper preview follows dark theme without themed
icons enabled.
Fix: 197475508
Change-Id: Ib71356fad3510348c1408c886c4796bc16a59642
- Don't remove a single page if it's empty, only if both pages are empty.
- Add back empty pages after they were removed while the phone
was on single panel home.
- On two panel home don't add new workspace items onto the second screen
Test: manual
Bug: 196376162
Change-Id: I4c54ffa3b359a236deb3ab67adb54111e77ec896
- Remove all usage of LEFT_PANEL_ID and fixed left panel code
- For preview renderer, load screen 0 + screen 1 instead
- Added a split display specific default workspace layout, with a placeholder app to pass test before we implement page pairing(b/196376162)
- Known issue: If screenId 1 is deleted, right panel will disappear from Wallpaepr & Style because there is no screenId 1. Will be resovled after page pairing(b/196376162)
Bug: 175939730
Test: manual and TaplTestsLauncher3#testWorkSpace
Change-Id: Icac1c94165c14a49c17897c45355b6cdc4d87e91
When a model preload call was made while the loader task is running
(eg: on enabling/disabling icon theme, Launcher reloads and then
launcher preview start a model-preload), it would cancel the original
loader and then start a new loader with empty callbacks. So the
model indeed get loaded, but the original callbacks never got notified
of it.
> Instead we only start preload if an existing task is not running.
> Also when preloading, we use existing callbacks, instead of using
empty callbacks
Bug: 193851085
Bug: 195155924
Test: Verified repro steps
Change-Id: I0a96310be8489756f364aa2a12e4345e1418733d
Fixing a possible context issue that was suggested
on the previous CL (ag/15079450) after it got submitted.
Bug: 185508060
Test: manually check launcher preview in wallpaper app
Change-Id: Ia653b833e4c1b911c7d7cac38c35ec2d12ab3a29
This reverts commit 7de95d6767, reversing
changes made to 0a70a5a690.
Lints have been added to fix errorprone.
Test: Widgets should adapt to wallpaper colors in launcher preview.
Bug: 192205054
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586
Change-Id: I6866f8521ed427d096f27da0a92d8b40e1099187
Revert "Implement generateColorsOverride from LocalColorExtractor"
Revert submission 15331418-colorcp
Reason for revert: Broke the build
Reverted Changes:
Ife80b07f9:Use wallpaper colors for widgets in wallpaper chan...
I1371eb787:Implement generateColorsOverride from LocalColorEx...
Bug: 194138049
// Using original change's merged-in tag to avoid clashing
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586
Change-Id: I3835dfb8efe745dc0a654712a5b1f68c4946f446
> Closing existing preview if a new request comes for same host token
> Closing in-memory icon db when closing preview
> Removing unnecessary wait blocks on UI thread and rendering
view asynchronously
> Fixing preview loading failing on LauncherAppState access
Bug: 186712316
Bug: 187140897
Test: Manual
Change-Id: I045930b007e5dc015320224a197eee20a8354d17
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag
Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
