Commit Graph

851 Commits

Author SHA1 Message Date
Fengjiang Li
cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Anushree Ganjam
43a826c579 Merge "Fix the Int value to reflect shared preferences value in TouchInteractionService." into main 2024-01-29 23:15:56 +00:00
Anushree Ganjam
eb5cb75753 Fix the Int value to reflect shared preferences value in TouchInteractionService.
This cl fixes following things

- When featureFlag is present, always read the value from FeatureFlag.get() instead of preferences.

- Add new function getIntFlagBackedUpByLauncherPrefs to read from sharedPreferences

- Make FlagTogglerPrefUi.java updateMenu() public

- When intFlag is modified in Developer Options, Apply button will show up. So launcher can restart and values get applied.

- Omnient Int flags will read from Featureflag.get() instead of shared preferences directly.

Bug: 320696242
Test: Manual
Flag: NA. Developer Options related

Change-Id: Id916b25d0397505d240ea8444d896c8ace826e57
2024-01-29 14:02:32 -08:00
Sunny Goyal
7891425109 Cleaning up release flag: ENABLE_ICON_LABEL_AUTO_SCALING
Bug: 270393294
Flag: N/A
Test: N/A
Change-Id: Ied7e21150e8176f044615959d20e75bb1cad7dfa
2024-01-29 11:18:29 -08:00
Saumya Prakash
b617daa6c6 Merge "Add standalone taskbar edu tooltip for the pinnable taskbar feature" into main 2024-01-18 01:41:14 +00:00
Saumya Prakash
dddebdff0c Add standalone taskbar edu tooltip for the pinnable taskbar feature
This change adds in a standalone edu window for the pinnable taskbar
feature. The reason for the change is to educate users about pinnable
taskbar to those who have already seen taskbar edu before.

Fixes: 302589411, 300161174
Test: Went through taskbar education taskbar with the flag on and off.
Check that the standalone pinning taskbar only shows up if previous
taskbar education was already completed.
Flag:  ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I03a5fb05ae5f15892421a57355f6d503de56d9fd
2024-01-17 21:23:30 +00:00
Jagrut Desai
fff93577e8 Merge "Update enableTaskbarNoRecreate logic" into main 2024-01-12 22:31:15 +00:00
Charlie Anderson
da3138cd91 Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag.
This is necessary because the value of the read-write flag will not be updated in time for backup/restore.

Bug: 307527314
Test: compiles
Flag: ACONFIG ENABLE_LAUNCHER_BR_METRICS_FIXED TEAMFOOD
Change-Id: I67a1a820734d8881b3ed5be4a1f2f1556e6e4704
2024-01-12 14:33:29 -05:00
Jagrut Desai
057144e0f6 Update enableTaskbarNoRecreate logic
Test: Presubmit
Bug: 318567569
Flag: NONE
Change-Id: I6927f0bab0317219a00a7c09c08640825d54e91b
2024-01-12 10:59:10 -08:00
Charlie Anderson
6c4dde2c4d Merge "Adds a legacy flag to enable Launcher BR metrics." into main 2024-01-05 01:32:11 +00:00
Sunny Goyal
1a8f804195 Merge "Removing ENABLE_CACHED_WIDGET since we now have always listenign widget" into main 2024-01-05 00:02:54 +00:00
Charlie Anderson
a4240c72c0 Adds a legacy flag to enable Launcher BR metrics.
This is necessary because the aconfig flag requires reboot to enable, however backup/restore happens on the first load so the flag will not be ready.

Flag: LEGACY ENABLE_LAUNCHER_BR_METRICS TEAMFOOD
Test: compilation / presubmit
Bug: 305984208
Change-Id: Ida90b1bd485fb037ebf3dde7ad17bf4e462661e6
2024-01-04 17:40:51 -05:00
Sunny Goyal
4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Jagrut Desai
2107717252 Merge "Change Tracking Bug for Taskbar pinning feature flag" into main 2024-01-02 20:52:50 +00:00
Fengjiang Li
abd3d6ddcc Merge "Revert " ALLAPPS PREINFLATION to TEAMFOOD"" into main 2024-01-02 20:00:35 +00:00
Jagrut Desai
5bcad413ec Change Tracking Bug for Taskbar pinning feature flag
Test: Presubmit
Bug: 296231746
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I4be1d2a247f0aa6b39854a667b576a523a8a776a
2023-12-20 11:09:50 -08:00
fbaron
e03af75df4 Remove unused flag UNFOLDED_WIDGET_PICKER
this flag was made long before we actually implemented unfolded two pane picker and by that point we migrated to using aconfig so this flag is not used.

Bug: 301918659
Flag: NONE
Test: NONE
Change-Id: Ibc541826d85ae251337567ae0275e1cd02c7bb43
2023-12-15 14:46:39 -08:00
Fengjiang Li
1a0c278622 Revert " ALLAPPS PREINFLATION to TEAMFOOD"
This reverts commit 11d8641e8a.

Reason for revert: ag/25590079 has been submitted to guarantee that we cancel icon preinflation job when device profile is changed.

Change-Id: I2c9254c63d89c389bd83725301c4957c66dad770
2023-12-14 18:19:54 +00:00
Sebastián Franco
d93bb98e02 Merge "Remove ENABLE_NO_LONG_PRESS_DRAG flag." into main 2023-12-14 17:20:45 +00:00
Anushree Ganjam
8a401e8817 Merge "Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY" into main 2023-12-13 22:57:59 +00:00
Sebastian Franco
cefdb28599 Remove ENABLE_NO_LONG_PRESS_DRAG flag.
Fix: 299748096
Flag: LEGACY ENABLE_NO_LONG_PRESS_DRAG ENABLED
Test: atest TaplDragTest
Change-Id: I6f14f2b048e111912fa0d1b8170ca702705e00bc
2023-12-12 15:23:06 -06:00
Anushree Ganjam
0d86f7859f Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY
Bug: 311370599
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: I25675cf65f8c7a53ea37d9ba317ddc6dbb271136
2023-12-08 10:17:42 -08:00
Hyunyoung Song
a6a16220d4 Merge " ALLAPPS PREINFLATION to TEAMFOOD" into main 2023-12-07 21:59:07 +00:00
hyunyoungs
11d8641e8a ALLAPPS PREINFLATION to TEAMFOOD
This flag should be enabled again when there is guarantee that
the icons inflated in the background thread is guaranteed to be in the same
device profile as the device profile that is current on the main UI thread

Bug: 312126498
Test: manual
Flag: LEGACY ENABLE_ALL_APPS_RV_PREINFLATION TEAMFOOD
Flag: LEGACY ALL_APPS_GONE_VISIBILITY TEAMFOOD
Change-Id: I9b4dae4327d6bdee135360ca1f40bdec5234ed56
2023-12-07 12:04:10 -08:00
Tony Wickham
18551f29fe Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support
Flag: NA
Test: manual, TaplTestsTaskbar, TaplTestsPersistent, TaplTestsTransient
Fixes: 270395798
Change-Id: I4ecf5ddcd1206e846538175c684043c5e065fd5d
2023-12-06 22:13:10 +00:00
Holly Jiuyu Sun
a568183f55 Merge "[cleanup] Clean up LayoutType.PEOPLE_TILE." into main 2023-12-06 18:32:30 +00:00
Holly Sun
b226257c17 [cleanup] Clean up LayoutType.PEOPLE_TILE.
Bug: 313696037
Test: manual
Flag: LEGACY ENABLE_PEOPLE_TILE_PREVIEW DISABLED
Change-Id: Iae66c86357ef50a97083c79d6a94d038ad83dcf1
2023-12-04 11:14:00 -08:00
Andreas Agvard
fd7f192a0a Enables ENABLE_SEARCH_HAPTIC_COMMIT
ENABLE_SEARCH_HAPTIC_COMMIT should be enabled for now to keep consistency in
behavior.

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Bug: 314005577
Change-Id: I98e2dea91fe58b6abaeeb63f6c92a5ee130b5204
2023-12-01 21:16:14 +01:00
Andreas Agvard
1ea0746e1c Adds support for shrinking nav handle on press
Fix: 314158312
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Test: Manual

Change-Id: Icd46467939ae9a38592ee67ee0d2a521eb8e0b6c
2023-12-01 17:54:41 +01:00
Andy Wickham
faa97d6224 Merge "Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag." into main 2023-11-30 20:17:42 +00:00
Saumya Prakash
89b93d4bbd Merge "Add taskbar pinning education for new users and update other steps" into main 2023-11-30 20:08:13 +00:00
Tracy Zhou
aa759645cf Merge "Use enableSplitContextually() to guard split keyboard shortcut feature" into main 2023-11-30 18:43:13 +00:00
Tracy Zhou
6209f34b02 Use enableSplitContextually() to guard split keyboard shortcut feature
enableSplitFromFullscreenWithKeyboardShortcuts() depends on enableSplitContextually() from the product perspective, hence merging these two flags

Bug: 270394122
Test: N/A
Change-Id: Iecf46a62bfa21ed0c3bad9ca8c9e2646b3aebc78
2023-11-29 22:20:42 -08:00
Andy Wickham
c0c420a3c2 Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag.
This controls whether a haptic is played when search invocation
starts. The assumption is that the search app will play this
haptic if the flag is disabled (default).

Test: Manual
Bug: 310659178
Bug: 314005577
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT DISABLED
Change-Id: I406c18cfaf27d004e19de26f00c997c0a03de996
2023-11-29 17:07:20 -08:00
Sebastian Franco
7a08e54eed Enabling ENABLE_NO_LONG_PRESS_DRAG
This is a simple flag, I don't think it requires the new
flagging system, I mainly added the flag for ease of debugging
if it breaks test on postsubmit.

This flag was already tested using enabled but it was disabled
before trunk stable, I think we can set this to true without risk
and then remove the flag.

Flag: LEGACY ENABLE_NO_LONG_PRESS_DRAG ENABLED
Fix: 299748096
Test: atest TaplDragTest
Change-Id: If99027d8cec7d75eee11012615da0e0d76951755
2023-11-29 10:09:57 -06:00
Saumya Prakash
5feb491549 Add taskbar pinning education for new users and update other steps
This change updates the current transient taskbar education to include
the pinning feature and additional updates to Lottie animations. It also
removes the tutorial that teaches users to switch navigation modes. The
pinning education is gated behind an additional pinning education static flag.

Fixes: 302588455,300161174
Test: Went through taskbar education for persistent and transient
taskbar with the flag on and off.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I836467091bfe694eee89ac46c4be597c490e1b3f
2023-11-28 20:20:25 +00:00
Andreas Agvard
9ed6d0be04 Merge "Fixed incorrect naming of flags" into main 2023-11-21 12:26:17 +00:00
Andreas Agvard
fc74c095d6 Adds a debug & server configurable delay to search haptic hint
Fix: 311370599
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED

Change-Id: Ic050e8426ef91b28e6bf1dc4d86839eaa20b0dc0
2023-11-20 12:49:54 +01:00
Andreas Agvard
0fc7d52863 Makes deep press for LPNH toggelable
By default when deep press is detected (https://developer.android.com/reference/android/view/MotionEvent#CLASSIFICATION_DEEP_PRESS)
during LPNH triggers the long press action immediately. This change makes this toggelable.

Flag is set to enabled by default, which leads to the default behavior.

Fix: 310952290
Test: Manual
Flag: LEGACY ENABLE_LPNH_DEEP_PRESS ENABLED
Change-Id: I970fed697979ee528e54b8be0139d842f3a64c43
2023-11-16 17:55:34 +01:00
Andreas Agvard
f2f026ba26 Fixed incorrect naming of flags
Bug: 309972570
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: Ie493e03c7e80fe0697e46dc02e9abaf1906aded4
2023-11-16 14:39:05 +01:00
Andreas Agvard
b36bcff974 Enables server side control of search hint haptic parameters
Fix: 309972570
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: I342a86546601b092b6eb40b8d00d94ee4cf1127a
2023-11-15 17:23:40 +00:00
Tracy Zhou
859edd00e9 Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig
Bug: 270394122
Test: N/A
Change-Id: I9bacd906099518b4a4c43a9f80ab0c753beac89a
2023-11-13 13:12:09 -08:00
Jagrut Desai
90dd098c85 Migrate ENABLE_TASKBAR_PINNING to aconfig flag
Test: Manual, Presubmit
Bug: 265437087
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I4800230c04feceefa2398e189c493c8c4a7b2fe5
2023-11-09 23:20:03 +00:00
Tracy Zhou
f2d7be1cec Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION
We want to turn on the flag when either of the dependent features is on

Bug: 299193589
Test: N/A
Change-Id: I7b48ff2be0cf9da3b6bc00d75370fa585ce4140d
2023-11-08 14:52:58 -08:00
Andreas Agvard
d103d230a9 Merge "Enabled haptics during long press nav handle" into main 2023-11-06 08:40:58 +00:00
Andy Wickham
402ca3e3e5 Merge "Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag" into main 2023-11-04 19:57:39 +00:00
Andreas Agvard
cb016243c7 Enabled haptics during long press nav handle
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Test: Manual
Bug: 303023676
Change-Id: Ia792fc6d00bf06320f51d56c43ed59c6dd23d456
2023-11-03 23:44:13 +01:00
Jagrut Desai
1e63858559 Merge "Turn on TASKBAR_PINNING for TEAMFOOD" into main 2023-11-01 22:06:31 +00:00
Andy Wickham
24a50df135 Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag
Bug: 306400785
Bug: 308693847
Test: Manual
Flag: LEGACY ANIMATE_LPNH TEAMFOOD
Change-Id: I996c923e5a1949e6219f900da12e2b5091597750
2023-10-31 23:45:12 -07:00
Jagrut Desai
0dbc0d0285 Turn on TASKBAR_PINNING for TEAMFOOD
Test: Presubmit
Bug: 265437087
Flag: LEGACY ENABLE_TASKBAR_PINNING TEAMFOOD
Change-Id: I13e7e5b96323a3b10d930a053fbeca7023cbba5f
2023-10-30 12:24:50 -07:00