When the dark night mode switch is triggered,systemui calls binder
to the onNavigationBarSurface method in the launcher and applies the
surfaceController.
Keep switching,you will keep applying,resulting in more surface
objects. The behaviour would cause that SurfaceFlinger couldn't
remove the unnecessary navigationbar layers timely and the
navigationbar layer would leak in SF.
Actively release the SC after using the SC in the launcher.
Bug: 317336417
Test: 1.Launch the settings app
2.Click Display menu
3.click the dark theme menu multiple times
4.Check whether the surfaceController is released
adb shell "ls -l/proc/904/fd|wc -l"
Change-Id: Ic449de9dbe0c52e0053be91e67ee9081a574581b
When opening freeform window from recents menu PiP should not
be started at the same time since the PiP transition can cause
freeform to not work as intended.
Bug: 299505542
Change-Id: I6392089b3ac9ce914fb37cc84780f28aa3fc75f8
- Set system bars appearance to light/dark depending on device
theme to ensure visibility
- Also fix issue where taskbar icons would appear partially
offscreen and prevent pressing nav buttons if you rotated
Fixes: 293438087
Test: adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
- Skip to the end (AllSetActivity), and ensure 3 buttons are visible
- Rotate device and ensure 3 buttons are still visible and functional
- Will also flash / wipe to the build once it's created
Flag: None
Change-Id: Ie2d9bf1e1d95a6ccbd1f9c592adb51390b21ad85
We need to re-create the icon alignment controller if the
stash status changes, otherwise it will use an old value.
Bug: 296414290
Test: home to app then quickly unstash
Change-Id: I35f23842f289fce95d102a9a93dc94cd033fa8cc
Before this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is off.
After this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is on.
This change doesn't reflect the DeviceConfig value changes done using
`adb shell device_config put` unless launcher is restarted.
Bug: 297202824
Test: Manual
Flag: NA
Change-Id: I5d83207cf454c60278fd02e59199207e855d51a8
Merged-In: I5d83207cf454c60278fd02e59199207e855d51a8
(cherry picked from commit 9eb68bb7cf)
- If task is translucent and excluded, fade out as swipe up
- Fade back in when re-launching live tile
- Ignore excluded tasks if there is another visible task,
and use that underlying task during gesture instead.
Fixes: 299351175
Fixes: 300297333
Fixes: 302672319
Test: Invoke translucent + excluded app (e.g. expanded Volume
dialog) over another app, swipe to overview, quick switch, home
Change-Id: I5740afc4bf561d1a264bd132863ffc15f27d2b20
This method recursively looks up the view hierarchy for a suitable view
to animate. The wrong variable was causing an infinite loop by never
updating the object being checked for the end condition.
With the fix, the animation behaves as expected.
Fix: 302568434
Flag: ENABLE_SEARCH_RESULT_LAUNCH_ANIMATION
Test: see video in the bug.
Change-Id: I123e50f1618a1e48256c0c976eeb46c93e8391b2
Merged-In: I123e50f1618a1e48256c0c976eeb46c93e8391b2
- adding more logs to TaskbarManager to investigate taskbar being present in folded state of the device.
Test: Presubmit
Bug: 254119092
Flag: not needed
Change-Id: I81c475f1c6bbc8d5b7874ddc45e8778861b61cd0
Previously [1] we removed the explicit insetsSizeOverride from the
Taskbar for the IME window, as we now [2] enable hiding the IME nav bar.
This would now send the normal insets the taskbar reports. When running
on pre/postsubmit, with test harness setup, the non-transient taskbar
would show, which is bigger than the IME's navigation bar height.
Due to the current logic in InsetsSource#calculateInsets, this leads to
the IME window receiving top navigation bar insets instead of bottom.
As the IME nav bar is now treated as a (fixed on bottom) caption bar,
the two would no longer overlap, and thus lead to a double insets
dispatch, and also a (temporarily) bigger IME window, for IMEs that set
their decorView height to WRAP_CONTENT (e.g. MockIME used in testing).
This instead keeps the previous insetsSizeOverride for IME, and uses the
stashedTasbarHeight when in gesture nav, which should account for both
transient and normal taskbars.
[1]: I86079cb6670a2ae3b6fa883694f8af81df212408
[2]: I8793db69fb846046300d5a56b3b0060138ef4cd5
Bug: 297000797
Test: atest WindowInsetsControllerTests#testDispatchApplyWindowInsetsCount_ime
Change-Id: I102a8bc1f8869ebbce9f8f1fefa651d49a9538ec
Test: can no longer repro incorrect orientation when launching apps from all apps
added logs to verify recents activity -> view were the same while rotating
turned off auto rotate and verified state matched
Bug: 288984663
Bug: 301024104
Change-Id: I7fc3b47bff0a99756aaf877bf634e2d162838d6f
