Commit Graph

7147 Commits

Author SHA1 Message Date
Nick Chameyev
c5d3a0d891 Do not animate QSB and hotseat when portrait
Disables fold/unfold animation for QSB and hotseat
icons when in portrait orientation. Launcher workspace
icons and widgets are still animated intentionally.
Reuses NaturalOrientationRotationProvider which is currently
used to disable fold/unfold animation in the status bar when
in non-natural orientation.

Bug: 201518277
Test: fold/unfold on launcher in landscape =>
 QSB and hotseat animated;
 rotate screen during fold/unfold animation =>
 translation reset after rotating to portrait,
 animated after returning to landscape;
 rotate after fold/unfold animation => no changes
Change-Id: I8ed405b09f445f554d7638ab44393c90773e0bb6
2021-12-02 14:39:08 +00:00
TreeHugger Robot
2bede2dbf2 Merge "Animate right icon of app pair" into sc-v2-dev 2021-12-01 20:06:56 +00:00
TreeHugger Robot
87f010f3bd Merge "Apply/reset split scroll offset regardless of previous state" into sc-v2-dev 2021-12-01 19:34:51 +00:00
TreeHugger Robot
e7e3d6ad31 Merge "Removed onBackPressed handling in SplitSCreenSelectState" into sc-v2-dev 2021-12-01 18:21:05 +00:00
Alex Chau
e81af3570b Animate right icon of app pair
Fix: 208647365
Test: Swipe up and observe right icon of app pair
Change-Id: I37a716c156d64c312d132bea80540ce922f3f709
2021-12-01 17:45:08 +00:00
Alex Chau
4536c2fc30 Apply/reset split scroll offset regardless of previous state
- Also do the same in setState without animation

Fix: 208605204
Test: Exit split screen and enter overview
Change-Id: I34dd102527dffa90925b6f0fd22465f1fe6e819c
2021-12-01 17:23:46 +00:00
Alex Chau
a307492525 Removed onBackPressed handling in SplitSCreenSelectState
- So it'll have exact same behavior as OverviewState to exit overview when going back
- Also removed RecentsView.cancelSplitSelect as it's longer needed

Fix: 181707736
Test: manual
Change-Id: Ide4dfc64680ecc9adfe245ae2de1463735b0490e
2021-12-01 16:24:10 +00:00
Vinit Nayak
b15d3cfe73 Merge "Treat RTL split placeholder animation same as LTR" into sc-v2-dev 2021-12-01 16:01:36 +00:00
Fedor Kudasov
d6a28fe202 Merge "Separate getTaskViewAt usage" into sc-v2-dev 2021-12-01 10:08:06 +00:00
TreeHugger Robot
f7518d42eb Merge "Schedule OverviewCommandHelper callbacks for GroupedTaskView" into sc-v2-dev 2021-12-01 06:35:35 +00:00
Vinit Nayak
f198f6e492 Merge "Add task unpinning support for 3 button taskbar" into sc-v2-dev 2021-12-01 04:34:06 +00:00
Vinit Nayak
09a822a6fe Schedule OverviewCommandHelper callbacks for GroupedTaskView
* Schedule runnables to clear pending queue in
OverviewCommandHelper similar to how TaskView does it.
* End callbacks get run when recents animation finishes in
RecentsView in the case of live tile when recents animation
is still running
OR
in directly when the split remote animation finishes

Bug: 207845542
Change-Id: I7e858ce55b08cde6436d44f2e857e28b73458f0b
2021-11-30 20:18:50 -08:00
Vinit Nayak
b997930afc Treat RTL split placeholder animation same as LTR
* Since we're doing all transformations in screen
coordinates we don't need to account for RTL.

Bug: 202156862
Change-Id: Ibcbf698dbc5b8fabf2647949de6d2718937832d5
2021-11-30 19:58:00 -08:00
Vinit Nayak
570653346f Add task unpinning support for 3 button taskbar
Bug: 199544447
Test: Tested on small and large screen
Change-Id: Ib7785992ef11825cd07a929e2cb623d02ef246f1
2021-11-30 17:18:09 -08:00
TreeHugger Robot
96f3f2214c Merge "Fix potential memory leak by setting mControllers = null" into sc-v2-dev 2021-12-01 00:49:56 +00:00
Jerry Chang
36eb818600 Merge "Remove stage type from split screen APIs" into sc-v2-dev 2021-12-01 00:41:10 +00:00
Tracy Zhou
d1f9fde371 Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-v2-dev 2021-12-01 00:34:00 +00:00
Tony Wickham
f6c28a4381 Fix potential memory leak by setting mControllers = null
Test: N/A
Bug: 202511986
Change-Id: Iad7cc89e0e68ce09ebe4ca3ab89392b50b6a82c7
2021-11-30 14:37:36 -08:00
TreeHugger Robot
b78cbf29e5 Merge "Possible fix for NullPointerException b/206040100." into sc-v2-dev 2021-11-30 19:58:24 +00:00
Sebastian Franco
8afeba605a Possible fix for NullPointerException b/206040100.
There is a NullPointerException when trying to get the
length of the array.

Test: Manually tested
Fix: 206040100
Change-Id: I69a03fd3658094655eaf97fa21039fd373ee37d5
2021-11-30 10:09:02 -06:00
Alex Chau
a8fc7e03fd Close task menu scrim when pressing home button
- Generally close all floating view when starting home from Recents

Bug: 193432925
Test: with 3 button, open task menu, then press home
Change-Id: Ic99c50333c797f222fc8e682fd0f3fcc4d641d47
2021-11-30 14:27:36 +00:00
Jerry Chang
8176366f54 Remove stage type from split screen APIs
Bug: 198438631
Test: manual check
Change-Id: Ic4f41e39013e4d49585da4cda9b28151c549357a
2021-11-30 17:15:40 +08:00
Tracy Zhou
260b90c7ad Merge "Reset live tile params along with resetTaskVisuals" into sc-v2-dev 2021-11-30 04:41:40 +00:00
Adam Bookatz
cbafa6803b Merge "Revert "Fix issue with Shell listeners being unbound if SysUI is restarted"" into sc-v2-dev 2021-11-30 03:44:30 +00:00
Tracy Zhou
bb594548bb [DO NOT MERGE] Make the cutout slightly smaller
Temporary fix for S. Leaving the bug open for a proper fix in T.

Since we reverted the z order back (launcher on top), we should apply this fix from S and find a proper solution in T

Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
(cherry picked from commit 26f47c711a)
2021-11-30 01:01:59 +00:00
Tracy Zhou
a56dc760dd Reset live tile params along with resetTaskVisuals
The dismissal animation doesn't return the translationY to 0, but resetTaskVisuals does.

Fixes: 207782306
Test: Drag live tile to dismiss lightly so it doesn't succeed. When it comes back, make sure it matches the cutout.
Change-Id: I64ee06ad72c403ab4fdd4671d08b1843a3e89253
2021-11-30 00:49:02 +00:00
Adam Bookatz
3d34f94784 Revert "Fix issue with Shell listeners being unbound if SysUI is restarted"
This reverts commit 34e384d2e1.

Reason for revert: Multiuser performance (b/208276322)

Change-Id: Icd27ab3095c446895360f8e2faa7f9c92ab2cf01
Bug: 208276322
2021-11-30 00:19:05 +00:00
TreeHugger Robot
ed05712f04 Merge "Handle configuration changes in floating rotation button" into sc-v2-dev 2021-11-29 19:41:26 +00:00
Nick Chameyev
ed6b29f211 Merge "Add WRITE_SECURE_SETTINGS permission to Launcher" into sc-v2-dev 2021-11-29 17:14:09 +00:00
Nick Chameyev
c52ec89e1b Add WRITE_SECURE_SETTINGS permission to Launcher
We reused a code that handles rotation suggestion button
from SysUI in Launcher. It requires WRITE_SECURE_SETTINGS
permission to write how many times we have shown this button
to show ripple only the first 3 times.
AOSP Launcher didn't have this permission and it was crashing.

Bug: 205491152
Test: tap on rotation suggestion button when in AOSP launcher
Change-Id: I216abb86d43cc505aec1ff581c1f332ae3ad0db4
2021-11-29 12:21:35 +00:00
TreeHugger Robot
c5f18aa980 Merge "Resets taskSplitTranslation of inactive orientation" into sc-v2-dev 2021-11-26 18:23:43 +00:00
Alex Chau
9a5f99bfe6 Resets taskSplitTranslation of inactive orientation
Fix: 204185003
Test: manual

Change-Id: I10e49994e8a9723f39d7f9159de7c1f8216ea77f
2021-11-26 12:04:47 +00:00
Nick Chameyev
71eed5ca35 Handle configuration changes in floating rotation button
Update resources in floating rotation button
when configurations such as screen density, screen size,
current locale have changed.

Bug: 200103245
Test: change display size, locale, fold/unfold
 -> check that floating rotation button resources
    are updated
Change-Id: Ia69f4f8b393a686012e286a1e39822650c562d52
2021-11-26 11:38:28 +00:00
Jerry Chang
71b7d1537d Merge "Support to launch app pair from overview with recorded split ratio." into sc-v2-dev 2021-11-26 05:43:34 +00:00
Alex Chau
b3a9386556 Use alternative way to fix split select page snapping issue
- Reverted to before ag/16095449 where reset() is called after state transition completed
- Call pageBeginTransition in dismiss animation to make sure onPageEndTransition is triggered to clear mCurrentPageScrollDiff properly
- Fixed a condition in resetFromSplitSelectionState ot use DeviceProfile.overviewShowAsGrid, as when state is in transition, showAsGrid() would be false

Fix: 207744890
Test: manual
Change-Id: I5a812a7ee26df2f953f7fed0155880620d2c4e66
2021-11-25 16:48:39 +00:00
TreeHugger Robot
32ebd9f94f Merge "Fix ClassCastException in QuickstepModelDelegate" into sc-v2-dev 2021-11-25 04:00:37 +00:00
Jerry Chang
279c3b7fa2 Support to launch app pair from overview with recorded split ratio.
Bug: 207479945
Test: Quickswitch back to app pair keep split ratio
Change-Id: Id24195c15fe59053cc51515a942f72c3b8e87ba7
2021-11-25 11:38:14 +08:00
TreeHugger Robot
79132556f7 Merge "Add TaskbarControllers#runAfterInit()" into sc-v2-dev 2021-11-25 00:08:08 +00:00
Tony Wickham
a143500a69 Add TaskbarControllers#runAfterInit()
And use it in TaskbarModelCallbacks#commitItemsToUI(), which in rare cases can run during init() before other controllers (namely TaskbarStashController) have been initialized.

Test: call commitItemsToUI() in TaskbarModelCallbacks#init(), ensure no crash
Fixes: 204847702
Change-Id: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
Merged-In: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
2021-11-24 23:14:06 +00:00
Schneider Victor-tulias
380f8fd890 Fix ClassCastException in QuickstepModelDelegate
- Added a casting check as an immediate fix to b/173838775
- Added logging to help debug the corrupt state where an item of type other than FolderInfo is used as an other item's container.
- Added LoaderMemoryLogger for adding large logs that are only conditionally printed.

Bug: 173838775
Test: manually checked logs
Change-Id: I9491cb421b9fb807d5fb110b04ad069481de768f
2021-11-24 14:26:45 -08:00
Fedor Kudasov
4e678ff6d5 Separate getTaskViewAt usage
getTaskViewAt is used in two different contexts with different
assumptions:
1. In the context of iterating over the all TaskViews, where
the valid tasks indices are know.
2. In the context of requesting some TaskView by index, where
the caller expects null when the input index is invalid.
The nullability status of the method differs in these contexts
and therefore getTaskViewAt usage can be separated into two
different methods.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I42c04c115c309f1849f9dfbb05c74b9b080acf13
(cherry picked from commit 4da3b4bddd)
2021-11-24 21:19:22 +00:00
Alex Chau
376b09ade2 Merge "Consider two panel in home to overview transition" into sc-v2-dev 2021-11-24 20:33:32 +00:00
Alex Chau
6095333370 Consider two panel in home to overview transition
- Get the value from DeviceProfile directly

Fix: 202444558
Test: manual
Change-Id: Ifadbbf34c8103d7275b8b4043dcae47d1168ae83
2021-11-24 18:11:45 +00:00
Tony Wickham
b4aefc1277 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev 2021-11-24 17:54:18 +00:00
Alex Chau
226bd5b973 Merge "Fix grid layout problem after going back from split select" into sc-v2-dev 2021-11-24 10:32:46 +00:00
Tony Wickham
821e37b447 Stash taskbar when IME is present, including during gestures
- SysUI removes SYSUI_STATE_IME_SHOWING when starting a gesture from an app, but because unstashing has implications on the gesture transition (e.g. clips the bottom of the app), we defer handling the ime hiding until the gesture settles. Repurposed the flow that swaps the taskbar background during the gesture to support this case as well.
- Delay the unstash when IME is closing, to align with the end of the IME exit transition
- Remove TaskbarViewController.ALPHA_INDEX_IME now that we stash when IME is opening, since stashing already hides the taskbar icons
- Also support passing a starting progress to the stashed handle reveal animation, to allow it to be reversed when cancelled. For example, when returning to an app that has IME showing, we first start unstashing because we're in an app, but then we get the signal that IME is attached so we stash again almost immediately (within a frame or two).

Test: In both 3 button and fully gestural, open a keyboard in an app, ensure taskbar gets out of the way and then reappears at the end when the keyboard is dismissed
Bug: 202511986
Change-Id: I93c298a98ba369ea6310466ff3f802231c582687
2021-11-23 16:37:06 -08:00
Winson Chung
2919653136 Merge "Prevent setting launcher layer has opaque when there is content behind" into sc-v2-dev 2021-11-23 23:04:01 +00:00
Winson Chung
c1afaa4042 Merge "Removing logs" into sc-v2-dev 2021-11-23 21:58:14 +00:00
Vinit Nayak
458832c09e Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev 2021-11-23 20:09:47 +00:00
TreeHugger Robot
db5f5f05e7 Merge "Add scrim below TaskMenu" into sc-v2-dev 2021-11-23 19:29:00 +00:00