Commit Graph

2374 Commits

Author SHA1 Message Date
Vadim Tryshev
1cbdcb2961 Merge "Extending the list of test owners" into ub-launcher3-qt-qpr1-dev 2019-08-16 17:36:54 +00:00
Hyunyoung Song
96eba3aea6 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev 2019-08-15 22:25:33 +00:00
Hyunyoung Song
d4204437de Make TogglableFlag backed by DeviceConfig for e2e testing
Bug: 138964490

TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.

Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.

Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
2019-08-15 14:02:28 -07:00
vadimt
a81be5003c Extending the list of test owners
Otherwise, changes in tests would require my-only approval.

Change-Id: Ia957a28a5a8e55dc2ee4efdf9a46c91511d3e611
2019-08-14 17:18:45 -07:00
TreeHugger Robot
46463f6a19 Merge "Adding support for storing keywords in iconCache" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
Sunny Goyal
934ebd087b Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
Merged-In: I1183e63a6556ebfb3eee5df23d149e09728193a9
(cherry picked from commit e529a86fbd)
2019-08-14 22:12:49 +00:00
Felipe Leme
7ca46ba2ee Fixed PredictionAppTracker as service might not be available on device.
Fixes: 139416391
Bug: 135218095

Test: echo 'in TreeHugger we trust'

Change-Id: Iea89b3d379792327657e01869c9494975e7b0306
(cherry picked from commit 214a45ee02)
2019-08-14 22:02:22 +00:00
Becky Qiu
22edac9bf5 Merge "Log the event for swiping up to dismiss a task in Overview." into ub-launcher3-qt-qpr1-dev 2019-08-14 17:48:45 +00:00
Sunny Goyal
f3dac0ef13 Always go to home in case of fling-up
am: a2cfc2d95e

Change-Id: I560fd690882998a9b503d5c30eda7f9397db138e
2019-08-13 14:58:45 -07:00
Sunny Goyal
a2cfc2d95e Always go to home in case of fling-up
Bug: 138881088
Change-Id: I86bf4c7a495805d5912b102470e72a51e843a222
2019-08-13 11:45:06 -07:00
Becky Qiu
90ea00b399 Log the event for swiping up to dismiss a task in Overview.
Test: manual
Bug: 137777105

Demo logging for dismissing a task:
  data {
    elapsed_timestamp_nanos: 70772067228810
    atom {
      launcher_event {
        action: DISMISS_TASK
        src_state: OVERVIEW
        dst_state: BACKGROUND
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I5569b80e2e1f35661bc5e9e343c6c298791a1ec1
2019-08-09 10:57:05 -07:00
Pinyao Ting
e4061fc931 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
Merged-In: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 23:31:35 -07:00
Sunny Goyal
bafd62971a Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev
am: 6cf32a2e95

Change-Id: I7313eb81291d3fbe353882446d7da39bba355ec9
2019-08-05 17:33:42 -07:00
TreeHugger Robot
6cf32a2e95 Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev 2019-08-06 00:21:01 +00:00
James O'Leary
c714f1657b Merge "Fix inability to dismiss Assistant answer when launcher frontmost" into ub-launcher3-qt-r1-dev
am: 290a9a814a

Change-Id: I128fb662ea38a00f3a14734aae9c5c1bbb849b09
2019-08-05 15:20:46 -07:00
Sunny Goyal
1eade2f947 Use task display id when starting split screen
Before starting split screen animation, we dismiss the task view, which
can detach the clicked view immediately, if animations are dissabled.
That will cause NPE as view.getDisplay will be null

Bug: 138793362
Change-Id: I611f6a824f756eceeed57aac5afdf38f421ff8d2
2019-08-05 11:24:43 -07:00
TreeHugger Robot
71b6d24964 Fix inability to dismiss Assistant answer when launcher frontmost
Bug: 136282913
Test: Verify Assistant answer card be dismissed from Home
Change-Id: I84d0a9bda333bc2f99161096299acfaa387ecf1e
2019-08-05 14:01:08 -04:00
Tracy Zhou
bd7acf7665 Change RecentsAnimationListenerSet interface (Launcher)
Bug: 138683199
Test: N/A
Change-Id: Ic53ef92fe4d5b55ff1d105a250accdf6f6c0916b
(cherry picked from commit 8e8a36f673)
2019-08-02 03:44:37 +00:00
Tony Wickham
f489a71365 Return mIconLastSetTextAlpha from TEXT_ALPHA property
am: 8ed3b437b1

Change-Id: I01cada1a1cca22e2e7792b019dd74221c0451cf3
2019-08-01 15:44:40 -07:00
Becky Qiu
84fa94e2fc Fill the log container as hotseat or workspace based on position.
Test: manual
Bug: 137953006

Swipe from workspace:
07-30 15:15:44.031  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:44.031  9779  9779 D UserEvent:  Source child:WORKSPACE id=0 span(951,1313)	parent:WORKSPACE id=0
07-30 15:15:44.031  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:44.031  9779  9779 D UserEvent:  Elapsed container 826 ms, session 9361 ms, action 0 ms

Swipe from hotseat:
07-30 15:15:46.010  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:46.010  9779  9779 D UserEvent:  Source child:HOTSEAT id=0 span(786,1908)	parent:WORKSPACE id=0
07-30 15:15:46.010  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:46.010  9779  9779 D UserEvent:  Elapsed container 1139 ms, session 11339 ms, action 0 ms

Change-Id: I959528889fda778efc569bb59e7f44d3bd5b81bc
2019-08-01 22:24:44 +00:00
Tony Wickham
8ed3b437b1 Return mIconLastSetTextAlpha from TEXT_ALPHA property
This was supposed to go in the last CL but I forgot to commit...

Bug: 132455160
Change-Id: Ieb66b1f256d7b14c84bbd4d10af1aa8b073d5ac3
2019-08-01 15:20:03 -07:00
Jon Miranda
783717c0c6 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev am: 9da9a2bd21
am: f20a7d252c

Change-Id: I3fcfe4dc137756d5b4a049468632d111ca7fa4f6
2019-08-01 15:19:01 -07:00
Tony
13bdbffe29 Don't end launcher components anim early even if it does nothing am: 03c548901f
am: 1d7e474c69

Change-Id: I1f1f70c2791755535d1318b636e37a745e97d057
2019-08-01 15:18:36 -07:00
Jon Miranda
f20a7d252c Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev
am: 9da9a2bd21

Change-Id: Icae4fd3fef3ad221d45e8d9ecdcc018813d560f3
2019-08-01 15:05:00 -07:00
Tony
1d7e474c69 Don't end launcher components anim early even if it does nothing
am: 03c548901f

Change-Id: Ifb228b935659e971facfd8d6bb4c56ab54424e68
2019-08-01 15:04:36 -07:00
TreeHugger Robot
9da9a2bd21 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev 2019-08-01 21:47:47 +00:00
Tony
03c548901f Don't end launcher components anim early even if it does nothing
The janky animation that ends on the home screen with an invisible
task on top is caused by the following scenario (for example):
- Quick switch from task A to task B
- After landing on B, but before we get the callback that it was
  successfully launched, switch back to A (or you could go to C)

Now we are animating back to A, but we are still waiting to hear
whether B was successfully launched. If we hear that the launch
was indeed successful, we dutifully clean up after ourselves  by
returning launcher to its default state. Unfortunately, that
clobbers the current animation that is scrolling back to A, and
we end up in the bad state where we are showing the default
launcher state even though we just launched task B and were
about to launch task A.

Normally we avoid cleaning up the state animation if the user
is still controlling it. The reason we weren't doing that here
is because we ended the launcher animation early even though
the window animation was still running. Instead, we should keep
the launcher animation running for the full duration, so that
it prevents a cleanup from occurring in the middle.

Bug: 138620399
Change-Id: I959e62a52638a5b974ef9b406555078c928b91f1
2019-08-01 13:28:43 -07:00
Tony Wickham
70f539cd45 Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
am: 1343f03e2e

Change-Id: Ie3f4c2c15e331c84f0f048c6337ae4e58111ec56
2019-07-31 15:36:50 -07:00
Tony Wickham
1343f03e2e Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
* changes:
  Tie prediction text to all apps interpolator
  Add OverviewScrim to show below overview but above workspace
2019-07-31 22:12:54 +00:00
Tony Wickham
35a4e0eec9 Tie prediction text to all apps interpolator
Now floating headers get 2 interpolators: one for the header content
itselt, and one for the all apps content that follows. That way, they
can choose to intperolate part of their content as if it were part of
all apps instead of the header. Currently, we do this to animate
predicted icons quickly, followed by the all apps icons, predictions
text, all apps scrollbar, and all apps divider as you continue swiping.

Bug: 132455160
Change-Id: Ib3e373c291e174e1306a53854d0ad4dc29eb4b76
2019-07-31 14:45:18 -07:00
Tony Wickham
c088051c29 Add OverviewScrim to show below overview but above workspace
- Refactor some basic scrim logic to Scrim class and have
  WorkspaceAndHotseatScrim and OverviewScrim extend it
- Draw OverviewScrim under recents unless predictions are disabled, in
  which case draw it under hotseat (since that is in recents)
- Remove sysui scrim (behind status bar and nav bar) when overview is
  peeking

Bug: 132455160
Change-Id: Ia5d6f54582a4c5a70e3b2d4a98281567edd68519
2019-07-31 14:44:28 -07:00
Vinit Nayak
45c12ff1b5 Set recents view to be visible from alt+tab
Recents was being initialized but was not
marked as attached to app window. This
was causing it's animator to never make it
View.VISIBLE.

Test: Open any app
On physical keyboard press alt+tab
Observe that overview shows up

fixes: 138396234
Change-Id: I9e6c001242f4552027e79b162fb812f476823a37
2019-07-31 20:10:55 +00:00
Jon Miranda
f462b251e1 Tune window/icon alpha for swipe up to home animation.
Bug: 136591785
Change-Id: Ib781bc77cfd49b6f4529a609d7025f510e219575
2019-07-31 10:05:16 -07:00
Sunny Goyal
c302baced0 Notifying the geature guide app when back gesture is performed
so that user onboarding can the updated accordingly

Bug: 138403212
Change-Id: Ib4e1cde0b2c746f955d5a58251c8ab653dadbc67
2019-07-29 11:55:11 -07:00
Winson Chung
fa652a8a4f Updating to use deferred cancel api
- Also updating the sysui flag to home's flags when passing some
  threshold
- Also ensure we don't allow swipe up when QS is open

Bug: 137196872
Bug: 135969043
Change-Id: I476eee7f02ae86aa795fceabb304bcaa7416ef9c
2019-07-27 10:08:52 -07:00
Winson Chung
1d3d19f2e1 Merge "Fix NPE in service dump" into ub-launcher3-qt-r1-dev 2019-07-26 16:46:35 +00:00
Winson Chung
0ef10a458d Skip tests for overlays that don't exist on device
Bug: 138401738
Bug: 138227387
Change-Id: If661fd342e1382915485bccdf6ae2c9e77a92bc4
2019-07-26 00:09:43 +00:00
vadimt
f88d0b5a8a More diags in TouchInteractionService
Bug: 138251824
Change-Id: I0909a2c85b1b2bdd8b67da59c978d6a3bbb58ee5
2019-07-25 16:38:39 -07:00
TreeHugger Robot
3bbb20262b Merge "Fix incorrect task index bounds" into ub-launcher3-qt-r1-dev 2019-07-25 23:17:21 +00:00
Winson Chung
5089140cda Fix NPE in service dump
Bug: 138144992
Change-Id: I608ea209b04fce13a63190ec424849dc909a6a9a
2019-07-25 15:22:47 -07:00
TreeHugger Robot
2cccb134a4 Merge "Add several missing swipe logging Enable swipe down to open noti shade from landscape" into ub-launcher3-qt-r1-dev 2019-07-25 21:55:16 +00:00
James O'Leary
93dceb8a48 Merge "Fix QSB becoming invisible" into ub-launcher3-qt-r1-dev 2019-07-25 20:41:34 +00:00
Hyunyoung Song
e299a45944 Add several missing swipe logging
Enable swipe down to open noti shade from landscape

Bug: 137137090
Bug: 137954767
Bug: 134181439

Change-Id: I47b4d17c9ae0586565fce101eb478e33ed8f7e3d
2019-07-25 13:18:48 -07:00
Vadim Tryshev
2870df0776 Merge "NavigationModeSwitchRule: log exception before 'finally'" into ub-launcher3-qt-r1-dev 2019-07-25 19:47:42 +00:00
Tony Wickham
2b365ae7f0 Fix incorrect task index bounds
Should have been using min, not max. Added lower bound for good measure.

Bug: 138025252
Change-Id: Icd8c7d62dca7605fe63e83602e4c9fceb91f68a6
2019-07-25 12:27:29 -07:00
vadimt
7593dc995b NavigationModeSwitchRule: log exception before 'finally'
Change-Id: I158105da467e2759fec6fa5d8acd582b2e95f7c5
2019-07-25 12:16:31 -07:00
James O'Leary
74ece6b021 Fix QSB becoming invisible
This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.

After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.

Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419

Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
2019-07-25 10:22:02 -04:00
Tony Wickham
cfbdb91a7f Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev 2019-07-24 19:39:48 +00:00
TreeHugger Robot
b7094fcf36 Merge "Using the first frame delay based on the display refresh rate instead of hardcoding it to 16ms" into ub-launcher3-qt-r1-dev 2019-07-24 19:32:17 +00:00
Sunny Goyal
4e6c45bcd3 Using the first frame delay based on the display refresh rate instead of
hardcoding it to 16ms

> Creating a utility class for caching display property changes

Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
2019-07-24 10:12:37 -07:00