Commit Graph

270 Commits

Author SHA1 Message Date
Liran Binyamin
c33fe5bd56 Update taskbar window size for flyout
This change updates the taskbar window size after the flyout view
has measured itself. This ensure that the taskbar window is tall
enough to display the entire flyout.

When the flyout is removed we reset the taskbar window size.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully and tested manually -- code is not wired up
Change-Id: I5e8618e57443212e1c4f19ab20d1542ae2d1b865
2024-10-14 19:59:59 -04:00
Brian Isganitis
bdc5dd5c86 Merge "Run Taskbar controller tests on VirtualDisplay." into main 2024-10-11 21:03:12 +00:00
Brian Isganitis
066f5adcf6 Run Taskbar controller tests on VirtualDisplay.
Flag: TEST_ONLY
Test: go/testedequals
Bug: 369641781
Change-Id: Id53f420e7edc1779da9eb7647644ffffb74e67b3
2024-10-10 19:13:40 +00:00
Uwais Ashraf
71fb897f39 Merge "Adds View screenshot tests for TaskThumbnailView." into main 2024-10-10 11:38:19 +00:00
Ats Jenk
d137856e26 Merge "Update bubble bar swipe logic" into main 2024-10-09 21:32:43 +00:00
Ats Jenk
6570ac750f Update bubble bar swipe logic
After changes following swipe interactions are available for the bubble
bar:
1. stashed handle
- swipe up to show bubble bar, after swipe reaches unstash threshold, we
  show the bubble bar
- swipe down to stash bubble bar in the same gesture (without lifting
  finger), do this when swipe moves back below unstash threshold
- expand bubble bar on finger lifted when currently above unstash
  threshold

2. collapsed bubble bar (used in home or overview)
- swipe up and release over unstash threshold to expand bubble bar
- bubble bar can't be swiped down to stash it

3. expanded bubble bar
- no swipe interactions available

Bug: 371229061
Flag: com.android.wm.shell.enable_bubble_bar
Test: BubbleBarSwipeControllerTest
Test: manually test:
  - stashed bubble bar:
      - swipe up and back down => bubble bar shown and stashed
      - swipe up slightly and release => bubble bar not shown
      - swipe up and release => bubble bar shown, expands on release
  - collapsed bubble bar:
      - swipe down => no action
      - swipe up slightly => no action
      - swipe up and release => bar expands on release
Change-Id: I42aa59dc288446603e06a3d02419be38cf17fa1f
2024-10-08 16:17:32 -07:00
Brian Isganitis
46b20441e4 Migrate Taskbar tests to use SandboxApplication.
This class has even better sandboxing and is a TestRule, making it easy to tear down singletons.

Flag: TEST_ONLY
Fix: 369504330
Test: go/testedequals
Change-Id: I86fbfecc275da536ab745d61bef8b9bebb28379c
2024-10-08 16:34:44 +00:00
Liran Binyamin
9c3c7cc3e2 Merge "Store the flyout in BubbleBarBubble" into main 2024-10-08 13:31:53 +00:00
Ats Jenk
ea6e59537e Merge changes I74af6a72,I603a67a8 into main
* changes:
  Animate bubble bar alpha when notif shade opens
  Set bubble bar invisible while stashed
2024-10-07 22:23:02 +00:00
Liran Binyamin
5e04f0960d Store the flyout in BubbleBarBubble
Extracts the flyout message from the bundle and stores it in
BubbleBarBubble.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully -- code is not wired up yet
Change-Id: I5e810290991b4ee638f43add4d6a6514edb167af
2024-10-07 16:57:08 -04:00
Tony Wickham
fc267fbd69 Merge "Don't invalidate swipe handler until parallel anim finishes" into main 2024-10-07 19:17:03 +00:00
Liran Binyamin
9b093db2f8 Merge "Rename bubble bar flyout fields" into main 2024-10-07 18:27:14 +00:00
Tony Wickham
ee98cd4bdf Don't invalidate swipe handler until parallel anim finishes
- When invalidateHandler() is called, it calls endRunningWindowAnim()
  which includes mParallelRunningAnim. This causes a jump if
  mParallelRunningAnim was not already finished, so we now wait to
  invalidate the handler after mParallelRunningAnim ends.

Flag: EXEMPT bugfix
Test: AbsSwipeUpHandlerTestCase (added two tests for this)
Fixes: 370208192
Change-Id: I37ed281a993b1d2fa3634754378314511f3295f0
2024-10-07 16:45:19 +00:00
Liran Binyamin
f44690bd69 Merge "Pass bubble flyout from wm shell to launcher" into main 2024-10-07 16:22:13 +00:00
Ats Jenk
df819b6145 Merge changes Iccb870b0,Ibea2dbe0 into main
* changes:
  Inject bubble controllers directly
  Allow injecting bubble controllers in taskbar test
2024-10-07 16:12:41 +00:00
Liran Binyamin
75675e123d Rename bubble bar flyout fields
Long term we'd like to use bubbles for any app, so this change
uses more general names instead of the chat-specific naming

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: built and tested on a device
Change-Id: Idec2aa7d9a8df5df0df49231e8871298084f8aa1
2024-10-07 10:37:55 -04:00
Schneider Victor-Tulias
12aff98cd8 Add a AbsSwipeUpHandlerTestCase for the RecentsWindowSwipeHandler
- Added RecentsWindowSwipeHandlerTestCase
- Slightly refactored AbsSwipeUpHandlerTestCase for simplicity

Flag: EXEMPT adding test code
Bug: 292269949
Test: RecentsWindowSwipeHandlerTestCase
Change-Id: Iacd8ff8261ad262d4645ba97c35d296050e61195
2024-10-04 13:37:01 -04:00
Ats Jenk
2166749190 Set bubble bar invisible while stashed
Update bubble bar visibility when it is stashed.
Ensures that if alpha is updated, it won't show up.

Bug: 345687278
Test: TransientBubbleStashController
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I603a67a824a5cee0fb35de7c3f2dc98d9d2323ed
2024-10-03 15:33:38 -07:00
Ats Jenk
35b87d33b2 Inject bubble controllers directly
Replace injecting bubble controllers class with each controller
separately.c

Bug: 371017282
Test: TaskbarStashControllerTest
Flag: TEST_ONLY
Change-Id: Iccb870b0976b51fcd5a987cf208531da413921d1
2024-10-03 10:09:30 -07:00
Mady Mellor
2aedf52b8f Merge "If we're going to overview we might need to unstash" into main 2024-10-03 16:12:09 +00:00
Ats Jenk
936fec94bd Allow injecting bubble controllers in taskbar test
Update TaskbarUnitTestRule @InjectController annotation to support
injecting bubble controllers.
Bubble controllers are optional and only initialized if the feature flag
is enabled.
Add a test to check that bubble controllers are only initialized when
the flag is on.

Bug: 371017282
Test: TaskbarUnitTestRuleTest
Flag: TEST_ONLY
Change-Id: Ibea2dbe0db854d530ef93ac53204a361572fa5b2
2024-10-02 15:56:08 -07:00
Liran Binyamin
d8c3328d4d Pass bubble flyout from wm shell to launcher
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarViewAnimatorTest
Change-Id: I8666765937a491903c6fc042d2d629374be4c70d
2024-10-02 12:27:52 -04:00
Liran Binyamin
1663bb3004 Merge "Bubble bar flyout polish" into main 2024-10-02 16:15:53 +00:00
Uwais Ashraf
67d0d59caf Adds View screenshot tests for TaskThumbnailView.
Bug: 344800402
Test: TaskThumbnailViewScreenshotTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: If6530ea9dfe026589f05731d5362dc10f719fc70
2024-10-01 23:42:39 +00:00
Ats Jenk
da477af93d Fix comment in TransientBubbleStashControllerTest
Bug: 345488489
Change-Id: Ide38c1e36a0da53e9fcc7a5c6b0c3241eff24add
Test: na
Flag: DOCS_ONLY
2024-10-01 21:06:02 +00:00
Mady Mellor
fd6772ab84 If we're going to overview we might need to unstash
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest NexusLauncherTests:PersistentBubbleStashControllerTest
Test: atest NexusLauncherTests:TransientBubbleStashControllerTest
Test: manual - swipe up to overview from home & from in an app, ensure
               bubble bar is unstashed
             - switch between home / overview / in app in transient
               and persistent taskbar to make sure things work
Bug: 368364143
Change-Id: I34c22b000d1fcc75489ea6da497f14def9649a20
2024-10-01 11:57:26 -07:00
Ats Jenk
da8487eb33 Merge "Update bubble stash test for transient taskbar" into main 2024-10-01 18:53:36 +00:00
Liran Binyamin
8bd8feb72d Bubble bar flyout polish
Animate the elevation of the flyout along with the expansion animation.
Also start revealing the triangle as soon as we're past the bubble bar.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Ie7e27240ae3ab86f8e7c3f39aa1c80885cfdc98e
2024-10-01 12:06:36 -04:00
Ats Jenk
5464ce0084 Update bubble stash test for transient taskbar
Include unit test to check that view properties are set to expected
values at the end of an unstash animation.
Add tests to check that alpha for bubbles and background changes
separately during unstash and stash animations.

Bug: 345488489
Test: TransientBubbleStashControllerTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ifd10d4524128d42d23fe67c0eff2c4ae16d3b27b
2024-09-30 15:43:15 -07:00
vinayjoglekar
562ab4d188 Fixed split in Desktop windowing
When desktop windowing is enable and split is selected, during second app selection apps' scroll was far off on left. There were several things needed to fix this :
1. Hide DesktopTaskView during split select mode by changing splitAlpha
2. Fix min/max scroll calculation by excluding DesktopTaskView in split select mode
3. Exclude DesktopTaskView in updateGridProperties row length calcualtion

Testing: Manually needed to test multiple scenarios
1. Split focused task.
2. Split Even/Odd tasks in top and bottom rows.
3. Split tasks from home screen
4. Split and rotate screen.
5. Split from app icon chip

Test: SplitSelectStateControllerTest, Manual
BUG: 330342294
FIX: 330342294
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I789873100f42896c9ed3084accb0f6970abcba0c
2024-09-30 15:22:40 -07:00
Liran Binyamin
74299edbc6 Merge "Update flyout content during animation" into main 2024-09-30 16:54:15 +00:00
Jeremy Sim
ce40e83e56 Merge "Update splitscreen SnapPosition constants" into main 2024-09-28 02:54:10 +00:00
Liran Binyamin
5c34cf2741 Update flyout content during animation
This change translates the content of the flyout according
to the progress of the animation. Adding an outline provider
allows clipping the content to the bounds of the animating
background.

Also animate the color of the background.

Demo:
on left - http://recall/-/bJtug1HhvXkkeA4MQvIaiP/cH2EK0FiD92dykhLkLeyh1
on right - http://recall/-/bJtug1HhvXkkeA4MQvIaiP/btpcter79rAlcavd4xxHu7

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest

Change-Id: Id142af2041410c0570759a360146d5e084411cc1
2024-09-27 17:27:20 -04:00
Ats Jenk
e7d52f523d Merge "Handle swipe down on collapsed bubble bar" into main 2024-09-27 19:44:56 +00:00
Jeremy Sim
66b695b5fd Update splitscreen SnapPosition constants
Bug: 349828130
Test: No logical changes, continues to pass tests
Flag: com.android.wm.shell.enable_flexible_split
Change-Id: I7b0b436c7eabf7d9fc46e2c6d6e504343d06e48a
2024-09-27 19:17:20 +00:00
Liran Binyamin
272eea45e6 Merge "Implement bubble bar flyout background animation" into main 2024-09-27 12:45:41 +00:00
Liran Binyamin
f7fc19bec1 Implement bubble bar flyout background animation
Update the bubble bar flyout drawing behavior to allow to animate
from a collapsed position into an expanded position.

This change only handles the rounded rect and the triangle. The
text is still left unchanged.

When wired up this looks like this:
left: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/gIsckRmFKj8CceafiJnPTa
right: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dpn51yXFCCkT6ViUegf351

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I85ae3bf908c04e5473655c9e536495f56d80f466
2024-09-26 14:38:41 -04:00
Ats Jenk
0b19598d36 Handle swipe down on collapsed bubble bar
Allow swiping down on collapsed bubble bar to stash it.

Bug: 325673340
Test: atest NexusLauncherTests:com.android.launcher3.taskbar.bubbles.BubbleBarSwipeControllerTest
Test: swipe up to show bubble bar and swipe down to stash it
Test: tap on stashed handle
Test: enable 3 button nav and tap on bubble bar
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I0367d36bdc1aef34dc71843052b691a95e293375
2024-09-25 13:06:22 -07:00
Treehugger Robot
d3e1d7ba42 Merge "Fixes to allow enabling of enable_refactor_task_thumbnail flag" into main 2024-09-25 02:48:24 +00:00
Brian Isganitis
bfe4d6b469 Merge changes Ie1b6609b,If115625c,I418675ba,I930e7458 into main
* changes:
  Add tests for TaskbarAllAppsViewController.
  Add tests for TaskbarAutohideSuspendController.
  Add tests for TaskbarScrimViewController.
  Add tests for TaskbarStashController.
2024-09-24 22:53:24 +00:00
Brian Isganitis
d7dc6ba320 Add tests for TaskbarAllAppsViewController.
Test: TaskbarAllAppsViewControllerTest
Flag: TEST_ONLY
Bug: 346394506
Change-Id: Ie1b6609b243326eb11d03d2ea7b0e98bd60c3a71
2024-09-24 18:51:46 -04:00
Brian Isganitis
bd90d3aa3c Add tests for TaskbarAutohideSuspendController.
Test: TaskbarAutohideSuspendControllerTest
Flag: TEST_ONLY
Bug: 346394406
Change-Id: If115625cb5a6bf2e7653dbe7225b60bf1c6f3836
2024-09-24 18:51:46 -04:00
Brian Isganitis
78f8d40519 Add tests for TaskbarScrimViewController.
Test: TaskbarScrimViewController
Bug: 346395034
Flag: TEST_ONLY
Change-Id: I418675ba9aeaa645a0b216d237c479ffd640baf9
2024-09-24 18:51:46 -04:00
Brian Isganitis
3231ba01e6 Add tests for TaskbarStashController.
Test: TaskbarStashControllerTest
Bug: 346394503
Flag: TEST_ONLY
Change-Id: I930e745826f2512d04434ad689a3e42cac7e9901
2024-09-24 18:51:46 -04:00
Ats Jenk
bf09e036b3 Merge "Have bubble bar unstash gesture track finger" into main 2024-09-24 22:33:02 +00:00
Ats Jenk
26d74b9ec0 Have bubble bar unstash gesture track finger
Follow the taskbar motion for unstashing via gesture.
When swiping up in the handle area, move the handle slightly up with the
finger movement.
Once reaching a certain threshold, unstash the bubble bar.
If user swipes up past a certain other threshold, and lifts the finger,
expand the bubble bar. Otherwise leave bubble bar in collapsed state.

Only stashed handle or collapsed bar can be swiped up on.

Bug: 325673340
Test: atest NexusLauncherTests:com.android.launcher3.taskbar.bubbles.BubbleBarSwipeControllerTest
Test: swipe up on stashed handle
Test: tap on stashed handle
Test: enable 3 button nav and tap on bubble bar
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I6bb3c201cd03f05e2be55ebb0c972c577373ea79
2024-09-24 09:56:49 -07:00
Uwais Ashraf
61e6cb27ed Fixes to allow enabling of enable_refactor_task_thumbnail flag
Fix: 362664267
Test: presubmits
Test: Flakiness check run - https://android-build.corp.google.com/builds/abtd/run/L80100030006605258 (shows an acceptably low flake rate)
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I10ef75d6298498ae827de6408ad661fba09cbde5
2024-09-24 15:04:39 +00:00
randypfohl
daf37eeb07 Cleaning up unusued handlers
Test: Built and tested locally

Flag: NONE Removing unused handler references

Bug:292269949

Change-Id: I83ec8299a82ea8f3db0dace7fb3b823a703b6b62
2024-09-20 16:09:52 -07:00
randypfohl
7ed1868d60 Moving RecentsWindowManager away from the singleton pattern
Test: Built and tested locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: Ic70d9a3e65ffb86e369f52982891b94bef4cacd7
2024-09-20 16:09:52 -07:00
randypfohl
c50aa8bf31 Limited recents in window introductory cl
Test: Built and tested locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: I5352ba0b6c5bc196fbd1322d435a7e27e884f7b5
2024-09-20 16:09:50 -07:00