Commit Graph

19474 Commits

Author SHA1 Message Date
Brian Isganitis
c2bb120a87 Have recreateTaskbar perform recreate on UiThread.
Test: Taskbar{AllApps,Overlay}ControllerTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I663e5ad7bb37e73381e2ef9d787c80177cfdf7a7
2024-06-27 18:32:26 -04:00
Brian Isganitis
e7e98985f7 Move test rules to subpackage.
Test: Compiles
Flag: EXEMPT refactor
Bug: 230027385
Change-Id: I9199fd92450180fa10673c3072dd6e8312fd24d6
2024-06-27 18:32:26 -04:00
Bill Yi
f872c59428 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-06-26 21:05:28 +00:00
Treehugger Robot
2f90296717 Merge "Use snapshotView references in TaskContainer when possible" into main 2024-06-26 18:01:54 +00:00
Alex Chau
c06bc41ee0 Use snapshotView references in TaskContainer when possible
- Moved majority of TaskContainer.thumbnailViewDeprecated usage to TaskContainer.snapshotView, so they'll cover the new TaskThumbnailView as well
- There are afew location left that will be handled as a follow-up
- Removed TaskThumbnailView's splitTranslation and use translation directly as it's the only translation we use

Bug: 336612373
Test: Ensure all Task CUJs still work without refacorting
Test: Ensure major Task CUJs work with refactoring
Flag: EXEMPT refactor
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ieb52236bc503ce0d0a511249978c1821a82d406e
2024-06-26 16:07:57 +01:00
Shamali Patwa
b8f4e16fa7 Merge changes from topic "standalone-fix" into main
* changes:
  [part 2] Update standalone picker to align widget loading and animations
  [part-1] Perform doMeasure only once in WidgetsFullSheet
2024-06-26 14:39:49 +00:00
Alex Chau
fca5237773 Merge "Remove unused PreviewPositionHelper.setSplitBounds" into main 2024-06-26 14:07:19 +00:00
Treehugger Robot
ab26fef0f2 Merge "Ignore minimized Desktop apps in Overview." into main 2024-06-26 10:52:29 +00:00
Luca Zuccarini
772c1efb7f Merge "Add return animations to Toast search results." into main 2024-06-26 10:50:49 +00:00
Gustav Sennton
d06e8dc8a3 Ignore minimized Desktop apps in Overview.
For each desktop session, Overview shows a single tile with multiple
desktop tasks. With this CL avoid showing minimized tasks in that tile.

Bug: 333013317
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: manual: ensured minimized desktop tasks are not shown in Overview

Change-Id: I48cb6826849abf225c0fe4448ca7b0b13afea44e
2024-06-26 08:53:15 +00:00
Bill Yi
159e4ccf1e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Icb2025d6c3f373460127e03cb6d3c117a605b55c
2024-06-25 22:57:47 -07:00
Brian Isganitis
1812030be0 Merge "Take in test instance as field." into main 2024-06-25 23:02:32 +00:00
Brian Isganitis
a07a7c2f91 Take in test instance as field.
This refactor makes it simpler for the rule to keep track of the test
instance (immutable). Having the rule be a TestRule instead of a
MethodRule also simplifies nesting TestRules within this implementation
(future CLs).

Test: Taskbar{AllApps,Overlay}ControllerTest
Flag: EXEMPT refactor
Bug: 230027385
Change-Id: Icf587202242fcb4526946d9c7619e5be4f59154e
2024-06-25 17:16:35 -04:00
Mady Mellor
4d1c6e55d5 Merge "Only return that bubbles are on home if we actually have bubbles" into main 2024-06-25 18:47:25 +00:00
Alex Chau
b76356a202 Remove unused PreviewPositionHelper.setSplitBounds
Bug: 336612373
Test: manual
Flag: EXEMPT refactor
Change-Id: I916341973c4279e548af59452842bc0a677ef6b0
2024-06-25 17:31:51 +01:00
Schneider Victor-tulias
21d4a9cdbc Merge "Finish the recents animation when an unhandled task appears" into main 2024-06-25 14:02:46 +00:00
Tracy Zhou
30e0597a36 Merge "Do not tint task/nav bar icons in folded state when task bar on phones is enabled" into main 2024-06-24 23:14:29 +00:00
Mady Mellor
6d09b0cd1e Only return that bubbles are on home if we actually have bubbles
This causes an issue in the touch inset calculations resulting in
taskbar items being not touchable causing some tests to fail (thank
you tests for catching this!)

Flag: com.android.wm.shell.enable_bubble_bar
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
Bug: 349174989
Change-Id: I8cad22be92f219e0e9d3ec0f551764681f281844
2024-06-24 15:35:55 -07:00
Fengjiang Li
94de34ce2f Merge "[Launcher Jank] Avoid SimpleBroadcastReceiver making binder calls on main thread" into main 2024-06-24 21:00:41 +00:00
Hongwei Wang
4f35222eb6 Merge "Offset display cutous on foldables" into main 2024-06-24 20:29:39 +00:00
Tracy Zhou
42cfe214cf Do not tint task/nav bar icons in folded state when task bar on phones is enabled
This logic will be handled by TaskbarTransitions instead.

Bug: 349155860
Test: Make sure the buttons don't dim after going to an app in folded, when taskbarOnPhones is enabled.
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ie8efa5c096123935458eb3bb451ace35e8914a30
2024-06-24 13:17:37 -07:00
Brian Isganitis
5ee679dbb8 Merge "Introduce TestRule for setting Taskbar mode." into main 2024-06-24 20:17:24 +00:00
Jagrut Desai
a7ec8fe852 Merge "Fix taskbar background alpha" into main 2024-06-24 20:14:28 +00:00
Jagrut Desai
eba5d919ef Fix taskbar background alpha
Test: Manual
Bug: 345018985
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: Ic675285724bcf64b7bd03f918703defb4dc12a47
2024-06-24 13:11:51 -07:00
Brian Isganitis
cbc07b4282 Introduce TestRule for setting Taskbar mode.
This rule is separate from TaskbarUnitTestRule, because mode isn't
relevant to all Taskbar controllers.

To keep MainThreadInitializedObject behavior consistent across
Robolectric and Instrumented environments, context needs to be a SandboxContext.

Test: TaskbarModeRuleTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: Iae2e3627b9002e13ee6da135113e7b8bcc4e7d47
2024-06-24 14:34:45 -04:00
Schneider Victor-tulias
882c83300e Finish the recents animation when an unhandled task appears
Flag: NONE bug fix
Fixes: 339738998
Test: forced error condition programmatically and checked logs
Change-Id: I791a5252c244eaefab041c283b70acf1faad6486
2024-06-24 13:15:54 -04:00
Shamali P
558afdafe2 [part 2] Update standalone picker to align widget loading and animations
In usual picker, widgets are already available before picker opens, so,
the work that happens during animations doesn't interrupt animations
on the scale it interrupt animations in standalone picker.

Bug: 346341156
Flag: EXEMPT bugfix
Test: Manual / see before after video
Change-Id: I7c8701447bd519b306799b28341d8f2f03daf59f
2024-06-24 16:58:32 +00:00
Alex Chau
20a077029c Merge "Disable Select mode from Menu in fake landscape" into main 2024-06-24 14:35:43 +00:00
Alex Chau
2026c80016 Disable Select mode from Menu in fake landscape
Fix: 349072279
Test: Verify that Select mode is only available from Menu in grid only Overview on tablets
Flag: EXEMPT bugfix
Change-Id: Icd0d8303547b45d3653696812c51ce2c2bfd410b
2024-06-24 13:41:37 +01:00
Treehugger Robot
c1391754ff Merge "Enable currently functional multivalent tests" into main 2024-06-24 01:17:40 +00:00
Uwais Ashraf
c902df4e41 Enable currently functional multivalent tests
Flag: EXEMPT test-only
Bug: 325088619
Bug: 325088638
Bug: 325088328
Test: Presubmit
Test: Gradle robolectric run
Change-Id: I20e77a401ed98c97168bf9c752eacc93c3c545dd
2024-06-22 22:14:30 +00:00
Treehugger Robot
0abbc4af14 Merge "Add scrim to TaskThumbnailView" into main 2024-06-22 01:22:31 +00:00
Treehugger Robot
f53b40e1a9 Merge "[Launcher Jank] Allow list OverviewCommandHelper making IActivityTaskManager$Stub$Proxy.startActivity from main thread" into main 2024-06-21 23:36:22 +00:00
Jon Miranda
f044d12fcc Merge "Fix taskbar bg delay for the case when user is going home." into main 2024-06-21 23:16:11 +00:00
Treehugger Robot
b938fa20b2 Merge "Close floating views before fake rotation" into main 2024-06-21 22:46:03 +00:00
Fengjiang Li
1f87d94e59 [Launcher Jank] Avoid SimpleBroadcastReceiver making binder calls on main thread
Fix: 348649441
Flag: NONE - jank fix
Test: manual - presubmit
Change-Id: Ie97713f3f0b1f117662d49c6d6a65651c593d424
2024-06-21 14:37:51 -07:00
Jon Miranda
09aa46b88e Fix taskbar bg delay for the case when user is going home.
The default value was not set. I decided to flip the variable to make
it more readable.

Bug: 345768019
Test: swipe up fast to go home, note no taskbar bg
      swipe up slow to reveal taskhome, note taskbar bg shows immediately
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I7fb4bbdce45a14312e42abcf71f7f0643376ddc6
2024-06-21 14:27:01 -07:00
Tony Wickham
74fc385999 Merge "Load and draw Recent/Running tasks that aren't in Hotseat" into main 2024-06-21 21:01:41 +00:00
Tony Wickham
a79bc15cd0 Merge changes from topic "taskbar-running-minimized" into main
* changes:
  Maintain Running Tasks order in Desktop mode
  Change running apps section to use GroupTask instead of AppInfo
2024-06-21 21:00:01 +00:00
Tony Wickham
59e8952fc9 Merge "Handle running task launch properly in desktop mode" into main 2024-06-21 20:57:38 +00:00
Treehugger Robot
f4934108bb Merge "Fix bubble bar bounce animation issue" into main 2024-06-21 20:44:10 +00:00
Hongwei Wang
87b4060106 Offset display cutous on foldables
When entering PiP on foldables, especically in unfolded mode, offset the
display cutouts even if it's from ROTATION_0 (which is always the case
in unfolded state).

Flag: NONE bug fix
Before: http://recall/-/aaaaaabFQoRHlzixHdtY/eIR7VykaHpYeOigkuZVTp
After: http://recall/-/aaaaaabFQoRHlzixHdtY/cP7NticbA68I4eev2MyZgc
Bug: 331128612
Test: Hold unfolded foldable in different orientation, enter PiP
Test: Hold folded foldable in different orientation, enter PiP
Test: see also the videos
Change-Id: I62e8d3f361644ca0ca78ef20b3d3b5441d7f26c8
2024-06-21 12:06:52 -07:00
Fengjiang Li
c5005171a6 [Launcher Jank] Allow list OverviewCommandHelper making IActivityTaskManager$Stub$Proxy.startActivity from main thread
Added comments

Fix: 348668521
Test: presubmit
Flag: NONE - add comment
Change-Id: I0b3cfb4ee7d05c3b3d2f2857542f1a76a5af7e1f
2024-06-21 12:04:04 -07:00
Alex Chau
bde639236f Close floating views before fake rotation
- We do the same in Launcher for real rotation

Fix: 348113790
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ibd5f42db439cd94a389f7aaf6fe2db317c11cd67
2024-06-21 18:37:21 +01:00
Uwais Ashraf
0d9b547471 Add scrim to TaskThumbnailView
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Fix: 334832108
Fix: 348195366
Test: Manual - checked scrim in un/folded
Change-Id: I758a26e9b4498dac509b75afbe059784557b3f8c
2024-06-21 16:27:01 +00:00
Mady Mellor
a2146c8f10 Merge "Update bubble bar overflow to have a unique resId" into main 2024-06-21 15:55:04 +00:00
Hongwei Wang
a648d13ea8 Merge "Position PiP animation based on actual coordinates" into main 2024-06-21 02:51:37 +00:00
Liran Binyamin
cdc3e4d8b4 Fix bubble bar bounce animation issue
The bubble bar bounce animation was assuming that the initial translation
of the bubble bar is also the translation the bubble bar should have at
the end of the animation. This is normally correct except when the
bubble bar is initially hidden. What happens in that case is that the
translation is 0 so the bubble bar gets animated incorrectly.

This change gets the target animation from stash controller.

ABTD 100 runs: https://android-build.corp.google.com/abtd/run/L26900030004638356/

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 347856510
Test: atest BubbleBarTest#selectDifferentBubble
Change-Id: I661bf006c6f23ff871c221f8d9da74d79a2dff11
2024-06-20 18:03:52 -04:00
Liran Binyamin
8af78f19a3 Merge "Animate bubble removal from the bar" into main 2024-06-20 20:57:34 +00:00
Hongwei Wang
cd6172911e Position PiP animation based on actual coordinates
In the previous patchset, we assumed the left/top to be 0/0 which is not
always the case. This could break, for instance, in ActivityEmbedding
setup, where the pip-ing app is on the left side.

Flag: NONE test fix
Bug: 345327260
Test: Verify with apps support auto-enter PiP such as YouTube
Change-Id: Ic2f3289cf0663d0687d5ccd7f4d0250066cb3f67
2024-06-20 13:24:18 -07:00