Commit Graph

3016 Commits

Author SHA1 Message Date
Krzysztof Kosiński
c1d05a7101 Merge "Clean up obsolete aliases for Truth." into main am: a4bc505d01 am: 6247399c9b am: f56d690e22 am: 42c39649a7 am: b085f9e819
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2778094

Change-Id: Id239979be76a11ce08d564c13f174aa5d02deb3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-11 00:16:49 +00:00
Krzysztof Kosiński
b085f9e819 Merge "Clean up obsolete aliases for Truth." into main am: a4bc505d01 am: 6247399c9b am: f56d690e22 am: 42c39649a7
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2778094

Change-Id: Idc45788d21959e1569e0fd33686536a9675442ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 21:50:07 +00:00
Sunny Goyal
b834d6eca8 Merge "Removing some usage of shared prefs" into main 2023-10-10 18:44:15 +00:00
Krzysztof Kosiński
6e3b7a6943 Clean up obsolete aliases for Truth.
Bug: 255714762
Test: presubmit
Change-Id: Idd56488c129096c520e4e69f175778f10156a569
2023-10-10 06:50:28 +00:00
Sebastián Franco
488defcac2 Merge "Removing logs of test investigation" into main 2023-10-09 21:23:22 +00:00
Vadim Tryshev
6bc3f5e0e1 Merge "Introducing a method for execution an action on Launcher for teardown" into main 2023-10-09 21:22:47 +00:00
Vadim Tryshev
39b4fad9b0 Introducing a method for execution an action on Launcher for teardown
If the test fails to initialize properly, tearDown is still called,
and we may have null Launcher activity.

We want to safely skip using that activity to avoid a NullPointerException
that would hide the original error message.

Bug: 304306290
Test: presubmit
Flag: N/A
Change-Id: I89774a92ede046fa3afadacc62df25f4f496f4e7
2023-10-09 11:29:42 -07:00
Sebastian Franco
76fcdd909d Removing logs of test investigation
Fix: 288944469
Test: uninstallWorkspaceIcon
Change-Id: I4ffaa0dd589a891f880296c7be35b5fce85362e3
2023-10-09 10:52:33 -07:00
Sebastián Franco
07f3e9dc04 Merge "Move test from TaplTestsLauncher3 to TaplUninstallRemove" into main 2023-10-07 00:36:22 +00:00
Sunny Goyal
576f7a5e80 Removing some usage of shared prefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: I158e9a5148d2c9404ea4d2e9e239696b29dbeb20
2023-10-06 14:35:56 -07:00
Federico Baron
0bd2c4ea75 Merge "Add smartspace removal option as a toggle" into main 2023-10-06 20:35:14 +00:00
Vadim Tryshev
acfb180a3d Merge "Next batch of modifications to ignore-lists of anomaly detectors" into main 2023-10-06 20:33:52 +00:00
Vadim Tryshev
75fae9b0b4 Next batch of modifications to ignore-lists of anomaly detectors
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: Ic5eb0a7bfa95c5a3cd890582e7ddf3de2f2bda1c
2023-10-06 11:00:01 -07:00
Brian Isganitis
96224ef755 Merge "Migrate Kotlin tests to use mockito-kotlin2." into main 2023-10-06 17:54:56 +00:00
Stefan Andonian
9acb884c90 Merge "Permanently provide functionality for LauncherPref items that don't need to be migrated, but are boot aware." into main 2023-10-05 21:14:24 +00:00
Sebastian Franco
0b30453722 Move test from TaplTestsLauncher3 to TaplUninstallRemove
Bug: 298234173
Test: atest TaplUninstallRemove
Change-Id: I80fe1c73d08fcf1e310b86a8662c13a8775ade6e
2023-10-05 20:34:06 +00:00
Sebastián Franco
4823dca49e Merge "Moving tests form TaplTestsLauncher3 to TaplTestsAllAppsIconsWorking" into main 2023-10-05 19:56:58 +00:00
fbaron
c0e687bad8 Add smartspace removal option as a toggle
Bug: 303471576
Test: try removing smartspace by going to home settings and turning it off
Flag: ENABLE_SMARTSPACE_REMOVAL
Change-Id: Idd95da1b302927885a8c469e38db6d3c5130f8c1
2023-10-05 17:26:03 +00:00
Stefan Andonian
865898e303 Delete App Icons from Test Data Assets
Previously, the test assets were being pulled into the release APK.
Unfortunately, it isn't possible to build the Release APK from within
SysUi Studio. Since the tests don't test the image loading, I am opting
to simply delete the large image strings, rather than try to figure out
why the release APK is including these test assets.

Bug: 301105199
Test: The tests still pass. That being said, it is difficult to test
this other than see if the APK size doesn't get flagged for growing too
large. It should be ok though, since the test assets are now WAY
smaller.

Change-Id: Ic52bede8296624740e4ca1573955494c3b94bf87
2023-10-05 03:51:54 +00:00
Stefan Andonian
18fe81864f Reapply "Add unit tests for LoaderTask"
This reverts commit e4735d77f1.

Bug: 301105199
Test: This already passed presubmit before.
Change-Id: I97ab28186ba1d4da4abe82686fe1a11d5e51c4b3
2023-10-05 03:51:44 +00:00
Sebastian Franco
547ddd4830 Moving tests form TaplTestsLauncher3 to TaplTestsAllAppsIconsWorking
Removing testGetAppIconName since that behaviour is already tested.

I'm also using this change to remove the TISBinder rule since it's not
needed.

Bug: 302869930
Test: atest TaplTestsAllAppsIconsWorking
Change-Id: Ie6b4f801254ca69b2485fe574914a73f947fc434
2023-10-04 16:43:19 -07:00
Stefan Andonian
54495f3018 Permanently provide functionality for LauncherPref items that don't need
to be migrated, but are boot aware.

Bug: 251502424
Test: Tested that Migration works as expected, as well as shared
preference information that doesn't need to be migrated. Also sanity
tested phone in general.

Change-Id: Ie8460e360856cbe20a7770b1747f75c7154759ab
2023-10-04 23:32:58 +00:00
Vadim Tryshev
e8f7dd5a51 Merge "Further tightening leak detector checks" into main 2023-10-04 22:18:18 +00:00
Vadim Tryshev
c116cee748 Further tightening leak detector checks
Some checks see 2 activities for some reason: Launcher and Overview.
Both active.
I'll have to decide what to do with these cases, but for now, I simply don't pass 'true' from places where this can happen.

When we have 2 activities:
Either Overview is present (and I guess we have to close it before the check) or the screenshot shows that there is no Overview, but internally, apparently, Overview activity is active and therefore, technically, is not leaked.
For the latter case, I may need to do some kind of investigation.
But for now, I'm tightening the check where there is no Overview.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1f1619093e0948b8112f29fd7e94facbf7093983
2023-10-04 22:18:12 +00:00
Vadim Tryshev
174db38f34 Merge "Ignoring the whole fallback TaskView" into main 2023-10-04 22:15:17 +00:00
Sebastián Franco
de846f3d76 Merge "Moving testWidgets from TaplTestsLauncher3 to TaplWorkspaceTest" into main 2023-10-04 21:42:05 +00:00
Sebastian Franco
fd96b78d14 Moving testWidgets from TaplTestsLauncher3 to TaplWorkspaceTest
Also, I'm taking advange of this change to update the name of
OopTaplOpenCloseAllApps to follow the standard TaplOpenCloseAllApps
and I'm also moving testPressBack to TaplOpenCloseAllApps since is
similar to the other methods in that class.

Bug: 298234173
Test: atest TaplWorkspaceTest

Change-Id: Ie933828baedf48b45e55f20853e238ecc6a594bd
2023-10-04 10:21:43 -07:00
Schneider Victor-tulias
0da65fa7a4 Fix flaky key event expectation in KeyboardQuickSwitch
- Add some missing event checks
- Wait until the device has fully settled before unpressing the key code

Flag: not needed
Fixes: 303252187
Test: TaplTestsKeyboardQuickSwitch
Change-Id: Iecc27d6f603d76b5d7c906ec6f703df13c275073
2023-10-04 16:15:59 +00:00
Brandon Dayauon
39276d643b Merge "Make DISPLAY_SEARCH_RESULT_SMALL not badged" into main 2023-10-04 16:13:10 +00:00
Vadim Tryshev
980769a857 Ignoring the whole fallback TaskView
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I9f8dad8ab2beebfcf37d0035096a5747a314c20a
2023-10-03 18:45:58 -07:00
Fengjiang Li
0c740c774e Merge "[Launcher] Fix launcher startup logging" into main 2023-10-03 21:26:39 +00:00
Brian Isganitis
06139e079c Migrate Kotlin tests to use mockito-kotlin2.
Test: atest
Bug: 300509464
Flag: No
Change-Id: I5e0d0f1f29d51cdbfacd51f7229afddf8bd66f7e
2023-10-03 16:04:19 -04:00
Brandon Dayauon
0ae52c9863 Make DISPLAY_SEARCH_RESULT_SMALL not badged
bug: 299364813
Test:Manual -
before: https://drive.google.com/file/d/1Gb_bV5oIEPAvNYnqMJwscX-r1iz967eY/view?usp=sharing
after: https://drive.google.com/file/d/1GTH1A8biVAVnWXaArMkdzWK9kiwFhVCn/view?usp=sharing

Flag: n/a
Change-Id: I6e928079d53bfa7f87cde4d420ee05b1edf875f5
2023-10-03 15:49:45 +00:00
Vadim Tryshev
daa553c7a9 Merge "Starting to tighten leak detector checks" into main 2023-10-03 04:59:09 +00:00
Sebastián Franco
bad922f50f Merge "Moving testWidgets from TaplTestsLauncher3 to it's own test TaplWidgetPickerTest" into main 2023-10-03 03:05:15 +00:00
Vadim Tryshev
d8c049f2af Starting to tighten leak detector checks
This will help to detect leaks earlier, not when we have 3 activities in some cases, but when we have 2.

Adding a parameter that enables more strict detection, and using it in some places.

I'll try to convert as many places as possible to the more strict check after landing this CL.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Idd5a0386005e46dad8aab222bd77c0240f23f43a
2023-10-02 18:34:32 -07:00
Vadim Tryshev
a6b74ffdfc Merge "Verifying that workspace looks correct at the end of the test." into main 2023-10-02 21:48:04 +00:00
Vadim Tryshev
8502a7fbbf Merge "Not recycling input events sent by the tests." into main 2023-10-02 19:52:35 +00:00
Brian Isganitis
c0b9b422be Merge "Add AllApps TAPL APIs for toggling with meta key." into main 2023-10-02 19:09:38 +00:00
Fengjiang Li
188fbc92d1 [Launcher] Fix launcher startup logging
After reporting startup logs, we should tear down logger to prevent sending invalid logs

Bug: 302560751
Test: Verify rotating screen doesn't send startup logs to server
Change-Id: I8cf0a1a34aa9fffb67ddf83efe27908a28538551
2023-10-02 11:14:18 -07:00
Alex Chau
8eb662c67b Merge "Create icon app chip menu for overview tasks." into main 2023-10-02 17:40:33 +00:00
Alex Chau
a84e50412c Merge "Mark existing Launcher CUJs as Platinum tests." into main 2023-10-02 13:05:30 +00:00
Pat Manning
1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Vadim Tryshev
b57e25127e Verifying that workspace looks correct at the end of the test.
I hope that this will lock bugs like b/298114205 in the test that created the bad condition, not the next one.

Bug: 298114205
Test: presubmit
Flag: N/A
Change-Id: If9b48fb5159fc35948607a99f87199d5a32e64d6
2023-09-29 18:31:04 -07:00
Pat Manning
ff74bb5ded Mark existing Launcher CUJs as Platinum tests.
Exclusion CL: cl/565329636 & cl/569615823

Acceptance Criteria:
- TaplTestsQuickstep#testOverviewActionsMenu: https://android-build.corp.google.com/test_investigate/?invocationId=I68300010197543619&testResultId=TR13128935381586398&tab=performance
- OopTaplOpenCloseAllApps#testAllAppsSwipeUpToWorkspace: https://android-build.corp.google.com/test_investigate/?invocationId=I29900010197342608&testResultId=TR26328933842394642&tab=performance
- AddWidgetTest#testResizeWidget: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR14428935383013115&tab=performance
- TaplTestsLauncher3#testLaunchHomeScreenMenuItem: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR20028935383489058&tab=performance

Bug: 300249773
Test: TaplTestsLauncher3
Test: OopTaplOpenCloseAllApps
Test: AddWidgetTest
Test: TaplTestsQuickstep
Change-Id: Ica71dbad91efe8f5b4fd243f0ec78fc3c3c4d456
2023-09-29 23:27:27 +00:00
Vadim Tryshev
b56c8b5c72 Not recycling input events sent by the tests.
The docs indicate that only the system should recycle events.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I76d0ed8ffce6de45f76c846df659c5a68abe3ed0
2023-09-29 15:39:43 -07:00
Mateusz Cicheński
9cf11627de Merge "Add a method to go Home from immersive fullscreen app" into main 2023-09-29 22:30:10 +00:00
Sebastian Franco
7ab324a503 Moving testWidgets from TaplTestsLauncher3 to it's own test TaplWidgetPickerTest
Bug: 298234173
Test: atest TaplWidgetPickerTest
Change-Id: Ia19469d2021cb833b5c1d9d176425b9d6d352797
2023-09-29 20:55:36 +00:00
Sebastián Franco
770559cb6e Merge "Moving test related to the app icon menu to their own file" into main 2023-09-29 20:46:17 +00:00
Jagrut Desai
9c80d72947 Merge "Fixing testQuickSwitchToPreviousAppForTablet" into main 2023-09-29 19:38:48 +00:00