Commit Graph

5231 Commits

Author SHA1 Message Date
Brian Isganitis
c19b51e1f3 Merge "Refactor all apps to depend on activity context." 2022-01-25 18:34:30 +00:00
TreeHugger Robot
78cac51636 Merge "Remove ADAPTIVE_ICON_WINDOW_ANIM feature flag." 2022-01-25 14:21:24 +00:00
TreeHugger Robot
5d534c807a Merge "Cleanup dead code from old all close prototype." 2022-01-25 13:15:01 +00:00
Jon Miranda
78d0d4f832 Remove ADAPTIVE_ICON_WINDOW_ANIM feature flag.
Has been enabled for past few releases, no longer needed
as a debug flag.

Bug: 209856611
Test: manual
Change-Id: Id25e36522636e5c5d8ee60cdec49b3ee3f4d4251
2022-01-24 18:00:04 -08:00
Jon Miranda
3ad2e4e350 Cleanup dead code from old all close prototype.
Bug: 209856611
Test: compiled
Change-Id: Ie94587467442ea00f949241fec41d10fb8c5a527
2022-01-24 17:56:44 -08:00
Brian Isganitis
1664c9f418 Refactor all apps to depend on activity context.
The current AllAppsContainerView has been split into a base class and a
subclass for activities. The base class allows using all apps with an
activity context. A-Z and work profile tabs are supported, but search
and the hotseat still require an Activity.

Test: Manual. All apps should work the same.
Bug: 204696617
Change-Id: I3b146714bc11b3b3555d97623aab5d78ac836482
2022-01-24 20:24:20 -05:00
Josh Tsuji
46728f6481 Merge "Adds Launcher in-window animations, and reworks how the unlock flow works." 2022-01-24 20:34:44 +00:00
Winson Chung
a0c451008a Merge "Add fallback for missing remote animation callbacks" 2022-01-24 18:13:47 +00:00
Sunny Goyal
fcb9182336 Merge "Updating logic to check if icon needs badging" 2022-01-24 16:20:34 +00:00
Wei Sheng Shih
1234813d1c Merge "Fix NPE crash when merge transition to remote transition." 2022-01-24 01:38:58 +00:00
Winson Chung
efb80ec588 Merge changes from topic "presubmit-am-cf03cdfdc7444d7faac91b866c05eae8" into sc-v2-dev-plus-aosp am: b7225856ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16685428

Change-Id: I5595a2cf4bdc179c74d20a01e9249de7c14199ce
2022-01-21 22:48:54 +00:00
Winson Chung
b7225856ad Merge changes from topic "presubmit-am-cf03cdfdc7444d7faac91b866c05eae8" into sc-v2-dev-plus-aosp
* changes:
  [automerge] Dispatch hover events through the input consumer proxy 2p: eff9a120c6
  Dispatch hover events through the input consumer proxy
2022-01-21 22:29:43 +00:00
Winson Chung
92d66a4d2a Merge changes from topic "presubmit-am-eb42a70960e740e988dfbddc552edcae" into sc-v2-dev-plus-aosp am: 4f9711c182
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16683595

Change-Id: Iaa54adbb00484f99272212781bdedd84a1d8ecfc
2022-01-21 20:33:38 +00:00
Winson Chung
4f9711c182 Merge changes from topic "presubmit-am-eb42a70960e740e988dfbddc552edcae" into sc-v2-dev-plus-aosp
* changes:
  [automerge] Skip animation if there are no targets 2p: 6751202328
  Skip animation if there are no targets
2022-01-21 20:04:04 +00:00
Presubmit Automerger Backend
2ec4b4bdf4 [automerge] Dispatch hover events through the input consumer proxy 2p: eff9a120c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16685428

Bug: 197043796
Change-Id: Ic29524b5310cfa89ef9a45e8201fa95e2f873648
2022-01-21 19:40:41 +00:00
Winson Chung
eff9a120c6 Dispatch hover events through the input consumer proxy
- Touch explore uses hover events to focus views for accessibility, but
  we were dropping these events when handling them through the input
  consumer proxy.  The reason this changed is that in sc-v2 we moved the
  recents input consumer to the top of the task display area to ensure
  that it was always above any of the tasks in splitscreen, but by doing
  so, it was always above launcher even after settling in overview.  The
  existing path for handling motion events is heavily tied to touch
  handling (action down/move/up) so we just add a separate path for
  dispatching hover events through the normal mechanism to launcher via
  the consumer.

Bug: 197043796
Change-Id: I5f8cfd357ff13971fe172ce1d0179535479cd26c
2022-01-21 19:40:01 +00:00
TreeHugger Robot
987b62eca5 Merge "Align OverviewActionsView for 3 button taskbar" 2022-01-21 19:31:18 +00:00
Tony Wickham
e586ad2dda Merge "Defer gesture when IME is currently rendering nav buttons" 2022-01-21 18:43:27 +00:00
Winson Chung
3f40a17e54 Add fallback for missing remote animation callbacks
- In some cases WM won't callback the remote animation callbacks (neither
  start nor cancel) and Launcher never finishes executing the pending
  command (preventing the subsequent commands from running).  For the time
  being, just cancel the current state to allow the commands to be
  processed.

Bug: 194011186
Test: Mash on overview and home buttons with a 3p launcher

Signed-off-by: Winson Chung <winsonc@google.com>
Change-Id: I1b1296fab316b979f441ebb474d1475e3fa68f95
2022-01-21 16:34:49 +00:00
Vinit Nayak
c9676e20d3 Align OverviewActionsView for 3 button taskbar
Bug: 189807374
Change-Id: I529dba5d4df3d0c3366c111e70991a36bec4bfc3
(cherry picked from commit 0bd0733ef4)
2022-01-21 15:51:47 +00:00
Josh Tsuji
231c9229bf Adds Launcher in-window animations, and reworks how the unlock flow works.
Bug: 197636887
Test: atest SystemUITests
Change-Id: Idab7249e4a761040863578d546f0831794efaf4a
2022-01-21 10:41:00 -05:00
TreeHugger Robot
3e25f29128 Merge "Add log dumps for taskbar state" 2022-01-21 15:05:32 +00:00
TreeHugger Robot
072b1f013c Merge "[AA+ Search] Update "All apps" to use Google Sans." 2022-01-21 14:40:40 +00:00
wilsonshih
68c38e40c4 Fix NPE crash when merge transition to remote transition.
After enable shell transition, the opening/closing target is for the
app.
In legacy RecentsAnimationController, the mode of the new
RemoteAnimationTarget is decide based on the recents activity type, so
basically the mode for all non-home/recents activity is closing.
So while create the recents window animator, the target apps will be
filter out in RemoteAnimationTargets#ctor because the mode is changed.
To make the remote animation targets compatible with shell transition,
there should only need to check the opening apps as target.

Also fix that the topMostSimulators can be null if the size of
remoteTargetHandles is zero.

Bug: 207297486
Test: Enable shell transition, run
atest TaplTestsQuickstep#testQuickSwitchFromApp
Test: Enable shell transition, enter recents, swipe to right-most page(
the page shows "Clear all"), then click the task and verify Launcher
won't crash. Test on both NexusLauncher and 3rd-party Launcher.

Change-Id: I9bde3d7864d3edd54145c66acae0cd1013d89c6b
2022-01-21 17:32:11 +08:00
Tracy Zhou
d38320eeb6 End live tile when notification panel is pulled down for the first time in Overview. am: 0077caa15d am: b5e6dbc91e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16591950

Change-Id: Ib2148b38ffbd3edbb5f80bea4b10aaf9de5dcfdd
2022-01-21 02:12:24 +00:00
Jon Miranda
fbdb6ac51f Merge "Fix bug where back swipe to icon in All Apps search result." 2022-01-21 02:08:08 +00:00
Alex Chau
dfa4424d4f Merge "Put AllApps in bottom sheet for tablets" 2022-01-21 00:34:03 +00:00
TreeHugger Robot
11d317228c Merge "Update taskbar resume alignment anim if launcher state changes in the middle" 2022-01-21 00:17:04 +00:00
Tony Wickham
da84bcad57 Defer gesture when IME is currently rendering nav buttons
Normally we only defer when touching the nav buttons themselves, but that will be difficult to propagate when IME is hosting the nav buttons. So just defer no matter what if IME is currently showing and rendering the nav buttons, ignoring the touch region.

Test: Enabled "persist.sys.ime.can_render_gestural_nav_buttons", ensure RecentsAnimationDeviceState#isImeRenderingNavButtons() returns true iff IME is showing in gesture nav.
Fixes: 215593010
Change-Id: I265cc042f9e24eb060f090febfbccebd3ba4d3c2
2022-01-20 23:49:34 +00:00
Schneider Victor-tulias
fa0bfee97a Add log dumps for taskbar state
Test: created bugreport and checked logs
Bug: -
Change-Id: Ic0c2330b18c8daf181ae5b236e0c4b212d630fa3
2022-01-20 14:41:25 -08:00
Jon Miranda
b030f83f52 Fix bug where back swipe to icon in All Apps search result.
Issue is that All Apps is scaling during the animation, so when
FloatingIconView looks for it in the view hierarchy,
it's not in its final position.

This would be the cleanest approach for a scv2 fix

Bug: 213306709
Test: manual
Change-Id: Iaec77d15c9533edccd9c82164143af8fa522158f
2022-01-20 13:48:40 -08:00
Winson Chung
6751202328 Skip animation if there are no targets
Bug: 210118444
Test: Manual
Change-Id: I362ca30d0e00b647d84b5df38b35b924d5ccfb33
2022-01-20 21:32:45 +00:00
Becky Qiu
cf627e4de5 [AA+ Search] Update "All apps" to use Google Sans.
Bug: 189356692
Test: manual, screenshot: https://screenshot.googleplex.com/W4RNYLbS9eTqGPr
Change-Id: I2b3f5c1ec5c57602b467e2fef8fdd9bbfa9775c6
2022-01-19 16:47:34 -08:00
Merissa Tan
1b077203d6 Merge "Create new DesktopNavbarButtonsViewController class." 2022-01-19 19:22:49 +00:00
Alex Chau
27b39b9668 Put AllApps in bottom sheet for tablets
http://screen/7steQ7W8U2ga3Hs

Bug: 208599118
Test: manual
Change-Id: I36cbac3cb7cb214081e5a33a6e042ae83e745f23
2022-01-19 18:57:34 +00:00
Tracy Zhou
0077caa15d End live tile when notification panel is pulled down for the first time in Overview.
Fixes: 211556489
Test: Go to overview with live tile. Turn on dark theme. Pull the panel back up. Make sure everything looks fine (live tile is ended).

Change-Id: I51cb81718a489ad7568c5e05ace0b3dbc6ca5443
2022-01-19 18:30:29 +00:00
Tony Wickham
5fa2ed27bf Update taskbar resume alignment anim if launcher state changes in the middle
One way to reproduce this issue is to run `adb shell input keyevent KEYCODE_HOME`, which happens to pause and immediately resume launcher. For example, let's say we run this while in All Apps. Because the isResumed=true comes before the state transition to Normal, we behave as if we are still going to All Apps, specifically goingToUnstashedState = false (since we stash in All Apps). To fix this, we now listen to state changes while the resume alignment animation is playing, and update it if necessary.

Also did the same correction for the gesture alignment animation, though I don't have a specific repo for that.

Finally, because there are now more triggers for alignment animations to play, we add a check to only play them if it's not animating to the same value it's already animating towards. One notable experience this improves is swiping down from All Apps to home; if you do it quick enough, the state animation ends before the taskbar unstash animation, and thus the unstash animation would cancel and start again with the full duration, making it look laggy/disjointed (this behavior existed before this change as well).

Test: TaplTestsQuickstep
Test: Go to All Apps, run `adb shell input keyevent KEYCODE_HOME`, open an app and ensure taskbar icons are visible
Test: Quick switch from home when taskbar is present in apps, but instead go to overview; ensure no jump when taskbar stashes
Test: Swipe down quickly from All Apps, ensure taskbar unstashing doesn't slow down when reaching the end of the state transition
Fixes: 214562370
Change-Id: Ie0c6140e14186e41c7e4748dc745f87349b084fe
2022-01-19 16:39:34 +00:00
Sunny Goyal
7dece749a3 Updating logic to check if icon needs badging
Bug: 209503720
Test: Manual
Change-Id: I66f0dbaf81be3190a106323fe3ce87717626d8e7
2022-01-19 17:22:46 +05:30
Iris Yang
36e0fd91a0 Merge "Set launch display id to an action performed on BaseQuickStepLauncher" 2022-01-19 06:09:30 +00:00
Jerry Chang
d941d02d95 Merge "Consolidate recent animation in split screen with shell-transition" 2022-01-19 01:45:55 +00:00
Merissa Tan
d41ce4980d Create new DesktopNavbarButtonsViewController class.
This CL creates a new DesktopNavbarButtonsViewController class to allow
for taskbar buttons and status icons customization on desktop
environment.

Recall: http://recall/clips/e008d2de-36d3-47f6-954a-5ce18bac69a5

Bug: 213964564
Bug: 196757951
Test: Switch between different system navigation modes and verify the
desktop taskbar buttons stay on screen.

Change-Id: Ie7a9a044fad3b60cd37d910b8eb78c8734aadfd5
2022-01-18 17:10:15 -08:00
TreeHugger Robot
f2172eba8c Merge "Make Taskbar focusable when a popup is open." 2022-01-15 00:00:55 +00:00
Schneider Victor-tulias
291d88460b Make Taskbar focusable when a popup is open.
- Added ArrowPopup#OnPopupClosedCallback to automatically remove Taskbar focus when the popup closes.

Fixes: 209917078
Test: opened popup in taskbar and closed it with switch access, touching anywhere on the screen and using the back gesture. went home to check if focus was removed.
Change-Id: Ie7aafc9cf0f03fadaa44e77818508e9e1d8db610
2022-01-14 12:52:53 -08:00
Tony Wickham
7b40594bc7 Merge changes I36f6cfb8,I7c784765
* changes:
  Create new window for Taskbar Nav Buttons when taskbar is focusable
  Make taskbar focusable when folder is open to get IME input
2022-01-14 17:12:08 +00:00
TreeHugger Robot
1b6d46f880 Merge "Remving SurfaceControlCompat" 2022-01-14 07:04:53 +00:00
Lucas Dupin
470c987e2e Merge "Directly assign mDepth" into sc-v2-dev am: c518932f74 am: 7b71c2ee59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16622831

Change-Id: I4686c845583d85ff58899869ac18a9d87762c537
2022-01-13 23:54:15 +00:00
Lucas Dupin
c518932f74 Merge "Directly assign mDepth" into sc-v2-dev 2022-01-13 23:19:20 +00:00
TreeHugger Robot
05de8c874f Merge "TalkBack doesn't announce when a task has being closed." into sc-v2-dev am: c0a6d3fc8f am: e81cab2fa4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16346766

Change-Id: I03d32f4df17adc36982ad03896583ede306934d3
2022-01-13 21:06:28 +00:00
TreeHugger Robot
c0a6d3fc8f Merge "TalkBack doesn't announce when a task has being closed." into sc-v2-dev 2022-01-13 20:36:44 +00:00
Lucas Dupin
03064a1e60 Directly assign mDepth
A request to set a new depth is ignored if the surface is currently
invalid. We should cache what was the requested value, so it will be
applied once the surface is valid again.

Test: manual
Fixes: 209028986
Change-Id: I812816da4b0139c7ea7b53a9fb00f11265ecdea8
2022-01-13 12:01:11 -08:00