Commit Graph

1657 Commits

Author SHA1 Message Date
Uwais Ashraf
39682e308f Flip set subtraction to produce correct list of tasks to remove.
Fix: 380067701
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TasksRepositoryTest
Change-Id: I26933614241e622a11a440829e89023822c8041b
2024-12-30 14:45:33 +00:00
Treehugger Robot
70e443cde8 Merge "Removing unnecessary baseContext usage in InputConsumerUtils" into main 2024-12-27 12:04:39 -08:00
Sunny Goyal
dff42e04b7 Removing unnecessary baseContext usage in InputConsumerUtils
Bug: 386288280
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ie1ceb513205028e12acefc6bcf8dbf628ce15bc4
2024-12-26 20:43:56 -08:00
Sunny Goyal
c2639e464f Replacing some fixed lookup flags with specific constant flag
This would make it easier to customize flags used on desktop icons

Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: I0f3f04ddbe73abea207a5b58a65714ff172b2726
2024-12-26 20:19:02 -08:00
Liran Binyamin
0e767a2a87 Merge "Fix flake in BubbleBarViewAnimatorTest" into main 2024-12-26 08:37:31 -08:00
Uwais Ashraf
84ce6e9e80 Merge "Fix blank recent tasks thumbnails." into main 2024-12-20 12:20:02 -08:00
Treehugger Robot
64eb038059 Merge "Moving sysproxy to kotlin" into main 2024-12-20 11:44:23 -08:00
Brian Isganitis
1e6ffc8a08 Merge "Split up tests by actual hardware keyboard status." into main 2024-12-20 11:36:35 -08:00
Jordan Silva
e638b5a25a Fix blank recent tasks thumbnails.
When user navigate back to Overview, getAllTaskData will be called and refresh the list of tasks in the repository which cleans the pre-loaded thumbnails and icons from the previous iteration.

In some cases, this causes the thumbnails to be blank in the recents. When getAllTaskData is called after the taskRequest is completed, the tasks will end up in an invalid state without the thumbnail and icon until the user scrolls through the recent apps list or re-open Overview.

Fix: 380067701
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TasksRepositoryTest
Change-Id: Ia15d905a2f5ceb71b87c0b91028ce88894524806
2024-12-20 02:30:39 -03:00
Treehugger Robot
ed7a726091 Merge "Removing state from TISBinder" into main 2024-12-19 18:53:35 -08:00
Sunny Goyal
5df843476c Moving sysproxy to kotlin
Bug: 385171800
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I9db2d4a2f7ff6e739e389ce0e076d5ea88adad5c
2024-12-19 17:22:00 -08:00
Brian Isganitis
791944ff63 Merge "Disable model loading with Sandbox check instead of static boolean." into main 2024-12-19 15:32:56 -08:00
Sunny Goyal
64dcfcf0c7 Removing state from TISBinder
Making OverviewComponentObserver a singleton

Bug: 384896306
Bug: 337863494
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Ic7805ee4f4eef25098ddec4025062135d03c1611
2024-12-19 13:05:42 -08:00
Jagrut Desai
636aba5acb Merge "Don't recreate taskbar in Overview" into main 2024-12-19 13:00:03 -08:00
Liran Binyamin
11323f3b76 Fix flake in BubbleBarViewAnimatorTest
Tried scheduling ABTD multiple times but unfortunately ABTD failed
allocating resources.

Flag: EXEMPT test only
Bug: 384807919
Test: atest BubbleBarViewAnimatorTest

Change-Id: I4c48c034b1bd6c9e8f681fb72cc65a9e0aee2eb7
2024-12-19 12:52:30 -08:00
Jagrut Desai
2f1c1e10de Don't recreate taskbar in Overview
This cl includes
	- when going to overview from Launcher or Desktop Mode don't recreate taskbar and keep it a same variant as the context user was in.
        - user will still be able to pin/unpin taskbar in overview, but it will be recreated to the launcher context.
	- opening app from taskbar context is now aware of if taskbar is in desktop mode and opens app in Desktop Mode when user oepn any app.
        - This cl will not include the animation when taskbar variant is changing between launcher and desktop mode.

Solution
    - if desktop tasks are visible we will open any app from taskbar context into Desktop windowing mode after launching the DesktopTaskView manually. We will launch desktop task from recentview first and upon end of recent animation we will launch the app.

Bug: 343882478
Test: Manual
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ib67e1e7150670f901c07c2df188cde81e7d725dc
2024-12-19 10:50:20 -08:00
Liran Binyamin
8b102fe820 Merge "Fix handle color when interrupting the animation" into main 2024-12-19 10:04:52 -08:00
randypfohl
b479f10d45 Refactor to use a DisplayModel to host common per display objects
Test: Built and ran locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:  379746094

Change-Id: I59b644f8905a3ba5af31234c4fb53709209d9d07
2024-12-18 21:52:41 -08:00
Treehugger Robot
a7bb99683d Merge "Some HSUM bug fixes" into main 2024-12-18 17:40:25 -08:00
Sunny Goyal
211f74608a Some HSUM bug fixes
Bug: 383952735
Bug: 384136644
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: I705d79d008100edd3fcf6fcac4524c204fd4ea30
2024-12-18 11:16:26 -08:00
Sunny Goyal
60bad051c4 Fixing module inheritence when overriding Launcher component
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I1f726e9895f6872d0294a11ab0c52c6c619c2a3f
2024-12-18 10:38:00 -08:00
minch
c7a66bd4af Migrating the remaining getTaskViewAt(0)
Migrating the remaining `getTaskViewAt(0)` to `getFirstTaskView()`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: I083626b0ca62b88d06f508dfc15d9f64112f1a6a
2024-12-11 23:50:53 +00:00
Treehugger Robot
8bba339d80 Merge changes Ifd8f10f5,I14f66628 into main
* changes:
  Update LauncherSwipeUpHandlerV2Test setup to account for RecentsWindowFactory
  Update TaplTestsQuickstep to expect recents window states when enabled
2024-12-11 02:40:01 +00:00
Treehugger Robot
3c3c96f66c Merge "Adding MSDL Feedback when swiping up to reveal overview." into main 2024-12-11 01:50:01 +00:00
Brian Isganitis
a481af5779 Split up tests by actual hardware keyboard status.
Flag: TEST_ONLY
Bug: 230027385
Test: TaskbarStashControllerTest
Change-Id: I63fc433810af3993db5655571a11887eb2c68422
2024-12-10 19:08:36 -05:00
Juan Sebastian Martinez
ce427bfe16 Adding MSDL Feedback when swiping up to reveal overview.
Test: AbsSwipeUpHandlerTestCase
Flag: com.android.launcher3.msdl_feedback
Bug: 376282841

Change-Id: I90a76ea72f87066b9f9d33dda055f99d25249e77
2024-12-10 15:57:07 -08:00
Treehugger Robot
11537828ad Merge "Fising some tests bugs, assuming primary user is user 0" into main 2024-12-10 23:50:28 +00:00
Brian Isganitis
002ef1f550 Disable model loading with Sandbox check instead of static boolean.
The static boolean also affects Taskbar within the Launcher process. We
only want this disabled for the Taskbar test Sandbox.

Flag: TEST_ONLY
Bug: 230027385
Test: NexusLauncherTests:com.android.launcher3.taskbar
Change-Id: Ife12e95ab34755d1aec42d79188c15232d8da092
2024-12-10 23:31:36 +00:00
Schneider Victor-Tulias
35c7dae0ef Update LauncherSwipeUpHandlerV2Test setup to account for RecentsWindowFactory
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 383375436
Test: LauncherSwipeHandlerV2Test
Change-Id: Ifd8f10f55a6c1e43ce7e5e410f77d47d845b216d
2024-12-10 16:18:07 -05:00
Schneider Victor-Tulias
76e1676c7f Update TaplTestsQuickstep to expect recents window states when enabled
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 382527932
Test: TaplTestsQuickstep
Change-Id: I14f66628105fab5d8c39ae7f9fd9ebfa61a268b7
2024-12-10 16:17:57 -05:00
Sunny Goyal
89551b71be Fising some tests bugs, assuming primary user is user 0
Bug: 383091872
Bug: 383183795
Bug: 383088668
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: I551f13fc3d51bf1c2718f0582f8ee76d51067896
2024-12-10 12:09:33 -08:00
Uwais Ashraf
1f09cd720d Don't use flow for one-off get of ThumbnailData
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TasksRepositoryTest
Test: Performance tests
Change-Id: I1990ad1972beea8c81b44cdd50c7f674f225c69d
2024-12-10 17:28:55 +00:00
Brian Isganitis
9c0552e09d Merge changes from topic "taskbar-view-recents-changes" into main
* changes:
  Move recents divider if hotseat is set after recents.
  Animate out/in the correct task view when recents change.
  Implement initial LayoutTransition for Taskbar recents.
2024-12-10 02:18:53 +00:00
Treehugger Robot
278ab17033 Merge "Fixing missing userId in various shell commands" into main 2024-12-10 00:50:10 +00:00
Treehugger Robot
9bb546953c Merge "Adapt TaskbarOverflow tests to check items added overflow view" into main 2024-12-10 00:21:18 +00:00
Randy Pfohl
6cbf910d9a Merge "initial commit for multicontext management for recent windows" into main 2024-12-09 22:27:52 +00:00
Brian Isganitis
c7f6cd6062 Move recents divider if hotseat is set after recents.
Fixes a bug where updateItems is first called with recents and then with hotseat. This causes the Taskbar to first be All Apps, Divider, and then Recents. The layout transition path assumes though that the Divider after All Apps is not for recents in this case, which is wrong. Due to this assumption, it skips over the divider and then adds the hotseat items after it (should be added before). Added a test for this case.

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: Ia690c71fe482709e35ab302a7b497bf547eb4478
2024-12-09 15:35:43 -05:00
Brian Isganitis
3c24c421f6 Animate out/in the correct task view when recents change.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I6c7708ed9f03eff8469b5f2e75ce00e545b03f54
2024-12-09 15:35:43 -05:00
Sunny Goyal
3dfaba2d8c Fixing missing userId in various shell commands
Bug: 380276168
Test: atest TaplMemoryTests
Flag: EXEMPT testfix
Change-Id: I87026eaf6340a2a43cbc899d262879259e339fc5
2024-12-09 10:36:06 -08:00
Toni Barzic
7bea1821d4 Adapt TaskbarOverflow tests to check items added overflow view
Adds a step to verify that TaskbarOverflowView items get set to the list
of the least recent tasks. Adds test cases for an edge case where
taskbar hits max number of items event without recent tasks
(b/379774843).
Has a fix for a further edge case where taskbar overflow view could be
created with a single item (in which case we can just show that item
directly).

Bug: 379774843
Flag: com.android.launcher3.taskbar_overflow
Test: atest TaskbarOverflowTest

Change-Id: I004676da3e17f26b8110d14d39589c84a9f384d8
2024-12-06 19:39:47 +00:00
randypfohl
81962e6fac initial commit for multicontext management for recent windows
Test: Built and ran locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug: 379746094

Change-Id: Ic48b4ef2471a3d6d5eb2e9bacdf00e7d71a87778
2024-12-06 11:17:01 -08:00
Liran Binyamin
b94fce457e Fix handle color when interrupting the animation
Pass the correct stash value to the controller after interrupting
an ongoing animation due to stash state changing. We previously
incorrectly passed a value that depended on the alpha value of the
bubble bar. This allows sampling to happen and for the handle to
have the correct color.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 377604151
Test: atest BubbleBarViewAnimatorTest
Test: manual
       1. Create 1+ bubble
       2. Receive new message and see the flyout
       3. Open an app immediately (Don't wait until the flyout disappear)
Change-Id: I739bcbd8fe4f7e02285244d78d7159c571be1ec2
2024-12-06 16:22:30 +00:00
Liran Binyamin
0e14bb8ef9 Merge "Fix bubble bar flicker in initial animation" into main 2024-12-05 22:22:07 +00:00
Liran Binyamin
77827d3167 Fix bubble bar flicker in initial animation
When the first bubble animates in we make the bubble bar visible
before translating it below the screen to prepare for the spring
animation. This change defers updating the visibility letting the
animator notify when it's safe to update visibility.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 382296842
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - dismiss bubble bar
       - send new bubble
       - observe bubble bar does not flicker
Change-Id: Ib611771dd9f315ab57ef00f8f6cb982b8b88ea73
2024-12-04 15:05:22 -05:00
Tony Wickham
ab8fa5e67e Merge "Factor in userId for updateHotseatItemsFromRunningTasks" into main 2024-12-04 00:31:48 +00:00
Tony Wickham
db64e1b3d1 Factor in userId for updateHotseatItemsFromRunningTasks
Test: onRecentTasksChanged_inDesktopMode_sameHotseatPackage_differentUser_isInShownTasks
Test: Pin personal Chrome, open work Chrome in desktop mode; ensure a
new work icon is created in the running apps section
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 376818660

Change-Id: Ie5cf3ab8e839456e6bd774de8a4398835e790019
2024-12-04 00:31:36 +00:00
Schneider Victor-tulias
bbefa5daf7 Merge "Use the RecentsWindowTracker in FallbackRecentsTest rather than RecentsActivity's ActivityTracker when flag is enabled" into main 2024-12-03 16:06:40 +00:00
Schneider Victor-Tulias
1df3836591 Use the RecentsWindowTracker in FallbackRecentsTest rather than RecentsActivity's ActivityTracker when flag is enabled
Test: pre/postsubmit
Fixes: 381548102
Flag: EXEMPT checking broken tests
Change-Id: I5764c661c53c383a80fbd568e839a5f3d2633427
2024-12-02 16:40:32 -05:00
Liran Binyamin
3931b671b4 Reset the bubble bar scale when the animation is interrupted
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 381283214
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - have a bubble in the bubble bar
       - launch an app
       - set animator scale to 5x to slow down animation
       - send a bubble
       - when the bubble bar animates interrupt the animation by
         touching the bubble bar
       - observe the bubble bar scale is reset correctly
Change-Id: I1abd81e3df987ba749a13eb1b7506d5c1d8fdddd
2024-12-02 11:23:35 -05:00
Liran Binyamin
495fe1d255 Merge "Animate the bubble bar on dismiss" into main 2024-12-02 14:28:30 +00:00