Commit Graph

6752 Commits

Author SHA1 Message Date
Samuel Fufa
e4057e628c Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev 2021-09-21 06:33:06 +00:00
Samuel Fufa
cf175820c4 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev 2021-09-21 06:24:37 +00:00
Evan Rosky
26c596b813 Merge "Register remote transitions on activity start" into sc-v2-dev 2021-09-20 22:29:57 +00:00
sfufa@google.com
d0a332371d [Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app
Bug: 182937704
Test: Add direct call widget from widget tray on a predicted spot. verify prediction clears space and no overlap.
Change-Id: Ie4977ca71ec0b7c2297ffe1454cb4a1e78518a75
2021-09-20 14:22:25 -07:00
sfufa@google.com
ef5ee36e90 [Hotseat] Fix hotseat migration in landscape mode
Bug: 189860214
Test: performed migration in landspace and verified items are moved properly. change is persisted when device is rotated or launcher is restarted.
Change-Id: Ice088e5524a1405dbfa20c21b4edc597f23da07e
2021-09-20 14:22:24 -07:00
Samuel Fufa
7f693253c8 Merge "[AllApps] Fix ConcurrentModificationException in AppPredictionRow" into sc-v2-dev 2021-09-20 21:19:00 +00:00
Samuel Fufa
091d91a84b Merge "[Hotseat] Remove stale predictions when AppIcon is removed" into sc-v2-dev 2021-09-20 21:16:49 +00:00
Evan Rosky
cab41ed670 Register remote transitions on activity start
Was only registering once, but launcher can stop/start
its activity (eg when changing gesture modes), so we
need to try and re-register every time

Bug: 200213691
Test: atest CloseAppHomeButtonTest
      change gesture mode and observe functional animations
Change-Id: I29f1eb647c2168d753e37f57657906979c5518be
2021-09-20 13:41:01 -07:00
Thales Lima
f2d44e8756 launcher: fix animation for quick switch + recents
We need to account for the fact that the running task is outside the
screen in this case, so we need to add that amount to the grid
translation.

Bug: 199265499
Test: manual, check the bug
Change-Id: I8c6ca28c5486ce9769bd6fa8fbb3d70eb9619dc6
2021-09-20 12:14:56 +01:00
sfufa@google.com
a46da7390c [AllApps] Fix ConcurrentModificationException in AppPredictionRow
Bug: 190574986
Test: presubmit
Change-Id: Ic74d1d466e8c7b0ecb870dd5ab47dc91ba71a01e
2021-09-19 22:55:43 -07:00
sfufa@google.com
b39cf0bb33 [Hotseat] Remove stale predictions when AppIcon is removed
Bug: 200088725
Test: Install work profile clock app, verify it is visible in the hotseat, launch (which should remove the icon from AllApps). Go home and verify icon is removed from the hotseat.
Change-Id: I5915f5469fd4f90da0471dc177ef0965e99d07c7
2021-09-19 12:41:23 -07:00
Bill Yi
9b13d2c51b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9bf1c7c41452c33c3ddccea00360022509bc7662
2021-09-18 14:08:25 +00:00
Vinit Nayak
03c13ad130 Merge "Show multiple icons for GroupedTaskView" into sc-v2-dev 2021-09-17 21:27:18 +00:00
Vinit Nayak
af6b85e3bc Show multiple icons for GroupedTaskView
* Hide all overview actions for GroupedTaskView
* Move some logic from TaskView into respective
PagedOrientationHandlers
* Remove unused methods from PagedOrientationHandler
* NOTE this is just visual changes. Properly showing
task menu's is still in-progress

Bug: 181704764
Test: Tested GroupedTaskView in portrait/landscape,
fake landscape in small screen, and real portrait/landscape
in large screen

Change-Id: I9c13ca114024db0a8e3fa5d295951696adb8516f
2021-09-17 10:16:56 -07:00
Tracy Zhou
308851d866 Stash the bar after settling in Overview
Test: https://recall.googleplex.com/projects/81822932-8526-4ee7-b5f7-4ef6d6603f1d/sessions/f0f7a3db-76b6-4f60-87e8-8918bd6cf180
Bug: 193938970
Change-Id: Ic08d3156f5c78a34f353783b760d5cf098e442e8
2021-09-16 00:06:47 -07:00
Vinit Nayak
104ed0b9a8 Show all TaskViews when doing seamless overview rotation am: 6434f8eae5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15838849

Change-Id: Id57edd739e61c9703449058f439c0526b6ef2e8c
2021-09-15 23:39:22 +00:00
TreeHugger Robot
da76a1defd Merge "Removing unused tracing" into sc-v2-dev 2021-09-15 20:26:49 +00:00
Vinit Nayak
6434f8eae5 Show all TaskViews when doing seamless overview rotation
* If user is scrolling and rotates overview in fake
landscape, we wouldn't change the alpha to show if it
was hidden previously.
Now we only skip changing the alpha if it's already visible.

Bug: 194715506
Test: Scroll overview in fake landscape and rotate.
No more invisible task.

Change-Id: Idb519125fbb5ec7be33e0d7b6dd313fb4df684db
2021-09-15 19:17:54 +00:00
Tony Wickham
3d0fca7e0d Merge "Don't set Taskbar window to non-fullscreen while folder animates closed" into sc-v2-dev 2021-09-15 17:47:46 +00:00
Tony Wickham
2908eb70fc Merge changes from topics "TaskbarLogging", "taskbar-log" into sc-v2-dev
* changes:
  Add logs for taskbar and overview split action
  Add TaskBarContainer to launcher_atom.proto
2021-09-15 16:28:45 +00:00
TreeHugger Robot
a2f04dd7d4 Merge "Don't move taskbar window when it resizes" into sc-v2-dev 2021-09-15 07:26:28 +00:00
Vadim Tryshev
72da449f8a Merge "Removing unused tracing" into sc-v2-dev 2021-09-15 02:35:04 +00:00
Tony Wickham
d5e116a750 Don't set Taskbar window to non-fullscreen while folder animates closed
Test: Open an app, open a folder in taskbar, and drag an app from the folder. Ensure the folder close animation plays completely.
Fixes: 199954907
Change-Id: I1caec4ef24b5325724d74f10ddbeae6ef8f9e959
2021-09-14 17:48:14 -07:00
TreeHugger Robot
25a1e0b913 Merge "Rebind TISBinder if service killed during connection" into sc-v2-dev 2021-09-15 00:31:23 +00:00
vadimt
155ce05218 Removing unused tracing
Test: presubmit
Bug: 192018189
Change-Id: I31e6fd8410e879aeda0249d89f650e1a41de6030
2021-09-14 16:42:59 -07:00
Tony Wickham
ed16fb4739 Don't move taskbar window when it resizes
Test: enter split screen, open folder or drag an app icon and ensure the
taskbar doesn't jump briefly to the top of the screen
Fixes: 199386357

Change-Id: I9a4787931a764db0bc036725a58984823a8d5467
2021-09-14 15:31:26 -07:00
Tony Wickham
d552132d0b Reset RecentsView#mNextPage when swiping to home
This ensures that we don't inadvertently update mCurrentPage to be
mNextPage in computeScrollHelper(), which would in turn mess up
calculations such as RecentsView#getHorizontalOffsetSize().

Also removed resetNextPage parameter from forceFinishScroller(), as
resetNextPage was always passed as true anyway.

Test: Swipe up and to the right to home, ensure adjacent page goes all
the way off screen
Fixes: 199927699

Change-Id: Iee1ffac10e5195f0c3a124a23b06d5411ecd7ba2
2021-09-14 14:38:15 -07:00
Vinit Nayak
c64c3cf488 Rebind TISBinder if service killed during connection
Fixes: 198845519
Change-Id: I6af79af5591e2dca941ca4428c550169a178479c
2021-09-14 11:26:00 -07:00
Vinit Nayak
ca549695aa Merge "Set GroupedTaskView child thumbnails in onMeasure" into sc-v2-dev 2021-09-14 17:34:52 +00:00
Vinit Nayak
e6abfca7ab Set GroupedTaskView child thumbnails in onMeasure
* Also add indicator if split was originally started
in portrait of landscape, so we know which dimension
of the divider bar to use if user goes to overview
and then rotates device (horizontal divider vs
vertical)

Fixes: 199461137
Test: Swipe to overview with staged split
Rotate device with and without live tile
Doesn't overlap with overview actions

Change-Id: I8b7f104f16d5b7265828f1b3d98ba3426b28d44f
2021-09-13 18:07:09 -07:00
Tony Wickham
2a10e62e92 Add logs for taskbar and overview split action
Log:
- Taskbar app launch (also from foldeR)
- Taskbar app drag (also from folder)
- Taskbar folder open
- Long press to hide taskbar
- Long press to show taskbar
- Overview Split screen action

Also add support for ActivityContext to overwrite/add to LauncherAtom.ItemInfo, which TaskbarActivityContext does to change HotseatContainer and PredictedHotseatContainer to TaskBarContainer

Test: enable logcat locally
Bug: 193009817
Change-Id: Ia82c846a727fecb8cbfd0a069c8af1276083bf83
2021-09-13 17:25:15 -07:00
TreeHugger Robot
cd3c385246 Merge "Use FakeTransformParams instead of real ones for gesture tutorial" into sc-v2-dev 2021-09-14 00:07:29 +00:00
Thiru Ramasamy
be8b2ad03d Add TaskBarContainer to launcher_atom.proto
Bug: 193009817
Test: Manual
Change-Id: Ib69be2b2405ab38891dff34c4d366105cd2499c1
2021-09-13 16:15:52 -07:00
Vinit Nayak
f66f8271cf Use FakeTransformParams instead of real ones for gesture tutorial
* SwipeUpAnimationLogic was ignoring the TransformParams arg
that was being passed in, because for staged split we are
creating/pairing TaskViewSimulators and TransformParams in
SwipeUpAnimationLogic itself.
* Override the remote handle that gets created during the gesture
tutorial (which shouldn't be done in other cases, but because
tutorial is a one-off it should be fine)

Fixes: 199482330
Test: Launched gesture tutorial from launcher home settings
No crash

Change-Id: I346211a422e46981a994bd40e34e46b44f9f5d0e
2021-09-13 12:57:17 -07:00
TreeHugger Robot
14df808f4d Merge "Fix taskbar education not touchable if taskbar is stashed" into sc-v2-dev 2021-09-13 18:05:28 +00:00
TreeHugger Robot
33df165ca0 Merge "Base split action on focusedTaskView instead of runningTaskView" into sc-v2-dev 2021-09-13 17:38:17 +00:00
Tony Wickham
9c7eda8135 Merge "Destroy taskbar when device is shutting down" into sc-v2-dev 2021-09-13 17:27:43 +00:00
TreeHugger Robot
6087951a9f Merge "Dump DepthController internals" into sc-v2-dev 2021-09-11 00:51:22 +00:00
Tony Wickham
4db4ec118b Destroy taskbar when device is shutting down
Test: Shutdown/restart device, ensure taskbar isn't showing
Fixes: 194633599
Change-Id: I8061e515e122c446438975b98527aeda6c59996a
2021-09-10 16:18:20 -07:00
Lucas Dupin
01c362bb6c Dump DepthController internals
Add DepthController to dumpsys, so it's easier to debug any future
issues.

Bug: 198732728
Test: adb shell dumpsys activity com.google.android.apps.nexuslauncher
Change-Id: Ifa7fe1d7fcb375cacc907d0da9524a2ee2a2677d
2021-09-10 22:57:24 +00:00
Vinit Nayak
5702b89b30 Base split action on focusedTaskView instead of runningTaskView
* getRunningTaskView() is null when rotating device,
only valid when swiping up to overview
* focusedTaskView() correctly set in both cases

Fixes: 199461147
Test: Bug doesn't repro
Change-Id: Ib39c1f6f05b3cd5f72c13facc6b8000346896476
2021-09-10 14:07:58 -07:00
Thiru Ramasamy
d495e8c8b4 Implement LauncherLayoutSnapshot pulled atom callback.
This change will pull only the workspace items but not the launcher settings such as grid layout etc. Future CLs will address it.

Bug: 181703659
Test: Manual-`statsd_testdrive 10108` http://gpaste/4894958784872448
Change-Id: I0e7d7da62034c411edb26ff9205a81b0e2e891a0
2021-09-10 13:29:27 -07:00
Dave Mankoff
f4f7b2234e Merge changes from topics "b194781951-flags", "b194781951-flags-5", "b194781951-flags-6", "b194781951-flags-7" into sc-v2-dev
* changes:
  Remove PluginInitializer.
  Remove #handleWtfs from PluginInitializer.
  Remove #getPrivilegedPlugins from PluginInitializer.
  Rename PluginInstanceManager to PluginActionManager.
2021-09-10 19:25:40 +00:00
TreeHugger Robot
8b30227f58 Merge "Explicitly set X and Y values when offsetting split tasks" into sc-v2-dev 2021-09-10 18:05:18 +00:00
vadimt
4e743887c5 Removing unused tracing
Bug: 181019015
Test: presubmit
Change-Id: I7df032e4345c512ba8eb06a2c4104362e1d51dbd
2021-09-10 10:29:07 -07:00
Nick Chameyev
5d50e49c3f Merge "[Taskbar icons unfold animation issue] Do not take into account initial translation" into sc-v2-dev 2021-09-10 12:25:17 +00:00
Vinit Nayak
6835115c13 Explicitly set X and Y values when offsetting split tasks
* Race condition where DeviceProfile that gets set on
TaskViewSimulator initially has incorrect values
(dp.isLandscape is incorrect)
* The correct one eventually gets set, but in the meantime
we set the split offset assuming in incorrect value in
PagedOrientationHandler#setLeashSplitOffset()
* Once corrected, we weren't removing the old offset
that was set. Now we ensure only either an X or Y offset set.

Bug: 199376724
Test: Enter split, rotate device and quickswitch.
Both tasks should be visible throughout the gesture

Change-Id: I9fa44642ab440a0200c0b0eb9b37574e47b7100d
2021-09-09 16:27:59 -07:00
Vinit Nayak
2d9741b832 Merge "Call exitSplitScreen() when user leaves split tasks" into sc-v2-dev 2021-09-09 20:19:20 +00:00
TreeHugger Robot
8f0de5d711 Merge "Introduces haptic feedback to launcher overview" into sc-v2-dev 2021-09-09 19:19:26 +00:00
Tony Wickham
cc6a1d6584 Fix taskbar education not touchable if taskbar is stashed
Instead of assuming taskbar window is not touchable while taskbar is stashed, fall through to the areIconsVisible() check, which already returns false if taskbar is stashed anyway. Additionally, add a check for AbstractFloatingView so we appropriately allow touches if one exists.

Test: Open Contacts, can still touch through stashed handle; start TaskbarEduView flow and can touch whether taskbar is stashed or not
Fixes: 199376513
Change-Id: If362bad5cb8262fc8c489010e4b2d306ac5f252a
2021-09-09 09:10:21 -07:00