Commit Graph

4738 Commits

Author SHA1 Message Date
Treehugger Robot
ba8a5a2235 Merge "Disable surface effects when a theme controller doesn't support adaptive themed icons" into main 2025-05-29 09:57:49 -07:00
Treehugger Robot
3893804a59 Merge "Moving hotseat variables in DeviceProfile to their own class" into main 2025-05-29 09:01:51 -07:00
Uwais Ashraf
478f07798e Moving hotseat variables in DeviceProfile to their own class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I377b33668c3ed330d362527f62226dd84a5773db
2025-05-29 13:16:05 +00:00
Treehugger Robot
baacf9f4df Merge "Converting StatsLogManager to kotlin" into main 2025-05-28 18:29:53 -07:00
Sunny Goyal
ac35781625 Disable surface effects when a theme controller doesn't support adaptive themed icons
Bug: 420985075
Bug: 415118235
Flag: com.android.launcher3.extendible_theme_manager
Test: Verified on device
Change-Id: I82c46e529aa59be345bf6cdfcfa29fdf784c0068
2025-05-28 16:38:24 -07:00
Vadim Tryshev
a5c22505bb Merge "Removing ViewCaptureRule" into main 2025-05-28 15:01:22 -07:00
Sunny Goyal
bb0f554148 Converting StatsLogManager to kotlin
This is make it easier to create factory classes for individual when adding more injected parameters

Bug: 361850561
Test: Presumit
Flag: EXEMPT refactor
Change-Id: Ie68e9e24aae801b7fed14d1b03df760e5b67c183
2025-05-28 14:12:13 -07:00
Vadim Tryshev
f3112aea02 Removing ViewCaptureRule
Bug: 315482167
Flag: EXEMPT test fix
Test: presubmit
Change-Id: If60412dcec9614fefe897e766395660acb8fa4f8
2025-05-28 11:53:07 -07:00
Vadim Tryshev
eb10725b17 Merge "Better trace for sampler rule." into main 2025-05-28 10:00:56 -07:00
Treehugger Robot
13a600cd96 Merge "Adding ListenableRef as an alternative to StateFlows." into main 2025-05-27 18:01:25 -07:00
Vadim Tryshev
d9c2c46d2a Better trace for sampler rule.
Bug: 415910933
Flag: EXEMPT test fix
Test: presubmit
Change-Id: Ic6a39d7c70cbc0dad9b2e8b208a07414122a307b
2025-05-27 16:06:17 -07:00
Sebastián Franco
aeab3c0d79 Merge "Revert "Revert "Moving DeviceProfile properties into DevicePrope..."" into main 2025-05-23 17:03:18 -07:00
Sebastián Franco
e1d31e5406 Revert "Revert "Moving DeviceProfile properties into DevicePrope..."
Revert submission 33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Reason for revert: Error is fixed

Reverted changes: /q/submissionid:33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Change-Id: Ib86824134955903c11e51e52dbfd6368aba1cd50
2025-05-23 14:08:11 -07:00
Priyanka Advani (xWF)
7705e92d93 Revert "Moving DeviceProfile properties into DeviceProperties da..."
Revert submission 33672643-DataDeviceProfile1

Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.

Fix: 419867875

Reverted changes: /q/submissionid:33672643-DataDeviceProfile1

Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
2025-05-23 13:53:04 -07:00
Sunny Goyal
a57d75cd11 Adding ListenableRef as an alternative to StateFlows.
This allows using listener pattern instead of coroutines within the recommended repository pattern and avoid the jank due to coroutines

Bug: 390572144
Test: atest ListenableRefTest
Flag: com.android.launcher3.model_repository
Change-Id: I9f74166e01e1bdb4cb8afce3213022ea10137230
2025-05-23 13:52:16 -07:00
Sebastian Franco
e1111e28c2 Moving DeviceProfile properties into DeviceProperties data class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I638f88cd76b926917965dbf9e70b5bdfff5971e0
2025-05-23 10:42:26 -07:00
Sebastian Franco
c5f5569f52 Removing methods from BaseLauncherActivityTest to make tests by composition
Bug: 324261526
Flag: EXEMPT test only
Test: All test using BaseLauncherActivityTest
Change-Id: If7cbe84b219b174cd51fac20f104080f735c03f4
2025-05-23 10:08:57 -07:00
Sebastián Franco
48e7365190 Merge "Removing getOnceNotNull from BaseLauncherActivityTest to launcherActivity" into main 2025-05-23 09:16:49 -07:00
Helen Cheuk
73661fda2e Merge "[Action Corner] Add padding between action corner and taskbar" into main 2025-05-23 06:35:28 -07:00
Jordan Silva
f21e4b8023 Merge changes from topics "app-chip-compose", "launcher-compose-tests" into main
* changes:
  Add AppChip in Compose
  Update build to support Compose tests custom directory
2025-05-23 05:18:32 -07:00
Sebastian Franco
1fcb21621b Removing getOnceNotNull from BaseLauncherActivityTest to launcherActivity
This is to make tests by composition instead of inheritance.

Bug: 324261526
Flag: EXEMPT test only
Test: All test using BaseLauncherActivityTest
Change-Id: I616207da890e1979480d1b748f69a9c27c53f9db
2025-05-22 12:06:25 -07:00
Treehugger Robot
e5b641dde1 Merge "Update TestLauncherActivity to send TAPL launcher stopped message" into main 2025-05-22 11:36:54 -07:00
Sebastián Franco
b01c488915 Merge "launcher: Add e2e quickstep tests to NexusLauncherE2ETests" into main 2025-05-22 10:08:04 -07:00
Jordan Silva
4de09ab0ee Update build to support Compose tests custom directory
- Support for Compose Screenshot tests using ScreenshotComposeLib.
- Support for custom directory for tests to be used when compose flag is enabled.

Bug: 400436593
Fix: 366387927
Flag: EXEMPT Build flag: RELEASE_ENABLE_COMPOSE_IN_LAUNCHER
Test: Build
Change-Id: I9a5a5fd4942da2b5d8be0e554e1a42b1cde5f2af
2025-05-22 17:29:51 +01:00
Schneider Victor-Tulias
9705f8fefa Update TestLauncherActivity to send TAPL launcher stopped message
This removes the need for a workaround in LauncherInstrumentation.executeAndWaitForLauncherStop for FallbackRecentsTests with recents window enabled

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: FallbackRecentsTest
Change-Id: I1b974cb2bfff4c14e99abb96c35dcdff04ed0be7
2025-05-22 09:01:14 -07:00
helen cheuk
6e5225bd77 [Action Corner] Add padding between action corner and taskbar
This is to avoid triggering unstashing taskbar and action corner at the same time.
A padding is added between the two areas.

Bug: 411091884
Test: TaplTestsTransientTaskbar
Flag: com.android.systemui.shared.cursor_hot_corner

Change-Id: I4e380a3d004977c96502af23f6126f22749e0a8f
2025-05-22 12:23:34 +00:00
Treehugger Robot
091890adbc Merge "Support workspace cells with two-line labels" into main 2025-05-21 18:25:15 -07:00
Toni Barzic
83b8cc19ca Support workspace cells with two-line labels
Adds `maxLineCount` attribute to CellSpec. The attribute indicates the max
number of lines of text the cell was speced to support. It's used to:
*   enable two-line labels in `BubbleTextViews` for workspace (including
    folder children) items
*   Update cell dimension calculation to inform cell vertical padding

When calculating cell content size the icon text size will be included
`maxLineCount` times, so the cell content gets centered as if it
contains `maxLineCount` lines of text. That way the icon position will
be consistent between cells with text that fits into one line, and cells
that contain two lines of text.

Adds `maxLineCountMatchesWorkspace` attribute to specify that the cell
should inherit `maxLineCount` from workspace cell spec.

Bug: 30153091
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Manual

Change-Id: I150a62f427a0ad755a4746a736d9846d3bea4d2e
2025-05-21 22:04:33 +00:00
Kevin Lim
f7ce5a06fe [Multiline] Clean-up multiline flag on Launcher3
Bug: b/409605328
Flag: EXEMPT removing multiline_search_bar
Test: Unit tests all passing
Change-Id: Id377b7c99af0d0265102888b8021c0809f53a6b9
2025-05-20 18:52:14 -07:00
Alex Chau
13d1b07304 Merge "Reland "Recreate Launcher activity when blur enabled changes"" into main 2025-05-19 07:03:27 -07:00
Treehugger Robot
5ae4fb14f4 Merge "Wait for all springs to finish before running end snapping and relayout." into main 2025-05-19 03:47:48 -07:00
Vadim Tryshev
a3e63d1e20 Merge "Skip all tests after a test times out" into main 2025-05-16 14:06:56 -07:00
Shamali Patwa
b7b5e60d9f Merge "Pass device profile as constructor arg to DatabaseWidgetPreviewLoader" into main 2025-05-16 14:06:39 -07:00
Sebastian Franco
57da21d3c4 launcher: Add e2e quickstep tests to NexusLauncherE2ETests
The test target apk will remain commented until we fininsh adding
all the tests there.

Bug: 324261526
Flag: EXEMPT test only
Test: atest NexusLauncherE2ETests
Change-Id: I989c85baf87cfb15eca817f0c725968dedf015ce
2025-05-16 21:03:03 +00:00
Shamali Patwa
35c051001c Merge "Centralize all entry points for widget picker" into main 2025-05-16 13:41:26 -07:00
Shamali P
4cb6ff3838 Pass device profile as constructor arg to DatabaseWidgetPreviewLoader
This is so, we can use it with compose, and let caller pass the needed
dependencies. May also convert to dagger in
 followup

Bug: 408283627
Flag: EXEMPT BUGFIX
Test: N/A
Change-Id: I9b04011ec2592df3bd02bd74ec4889eb05928e7f
2025-05-16 11:47:18 -07:00
Pat Manning
e229b40329 Wait for all springs to finish before running end snapping and relayout.
- Adds a SpringSet to track all running springs.
- Rearranges the code into blocks: end runnable, reflow, dismiss, neighbor bounce, etc.
- Renames all instances of draggedTaskView to dismissedTaskView for consistency
- To stop blocking touch earlier, run grid end translation without waiting for the neighbor bouncing to finish.
- Update TAPL split screen launching logic to wait for dismiss animation to end.

Fix: 415327465
Test: TaplTestsQuickstep.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I59ade102e35e3528971907e898dac9555c6de796
2025-05-16 19:10:00 +01:00
Alex Chau
557d8e6d7f Reland "Recreate Launcher activity when blur enabled changes"
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Reland fix:
- Removed mBlursEnabled in BaseDepthController, and only use `mCrossWindowBlursEnabled` to control swapping between blur style and fallback style
- Temporary variables like `mPauseBlurs` and `hasOpaqueBg` should only affect if blurs are applied, but not result in swapping of blur style, otherwise this cause unnecessary redraw or activity recreate

Reason for revert: reland
Reverted changes: /q/submissionid:33581402-revert-33554447-b/414789280-CTVRJLPLRT
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Test: PressBackFromLaunchedApp.testPressBackFromLaunchedApp
Flag: EXEMPT bugfix

Change-Id: Iac2b0c00811e0e79684da0cf77df76a120c1272a
2025-05-16 12:33:44 +01:00
Vadim Tryshev
3743ca97c7 Skip all tests after a test times out
That test can continue running in the "Time-limited test" thread,
and we don't know whether it makes sense to wait for its completion.

Flag: EXEMPT test fix
Fixes: 405849365
Test: TAPL tests; pre/postsubmit
Change-Id: I3bdd6e5b07f109124f938766b7f2e427d2e39b01
2025-05-15 13:44:40 -07:00
Alex Chau
38efd382b7 Merge "Revert "Recreate Launcher activity when blur enabled changes"" into main 2025-05-15 13:07:22 -07:00
Sunny Goyal
1d4a457680 Merge "Adding repository for AppsList data" into main 2025-05-15 12:23:44 -07:00
Priyanka Advani (xWF)
1f891a6b67 Revert "Recreate Launcher activity when blur enabled changes"
Revert submission 33554447-b/414789280

Reason for revert: Droidmonitor created revert due to b/417614196. Will be verifying through ABTD before submission.

Fix: 417614196

Reverted changes: /q/submissionid:33554447-b/414789280

Change-Id: Idf349cd39a3f86910f597f0f9ab4d46fb03e945c
2025-05-15 11:12:05 -07:00
Alex Chau
b7dd7bf1e0 Merge "Recreate Launcher activity when blur enabled changes" into main 2025-05-15 06:07:58 -07:00
Sunny Goyal
869b20cb27 Adding repository for AppsList data
Flag: com.android.launcher3.model_repository
Test: atest AppsListRepositoryTest
Bug: 390572144
Change-Id: I6e5993c91f77ed8f0b6f2c12c9d743c87a497134
2025-05-14 21:19:18 -07:00
Treehugger Robot
42aaacc11f Merge "Do not expect a desktop task has action views" into main 2025-05-14 19:11:34 -07:00
Brian Isganitis
70e62fce31 Merge changes from topic "taskbar-wmproxy-module" into main
* changes:
  Filter out DEFAULT_DISPLAY from Taskbar unit tests.
  Refactor test dagger graph to stub PerDisplayRepository instances.
  Only use mockito-kotlin in SandboxApplication.
2025-05-14 14:17:21 -07:00
Alex Chau
a6fa3db580 Recreate Launcher activity when blur enabled changes
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I90ad724867283fe3c62a9073a6e072491533f774
2025-05-14 17:45:04 +01:00
Sebastián Franco
2175b3fc2e Merge "Remove flags from aconfig where the code was already cleaned" into main 2025-05-14 09:16:56 -07:00
Shamali P
8dc2f98338 Centralize all entry points for widget picker
So we have a central place to replace it with opening
WidgetPickerActivity behind a flag.

Bug: 408283627
Flag: EXEMPT minor refactor
Test: Existing tests
Change-Id: I1c26c3faec8549fd5c3057b4c26ab2ab109f6f0c
2025-05-13 17:15:25 -07:00
Sebastian Franco
c6f6cb8cba Remove flags from aconfig where the code was already cleaned
Fix: 409610210
Test: BackupAndRestoreDBSelectionTest
Flag: EXEMPT refacotr
Change-Id: Ic0910c7a5c3124a47128b8b70bd2600374d9c157
2025-05-13 16:25:15 -06:00