Commit Graph

822 Commits

Author SHA1 Message Date
Daniel Andersson
04066346c2 desktop-exploded-view: Adding keyboard navigation to DesktopTaskView
This CL makes TaskContentView focusable and adds a focus border to it
that is shown when it has focus. There are some caveats currently:

* Recents has a bug where it starts to eat TAB inputs (b/403292849).
  This means that the tab navigation is currently quite shaky and
  often just works the first time entering recents.
* Activating a window (with enter) is currently disabled because of
  another existing bug (b/413378320).

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353949138

Change-Id: I1c9c7e437f2e131c4ead1d750952ee9ff77c17f4
2025-05-28 13:54:59 -07:00
Pat Manning
5d822e00fc Merge "Update spring constants for expressive dismiss." into main 2025-05-28 06:59:52 -07:00
Shamali Patwa
3b04cf3155 Merge "Extract widget picker intent extras in WidgetPickerActivity" into main 2025-05-27 20:09:52 -07:00
Shamali Patwa
021c13c172 Extract widget picker intent extras in WidgetPickerActivity
This change refactors activity to move base activity to launcher3

This is to prepare for using it for launching widget picker for
homescreen and use compose.

Bug: 408283627
Flag: EXEMPT independent module
Test: Manual
Change-Id: I271748fb73b3691ba4d046ac8aceb51c4c8aea55
2025-05-27 17:21:31 -07:00
Pat Manning
a0b7dde91c Update spring constants for expressive dismiss.
- Add separate horizontal spring constants for tablets.

Fix: 391101706
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I689b44697be3e5d7909f9f1238359ca529e917f0
2025-05-27 11:26:40 +01:00
Xiaoqian (Daisy) Dai
a66268c9fc desktop-exploded-view: Fix various values for Task windows in desktop tile.
To match with the UX spec, this CL updates the insets based on the
number of tasks within a tile. It also sets a maximum height to the
task window when multiple apps are available.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: OrganizeDesktopTasksUseCaseTest
Bug: 414614454
Change-Id: Icfecc1e41dfd0b95bae10b495adae95fe10dfef2
2025-05-23 14:09:05 -07:00
Helen Cheuk
73661fda2e Merge "[Action Corner] Add padding between action corner and taskbar" into main 2025-05-23 06:35:28 -07:00
helen cheuk
6e5225bd77 [Action Corner] Add padding between action corner and taskbar
This is to avoid triggering unstashing taskbar and action corner at the same time.
A padding is added between the two areas.

Bug: 411091884
Test: TaplTestsTransientTaskbar
Flag: com.android.systemui.shared.cursor_hot_corner

Change-Id: I4e380a3d004977c96502af23f6126f22749e0a8f
2025-05-22 12:23:34 +00:00
Jordan Silva
3d348a0d27 Add focus border animation to IconAppChipView
Fix: 366177160
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual using Keyboard. Access the app chip via TAB and navigate through the task menu.
Test: Manual using Mouse. Hover over the Chip and the Task Menu.
Change-Id: I785ad8723e5255186d744a20992ac0cd0968b380
2025-05-21 14:20:49 -07:00
Saumya Prakash
4d4fd45f02 Merge "Modify Gesture nav edu to new UX specs" into main 2025-05-20 11:58:06 -07:00
Treehugger Robot
9977ef7c2a Merge "Update Empty State to support Blur background" into main 2025-05-20 02:17:40 -07:00
Saumya Prakash
0c6c1d7309 Modify Gesture nav edu to new UX specs
This change adapts the "Done" button in the gesture navigation tutorial
according to new UX specs. Specifically, the button is wider and may
have a different font according to theme.

Fix: 416144733
Test: Run the gesture navigation tutorial and observe the done button
Flag: EXEMPT bugfix
Change-Id: I4732a21c76e5a0e95433a211cd747cb36aaeaa4d
2025-05-19 23:33:32 +00:00
Andy Wickham
982b08ede0 Merge "Fix All Apps interpolators and blur." into main 2025-05-19 15:11:00 -07:00
Treehugger Robot
496de611cd Merge "Change "Close" menu shortcut label to "Clear" in Overview" into main 2025-05-19 09:18:43 -07:00
vinayjoglekar
c66cc78eca Update Empty State to support Blur background
Updated icon and text font as well as scrim values to make the text and
icon visible in both themes and different wallpapers.

Fix: 408437743
Test: Go to overview in empty state(no tasks)
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic76d25f4a70bffa402950fc4c3c3fade32c66c2b
2025-05-19 15:48:24 +01:00
Alex Chau
13d1b07304 Merge "Reland "Recreate Launcher activity when blur enabled changes"" into main 2025-05-19 07:03:27 -07:00
Sam Cackett
5bf67401f6 Change "Close" menu shortcut label to "Clear" in Overview
Fix: 413764920
Flag: EXEMPT. Bugfix
Test: Manual. Open recents, tap menu, "Close" should now be "Clear"
Change-Id: Ic727ae7dedf23af65a382e0c7bfe455653865819
2025-05-19 09:23:41 +01:00
Alex Chau
557d8e6d7f Reland "Recreate Launcher activity when blur enabled changes"
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Reland fix:
- Removed mBlursEnabled in BaseDepthController, and only use `mCrossWindowBlursEnabled` to control swapping between blur style and fallback style
- Temporary variables like `mPauseBlurs` and `hasOpaqueBg` should only affect if blurs are applied, but not result in swapping of blur style, otherwise this cause unnecessary redraw or activity recreate

Reason for revert: reland
Reverted changes: /q/submissionid:33581402-revert-33554447-b/414789280-CTVRJLPLRT
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Test: PressBackFromLaunchedApp.testPressBackFromLaunchedApp
Flag: EXEMPT bugfix

Change-Id: Iac2b0c00811e0e79684da0cf77df76a120c1272a
2025-05-16 12:33:44 +01:00
Andy Wickham
d4100bec42 Fix All Apps interpolators and blur.
Fixes an issue where leaving All Apps did not reverse interpolators,
causing blur to disappear too quickly.

In addition, the logic in BaseDepthController is updated to ensure
100% blur is applied upon reaching max depth. Previously we were
multiplying the depth by 3, but the intention was to reach 1 when
depth reached 0.3. So the blur was only at 90% the intended value in
All Apps (which has a depth of 0.3).

Finally, related to the 100% blur, we correctly end early wakeup
when that is reached, which means we also start it again when the
blur starts changing back towards 0 again. This spins up the GPU,
CPU, and SurfaceFlinger and should help avoid missed frames.

In order to avoid negative performance hits, reducing the max blur
radius from 34dp to 30dp, so that it matches what we were hitting
previously. (The full 34dp unfortunately does cause some regressions).

Bug: 415247657
Test: Open all apps, drag back down, view animation. Also try other
Launcher state transitions.
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ia5daa07525ac96c0597a25bb4320348f27a4ee56
2025-05-15 17:53:17 -07:00
Andy Wickham
db3e5ac901 Merge "Update All Apps handle and work tab color." into main 2025-05-15 16:06:30 -07:00
Priyanka Advani (xWF)
1f891a6b67 Revert "Recreate Launcher activity when blur enabled changes"
Revert submission 33554447-b/414789280

Reason for revert: Droidmonitor created revert due to b/417614196. Will be verifying through ABTD before submission.

Fix: 417614196

Reverted changes: /q/submissionid:33554447-b/414789280

Change-Id: Idf349cd39a3f86910f597f0f9ab4d46fb03e945c
2025-05-15 11:12:05 -07:00
Alex Chau
a6fa3db580 Recreate Launcher activity when blur enabled changes
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I90ad724867283fe3c62a9073a6e072491533f774
2025-05-14 17:45:04 +01:00
Jagrut Desai
7c2a76b499 Merge "Fix TaskbarAllApps Icon" into main 2025-05-12 16:58:46 -07:00
Andy Wickham
0bbe92cda8 Update All Apps handle and work tab color.
Screenshots:
https://drive.google.com/drive/folders/1PfKH2l7cnReWbHmT0o5OKY_KlrK2Wihz?resourcekey=0-kEWlkNyvYkmHO50oeYziYg&usp=drive_link

Fix: 416615578
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: I29fd77863d921afd211527eef2aa7bfa3526fe91
2025-05-12 21:15:41 +00:00
Jagrut Desai
bc28b98b8f Fix TaskbarAllApps Icon
Test: Manual, UX
Bug: 415836854
Flag: EXEMPT bugfix
Change-Id: I8b305ce35e0a6b73559f73083a0ca9b025043e8c
2025-05-12 10:46:57 -07:00
Andy Wickham
58fd27a0cb Fix All Apps fallback colors.
Spec is linked in the bug.

Test: Manual
Fix: 415847439
Flag: com.android.launcher3.all_apps_blur
Change-Id: I805aff19bb3d15d479b7c2c026f041c35585efd2
2025-05-10 01:21:54 +00:00
Andy Wickham
359280ef2c Split BlurStyle and BlurFallbackStyle for All Apps and Overview.
Problem: We don't want to apply the blur style to All Apps if the
all_apps_blur flags are disabled. However, we want to still apply
the relevant colors for Overview when the Overview blur is enabled.

Solution: Split the styles into All Apps and Overview variants.
Unfortunately this creates quite a bit of extra code, but such is
the nature of flag permutations.

This is a more comprehensive color fix compared to ag/33356345,
which is reverted as part of this CL.

Note: enable_overview_background_wallpaper_blur is already broken
when disabled without this change (the live tile gets blurred),
presumably because it's already in nextfood and hasn't been tested
disabled. As such, I focused on testing All Apps blur flags both
enabled and both disabled, with the Overview flag always enabled.

Demo with All Apps flags disabled:
 - Blurs enabled (Overview should blur; All Apps unaffected):
   https://drive.google.com/file/d/1eb882JKSMF-Irc7Ls-iAClYfJIASzzXs/view?usp=drive_link&resourcekey=0-j5EafBfVHIh5oOSFzsYE4g
 - Blurs disabled (Overview should not blur; All Apps unaffected):
   https://drive.google.com/file/d/1toVHYUTj9FjpXCD7m8waeuFIwBbdy_Am/view?usp=drive_link&resourcekey=0-drqPVsELmgJVxhpgxLc-aQ

Demo with All Apps flags enabled:
 - Blurs enabled (Overview and All Apps should blur):
   https://drive.google.com/file/d/1se5yaPDYdDKcoBjZSjDSlqCiSfX0bmHv/view?usp=drive_link&resourcekey=0-U9fBJSVYY9na9r8J5xHXMw
 - Blurs disabled (Overview and All Apps should not blur):
   https://drive.google.com/file/d/1YmqlCdSJDZXGSgpeO5hk16V8Y-6tVpeW/view?usp=drive_link&resourcekey=0-rK4Zy7D8fFyPMA_1XXxwCQ
   (Note: All Apps fallback colors will change with ag/33405653)

Test: Above videos
Fix: 416248709
Flag: com.android.launcher3.all_apps_blur
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9b5cf6b0dce4014053b27ea95a91d047262427b2
2025-05-10 01:21:43 +00:00
vinayjoglekar
3997f6ce4a Separate blur/fallback styles for all apps and overview
Fix: 415233763
Test: Manual. go to overview/all apps enable/disable battery saver mode.
Flag: com.android.launcher3.all_apps_blur
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I4fdb672feb34d4b4da74f430eb8ef9a86ec3adf2
2025-05-09 10:17:11 +01:00
Pat Manning
d2f050ab26 Add magnetic detach to task dismiss using MotionValue library.
Fix: 389081766
Test: TaplTestsQuickstep
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I77f980f9851f4b1c041cbf3bb7247b972c1730fd
2025-05-02 17:13:57 +01:00
vinayjoglekar
45cb055158 Apply fallback overview scrim, overviewactions and clearall in battery saver mode.
1. BlurFallbackStyle/BlurStyle will now be applied in Launcher startup.
   When "updateBlurStyle" is called, individual element style's swap
   happens as per blur style.
2. "hasOpaqueBg" background will now be checked in "applyDepthAndBlur"
   for setting the "currentBlur" value.

Bug: 409758306
Test: Manual. go to overview, enable/disable battery saver mode.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic9030c2b267867b9124705426dd51deb1b30ca55
2025-04-30 17:23:42 +01:00
Treehugger Robot
3bde3a8331 Merge "Update blur style for more things." into main 2025-04-28 13:51:25 -07:00
Andy Wickham
6610425a1d Update blur style for more things.
- Quick Launch highlight (focusHighlight)
 - Drag bar at top of All Apps
 - Divider inside Private Space

Demo (enabling blur via adb in the middle):
https://drive.google.com/file/d/1MjYn1c1mz3m1llmJ-J6kLHUa1j3biv_H/view?usp=drive_link&resourcekey=0-6d1yf_4zDL0W9nTYe6HLNQ

Fix: 413143411
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: I37340759867aba1460fb038269d21c86e8b3c4f6
2025-04-26 01:25:05 +00:00
Treehugger Robot
fe7225eace Merge "Move LauncherRestoreEventLogger to dagger" into main 2025-04-25 14:11:18 -07:00
Jordan Silva
6a70a9ac1c Update Icon App Chip menu animation
Fix: 320435745
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual. Expanding and Collapsing Icon App Chip menu.
Change-Id: Ibfaeb5908f6edf4d3f4c249f6064a21ff10ee0ba
2025-04-25 14:28:27 +01:00
Anushree Ganjam
06bc3f5301 Move LauncherRestoreEventLogger to dagger
Helps us to delete ResourceBasedOverride class.
Delete "launcher_restore_event_logger_class" resource from config.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Ia11162979f016513bd09e06796346d29699b2efd
2025-04-25 01:02:28 +00:00
Anushree Ganjam
93b2c414d4 Move NavHandleLongPressHandler to Dagger.
Helps us to delete ResourceBasedOverride class.
Delete "nav_handle_long_press_handler_class" resource from config.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I3ea307c8da95756ade84dc9c3210dacdeccf9a51
2025-04-23 00:35:57 +00:00
Anushree Ganjam
291438aaec Move StatsLogManager to Dagger
Helps us to delete ResourceBasedOverride class.
Delete "stats_log_manager_class" resource from config.

Delete unused "app_launch_tracker_class" resource from config.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I71ed7ffca62e7c74d4ee0d0b4c045ffed9599cfe
2025-04-21 19:13:22 +00:00
Treehugger Robot
bf044d730c Merge "Move InstantAppResolver to Dagger." into main 2025-04-18 18:06:15 -07:00
Andy Wickham
303b52f84a Merge "Make TaskbarOverlayContext overrideable." into main 2025-04-18 15:02:50 -07:00
Anushree Ganjam
59d5401f59 Move InstantAppResolver to Dagger.
Helps us to delete ResourceBasedOverride class.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9320e0309e2ae4370dcbf2f6f62d704712876bd5
2025-04-18 20:14:14 +00:00
Andy Wickham
33c7b3dcf1 Make TaskbarOverlayContext overrideable.
Bug: 371343636
Flag: EXEMPT refactor
Test: with other change
Change-Id: I46c4bcb88d21890e66e7db7240d3450d75d74354
2025-04-18 01:24:56 +00:00
Andy Wickham
51a0a3829a Update All Apps colors to use shared sysui resources.
This includes the new scrim color and panel treatment documented
here: https://docs.google.com/presentation/d/1BKFfB2LAIDoaA5aLs8did6IcUw_pktrSWI5xmypkl3s/edit?slide=id.g3484dcfffc6_1_203&resourcekey=0-HpXwztiEYGe0BYQzUeBBbQ#slide=id.g3484dcfffc6_1_203

Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: I810aaa84eda218ab33112c9a5c1561cdb088b310
2025-04-17 19:14:18 +00:00
Andy Wickham
16a024df71 Adds Blur and BlurFallback styles for All Apps.
Technically these styles can be used throughout Launcher, e.g.
Widget Picker and Folders, but this CL only applies it to All Apps.

At a high level, views wishing to apply transparency to show blur
should use these new attr values rather than colors directly.

When blur changes, e.g. starting or stopping battery saver, the
style is re-applied and revelant views are invalidated. For
Launcher, this is handled by DepthController, and for Taskbar it's
handled by a CrossWindowBlurListener.

Also updated the Private Space animation slightly to account for
the translucent decorators (specifically, we can't use the mask
view to cover them when blur is enabled).

Screenshots: https://drive.google.com/drive/folders/1tU472KHotgEBpT-Ec9VOBWPBf_YdVqv2?resourcekey=0-ebf7W8O6iDJ4UVMtRzTABg&usp=sharing
Private Space animations: https://drive.google.com/file/d/1h5pn8Xb17TPcbujr7uSAJNTq8kwNZoIp/view?usp=drive_link&resourcekey=0-TzpaJ16Gg8_QJctBx4oiIg
Private Space QS Tile animations: https://drive.google.com/file/d/1dCuqnqd5z2kSBEakGobMlEkMwFDBWRbJ/view?usp=drive_link&resourcekey=0-qRVFPb-a6OzaZQOf4x86Jw

Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ia9f581f50d1adc0830569656bdeb751deb710a9c
2025-04-15 16:42:56 -07:00
Saumya Prakash
178b49beb3 Merge "Remove the skip button from the gesture tutorial" into main 2025-04-15 15:29:37 -07:00
Saumya Prakash
ebfcad524b Remove the skip button from the gesture tutorial
This change removes the legacy skip button from the gesture tutorial. It
is not needed in the current version of the gesture tutorial.

Bug: 400485351
Test: Run tutorial and observe no change as this was for the legacy
tutorial that is no longer in use.
Flag: EXEMPT bugfix

Change-Id: Ice384a0b5811fdc0d09da58ade68539aa146d84d
2025-04-14 23:35:10 +00:00
Brandon Dayauon
b570514ee0 Merge "Add nudgeView to Taskbar.xml" into main 2025-04-11 16:28:59 -07:00
Brandon Dayauon
1fc6f916d3 Add nudgeView to Taskbar.xml
Aiai will send a broadcast to Launcher and will animate the stashHandleView and nudgeView accordingly.
Verified on large screen device that transient taskbar is not affected as its not in scope at the moment.

bug:409121556
Test: manual - video in bug
Flag: com.android.launcher3.nudge_pill

Change-Id: I740e5d81dd008a230aa089f311d38bac665fc227
2025-04-11 13:24:22 -07:00
Sam Cackett
bf69d6e6a5 Merge "Add TaskContentView wrapper to TaskThumbnailView" into main 2025-04-09 23:54:40 -07:00
Brian Isganitis
8c6dd04740 Merge "Expose desktop experience CD Taskbar flag to SecondaryDisplayLauncher." into main 2025-04-09 13:33:40 -07:00
samcackett
2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00