Commit Graph

18079 Commits

Author SHA1 Message Date
Sunny Goyal
bd7ec3335b Using xml override instead of code swap for predicted icon
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: I5ff52464b931630da003fb6aeff2a4fd9d2dd3b3
2024-03-25 15:18:48 -07:00
Sunny Goyal
85b40b37c5 Merge "Removing ext_test directory" into main 2024-03-25 17:42:21 +00:00
Fengjiang Li
9adc988412 Merge "Update WidgetSize on binding workspace, and when dropping widget with config activity" into main 2024-03-22 23:57:01 +00:00
Sunny Goyal
9d2ece156d Removing ext_test directory
Except for a few methods, most of the testing code was already in the main
codebase. Maintaining the additional source directory adds unnecessary overhead

Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: I56c43ab7a4869b26858d622d0b8b14f286d50e90
2024-03-22 15:45:32 -07:00
Brandon Dayauon
9727caec8d Merge "Remove applyBackground param in decorator" into main 2024-03-22 21:29:01 +00:00
Treehugger Robot
ef17913e72 Merge "add more logging for failure to load Widgets" into main 2024-03-22 16:15:31 +00:00
Charlie Anderson
7779852bbe add more logging for failure to load Widgets
Bug: 294386159
Test: locally
Flag: N/A
Change-Id: Ib1fc2c28d1f20142658077047bbe6bc2eabe49d4
2024-03-22 10:43:49 -04:00
Fengjiang Li
6f8069a8dc Update WidgetSize on binding workspace, and when dropping widget with config activity
ag/25923606 seems to have changed when we update widget size, this CL will make sure widget sizes are updated when dropping a widget that requires a config activity

Fix: 328133427
Test: manual
Flag: NONE
Change-Id: I5b62b78a9afde3b79b933f233361b409258649c9
2024-03-22 03:59:23 +00:00
Anushree Ganjam
6dadf21a7f Add FastScrollSectionInfo with "info icon" when work educard exists.
Before: https://b.corp.google.com/issues/325490294#comment1

After: https://b.corp.google.com/issues/325490294#comment5

Bug: 325490294
Test: Manual
Flag: NA
Change-Id: I557971cddd5829f46697004159d62a9343e75f69
2024-03-21 12:29:47 -07:00
Brandon Dayauon
65e373912b Remove applyBackground param in decorator
- This applyBackground() internally calls setBackground which is something that should not be
done in onDraw. Not needed anymore since privateprofile doesn't use the recyclerViewAnimationController anymore.
If it is still needed, when applyingBackground it should be done probably during onBind().
- When setBackground() is called during onDraw() there's a cyclic situation that ends up blocking the thread
and thats why you cannot see the privatespace be deleted.

bug: 329317904
Test: manual:
before: https://drive.google.com/file/d/1vAaA_juK8Bg2QB3oHhRmtiZxcHzEHHP1/view?usp=sharing
after: https://drive.google.com/file/d/1vAR6Okw17uskruHre8RrhsKa7-GiqE6k/view?usp=sharing
Flag: None
Change-Id: I06d31abb31496994d12b96fe6c0ca8cb26c93f69
2024-03-21 11:24:44 -07:00
Alex Chau
59781a7d79 Remove DesktopTaskView.isDesktopModeSupported
- Use Flags.eanbleDesktopWindowingMode directly
- Also clean up unnecessary and improper flag usage

Bug: 309008406
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Test: presubmit
Change-Id: I86ce317ce577f279d2ce819d6dc1738204c2631e
2024-03-21 14:05:27 +00:00
Helen Cheuk
8896580b58 Merge "Change single stroke focus outline to double stroke" into main 2024-03-21 12:09:19 +00:00
Shamali Patwa
f8cd95314c Merge "Update the available size for suggestions in small landscape heights." into main 2024-03-21 02:55:58 +00:00
Shamali P
55f1a39c15 Update the available size for suggestions in small landscape heights.
Bug: 330514207
Test: TAPL test
Flag: N/A
Change-Id: I1e1f43a46f4aa339bcafac013817846d893b0a9b
2024-03-20 22:12:00 +00:00
Vinit Nayak
5afb093a58 Merge "Add CUJ Jank interactions for App Pair saving and launching" into main 2024-03-20 20:31:01 +00:00
Willie Koomson
1b0e8eea61 Merge "Set initial bind options for widgets added with tap-to-add" into main 2024-03-20 16:23:19 +00:00
Rohit Goyal
f21220c79d Bugfix: In case of unarchival, do not add an installer task to add workspace item. am: f8302c388f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26598401

Change-Id: I538d3804b9fdd8ed6d8425abaad38087083d15d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-20 12:59:12 +00:00
Rohit Goyal
f8302c388f Bugfix: In case of unarchival, do not add an installer task to add workspace item.
* In case install queue is cleared (which happens when launcher comes back to foregorund from background) when app has successfully unarchived, since app is not archived anymore, `AddWorkspaceItemTask` successfully manages to add item to the workspace.
* We should avoid adding pending task for adding workspace item in the queue at all for unarchival to prevent this.

Test: verified bugfixes locally.
Bug: 326495267
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iae6d6390d8e2d9b270f7aef0dce1fa32d9899f28
2024-03-20 11:12:38 +00:00
Treehugger Robot
60484e3e2a Merge "Fixing async inflation not happening for first page" into main 2024-03-20 07:53:38 +00:00
Sunny Goyal
e5a95ed11d Fixing async inflation not happening for first page
Bug: 330416518
Test: atest AsyncBindingTest
Flag: aconfig enable_workspace_inflation STAGING
Change-Id: Iab9b203dfab36367cdf531d2dbf023bfbaefe224
2024-03-19 23:28:13 -07:00
Fengjiang Li
b7e9427dc9 Merge "[Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding" into main 2024-03-20 01:21:09 +00:00
Shamali Patwa
eef12ba5b7 Merge "Retain recommendations (if possible) while picker is open" into main 2024-03-20 00:41:41 +00:00
Willie Koomson
a55f214d71 Set initial bind options for widgets added with tap-to-add
Calls PendingAddWidgetInfo.getDefaultSizeOptions to set the bind options
for widgets added with tap-to-add.

Bug: 323886237
Test: manual, place Drive/Gmail widget and confirm correct initial size
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT
Change-Id: Ib0143e3ff49b62d6394d6ca362d89b0ea9773e5f
2024-03-20 00:24:19 +00:00
Fengjiang Li
ea7cb497f5 [Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding
Bug: 325930715
Test: Added unit test
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I509546ac4ee1fa851cf0648d365a5348362267cc
2024-03-19 15:28:38 -07:00
Shamali P
b081314330 Retain recommendations (if possible) while picker is open
Picker rebinds recommendations when size constraints change or
fold/unfold, but recommendations from popup provider may have changed.
This is an attempt at trying to maintain currently shown items
as much possible.

Also, align the pagination and title to the top in two pane picker
 (confirmed with David that we prefer this version)

Additionally, we don't show the widgets count for suggestions.

Bug: 318410881
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Test: Manual

Change-Id: I60799f9ad38da913c3e084d758f5b82c79cd641c
2024-03-19 21:26:14 +00:00
Sunny Goyal
39a24e7c9b Merge "Only use async bind if the callbacks supports it" into main 2024-03-19 20:31:52 +00:00
Sunny Goyal
bf9d02adfe Only use async bind if the callbacks supports it
Bug: 330158016
Bug: 330160059
Test: Presubmmit
Flag: aconfig enable_workspace_inflation STAGING
Change-Id: I7ac62090207db4b78ead8f44b126077ea62fc41b
2024-03-19 11:45:04 -07:00
Anna Zhuravleva
2bbbc2a37e Merge "Log number of apps in Private space" into main 2024-03-19 16:51:18 +00:00
Fengjiang Li
c19e337202 Merge "[Predictive Back] Support WidgetsTwoPaneSheet" into main 2024-03-19 01:53:10 +00:00
Vinit Nayak
422a634a24 Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
2024-03-18 16:27:47 -07:00
Fengjiang Li
c51363fc46 [Predictive Back] Support WidgetsTwoPaneSheet
Fix: 325930715
Test: Manual - attached video to bug
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I44098de12253f803526160bce6457a940b2153c7
2024-03-18 15:31:13 -07:00
Liana Kazanova
7d5531757b Merge "Revert "Add CUJ Jank interactions for App Pair saving and launching"" into main 2024-03-18 18:39:20 +00:00
Charlie Anderson
d62a9f1a6a Merge "Asynchronously call snapToPage so Talkback correctly scrolls to added widget" into main 2024-03-18 18:37:08 +00:00
Liana Kazanova
d8d4fb4375 Revert "Add CUJ Jank interactions for App Pair saving and launching"
Revert submission 26567492-appPairsCUJ

Reason for revert: http://b/330185095

Reverted changes: /q/submissionid:26567492-appPairsCUJ

Change-Id: I73d29fe3618a55622e0daa22c9960e3c5783c275
2024-03-18 18:35:02 +00:00
Vinit Nayak
025b06a1a3 Merge "Add CUJ Jank interactions for App Pair saving and launching" into main 2024-03-18 18:06:21 +00:00
fbaron
fe3f542e61 Remove logspam for resolved bug
b/318394698 was fixed so we can now remove these logs.

Fix: 321837497
Test: N/A
Flag: NONE
Change-Id: Ifc8b18238778f6aa2c0ad1be5df627c07cbaf1d8
(cherry picked from commit 7e5d855886)
2024-03-18 16:48:18 +00:00
Charlie Anderson
fbf41783fc Asynchronously call snapToPage so Talkback correctly scrolls to added widget
Bug: 326269165
Test: locally tested via Talkback
Flag: N/A

Change-Id: I2be6e9758617e4eca18b3ea1ebed8189145c4108
2024-03-18 16:41:53 +00:00
Anna Zhuravleva
b05ceb39b5 Log number of apps in Private space
Log number of user installed and preinstalled apps
in private profile.

Bug: 328406844
Test: aster-previz https://paste.googleplex.com/5134195153698816
Flag: ACONFIG com.android.launcher3.enable_private_space_launch DEVELOPMENT
Change-Id: Ife8a8ee81dca90fa37dba2f3e719ba8031d2eb49
2024-03-18 16:32:31 +00:00
Andrew Cole
6667611f59 Merge "Moving FORCE_MONOCHROME_APP_ICONS to New Flag System" into main 2024-03-18 16:10:03 +00:00
Rohit Goyal
1a59da4e82 Merge "Bugfixes: Handle session failure unarchival cases so that icon and title are accurate." into 24D1-dev am: f51bd26b3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26599264

Change-Id: I1451fff8e1be77d7f3bb45e1406ba48fdda1df08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-18 13:58:54 +00:00
Rohit Goyal
f51bd26b3d Merge "Bugfixes: Handle session failure unarchival cases so that icon and title are accurate." into 24D1-dev 2024-03-18 13:45:51 +00:00
Alex Buynytskyy
30c0325275 Merge "Fix NewApi warning" into main 2024-03-16 22:38:06 +00:00
Willie Koomson
078737f22b Merge "Add tap-to-add button to widget picker" into main 2024-03-15 23:26:05 +00:00
Shamali Patwa
61adb489d1 Merge "Distribute the padding between search&rec container and tabs/applist" into main 2024-03-15 22:42:23 +00:00
Andrew Cole
16b68816ce Moving FORCE_MONOCHROME_APP_ICONS to New Flag System
In order to continue work on theming all app icons we are moving the developer flag over. This is cleanup work

Bug: 270396209
Test: None
Flag: ACONFIG FLAG_FORCE_MONOCHROME_APP_ICONS disabled
Change-Id: Ia290a6761aec68eadd2e78f64ac5dbd233af6033
2024-03-15 14:19:22 -07:00
Vinit Nayak
7ce42078da Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: I5dce4b7e83fb17cc3a70565bfd5ce100a4cf72bb
2024-03-15 14:10:36 -07:00
Willie Koomson
cdc26951ff Add tap-to-add button to widget picker
This change introduces an "Add" button that appears when a widget
preview is clicked in the widget picker. This button disappears when the
preview is clicked again, or another preview is clicked. When the button
is pressed, it adds that widget to the picker. The add button is
available in the app-specific widget sheet as well.

Bug: 323886237
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT

Change-Id: I86a8a4c22119960c54a885fd2efeb91916b4f9a0
2024-03-15 20:10:45 +00:00
helencheuk
7b83b8e011 Change single stroke focus outline to double stroke
Add paint for inner stroke, add padding for launcher widget

Bug: 327386149
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Teamfood
Change-Id: I59cf1088209370b89f2faffdab80787f1b0c1e3b
2024-03-15 18:16:20 +00:00
Sunny Goyal
d51f91a7d0 Fixing PendingWidgets getting attached to real host
Bug: 318539160
Flag: aconfig enable_workspace_inflation DISABLED
Test: TaplBindWidgetTest#testPendingWidget_notRestored_activeInstall
Change-Id: I013811e83b90ea32221904a27790dd677dd63b4b
2024-03-15 10:16:33 -07:00
fbaron
b41c826c6a Fix bug where folder with 1 icon can exist
Fix: 329357132
Flag: NONE
Test: TaplDragTest
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
(cherry picked from commit 5645c3ec55)
2024-03-15 16:11:26 +00:00