Commit Graph

1438 Commits

Author SHA1 Message Date
Liran Binyamin
bb87ec09de Add OWNERS file for multivalentScreenshotTests/src/com/android/launcher3/taskbar/bubbles
Flag: EXEMPT only changing OWNERS
Test: EXEMPT only changing OWNERS

Change-Id: If35010b4bfc166bd8e3734a8fa5be58f6c238f0c
2024-09-26 00:15:42 +00:00
Treehugger Robot
5628ce97e9 Merge "Increase frame limit in bubble bar screen test" into main 2024-09-25 18:25:42 +00:00
Treehugger Robot
d3e1d7ba42 Merge "Fixes to allow enabling of enable_refactor_task_thumbnail flag" into main 2024-09-25 02:48:24 +00:00
Brian Isganitis
bfe4d6b469 Merge changes Ie1b6609b,If115625c,I418675ba,I930e7458 into main
* changes:
  Add tests for TaskbarAllAppsViewController.
  Add tests for TaskbarAutohideSuspendController.
  Add tests for TaskbarScrimViewController.
  Add tests for TaskbarStashController.
2024-09-24 22:53:24 +00:00
Brian Isganitis
d7dc6ba320 Add tests for TaskbarAllAppsViewController.
Test: TaskbarAllAppsViewControllerTest
Flag: TEST_ONLY
Bug: 346394506
Change-Id: Ie1b6609b243326eb11d03d2ea7b0e98bd60c3a71
2024-09-24 18:51:46 -04:00
Brian Isganitis
bd90d3aa3c Add tests for TaskbarAutohideSuspendController.
Test: TaskbarAutohideSuspendControllerTest
Flag: TEST_ONLY
Bug: 346394406
Change-Id: If115625cb5a6bf2e7653dbe7225b60bf1c6f3836
2024-09-24 18:51:46 -04:00
Brian Isganitis
78f8d40519 Add tests for TaskbarScrimViewController.
Test: TaskbarScrimViewController
Bug: 346395034
Flag: TEST_ONLY
Change-Id: I418675ba9aeaa645a0b216d237c479ffd640baf9
2024-09-24 18:51:46 -04:00
Brian Isganitis
3231ba01e6 Add tests for TaskbarStashController.
Test: TaskbarStashControllerTest
Bug: 346394503
Flag: TEST_ONLY
Change-Id: I930e745826f2512d04434ad689a3e42cac7e9901
2024-09-24 18:51:46 -04:00
Ats Jenk
bf09e036b3 Merge "Have bubble bar unstash gesture track finger" into main 2024-09-24 22:33:02 +00:00
Treehugger Robot
befd400b20 Merge "Revert "Move testQuickSwitchFromHome to possubmit"" into main 2024-09-24 20:13:09 +00:00
Ats Jenk
26d74b9ec0 Have bubble bar unstash gesture track finger
Follow the taskbar motion for unstashing via gesture.
When swiping up in the handle area, move the handle slightly up with the
finger movement.
Once reaching a certain threshold, unstash the bubble bar.
If user swipes up past a certain other threshold, and lifts the finger,
expand the bubble bar. Otherwise leave bubble bar in collapsed state.

Only stashed handle or collapsed bar can be swiped up on.

Bug: 325673340
Test: atest NexusLauncherTests:com.android.launcher3.taskbar.bubbles.BubbleBarSwipeControllerTest
Test: swipe up on stashed handle
Test: tap on stashed handle
Test: enable 3 button nav and tap on bubble bar
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I6bb3c201cd03f05e2be55ebb0c972c577373ea79
2024-09-24 09:56:49 -07:00
Randy Pfohl
31aefc3290 Merge changes from topic "windowRecents" into main
* changes:
  Cleaning up unusued handlers
  Moving RecentsWindowManager away from the singleton pattern
  Limited recents in window introductory cl
  abstracting fallback views to support container instead of activity
2024-09-24 16:13:30 +00:00
Schneider Victor-tulias
86046044b7 Revert "Move testQuickSwitchFromHome to possubmit"
This reverts commit 91602f658c.

Reason for revert: failure no longer reproducing

Fixes: 325659406
Change-Id: Ibaaf46ac012b20ab0a901e2794860faae3a53426
2024-09-24 15:36:10 +00:00
Uwais Ashraf
61e6cb27ed Fixes to allow enabling of enable_refactor_task_thumbnail flag
Fix: 362664267
Test: presubmits
Test: Flakiness check run - https://android-build.corp.google.com/builds/abtd/run/L80100030006605258 (shows an acceptably low flake rate)
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I10ef75d6298498ae827de6408ad661fba09cbde5
2024-09-24 15:04:39 +00:00
Liran Binyamin
87a4cee6d7 Increase frame limit in bubble bar screen test
50x run ABTD (passed): https://android-build.corp.google.com/abtd/run/L87100030006646570

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 366544536
Test: atest BubbleBarViewScreenshotTest and ABTD above

Change-Id: If6683001bf3e87a60500b99d022d956f76dd9da4
2024-09-23 20:44:29 +00:00
randypfohl
daf37eeb07 Cleaning up unusued handlers
Test: Built and tested locally

Flag: NONE Removing unused handler references

Bug:292269949

Change-Id: I83ec8299a82ea8f3db0dace7fb3b823a703b6b62
2024-09-20 16:09:52 -07:00
randypfohl
7ed1868d60 Moving RecentsWindowManager away from the singleton pattern
Test: Built and tested locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: Ic70d9a3e65ffb86e369f52982891b94bef4cacd7
2024-09-20 16:09:52 -07:00
randypfohl
c50aa8bf31 Limited recents in window introductory cl
Test: Built and tested locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: I5352ba0b6c5bc196fbd1322d435a7e27e884f7b5
2024-09-20 16:09:50 -07:00
randypfohl
f29dc7c5ec abstracting fallback views to support container instead of activity
Test: Built and tested locally

Flag: NONE just abstracting in this cl

Bug:292269949

Change-Id: I0ce5efb4f193211216430f373605107c87de2c1a
2024-09-20 10:23:31 -07:00
Liran Binyamin
7b0c32567f Merge "Update bubble bar flyout according to spec" into main 2024-09-20 16:42:34 +00:00
Anushree Ganjam
f2c65c289b Merge "Make sandboxContext extend LauncherApplication (4/n)" into main 2024-09-19 23:22:56 +00:00
Anushree Ganjam
26a5f65afd Make sandboxContext extend LauncherApplication (4/n)
See
https://docs.google.com/drawings/d/1JHFi_nhmQt2xPT1N3FB_1mnaRK5TVqKZ9-fSl3EA7sU/edit?usp=sharing
and
https://docs.google.com/drawings/d/1bx4WURP4uHZGzZ1bWQgpw701jkTkVqlNfA02Yt-ZtSI/edit?usp=sharing&resourcekey=0-oySjsnaCsOSrNIPqqEa0gw
for design details.

We need to make SandboxContext extend LauncherApplication because we
want create MainThreadInitializedObjects in SandboxContext's
AppComponent scope. Since MainThreadInitiliazedObjects are closed in
SandboxContext's OnDestroy() , we need to replicate same thing using
dagger as well.

- DaggerSingletonObject is same as MainThreadInitializedObject but is
  used for fetching the dagger created singletons so that we can avoid
  major refactors for accessing singletons. This will be deleted soon.

- DaggerSingletonTracker to track dagger created singletons and call
  close() on those singleton objects created in SandboxContext scope.

- Annotate the singleton object SettingsChangeLogger constructor with @Inject and execute the statements in Main thread.
- Added createSandboxContextForTest(only for Test) to avoid creation of
  dagger component in test. As follow up, I will delete this method and
  introduce fakeDaggerComponents in test.

Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration

Change-Id: I2d3762ea64e53baa4de190790568aec750b54201
2024-09-19 11:20:30 -07:00
Liran Binyamin
19a43fb7cf Update bubble bar flyout according to spec
Also add a triangle

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I1a16ba6c9e1a2ca4efe01524ba3ef1d049f81d68
2024-09-19 14:02:43 -04:00
Helen Cheuk
e58dad0821 Merge "[Contextual Edu] Update Edu stats when going to overview and all apps from home" into main 2024-09-19 14:45:49 +00:00
Liran Binyamin
c2c7913134 Merge "Create BubbleBarFlyoutView" into main 2024-09-18 14:21:26 +00:00
Treehugger Robot
545440327d Merge "Update out-of-date TODO comment" into main 2024-09-17 16:25:49 +00:00
Liran Binyamin
36b5ef2271 Create BubbleBarFlyoutView
Initial version of the flyout view for displaying bubble bar
notification.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I5d0643fe5d2691ad2349b45eaaad6cd2660d9df0
2024-09-17 11:14:54 -04:00
helencheuk
5012640ab2 [Contextual Edu] Update Edu stats when going to overview and all apps from home
Update education stats when
- go overview and all apps by swiping up at homepage (AbstractStateChangeTouchController)
- go home from all apps by swiping down the all apps panel (AbstractStateChangeTouchController)
- go home from all apps or overview by swiping up from the bottom nav bar (NavBarToHomeTouchController)
- in 3 button navgiation mode (TaskbarNavButtonController)

NavBarToHomeTouchController does not inherit from AbstractStateChangeTouchController so logic are added separately.

Bug: 363480554
Test: TaskbarNavButtonControllerTest
Flag: com.android.systemui.keyboard_touchpad_contextual_education
Change-Id: I0662704a9093b9f5a4d2f086a8297429fbc49881
2024-09-17 16:00:24 +01:00
Schneider Victor-Tulias
0a815eae39 Update out-of-date TODO comment
These TODO comments will be adressed by b/342627272, so b/326565120 should be closed.

Flag: EXEMPT comment update
Bug: 326565120
Bug: 342627272
Test: none needed, comment update
Change-Id: I75637e1494a1abba5c542a292a8a1e8881cbedfc
2024-09-17 10:13:16 -04:00
Himanshu Gupta
edebee564f Skipping testPrivateSpaceLockingBehaviour for LS devices.
Skipping the test until we fix the root cause of failure
on LS devices.
Also removing ScreenRecord from now passing tests.

Bug: 355466672, 367258373
Fix: 334946529
Test: atest NexusLauncherTests:com.android.quickstep.TaplPrivateSpaceTest#testPrivateSpaceLockingBehaviour
Flag: TEST_ONLY
Change-Id: Ia0d43386e70b8584b8c77d541abd16cbd5e64741
2024-09-17 09:19:58 +00:00
Treehugger Robot
34b535c76d Merge "Don't wait for thumbnails to update if updatedThumbnails are empty" into main 2024-09-16 12:57:12 +00:00
Treehugger Robot
196422d6cc Merge "Revert "Add screenrecording for testOverview"" into main 2024-09-16 11:47:52 +00:00
Alex Chau
88f4eb48b1 Revert "Add screenrecording for testOverview"
This reverts commit 01fc975288.

Reason for revert: b/355042336

Change-Id: I1a5038e1608624dc1bc774940d84aea09381da87
2024-09-16 09:59:01 +00:00
Alex Chau
8b692c356b Don't wait for thumbnails to update if updatedThumbnails are empty
Fix: 366205521
Test: Double tap recents button in -1 screen
Test: RecentsViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I3eb854c8068fe70473bde32c5f7706af8d17a3cf
2024-09-16 10:39:23 +01:00
Treehugger Robot
41d2d507a3 Merge "Revert "Add screen recording to TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet"" into main 2024-09-13 23:57:50 +00:00
Ats Jenk
61d45eb8d2 Merge changes I3cfdb715,Ic194afdb into main
* changes:
  Fix initial alpha when unstashing bubble bar
  Set additional bubble translation during stash
2024-09-13 22:38:24 +00:00
Schneider Victor-tulias
ef404a786e Revert "Add screen recording to TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet"
This reverts commit 600c508569.

Reason for revert: test no longer fails
Fixes: 358607191

Change-Id: Ie944a7d79dab03fcb61ca62926929b0b462c1ba6
2024-09-13 21:49:24 +00:00
Ats Jenk
9639315baa Fix initial alpha when unstashing bubble bar
For the stash and unstash animation we use separate timings for the
Bubble views and background. In other animations we animate the entire
bubble bar alpha as one.
To achieve this during unstash animation we set the bubble views and
background alpha to 0. And then set the bar alpha to 1.
Since alpha animation has a delay during unstash, we need to set the
initial values as the start of the entire animation and not just the
alpha part. Otherwise there are flickers in the animation.

We also need to set initial values for the alpha animator that the
AnimatedFloat creates. AnimatedFloat uses the current values as the
start value. If we update it later, the animator was already created and
it won't have an effect. To fix this, we set the start and end values
for the alpha animators created by AnimatedFloat.

Bug: 345488489
Flag: com.android.wm.shell.enable_bubble_bar
Test: slow down animations and unstash bubble bar, check that bubbles
  alpha slowly animates in

Change-Id: I3cfdb715e1703bd2195c809fd77751a216558176
2024-09-13 10:51:11 -07:00
Liran Binyamin
6138138d99 Merge "Initial screenshot tests for bubble bar view" into main 2024-09-12 13:33:50 +00:00
Vinay Joglekar
b3189d8404 Merge "Add keyboard navigation for all large tiles" into main 2024-09-12 09:09:02 +00:00
Treehugger Robot
206e15b286 Merge "Move DesktopVisibilityController to TouchInteractionService" into main 2024-09-12 02:32:00 +00:00
Ats Jenk
aad71bc532 Set additional bubble translation during stash
Fixes bubbles stash translation not getting cleared up after stash
animation finishes.

Bubbles are clipped using an outline animator during the stash
animation. They need separate translation applied to keep them within
the bounds of the bubble bar that is also shrinking and moving.

Set the translation for the bubbles in the stash controller so we can
reset the translation after the animation has finished.

Bug: 365829293
Flag: com.android.wm.shell.enable_bubble_bar
Test: TransientBubbleStashControllerTest
Test: have bubbles in bubble bar, trigger a new auto expanding bubble,
  check translation for bubbles
Change-Id: Ic194afdb4d650fcd525355d8bae08dd651d1ea05
2024-09-11 16:29:22 -07:00
Schneider Victor-Tulias
2b46c945a7 Move DesktopVisibilityController to TouchInteractionService
Moved DesktopVisibilityController to TIS for 3P launcher support.

Flag: EXEMPT bug fix
Fixes: 338063030
Fixes: 357859025
Test: Launched overview and resumed desktop task from desktop mode on 1P and 3P launchers
Change-Id: I64e99a32ed13bcb6e4a81a18c29df2643373dc35
2024-09-11 09:56:35 -07:00
vinayjoglekar
941a9e4f98 Add keyboard navigation for all large tiles
Currently large tiles are excluded from adding into collection which is used for keyboard navigation. This cl adds them if desktop windowing tile is enabled.

Test: TaskGridNavHelperTest
BUG: 361070854
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I63fbb6867c34bbd80df926d750a7a392860b70a0
2024-09-11 16:02:18 +01:00
Ats Jenk
d72a0400eb Merge changes I485f6346,I24b0c646 into main
* changes:
  Animate alpha for bubbles and background (3/n)
  Use a reveal animator for bubble icons (2/n)
2024-09-10 18:03:00 +00:00
Liran Binyamin
3a2a7685b0 Initial screenshot tests for bubble bar view
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 355454021
Test: atest BubbleBarViewScreenshotTests
Change-Id: Id74c78d99a8b4528bb473c5a751edb19bda34007
2024-09-10 13:59:01 -04:00
Ats Jenk
4ea856ee2d Merge "Align bubble bar stash anim with taskbar (1/n)" into main 2024-09-10 00:45:36 +00:00
Ats Jenk
332828b340 Animate alpha for bubbles and background (3/n)
Use separate timings for bubble icons and bubble bar background when
stashing and unstashing.
Follows alpha timings applied to taskbar background and icons.

Bug: 345488489
Test: TransientBubbleStashControllerTest
Test: stash and unstash bubble bar in app by swiping up from taskbar
Test: expand and collapse bubble bar in app by swiping up on bar
Test: expand and collapse bubble bar on home screen by tapping on it
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I485f6346539cb6c8ea6dd4d15f25a6421021fec1
2024-09-09 15:23:51 -07:00
Ats Jenk
9ca662a7f7 Use a reveal animator for bubble icons (2/n)
Use a similar animation for bubble bar icons as we use for taskbar. When
stashing or unstashing, use a reveal animator to show the icons.
Previously we were scaling the icons to the desired size.
New reveal animator matches what is used for taskbar.

Bug: 345488489
Test: TransientBubbleStashControllerTest
Test: stash and unstash bubble bar in app by swiping up from taskbar
Test: expand and collapse bubble bar in app by swiping up on bar
Test: expand and collapse bubble bar on home screen by tapping on it

Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I24b0c64673d6becfa2ed68993bb95fe78e105670
2024-09-09 15:23:51 -07:00
Ats Jenk
9eadd68e01 Align bubble bar stash anim with taskbar (1/n)
Only scale bubble bar background during stash and unstash animation.
Follows the logic used for taskbar. We scale only the background and
clip the icons separately.

Bug: 345488489
Test: PersistentBubbleStashControllerTest
Test: TransientBubbleStashControllerTest
Test: BubbleBarViewAnimatorTest
Test: stash and unstash bubble bar in app by swiping up from taskbar
Test: expand and collapse bubble bar in app by swiping up on bar
Test: expand and collapse bubble bar on home screen by tapping on it

Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ifc7922c444f2179fc49643424815e5e7dde519cc
2024-09-09 15:23:48 -07:00