Commit Graph

22 Commits

Author SHA1 Message Date
vadimt
d9ca71b1d9 Ignoring failing out-of-SLO test
Test: presubmit
Bug: 243855320
Change-Id: I7795bdae6b30cd663fa4e6cbba118d84d57ec96d
2023-01-03 12:46:43 -08:00
TreeHugger Robot
1c22b7e57c Merge "Support for animating A-Z <-> Search." into tm-qpr-dev 2022-09-10 01:11:36 +00:00
Andy Wickham
94d5d3cb6c Support for animating A-Z <-> Search.
Demo videos (1/5 speed) and APK: https://drive.google.com/drive/folders/1qQNzcoibiFMzxYhvXc7UEHCaBhJg6SjN?resourcekey=0-OWD06iLXg3wf_eWce4rUPA&usp=sharing

Bug: 234882587
Bug: 243688989
Test: Manually tested a bunch of cases at 1/10 animation speed.
Such as work profile or not, suggested apps enabled/disabled,
typing during the animation, going back during the animation,
web results injected above apps, etc.

Change-Id: Id4f1a858d387bf3a7f9cf2d23564a276544abef1
2022-09-09 15:37:57 -07:00
Brandon Dayauon
e4c4e2043f Added extra check to CLI command that was not checked for
check if work profile is indeed set up

 - after workProfile setup, added log of profile ID for each test..
 - added CLI check for "start-user"
 - Investigating where flakiness occurs because of failed
 work profile account set up or test just fails

bug: 243688989
test: Tested where there is no shell command in setup and all tests were skipped
Change-Id: I131b62c1a929c2e550be111a3840fd93c7435860
2022-09-07 10:00:56 -07:00
Brandon Dayauon
7ad8227a08 Make test always pass when command fails
because command Would cause flakiness if cli command fails.

bug: 237428272
test: on AS
Change-Id: I0bfe26b9242afffe1399fd9788981f71d8fea73e
2022-08-22 21:00:21 +00:00
Sunny Goyal
cba5f9a64e Removing unnecessary work adapter wrapper
Simplifying view type constants to make it easier to add new view types

Bug: 234008165
Test: Verified on device
Change-Id: I96589ceba362ea7e75afdfc3fe8da3be214aa682
2022-07-15 16:24:31 -07:00
Andy Wickham
2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Sunny Goyal
3c5a08ada1 Implementing support for item diffing instead of creating out the
complete UI on every update

Bug: 229860311
Test: Verified locally
Change-Id: I5712b5d76878a0ed72cc1392ede59b3778b7a1dc
2022-05-03 16:24:46 -07:00
Anushree Ganjam
5cc7ff0990 Revert "Refactors Search results into separate RV for Toast."
This reverts commit 6729f0b950.

Reason for revert: This change caused b/230648542.

Please see https://b.corp.google.com/issues/230648542#comment5 for the video after reverting this change.

Bug: 206905515
Bug: 230648542

Change-Id: I85f063c56cad137c05b810204244bba7e8f94ee7
2022-04-28 01:37:49 +00:00
Andy Wickham
6729f0b950 Refactors Search results into separate RV for Toast.
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
2022-04-24 17:36:48 -07:00
Brian Isganitis
1664c9f418 Refactor all apps to depend on activity context.
The current AllAppsContainerView has been split into a base class and a
subclass for activities. The base class allows using all apps with an
activity context. A-Z and work profile tabs are supported, but search
and the hotseat still require an Activity.

Test: Manual. All apps should work the same.
Bug: 204696617
Change-Id: I3b146714bc11b3b3555d97623aab5d78ac836482
2022-01-24 20:24:20 -05:00
TreeHugger Robot
8c8e2a22da Merge "Revert "Adding screen record for a flake"" into sc-v2-dev 2021-11-19 00:51:07 +00:00
Jonathan Miranda
ae1bcc9ba8 Revert "Adding screen record for a flake"
This reverts commit da02250c29.

Reason for revert: Flake resolved
Bug: 202735477
Test: presubmit

Change-Id: I86856110ca9b8745c194a716a587d3bbe7f0137e
2021-11-17 16:24:26 +00:00
Jon Miranda
8568602aaf Add back waitForStateTransitionToEnd to fix flakiness.
Bug: 202735477
Test: presubmit
Change-Id: I03c7e8b0c40177f4e6e38a7d9aa3e01b029effd6
2021-11-09 17:02:31 -08:00
Jon Miranda
f37d7a21f2 Add resume check to other WorkProfileTests to fix flakiness.
- Tests were flaky with waitForStateTransitionToEnd
- Tests stopped flaking with both waitForResume and waitForStateTransitionToEnd
- waitForResume may be enough to fix the flakiness, so
  removing waitForStateTransitionToEnd for now, if flakiness
  returns we can add it back

Bug: 202735477
Test: presubmit
Change-Id: Ib9cc16ea7815387582486517a87249d0053475f6
2021-11-09 10:14:01 -08:00
Jon Miranda
b9f5602d96 Testing to see if waiting for resume will fix flaky tests.
Similar to how AbstractLauncherUITest waits for resume after
switching state to Normal.

Bug: 202735477
Test: presubmit
Change-Id: I61834d32f8005491a4e14a354dc0097b05267f7b
2021-11-08 11:58:10 -08:00
Jon Miranda
a234a8ea85 Testing to see if waiting for transition to end will fix flaky tests
Test: presubmit
Bug: 202735477
Change-Id: Icf62003b9f422cf0e327365260c36f6d57b71aef
2021-11-05 12:31:15 -07:00
Jon Miranda
f3fbc935cd Testing to see if using isInStableState is better condition vs getCurrentStableState
Test: presubmit
Bug: 202735477
Change-Id: I06c964cc92b7731e73628210688817e2d9cf1bac
2021-11-03 11:42:01 -07:00
Jon Miranda
da02250c29 Adding screen record for a flake
Test: presubmit
Bug: 202735477
Change-Id: I4e1d2bc3650e2f52767f57e9b00c9c2bf7974489
2021-11-01 14:25:35 -07:00
sfufa@google.com
467d95cef3 [Test] Introduce tracing to identify why pm create-user is failing
Bug: 203817455
Test: presubmit
Change-Id: Iccfa152bea7a914292d566d6dd3e58eb73c38aa4
2021-10-25 18:56:49 -07:00
sfufa@google.com
9f0981dc4f [Work profile][Test] Remove tracing logs for testWorkeduFlow
Bug: 159671700
Test: NA
Change-Id: I097134c45155f0e65ef4376fab803796f3fdb12a
2021-10-07 16:48:41 -07:00
sfufa@google.com
bd977f3598 [Work Profile] Enable work profile tests
Bug: 159671700
Test: presbumit
Change-Id: Icfe39c30d603a4ae4cac576bc44037f545437ced
2021-10-07 16:48:20 -07:00