Commit Graph

278 Commits

Author SHA1 Message Date
Hyunyoung Song
b9f9d69f67 Hide IME when scrolling happens on all apps screen/scroller
Bug: 161594550

TL;DR;;
- draging an item closes the IME
- clearing a searchbox to empty string has no effect on IME

Change-Id: Ic3a91d1b22434dcb78347dd8b12b5ceab14eb928
2020-08-19 01:20:06 -07:00
Hyunyoung Song
5dd045bec6 Handle IME selection focus for ENABLE_DEVICE_SEARCH
Bug: 162861289
Change-Id: I15e4eae09be2aa9f89a5157fd74c95e91e64bc53
2020-08-11 09:27:45 -07:00
Samuel Fufa
e8bea3ea7a Allow search results decoration [part 2/3]
[Video attached to bug report]

Bug: 162480567
Test: Manual
Change-Id: Iff285abde5b2a3f3f3a63e7318020cfe7572af49
2020-08-04 10:28:28 -07:00
Sunny Goyal
ea600c70fd Creating a common method to iterate over all model items.
This would allow adding different source for model items without
modifying every model task

Bug: 160748731
Change-Id: I5a14dd761e2b8696c58dc8fec7b14077da0aced3
2020-07-10 09:56:15 -07:00
Samuel Fufa
25afca44c4 Merge "Work profile visual polish" into ub-launcher3-rvc-dev 2020-06-09 21:21:56 +00:00
Samuel Fufa
2e59b95024 Work profile visual polish
- Calculate work profile switch height and apply it as a padding to recyclerview instead of reading height from view.
- Add solid background to work_apps paused overlay for improved crossfade animation on pause/unpause
- Don't show work paused overlay text in landscape mode

Bug 151672365
Bug 153763804
Bug 151595687

Test: Manual
Change-Id: I6c14a8a1624455181d4998555bcc3ae2bb422efe
2020-06-09 14:17:47 -07:00
Sunny Goyal
28daf4a76f Removing multiple system RPCs to packageMAnager and userManager from UI thread
Bug: 158427348
Change-Id: Ibb1837fe932000b69cf5683bb01727fc32abca91
2020-06-08 17:56:36 -07:00
TreeHugger Robot
f7c768c7db Merge "Disabled app icon Visuals" into ub-launcher3-rvc-dev 2020-06-06 18:58:15 +00:00
Samuel Fufa
61bc63a6a4 Disabled app icon Visuals
Bug: 154855908
Test: Manual
Change-Id: I58c75ed51426ceb4a09b608ee77636c803955025
2020-06-05 17:35:00 -07:00
Sunny Goyal
786940ae93 Allowing Launcher to draw behind cutouts
> Launcher uses realSize, availableSize and insets to calculate
various layout values. Without drawing behind cutouts, these values
are not consistent (insets + availableSize != realSize) leading to
jumps in layouts.
> Removing fake black bars in low-ram devices to avoid inconsistent
insets.
> Fixing various layouts not taking lert/right insets into account.

Bug: 156268804
Change-Id: I8441db8a468b08a65b57b932050b5b4b37313966
2020-06-05 00:25:58 -07:00
Samuel Fufa
6c00f16d67 Define a11y content description for work paused list
Bug: 151803591
Test: Manual
Change-Id: I2b592189d784010f09fcd54378f2b34bd2d6c6e3
2020-04-12 17:38:14 -07:00
Sunny Goyal
e396abf502 Moving model data structures to a separate file
Change-Id: I77ad7a5219e72d2e0d6c1803de2ac3ed6a65a8f7
2020-04-09 13:20:39 -07:00
TreeHugger Robot
239e05eccb Merge "Highlight personal tab on work profile reinstallation" into ub-launcher3-master 2020-03-25 22:14:23 +00:00
Samuel Fufa
6fb959d8cc Highlight personal tab on work profile reinstallation
Bug: 145595763
Test: Manual
Change-Id: I4da5e03c3aa66b324bc375d328e7b81278d58aca
2020-03-25 11:26:25 -07:00
Samuel Fufa
1b373657a4 Animate Work paused overlay
Please see bug for video preview

Bug: 151408501
Test: Manual
Change-Id: Ic96bdc438b7c897c89261764dad16124006d7138
2020-03-20 20:19:03 -07:00
Samuel Fufa
45c3b10448 Work profile accessibility fixes
- Remove TextView and use work switches text
- Allow talkback to read recyclerview overlay

Bug: 151884799
Bug: 151803591
Bug: 151274763
Bug: 151585835
Test: Manual
Change-Id: Ieee0d37d0244eb12ecb923d710cbbd6a86281062
2020-03-20 11:52:03 -07:00
Samuel Fufa
f5a4deb120 Hide work apps when work profile is paused
- hide overlay icon in landscape mode
- don't show edu if user has already seen legacy work profile edu
- make sure personal tab is highlighted when work profile is reinstalled
- always go home after a work profile is added or removed
- add tests for work edu flow

Bug: 150122946
Test: Manual
Change-Id: I8f80ac763acf03ca31a534464f4ddfd84528d329
2020-03-12 10:25:50 -07:00
Samuel Fufa
a579ddc9c8 Refactor logging to capture Target hierarchy
Instead of creating a fixed number of targets, we now pass an ArrayList
of targets to. Any class implementing
LogContainerProviders#fillInLogContainerData can setup it's own target
and add it to the ArrayList, It can also pass the ArrayList to other
LogContainerProvider to capture full Target hierarchy.

Bug: 147305863
Change-Id: I0063c692120fb9e1cff2d8902c5da972d0623418
2020-03-06 13:49:19 -08:00
Samuel Fufa
748afbec35 Prevent hotseat touch hijack
Bug: 148639821
Test: Manual
Change-Id: Ia08af6b243a3492a898371b7bc66158df49d2427
2020-03-05 11:41:49 -08:00
Samuel Fufa
aeb185e744 Merge "Clean up work profile" into ub-launcher3-master 2020-02-19 19:53:38 +00:00
Samuel Fufa
ccebfbe273 Clean up work profile
This includes
- Dismiss work edu on launcher state change
- Remove work tab flash on first setup
- Make edu bottom sheet adopt theme color
- Fix Work toggle bottom inset


Bug: 149200572
Bug: 149197172
Bug: 149199058
Bug: 149215103
Bug: 149198955
Bug: 145595763
Bug:149481723

Test: Manual
Change-Id: I39a30782b80fd3a66bede55754fa30a940d2caee
2020-02-19 19:33:09 +00:00
Samuel Fufa
ea4dcf468e Add Tests for work profile toggle
+ Fix minor style issues

Bug: 140099753
Bug: 112899690
Test: Manual
Change-Id: I1257560be79748abe54a75a74d93caa4390943b5
2020-02-13 17:21:54 -08:00
Samuel Fufa
8f6d141d84 Work toggle improvements
Bug:141289979
Test:Manual
Change-Id: If96845c0220816f9ffd5a5c86ec33b2674d15d1d
2020-01-31 12:07:12 -08:00
Sunny Goyal
9c2b96090b Adding SecondaryDisplayLauncher in Launcher using common listener
Bug: 141596722
Change-Id: I480bfadf592f7d0309f17c33a3fe14bb77fb5586
2020-01-30 08:27:27 +00:00
Samuel Fufa
4bbed19012 Work profile edu
+ Move bottom sheet edu resources to launcher3

Bug: 140099753
Test: Manual
Change-Id: I933acea2b503c0f98362322d24a067c33a1bb2a7
2020-01-27 10:09:04 -08:00
Sunny Goyal
3d56046ff8 Fixing some tests for 2-button mode
Bug: 141315387
Change-Id: I66db3e790f5fbe6bc30999ed599cce03874509be
2019-09-20 10:40:14 -07:00
Jonathan Miranda
903abfc48f Merge "Support defining X column layout for all apps as a display option." into ub-launcher3-qt-future-dev
am: 315732e524

Change-Id: I1c47d689fbec052859d5fdbfcf8d10b07ddd0202
2019-09-17 11:25:21 -07:00
Jon Miranda
6f7e9702e3 Support defining X column layout for all apps as a display option.
Bug: 124967099
Change-Id: I7bf576759b3fa4f6ca617fbbd660541c12fd09ac
2019-09-16 16:24:59 -07:00
Sunny Goyal
3e3d759db2 Removing flag overrides. All flags should be defined as togglable flags instead.
Change-Id: Ia7b9ff84413096cd5b0c4a9a81a232019f2522d2
2019-09-12 10:17:14 -07:00
vadimt
2b3303c744 Not freezing All Apps during user interactions
Extremely rarely, All Apps will get stuck in a non-updating state even
after the interaction ends.

It would be impractical to try drilling to the root cause of this,
so it's better to just allow All Apps updates while the user interacts
with it.

Bug: 139384936
Change-Id: I2ed7fb052da77a9e47ef9b9aa7800499071b98c3
2019-08-22 22:34:17 +00:00
Becky Qiu
75970447a7 Merge "Fill the logging container in the AllAppsContainerView" into ub-launcher3-qt-r1-dev 2019-07-12 21:15:25 +00:00
vadimt
1fd52d9024 Remove tracing for a fixed bug
Bug: 132900132
Change-Id: Ic4ce3669f88c932e392b7517ec9fda11384dc334
2019-07-11 16:00:12 -07:00
Becky
8874e5f8a7 Fill the logging container in the AllAppsContainerView
This would fix the issue that when drag and drop an icon from the all apps
page, it doesn't have the right container information logged.

Logging after this fix:
07-11 10:57:04.392 12969 12969 D UserEvent: action:DRAGDROP
07-11 10:57:04.392 12969 12969 D UserEvent:  Source child:APP_ICON	parent:ALLAPPS
07-11 10:57:04.392 12969 12969 D UserEvent:  Destination child:APP_ICON	parent:WORKSPACE id=0
07-11 10:57:04.392 12969 12969 D UserEvent:  Elapsed container 744 ms, session 17440 ms, action 739 ms

Test: manual
Bug: 111935715
Change-Id: Ifb078e57697b051e3a527c16abaad40663eae687
2019-07-11 14:36:37 -07:00
TreeHugger Robot
ec5561060b Merge "More tracing for app not starting from all apps" into ub-launcher3-qt-dev 2019-06-13 21:22:14 +00:00
vadimt
f02bef7345 More tracing for app not starting from all apps
Bug: 132900132
Bug: 134172603
Change-Id: I6a85e616552e84b8165661d25ed4330f55d3946f
2019-06-13 14:05:17 -07:00
vadimt
d4c90e12e9 Freezing all apps updates during certain tests
This CL adds a very low risk because most (but not all) changes affect
only Launcher behavior during the test.

This should fix a lab-only flake when all apps keeps changing while
the test is working with it.

Example: test figures out which icon to click, by the moment it clicks
there, there is another icon there, or the icon is under the search box,
and clicking opens IME.

Switching test devices to airplane mode didn't help. The earlier change
that prevents popup menu cancellation is not general enough.

Now the tests are given an API to explicitly freeze and unfreeze
all-apps, which should be a final solution.

Bug: 132900132
Bug: 133765434
Change-Id: I8b81cc9be004482beb6cdcdd05406e2d9b4c7629
2019-06-06 11:10:56 -07:00
vadimt
3ca5280186 Fixing All Apps's getting stuck in a non-updating state
Normally, if all apps is open, and an app installs/uninstalls/updates,
All Apps will immediately reflect this.

However, depending on something subtle in the intensity of the swipe
gesture that brought All Apps, all apps will freeze, and won't update.

This frozen state will go away after scrolling in all apps, iteration
with an icon and, generally, any tap interaction with All Apps.
Otherwise, it will stay until it's closed and opened again via a gesture
with a different pattern.

The reason is in the code that freezes All Apps updates during user
interactions with all apps.

For example, during scrolls. Or while the user holds an icon, expecting
to see a context menu; in this case an update would cause the menu to
not appear, which is somewhat annoying.

The motivation to add this code was to solve a category of lab-only
flakes when a context menu couldn't open because the lab device was busy
with post-flash activities.

The code incorrectly assumed that after ACTION_DOWN, we are guaranteed
to get either UP or CANCEL, which is wrong.

It's after *consumed* ACTION_DOWN that we'll get these events.

The fix still solves the user's and tests' problems that the code was
supposed to solve.

Bug: 134442147
Change-Id: I9db74a33ecf93b1dc6bc69df301f7f542dea2a40
2019-06-03 18:35:52 -07:00
TreeHugger Robot
f54839bf35 Merge "Remove unnecessary dispatchInsets routing" into ub-launcher3-qt-dev 2019-05-24 00:31:18 +00:00
Sunny Goyal
ab3963ddcf Moving TestInformationProvider to Launcher3 so that it can be used for
testing Launcher3 without quickstep

Also keeping the provider as disabled until needed

Change-Id: Ib5f459e02ae551724b390f3b74f43d601568d749
2019-05-23 14:02:33 -07:00
Adam Cohen
a09cfe2340 Fix issue where AllAppsContainerView was blocking touches to part of the home screen
=> After the scrubber was engaged, it would continue to intercept touches forever
   (seems like a long standing issue)
=> Also fixed issue where the All Apps scrubber could be engaged from the Home / Overview
   states

b/133265591
b/132716177

Change-Id: I8c7b9d45be65216f2f1a69f69ab1636accd812c0
2019-05-22 14:21:12 -07:00
Sunny Goyal
2524b82369 Remove unnecessary dispatchInsets routing
Insets are dispatched to all views. We never consume the insets and
let each view decide what to do with it.
Also fixing scrim in all-apps when in full-gesture navigation

Change-Id: Ib1c6bef5b32aac0c6ea03078b5138d2d0408c6d8
2019-05-21 15:58:44 -07:00
vadimt
24d31d4b6e Disabling updating All Apps during a long-press recognition
This is supposed to eliminate test flakes in the lab.

When an app gets updated while all apps is opened, all-apps will be
re-laid-out.

If the layout happens while we are recognizing a long-press on an app
icon in all Apps, the long-press won't be recognized.

In the lab, this happened so frequently that it caused considerable
flakiness. Even after we started running tests in airplane mode, this
still keeps happening. The bug refers an example with airplane mode on.

The fix will be also mildly beneficial for users.

Bug: 132177321
Change-Id: Ie7c7473fe94b8af83f04cd719286bae69e2d9de0
2019-05-09 15:48:32 -07:00
Govinda Wasserman
c06e151e0f Makes Launcher hide the all apps content and scrim on assistant visible.
This hides the quick search bar and the suggested apps. Visibility is
unchanged when the all apps view is fully expanded.

Test: Tested locally
Change-Id: I6bc453b5ad89ca3d1280957e595bf2a3f074a72d
BUG:129755311
FIX:129755311
(cherry picked from commit 917af755e4)
2019-04-23 17:20:37 +00:00
Sunny Goyal
33611be973 Removing Launcher dependency in search box layout
Bug: 118758696
Change-Id: Id918c44b8bd2a97ab577481b7584afbe56e8a591
2018-11-20 13:53:33 -08:00
arangelov
ad78305862 Highlight work tab when user already in All Apps after creating WP.
When a user created a work profile and was already in the All Apps
view, the work tab was not highlighted, because the logic for that
was only in AllAppsContainerView#onScrollUpEnd(). This CL
highlights the tab when the user has resumed and the All Apps view
is expanded.

Bug: 79242814
Test: Manual
Change-Id: I40af0d513c95f8084e21f4e276e9f56bcb06555e
2018-08-17 20:28:52 +01:00
Vadim Tryshev
b6398a1eb8 Sharing protocol constants between Launcher and TAPL
Bug: 110103162
Test: TaplTests
Change-Id: I5b2a2b8576a7a6ea4a156f00858711496d6b5bba
2018-08-14 19:53:43 -07:00
Sunny Goyal
d230307a95 Migrating to android-x
Change-Id: I9a774152d13a541e8496dd84f2469bfed407f86d
2018-08-14 15:22:12 -07:00
Vadim Tryshev
dc755e718d Started converting Launcher to be gesture-stable
All tests keep passing.

WorkTabTest.workTabExists was made gesture-stable. There is no need to
use TAPL, as the point is not to check answering to gestures, but to
check presence of tabs, which is better to do using launcher internal
state. (It still fails if run as a part of all tests, presumably,
because after Launcher's start, changes in user configuration are not
recognized, so I've commented the failing part)

Bug: 110103162
Test: Run all tests
Change-Id: Ic30b8e8475d16cee3880332f12311a44ddfa26cb
2018-08-14 10:29:57 -07:00
Vadim Tryshev
ff3fa34a7a Fixing scrolling up in App Apps.
Done by scrolling only when scroll position is not zero. This way, the
scroll gesture can't close All Apps.

Bug: 110103162
Test: TaplTests suite
Change-Id: Icfe47d2bcc0210ae221df169d6c35cd1be10ff86
2018-08-02 14:15:05 -07:00
Jon Miranda
3c71c6a564 Fix bug where QSB gets clipped when flinging All Apps open.
Bug: 77538324
Change-Id: I3e40346559fd3b7010d92d28e12efcf2d8581640
2018-06-15 11:19:32 -07:00