Commit Graph

5490 Commits

Author SHA1 Message Date
Vinit Nayak
b85e0afe70 Merge "Keep live tile running when TaskMenuView is showing" into tm-dev 2022-03-22 04:48:43 +00:00
Vinit Nayak
a5addf0e89 Keep live tile running when TaskMenuView is showing
* Doesn't fix the bug, but a nicer UX to have

Bug: 223317893
Test: Live tile was running after tapping app icon.
Was able to enter split just fine

Change-Id: I50c5d5623546d19d216beae09b76c310e8b3c815
2022-03-21 18:15:28 -07:00
Jeremy Sim
c789ade45e Merge "Fix crash condition by adding a null check in DigitalWellBeingToast" into tm-dev 2022-03-22 00:39:47 +00:00
Jeremy Sim
7a84442436 Merge "Fix UI overlap when rotating in split select mode" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim
8746367f40 Merge "Fix paired icon placement in landscape/seascape" into tm-dev 2022-03-22 00:17:43 +00:00
Vinit Nayak
68d5dd82db Merge "Use ComponentCallbacks to recreate on fold/unfold" into tm-dev 2022-03-21 19:05:52 +00:00
Vinit Nayak
c55c94880e Merge "Limit the number of commands in OverviewCommandHelper" into tm-dev 2022-03-21 18:49:42 +00:00
Alex Chau
c9f3cc36bb Merge "Update overview grid icon sizes and paddings" into tm-dev 2022-03-21 17:08:31 +00:00
Jon Miranda
d17cb2722c Merge "Allow depth animation when user swipes back to home." into tm-dev 2022-03-21 15:33:08 +00:00
Kholoud Mohamed
ac0574781c Merge "RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3" into tm-dev 2022-03-19 06:30:09 +00:00
Jeremy Sim
b4b79142d8 Fix UI overlap when rotating in split select mode
Fixes an issue where you could trigger a UI overlap by rotating the phone during split select. The issue occurred because devices with insets were calling TaskView#resetViewTransforms during rotation, and not accounting for the fact that an extra transform was applied for split staging.

Fixes: 220998096
Test: Manual test on inset and non-inset devices
Change-Id: I2d6c969231127aa16c9eae39cf69e08ceb96c44b
(cherry picked from commit 51bfabf8b7)
2022-03-19 00:10:44 +00:00
Jeremy Sim
b42345273c Fix paired icon placement in landscape/seascape
In grouped task view, paired icons will now align better with task thumbnails.

Fixes: 218783211

Test: Extensive manual testing on local device(s).
Change-Id: I372d2ee90302a8d96ace048ff4f82126d9b2b363
(cherry picked from commit d6826c74a4)
2022-03-19 00:10:16 +00:00
Jeremy Sim
64212c5439 Fix crash condition by adding a null check in DigitalWellBeingToast
Fixes a crash condition where TaskView#getRecentsView() could return null when being called from DigitalWellBeingToast#setBanner(), resulting in a crash.

Fixes: 217671133

Test: Manual
Change-Id: I964384d97d26336e9a5e8e4c025f66ab78c63e0a
2022-03-18 16:55:17 -07:00
TreeHugger Robot
f1543cb520 Merge "Small improvement for ag/17016891 (unstash taskbar input area size)" into tm-dev 2022-03-18 18:38:42 +00:00
Jon Miranda
f6780f66c3 Allow depth animation when user swipes back to home.
Bug: 221196062
Test: open app, swipe back to home, ensure blurs
Change-Id: I9faff4e41c2e8d22df72e41c7753e2090fa0973d
2022-03-18 09:58:55 -07:00
Vinit Nayak
38397e46cf Limit the number of commands in OverviewCommandHelper
* Rapidly tapping recents button in 3 button nav
puts launcher in a strange state.
Reproing and understanding that state is complex
since so many state transitions are rapidly happening.
* Easier to limit the number of commands a user
will perform for valid use-cases.

Fixes: 207680265
Test: Rapidly pressing recents when unfolded
doesn't show live tile task on workspace.

Change-Id: I7db849e83c2cafc37a419e189479283f2057bde6
2022-03-17 16:26:56 -07:00
Vinit Nayak
bacd5e1d21 Use ComponentCallbacks to recreate on fold/unfold
* DisplayController callbacks were sometimes being
called too soon and providing stale window bounds,
which led to the incorrect DeviceProfile being used.
Switched to ComponentCallbacks on the window to get
the most up-to-date callbacks.
* Sadly, for navigation mode changes, ComponentCallbacks
get fired too soon and have a stale navigation mode
so we continue to rely on DisplayController for that
change for now.

Fixes: 219958843
Test: Tested folding/unfolding, no taskbar appears when
it shouldn't.
Tested with changing display/font size as well as
nav mode changes

Change-Id: I1b398934c0ea49f69bad19b13977b7b0906f3190
2022-03-17 12:03:14 -07:00
Alex Chau
8cee1ebed0 Fix splitPrimaryScrollOffset in RTL
Fix: 225165124
Test: split select in RTL and non-RTL, check min/max scroll
Change-Id: I5fb13e39560d9dceb4a53c9c79a355f72faf3dba
2022-03-17 14:55:14 +00:00
Alex Chau
2e48760e97 Update overview grid icon sizes and paddings
- Introduced additional page spacign for clear all button to match mocks

Fix: 222664142
Test: Quick switch to last task and immediately enter overview
Test: Dismiss last task in overview grid
Change-Id: I4d2f93d843c50b10051f3fb17027cd06e86707e1
2022-03-17 13:44:21 +00:00
Wei Sheng Shih
5d9a319c76 Merge "[Shell Transition]Release floating task view after second task select." into tm-dev 2022-03-17 00:25:34 +00:00
wilsonshih
7315e33630 [Shell Transition]Release floating task view after second task select.
Register animation start callback to RemoteSplitLaunchTransitionRunner,
so there can clear up the floating task view when entering recents.

Bug: 223397364
Test: verify no floating task view remaining on RecentsActivity.
Change-Id: Idedc7950b8954d1376960d5e74aa4c60fefa9c86
2022-03-16 11:30:46 +08:00
TreeHugger Robot
a66bbdab86 Merge "Fix failing test TaplTaskbarTest#testHideShowTaskbar" into tm-dev 2022-03-15 23:20:08 +00:00
kholoud mohamed
e210b47c20 RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3
Bug: 217388602
Bug: 218875965
Test: atest EnterpriseResourcesTests
Test: manual
Change-Id: I095a1da30766e4b4eab33f42b034601b3322eb3d
2022-03-15 17:24:04 +00:00
Schneider Victor-tulias
0cde81a5d2 Fix failing test TaplTaskbarTest#testHideShowTaskbar
Closing the Taskbar all apps page doesn't automatically close any open popup menus. This lead to the popup menu opened in TaplTaskbarTests#testOpenMenu_FromTaskbarAllApps remaining open after going home in setUp (before running TaplTaskbarTest#testHideShowTaskbar). The the workspace is not visible to the tests while the popup menu is open, so this test would consistenly fail.

Bug: 215218813
Fixes: 224597087
Test: Ran tests locally and remotely
Change-Id: I81d8eb1e99a264611749eb3c508f707988c0fcb1
2022-03-14 22:19:12 +00:00
Schneider Victor-tulias
b82d945953 Add event tracking to the gesture navigation tutorial.
- Added logs for tutorial step shown/completed and for tutorial skip.
- Added shared preference tracking for tutorial steps completed and for tutorial skip.

Bug:
Test: manual
Change-Id: I47dbdb394db80c5687e98fb034a3883b33f6fd3c
2022-03-14 13:14:05 -07:00
Shan Huang
b6ff87bb99 Merge "Clear back callback in SystemUiProxy." into tm-dev 2022-03-14 16:29:25 +00:00
Alex Chau
85978e7dc8 Merge "Use overview_actions_height from Resources to calculate OverviewActionsView alignment" into tm-dev 2022-03-14 11:21:32 +00:00
Shan Huang
b960ea2be1 Clear back callback in SystemUiProxy.
Bug: 223955009
Test: atest com.android.launcher3.jank.BinderTests#testPressHome

Change-Id: I00197732a6e50c0907afecff497702fc4b799925
2022-03-11 18:03:52 +00:00
TreeHugger Robot
19570f9b05 Merge "Close taskbar all apps when task stack changes." into tm-dev 2022-03-11 02:18:34 +00:00
TreeHugger Robot
1b4d9b3b23 Merge "Launcher side implementation of gesture seekable back to home animation." into tm-dev 2022-03-11 02:11:03 +00:00
Shan Huang
581429b3dc Launcher side implementation of gesture seekable back to home animation.
This is a two part animation. The first part is an animation that tracks gesture location to scale and move the leaving app window. Once the gesture is committed, the second part takes over the app window and plays the rest of app close transitions in one go.

This animation is used only for apps that enable back dispatching via {@link android.view.OnBackInvokedDispatcher}. The controller registers an {@link IOnBackInvokedCallback} with WM Shell and receives back dispatches when a back navigation to launcher starts.

Apps using the legacy back dispatching will keep triggering the WALLPAPER_OPEN remote transition registered in {@link QuickstepTransitionManager}.

Bug: b/195946584
Test: m -j
Test: Swipe back to home on pre-T and T apps, at different life cycle
stages.

Change-Id: I615c5171cd875130f10346fa3ca2a8e9670176cf
2022-03-11 00:11:21 +00:00
Brian Isganitis
7910a3ca0a Close taskbar all apps when task stack changes.
Test: Manual
Fix: 223898952
Change-Id: I4c5e41227f0ee199cc08931f4532d769f376a617
2022-03-10 16:03:30 -08:00
TreeHugger Robot
6b7e469088 Merge "Add taskbar TAPL tests" into tm-dev 2022-03-11 00:00:36 +00:00
TreeHugger Robot
ec8ba135be Merge "Revert "Sync hotseat/taskbar handoff"" into tm-dev 2022-03-10 22:19:16 +00:00
Jon Miranda
e8b174482d Merge "Add debug logs for bad launcher state." into tm-dev 2022-03-10 22:03:37 +00:00
TreeHugger Robot
5ad574ae60 Merge "Set taskbar touchable region to empty when all apps is open." into tm-dev 2022-03-10 22:01:40 +00:00
TreeHugger Robot
72ef2ed094 Merge "Fix gesture navigation tutorial colors to match SUW colors." into tm-dev 2022-03-10 21:08:45 +00:00
Schneider Victor-tulias
fb252e7ce1 Add taskbar TAPL tests
- Added TAPL objects to support TAPL tests for taskbar features
- Added tests for major taskbar features: hiding/showing the taskbar, opening all apps, lauching apps and app deep shortcuts from the taskbar/all apps page, launching apps and app deep shortcuts in splitscreen
- These tests should only run for large devices

Design: go/taskbar-tapl-tests
Test: ran tests locally with invalid configurations and remotely
Bug: 215218813
Change-Id: I3c28c339707467414aa47fa633f87fa0c1fdee57
2022-03-10 13:02:35 -08:00
Jon Miranda
7ebe209c21 Add debug logs for bad launcher state.
Bug:223498680
Bug:221658803

Test: manual
Change-Id: I138a7ab031269009fa8ca492cd0bd48085aa4e68
2022-03-10 20:25:38 +00:00
TreeHugger Robot
7a8b8fb2c1 Merge "Properly center all apps divider." into tm-dev 2022-03-10 20:23:52 +00:00
TreeHugger Robot
1f3cc12a76 Merge "Recreate All Apps when Taskbar is recreated." into tm-dev 2022-03-10 20:22:29 +00:00
Alex Chau
19c6eca5c5 Use overview_actions_height from Resources to calculate OverviewActionsView alignment
- startActionView.getHeight() isn't ready when updatePaddingAndTranslations is called, so use overview_actions_height from Resources through DeviceProfile instead.

Fix: 218442870
Test: Restart launcher, go to overveiw from app, rotate and rotate back, overview actions stays in same position
Change-Id: Ia5e234f73100a2f418c17222145a8f993cbfab8a
2022-03-10 20:16:59 +00:00
Brian Isganitis
a2f26954a0 Set taskbar touchable region to empty when all apps is open.
Fix: 223653710
Test: Manual
Change-Id: Ia78831028b67aa425d5bd5ae61ae460d3caabbb7
2022-03-10 11:21:27 -08:00
Jon Miranda
7db484396a Merge "Never look for matching view in All Apps when swiping up to go home." into tm-dev 2022-03-10 18:46:51 +00:00
Schneider Victor-tulias
b282446dac Fix gesture navigation tutorial colors to match SUW colors.
- Updated the gesture nav tutorial to use the system accent color for buttons and the feedback animations

Fixes: 222269039
Test: built change, flashed and factory reset device
Change-Id: I4e515aef0ccdab98f1d3900007f6006b1975b41b
2022-03-10 10:33:06 -08:00
Brian Isganitis
cea2480cac Properly center all apps divider.
Fix: 223837782
Test: Manual on large and small screens in portrait and landscape.
Change-Id: Ie4d609ce6524cc739d00bec5a8d26ec4c4152633
2022-03-10 18:29:34 +00:00
Jon Miranda
efca5c8655 Revert "Sync hotseat/taskbar handoff"
This reverts commit ede8718e63.

Reason for revert: causing ANR b/223789074

Bug: 223789074
Bug: 223443781
Bug: 202507555

Change-Id: Ibd76939a345f54e8945cdd97e652f5e06e40edcb
2022-03-10 18:27:36 +00:00
TreeHugger Robot
b873662734 Merge "Sync hotseat/taskbar handoff" into tm-dev 2022-03-10 09:22:21 +00:00
Tracy Zhou
6416cea0e5 Merge "Support launching an intent and a task from the same app as multi-instance" into tm-dev 2022-03-10 02:09:53 +00:00
Tracy Zhou
fec75c5a0e Merge "Fix wrong initial staged split position" into tm-dev 2022-03-10 01:47:53 +00:00