Commit Graph

5296 Commits

Author SHA1 Message Date
TreeHugger Robot
b70131e1dd Merge "Use config_imeDrawsImeNavBar in Launcher" 2022-02-15 02:50:21 +00:00
Benno Lin
978d646864 Merge "Implemnet methods to drag a icon to given Workspace cell" 2022-02-15 01:49:21 +00:00
Benno Lin
7738cac424 Implemnet methods to drag a icon to given Workspace cell
The CL implements public methods to drag an Icon from AllApps to a
given cell in the workspace.

Bug: 199120092
Test: Launcher3Tests:com.android.launcher3.ui.TaplTestsLauncher3#testDragAppIconToWorkspaceCell
Test: https://android-build.googleplex.com/builds/abtd/run/L89300000953052361
Test: https://android-build.googleplex.com/builds/abtd/run/L44500000953013792
Change-Id: Ife16d1f1b55b809763dd40f5afee6711049a4729
2022-02-15 01:48:45 +00:00
TreeHugger Robot
bf96683e46 Merge "Fix taskbar hotseat alignment" 2022-02-14 13:03:46 +00:00
Tom Natan
7823e8b5b6 Merge "[11/n] Letterbox Education: set LAUNCHER_TASKBAR_EDUCATION_SHOWING." 2022-02-13 12:20:57 +00:00
Tony Wickham
1c51edcef3 Merge "Only show unstash feedforward hint when long press will unstash" 2022-02-12 20:22:38 +00:00
Tony Wickham
9b2b607a09 Fix taskbar hotseat alignment
- Use hotseatBorderSpace instead of cellLayoutBorderSpace
- Also divide by 2f instead of 2 because AS was complaining. May or may not potentially address off by 1 pixel issues.

Test: locally set alignment = 1, ensure perfectly aligned
Fixes: 218880076
Change-Id: Ifec30e6727f62985427b65b6c0b0810e7f7cd695
2022-02-12 19:23:23 +00:00
Thiru Ramasamy
5ed87e4c96 Populate search attributes only if the atom's has DeviceSearchResultContainer.
Bug: 199495917, 218973952
Test: https://android-build.googleplex.com/builds/abtd/run/L37100000953023420
Change-Id: I355b4ec0806755f6c72d59b04555b970ca1578f5
2022-02-12 00:57:33 +00:00
Thiru Ramasamy
84a7fee8af Reverting the change that causes test breakage
Bug: 218973952
Test: wwdebug && wwlogcat
Change-Id: I494608ba3df31e9129dc47fc016a7e077e506165
2022-02-11 11:03:09 -08:00
tomnatan
9f12373bdd [11/n] Letterbox Education: set LAUNCHER_TASKBAR_EDUCATION_SHOWING.
The setting is set to 1 if the taskbar education should be shown as soon as the animation for opening an app starts and is set back to 0 when the taskbar education window is detached from the window.

Bug: 214590804
Test: N/A
Change-Id: Id26e3051a6e0ef1f9c2dcbeef98710efbb4df54f
2022-02-11 10:28:51 +00:00
Riddle Hsu
adfdfd8868 Merge "Set launch source info for shell recents animation" 2022-02-11 06:33:18 +00:00
Jeremy Sim
b84462a6b4 Merge "Fix DWB placement in grouped task view" 2022-02-11 06:22:40 +00:00
Tony Wickham
31a4c539d0 Only show unstash feedforward hint when long press will unstash
Test: Long press to unstash while in an app still works and shows feedforward; long pressing handle while in overview, all apps, or when IME is showing doesn't show anything.
Fixes: 218902248
Change-Id: I2c96570cab018c0e63c446793b84b210964bdb94
2022-02-11 00:29:56 +00:00
Jeremy Sim
c78ac6277c Fix DWB placement in grouped task view
In grouped task view, DWB banners will now rotate properly when phone is
in landscape or seascape orientation. Also fixes a couple of minor
existing issues with the bottom task not displaying correctly in the
first place.

Fixes: 208357326
Fixes: 216218406

Test: Tested locally on Pixel 6, using landscape, seascape, and
portrait. Double-checked with task proportions changed, RtL/LtR, and
split top/split left/split right initialization.

Change-Id: I945f9937d2d4d784c0c74a006c7d0680daf628c2
2022-02-11 00:13:13 +00:00
Thiru Ramasamy
70f3f86702 Merge "Populate LauncherUiChanged.search_attributes field." 2022-02-10 23:35:49 +00:00
Evan Rosky
19f7d988d1 Merge "Use fixed-rotation by default for shell transitions" 2022-02-10 19:51:45 +00:00
thiruram
103ccf1d87 Populate LauncherUiChanged.search_attributes field.
Test: Manual
Bug: 199495917
Change-Id: I9a7f9696d44b5b2af8d11e7f537b5c4ed78db060
2022-02-10 08:29:39 -08:00
Riddle Hsu
53e864d118 Set launch source info for shell recents animation
In legacy animation, it was set in RecentsAnimation
#startRecentsActivity. Now because shell transition use
startActivity, it can be set directly to the options.

Bug: 218847872
Test: adb shell setprop persist.debug.shell_transit 1; reboot
      Enable statsd log: "adb shell cmd stats print-logs"
      Swipe up gesture navigation bar from an app.
      adb logcat | grep statsd | grep "(48)"
      The line may contain 0x100000->4[I] 0x110000->20[I]
      that means 4=by recents and 20=latency 20ms.
Change-Id: Ia7bef23f8dc6cbf371cd1cdfb42f1f68d88d0787
2022-02-11 00:08:27 +08:00
Winson Chung
6992855742 Merge "Add basic return animation when drag is canceled" 2022-02-09 19:32:22 +00:00
Winson Chung
d937831791 Add basic return animation when drag is canceled
Bug: 179390870
Test: Drag, but don't drop to split an app from the taskbar and
      check that Launcher animates the surface back into place
Change-Id: I726855ff5bdffd1fc58d2839b3cc44b3fdb131e9
2022-02-09 06:44:21 +00:00
TreeHugger Robot
e8b200eb6b Merge "Fix NPE when mRecentsView is null" 2022-02-09 05:04:57 +00:00
Jon Miranda
32319bf166 Merge "Move All Apps button to the left in RTL." 2022-02-09 01:55:36 +00:00
TreeHugger Robot
fb1e592020 Merge "Prediction icons in Taskbar were updating when dragging icon in the same place" 2022-02-08 19:54:08 +00:00
Yohei Yukawa
697ae451d4 Use config_imeDrawsImeNavBar in Launcher
With this CL, the Launcher starts checking

  config_imeDrawsImeNavBar [1]

instead of

  config_navBarInteractionMode

when determining whether the IME should render the back and IME
switcher buttons or not.

There should be no observable behavior change as long as

  config_navBarInteractionMode

is set to true when the gestural navigation is enabled.

Bug: 216118048
Test: presubmit
Change-Id: Ia8269e240e0b18e1c7b8bd550dbb197ad58a6dbc
2022-02-08 07:47:29 -08:00
Tony Wickham
b1c3f88185 Fix NPE when mRecentsView is null
The NPE was in an unused variable, so also address the TODO to use it as log rank.

Test: wwdebug, wwlogcat, quickswitch and check rank field
Fixes: 218216440
Change-Id: I173ae607e9f73e58880c0fb1b6e8f2352469816f
2022-02-08 00:35:43 +00:00
Jon Miranda
daa3150b9c Move All Apps button to the left in RTL.
Bug: 205803230
Test: verify LTR
      force RTL using developer option
      verify All Apps button is in the left
      verify All Apps button moves left before fading out

Change-Id: I2a5be9b37f471bfaa1a92f6819e04274e4dfb7a1
2022-02-07 14:08:47 -08:00
Thiru Ramasamy
40570799b3 Merge changes from topic "SuggestedResultAttribute"
* changes:
  [OneSearch] Add direct_match to SearchAttributes.
  [OneSearch] Deprecate CorrectedDeviceSearchResultContainer with SearchAttributes.
2022-02-07 20:36:38 +00:00
Sebastian Franco
5a6e08c3cd Prediction icons in Taskbar were updating when dragging icon in the same place
When dragging an icon in the Taskbar and dropping
it in the same spot it triggers new predictions when
it shouldn't. Basically, it was thinking that the icon
was moved outside of the taskbar which should trigger
new predictions. To fix it, it simply required to change
the order of the events, sending the UNPIN event before
the PIN event.

Bug: 202922907
Test: Have at least two prediction icons in the Taskbar, drag an app icon in the Taskbar, and drop it in the same place the prediction icon shouldn't change
Change-Id: I6079ff6eb69d7b1cb3c22bebc84511c0abd61cec
2022-02-07 19:10:55 +00:00
Thiru Ramasamy
c33c574698 [OneSearch] Add direct_match to SearchAttributes.
Captures if user acted on a search result that is not directly matched with search query, but instead related/suggested result.

Bug: 199495917
Test: Manual - http://gpaste/5167163338915840
Change-Id: Ib38244b1a82c502f551e8eb24dd14c14d8b375f2
2022-02-07 09:35:42 -08:00
Winson Chung
b4bbec80b8 Merge "Prevent lingering divider animators in AbsSwipeUpHandler" 2022-02-07 17:09:49 +00:00
Winson Chung
26031b0dd2 Prevent lingering divider animators in AbsSwipeUpHandler
- Refactor the util method to create the animator and track the existing
  animation in AbsSwipeUpHandler to be able to cancel it if another call
  to change the visbility comes in.  Note that this doesn't address
  the case where the launch animation overlaps with swipe up (though that
  hopefully shouldn't happen in normal usage)

Bug: 213403679
Test: Tap in the gesture space while split
Change-Id: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
2022-02-05 04:55:52 +00:00
Thiru Ramasamy
441461c95c [OneSearch] Deprecate CorrectedDeviceSearchResultContainer with SearchAttributes.
Loggin query_corrected signal as field is more scalable than separate CorrectedDeviceSearchResultContainer for future usecases.

Test: Manual - http://gpaste/6343087535161344
Bug: 199495917
Change-Id: I6b3a410f4d977db2a058f337d1684f78763acbd2
2022-02-04 11:51:59 -08:00
Tracy Zhou
4acb718a5c Merge "Initial implementation of split from workspace and all apps" 2022-02-03 04:30:35 +00:00
TreeHugger Robot
47a39329ae Merge "Be forgiving with accidental horizontal scroll" 2022-02-03 00:41:54 +00:00
Tracy Zhou
a0d4720815 Initial implementation of split from workspace and all apps
Bug: 216829535
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/feb5db9c-9429-42c2-a124-777e66fd5f0b
Change-Id: I34118975d0d7e15eb46b483f5a05447f5391e6fd
2022-02-02 13:37:47 -08:00
TreeHugger Robot
a19af85605 Merge "Add split action buttons to workspace icon menu" 2022-02-02 20:52:33 +00:00
Evan Rosky
dce4693bff Use fixed-rotation by default for shell transitions
As explained in title. Temporarily use fixed-rotation
by default for shell transitions

Bug: 217560545
Test: manual + existing flicker
Change-Id: Ic7c70d9305fe62dc7b6da0a02c0e1ccad412a1e2
2022-02-02 11:28:19 -08:00
TreeHugger Robot
13ea683810 Merge "Don't apply nav bar insets in tablets" 2022-02-02 16:58:06 +00:00
Tracy Zhou
c70fa777de Add split action buttons to workspace icon menu
Bug: 216829535
Test: https://screenshot.googleplex.com/BNu6iWHGKV9sX7u
Change-Id: Id7ef9093e24c0211cf9590b35399e1f4d5b55ecf
2022-02-01 21:37:24 -08:00
Alex Chau
6a7d1e2ad1 Don't apply nav bar insets in tablets
- With flexible inset changes in T, taskbar is no longer inseted in getCurrentSizeRange, i.e. DeviceProfile.availableHeight no longer inset nav bar size
- In order for home screen sizes to be calcualted correctly, avoid inseting nav bar in LauncherRootView
- Only apply a bottom padding with stashed taskbar size to necessarily surfaces (Overview)
- Home screen icon overlap will be fixed in separate CL

Bug: 215528237
Test: maual in tablet gesture nav and 3 buttons
Change-Id: I9bc796ba059159e819f8cd121ddabab96c8113d2
2022-02-01 13:08:49 +00:00
Jon Miranda
fd48b0c988 Add All Apps entry button to Taskbar.
- Opens All Apps when clicked
- Fades button in/out when transitioning b/w Hotseat & Taskbar

Bug: 205803230
Test: manual
      ensures alpha gets reset properly
      clicking button opens all apps
Change-Id: I1b96bae734aa9fd9308931d6312e3d65559d4284
2022-01-31 17:22:58 -08:00
Winson Chung
458e842bca Merge "Revert "Temporarily disable SUW specific insets logic"" 2022-01-29 22:05:14 +00:00
Brian Isganitis
c13700b61e Merge changes I2ede15d8,I86a0ffc0,I7c5fdbc7
* changes:
  Do not scale down taskbar all apps icons.
  Inflate taskbar all apps in abstract slide-in view.
  Introduce initial A-Z app drawer to taskbar.
2022-01-29 03:00:45 +00:00
TreeHugger Robot
5f0dbb6828 Merge "Include A11y timeout for taskbar icon dimming in kids mode." 2022-01-29 02:42:55 +00:00
Alex Chau
65dd83817c Merge "Remove ENABLE_OVERVIEW_GRID feature flag" 2022-01-28 23:14:23 +00:00
Lucas Dupin
b9f7e269a9 Be forgiving with accidental horizontal scroll
An accidental horizontal touch, due to vertical fling on the -1 screen
could lead to imperceptible change in zoom, and send a frame to client
composition. This CL adds extra padding to overlay scroll amount, to
avoid these accidental gestures.

Bug: 211245940
Test: https://ui.perfetto.dev/#!/viewer?trace_id=3260c116-c578-6dad-e047-0a327b7d346c
Change-Id: Id05e482c79c1dcc2e1ba73baf8a4a4101797bbd2
2022-01-28 14:58:02 -08:00
Brian Isganitis
25b2ac8527 Do not scale down taskbar all apps icons.
Test: Manual
Bug: 204696617
Change-Id: I2ede15d8beaef65661984fe63bd99d0e7e726774
2022-01-28 16:43:24 -05:00
Brian Isganitis
9e80fb355c Inflate taskbar all apps in abstract slide-in view.
All apps can now be dismissed via the scrim or swiping down. To properly
behave as an AFW, the apps view can no longer be within the taskbar's
layout, and will instead add and remove itself from the drag layer.

Test: Manual
Bug: 204696617
Change-Id: I86a0ffc06faa653c65b3797a57ba6512c6874221
2022-01-28 15:21:11 -05:00
Brian Isganitis
4edf1da6e2 Introduce initial A-Z app drawer to taskbar.
Invoking the drawer is currently hooked up to tapping empty space on the
taskbar. Apps can be launched, and drag-n-drop split screen works. The
drawer can only be dismissed by acting on an app icon or tapping the
taskbar again.

Test: Manual
Bug: 204696617
Change-Id: I7c5fdbc7d54d8209f6f15ef80bfeb5e9b80cf647
2022-01-28 15:20:00 -05:00
TreeHugger Robot
65ffe19260 Merge "Allow overriding enterprise related strings in Launcher" 2022-01-28 18:52:43 +00:00