Commit Graph

12675 Commits

Author SHA1 Message Date
Jagrut Desai
b572cfee26 Merge "Make TaskbarStashController aware of accesseibilty time to action settings." into tm-qpr-dev am: 5cef4b83d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778874

Change-Id: Iaf4c7b086975d54896cb9806fb824cfbc7575789
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 20:14:12 +00:00
Jagrut Desai
5cef4b83d5 Merge "Make TaskbarStashController aware of accesseibilty time to action settings." into tm-qpr-dev 2023-03-09 19:49:18 +00:00
Fengjiang Li
b595d347a9 Merge "Fix NPE of TopTaskTracker" into tm-qpr-dev am: c523de6dc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21894262

Change-Id: I7b256fd8620c02797c7dc25f0943badc7b5ad437
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 18:53:52 +00:00
Fengjiang Li
c523de6dc2 Merge "Fix NPE of TopTaskTracker" into tm-qpr-dev 2023-03-09 18:25:07 +00:00
Brandon Dayauon
3f5e40eaae Merge "Play original haptic when feature flag is off. Rename feature flag" into tm-qpr-dev am: c1e12fc150
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21896830

Change-Id: I7104e588e71400dff21e330b7420d72da6e866fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 17:11:57 +00:00
Brandon Dayauon
c1e12fc150 Merge "Play original haptic when feature flag is off. Rename feature flag" into tm-qpr-dev 2023-03-09 16:44:07 +00:00
Eddie Lan
cdf797c22e Merge "Revert "Hide the splash icon when launching with no view and no ..."" into tm-qpr-dev am: cbdd6493f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21916962

Change-Id: Ie16046b1814bcf6efe92bdd86afb140f6c1e2053
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 09:30:37 +00:00
Eddie Lan
cbdd6493f1 Merge "Revert "Hide the splash icon when launching with no view and no ..."" into tm-qpr-dev 2023-03-09 09:06:11 +00:00
Eddie Lan
293688a9a0 Revert "Hide the splash icon when launching with no view and no ..."
Revert submission 21447384-no-splash

Reason for revert: build break
Bug: 272383391

Reverted changes: /q/submissionid:21447384-no-splash

Change-Id: I73565b1f4e5dd969237980b2b5dbeee7b563abcb
2023-03-09 09:00:29 +00:00
Jon Miranda
55b2ec2d70 Merge "Polish taskbar un/stash animation." into tm-qpr-dev am: 4c368373cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21751712

Change-Id: I1ce5871d5230e309acef219095c0525c247d983d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 03:45:34 +00:00
Jon Miranda
4c368373cb Merge "Polish taskbar un/stash animation." into tm-qpr-dev 2023-03-09 03:33:39 +00:00
Jon Miranda
1ffac1c8ac Merge "Hide taskbar view for app open/close animation." into tm-qpr-dev am: 1671b704b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21808184

Change-Id: I113319547da7b51366e4be2aeb94a51d976b7382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 01:04:21 +00:00
Ats Jenk
cff883d96f Merge "Remove empty desktop tile" into tm-qpr-dev am: bac6d4946a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21893975

Change-Id: Ie7d90dd608dda1288032b47375e3ca491676ecdf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 01:04:09 +00:00
Jon Miranda
1671b704b3 Merge "Hide taskbar view for app open/close animation." into tm-qpr-dev 2023-03-09 00:33:27 +00:00
Ats Jenk
bac6d4946a Merge "Remove empty desktop tile" into tm-qpr-dev 2023-03-09 00:31:50 +00:00
Brandon Dayauon
dee687c33a Play original haptic when feature flag is off. Rename feature flag
- Remove the Utilities.atLeast check since it's no longer relevant as there is no new haptics being played
in the original haptic..

When FeatureFlag is off, the haptic for all apps and qsb is played in one place. So when
FeatureFlag is on, we need to isolate where the haptic call gets played so we disable calling it from two places
and play the haptics at the respective areas.
flag: ENABLE_PREMIUM_HAPTICS_ALL_APPS=false


bug: 270634265
test: Manual
Change-Id: I7b92c427e880b196130270ed9709cf1ea0e19e0a
2023-03-09 00:14:14 +00:00
Mateusz Cicheński
efeae8e3aa Merge "Fix entry bounds for 3 button nav" into tm-qpr-dev am: 321127d14a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21847300

Change-Id: I2a4dafc799be1cc58b4cf54062571a7b39a5de6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 00:12:54 +00:00
Brian Isganitis
16fdd8b4f0 Ensure taskbar background always transparent in notification tray. am: 84261f9d9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21593273

Change-Id: I301369bdce2bf00ef00d95d75ae91365022e4d6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 00:12:04 +00:00
Jagrut Desai
545f6540c3 Merge "Announce for accessiblity when taskbar is invoked/closed" into tm-qpr-dev am: d301c9b628
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21735251

Change-Id: Ibdb3a308550727a8c03c83c99e1c8566b443e503
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 00:11:29 +00:00
Mateusz Cicheński
321127d14a Merge "Fix entry bounds for 3 button nav" into tm-qpr-dev 2023-03-08 23:52:41 +00:00
Brian Isganitis
84261f9d9b Ensure taskbar background always transparent in notification tray.
Persistent, taskbar can be in light or dark modes. Since notification
tray has its own background color, we should hide ours to avoid clashing
with it.

Test: Manual
Fix: 270758899
Change-Id: Iedc6aae42aac30987af3259ccee11c5998e10517
2023-03-08 23:51:34 +00:00
Jon Miranda
67d4b0ed6b Polish taskbar un/stash animation.
- When QSB is inline, we add it to the reveal animation
  so that it moves in coordination with the rest of the
  taskbar icons
- Hide All Apps button when transitioning from Home -> App
  to match spec
- Shorten duration icons move in x duration so that they
  stay within the taskbar background bounds.

Bug: 267806083
Bug: 246635237
Bug: 246660243
Test: transient taskbar
      with isQsbInline = true and false

Change-Id: Ie6b866311cc2ceba88cdf01652b30fee457d0359
Merged-In: Ie6b866311cc2ceba88cdf01652b30fee457d0359
2023-03-08 23:47:29 +00:00
Jagrut Desai
d301c9b628 Merge "Announce for accessiblity when taskbar is invoked/closed" into tm-qpr-dev 2023-03-08 23:34:01 +00:00
TreeHugger Robot
9fbd4b9c4e Merge "Revert "Create TAPL test suite for splitscreen"" into tm-qpr-dev am: 19c0877745
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21806280

Change-Id: I1c37aee0caa430161761f2bdddc89669be6f553c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 20:18:52 +00:00
Sunny Goyal
7975109d74 Merge "Removing flag management UI states from flag definition" into tm-qpr-dev am: 839fc20feb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21725630

Change-Id: I64613adac5217b6a2abd734e80af21f9ba2962d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 20:18:37 +00:00
TreeHugger Robot
19c0877745 Merge "Revert "Create TAPL test suite for splitscreen"" into tm-qpr-dev 2023-03-08 20:04:50 +00:00
Ats Jenk
4d01acf44e Remove empty desktop tile
Do not show the desktop tile in overview when there are no apps on the
desktop.

Bug: 270399069
Test: have desktop mode proto 2 enabled, launch an app in fullscreen,
  open overview, observe no desktop tile
Test: move an app to desktop, be on desktop, open overview, observe
  overview is opened with desktop tile focused
Test: have an app on desktop, go home and launch an app in fullscreen,
  open overview, observe fullscreen app is focused, desktop is peeking
  in from right
Test: have an app on desktop and a fullscreen app in overview, open
  desktop from overview, close the desktop app, open overview, observe
  desktop tile is not shown
Change-Id: Ia8657d5b260043a630f32b35f2560ea93273d421
2023-03-08 11:49:48 -08:00
Sunny Goyal
839fc20feb Merge "Removing flag management UI states from flag definition" into tm-qpr-dev 2023-03-08 19:45:21 +00:00
Ats Jenk
4261ab7e99 Merge "Set desktop icon to always use black for the icon" into tm-qpr-dev am: 8efad6b111
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21892092

Change-Id: I5147a219b6f05e70d1a02530258d3c7a913591be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 19:26:14 +00:00
Ats Jenk
8efad6b111 Merge "Set desktop icon to always use black for the icon" into tm-qpr-dev 2023-03-08 19:10:09 +00:00
Brian Isganitis
cba28f0b3f Merge "Log when taskbar is in task switcher container." into tm-qpr-dev am: ba5b25c198
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21780681

Change-Id: Id8de9691667824ccc6bf78c4d4c804f99882f8be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 19:09:30 +00:00
Sihua Ma
fc9d3a50ad Merge "Set the original drawable for floating widget view" into tm-qpr-dev am: 792dda2344
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20899726

Change-Id: I345f74a393fb994b7b83ccde884263c8a43b4678
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 19:09:19 +00:00
Brian Isganitis
ba5b25c198 Merge "Log when taskbar is in task switcher container." into tm-qpr-dev 2023-03-08 18:56:02 +00:00
Jon Miranda
acdf07e0b7 Hide taskbar view for app open/close animation.
Bug: 246635237
Test: open app in hotseat
      close app in hotseat
      the 'matching' view in taskbar should be hidden
      tested icon, predicted icon, folders in taskbar/hotseat
Change-Id: I74382480826afafe6ae58e78faf26fe10812e29b
2023-03-08 10:37:25 -08:00
Sihua Ma
792dda2344 Merge "Set the original drawable for floating widget view" into tm-qpr-dev 2023-03-08 18:26:59 +00:00
Jagrut Desai
4ddd20c53d Make TaskbarStashController aware of accesseibilty time to action settings.
Test: Manual
Bug: 265594904
Bug: 265755827
Change-Id: Id71a6343a0a014933c4468c971ae3e8c4dd9f806
2023-03-08 09:55:43 -08:00
Jagrut Desai
1dc99f3848 Announce for accessiblity when taskbar is invoked/closed
Test: Manual
Bug: 265620540
Change-Id: I6660be7716ec59c765f3d54f8fe9889eaaf56e10
2023-03-08 09:54:10 -08:00
Charlie Anderson
04d2397c43 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev am: 3b072b9a07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21559561

Change-Id: I070d83e8389c5a4df8b60923b9615a00e2bbc037
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 14:35:52 +00:00
Charlie Anderson
3b072b9a07 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev 2023-03-08 14:15:17 +00:00
Fengjiang Li
8af9940f4c Fix NPE of TopTaskTracker
Fix: b/270602014
Test: manual
Change-Id: Ifdfedee45edea521cb60dad2b41823b9964e8c11
2023-03-07 16:23:32 -08:00
Sihua Ma
914549b482 Set the original drawable for floating widget view
This ensures that the background of the widget will not disappear after cancelling opening the widget activity.

Normally, when opening and closing the widget activity, the following procedures are executed:

tap on widget
-> opening animation initialized -> opening animation finished
-> close the activity
-> closing animation initialized -> closing animation finished

The steps above would work fine. However, a different set of procedures is followed if we try to cancel opening the widget activity:

tap on widget
-> opening animation initialized
-> opening animation started
-> swipe back before opening animation is completed
-> closing animation initialized
-> opening animation finished
-> closing animation started
-> closing animation finished

During the animation initialization process, FloatingWidgetBackgroundView would be initialized. It will then cache the original background and replace with a temporary drawable with alpha set to 0. The background is only restored at the end of the animation.

If two FloatingWidgetBackgroundView is initialized on the same app widget view before one of them is finished, the second floating view will treat the temporary drawable as the original background. At the end of the closing animation, the temporary drawable with an alpha value of 0 will be set for the app widget view, causing the background of the widget view to disappear.

This CL stores the original drawables into the background view so they could be retrieved during the initialization process of the floating background view.

Test: Manual
Fix: 259526083
Change-Id: Iefa29b22b690076a4fc3fc77fe6eea4b6316f852
2023-03-07 15:20:22 -08:00
Ats Jenk
80f4c20f6c Set desktop icon to always use black for the icon
Desktop icon in overview was using a themed color for the icon. But the
background is always a white circle. When using a dark theme, the themed
primary text color is too light. Fixing the color of the icon to be
black always.

Bug: 267326722
Test: enable dark mode, open overview and check the desktop tile icon
Change-Id: Ibcfdfd92ffe2db41cf6ed75c3da8f6457773c2bf
2023-03-07 14:24:37 -08:00
Schneider Victor-tulias
673549f1df Merge "Translate the navigation setting text to prevent overlapping with home gesture hint" into tm-qpr-dev am: f1a0bd61f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21681580

Change-Id: I76652e3df99cad129f3b1443257b65454c1bf389
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 21:13:43 +00:00
Schneider Victor-tulias
f1a0bd61f4 Merge "Translate the navigation setting text to prevent overlapping with home gesture hint" into tm-qpr-dev 2023-03-07 20:49:22 +00:00
Jon Miranda
89d42acf47 Merge "Use dY to determine if taskbar nav threshold is met." into tm-qpr-dev am: 05f08214be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21802101

Change-Id: I08787b44374c195e617fa35147b31232ea4bfcc4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 20:18:02 +00:00
Jon Miranda
05f08214be Merge "Use dY to determine if taskbar nav threshold is met." into tm-qpr-dev 2023-03-07 20:07:24 +00:00
Jon Miranda
3ed72b4f92 Use dY to determine if taskbar nav threshold is met.
Prior to this change, we used absoulte screen values.
With this change, the nav threshold is aligned with all other taskbar
thresholds.

Fixes: 269167210
Bug: 267646355
Test: swipe up to show taskbar
Change-Id: Ie2017577fd640b4173fd5ba10122d6906e74f90a
2023-03-07 16:50:42 +00:00
Mateusz Cicheński
c5cbf0f326 Fix entry bounds for 3 button nav
The fix uses the similar approach to shelf height to ensure that the
keep clear area is being updated as soon as possible for quickstep.

Without this, the entry animation finishes before the actual keep
clear area from the view is registered, which causes the PiP to enter
lower right corner and then move up, which was the regression.

Bug: 260779127
Test: manually
Test: http://recall/-/g8x7ZkgdfbqscttAA9wzl9/72aNHwWH5wihwN4gf3mfj

Change-Id: Ide11a903558d7e6cb9e477abe12b81129a7f7afc
2023-03-07 07:50:06 +00:00
Brian Isganitis
c762ef68d4 Log when taskbar is in task switcher container.
Test: wwdebug & wwlogcat
Bug: 261177876
Change-Id: Id4eda7ee7e4e2c1aa60e07d5b65410b3847d9ac6
2023-03-07 03:29:21 +00:00
Brandon Dayauon
76e123820a Merge "Correctly make to spec the color for "Turn on work apps" button and add stroke" into tm-qpr-dev am: d0838d3ac1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470669

Change-Id: I2a0d9cccea4a9593af9d4079b0c58f16e27f5156
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 03:25:10 +00:00