Commit Graph

3822 Commits

Author SHA1 Message Date
Alex Chau
ed16e41c51 Merge "Refine logs for debugging TaplTestQuickStep.testOverviewActions on cf_foldables" into sc-v2-dev am: f4b2b2d304 am: a388452fe9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15243930

Change-Id: I094b191f4e548a1ffa6ac1c0202579062ee7f639
2021-07-10 11:00:16 +00:00
Alex Chau
1e767a6ecc Refine logs for debugging TaplTestQuickStep.testOverviewActions on cf_foldables
- The failure is not reproducible locally, thus requires adding logs and check ATP result
- Removed some redundant logs
- Changed to log at VERBOSE
- Added extensive logging to all visibility/enable/alpha setter of ActionsView

Bug: 193125090
Test: Manual
Change-Id: I5b449a7f86ea4cef65e0e46de4b389deef9f53f3
2021-07-09 13:32:49 +01:00
Vinit Nayak
0efe328995 Merge "Re-try binding to TouchInteractionService if service is killed" into sc-v2-dev am: 80aa4dbec0 am: 69fd801273
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15225084

Change-Id: I91b1a6c0705fb74629b096603fffa86130175cd7
2021-07-08 22:28:24 +00:00
Evan Rosky
244efa9e72 Merge "Include shell+stage-split in legacy recents animations" into sc-v2-dev am: 340471f9e6 am: 881c361667
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15193283

Change-Id: I480e05f259da5c4ee81ab24c0a7daccbdb1460bd
2021-07-08 22:22:45 +00:00
Vinit Nayak
80aa4dbec0 Merge "Re-try binding to TouchInteractionService if service is killed" into sc-v2-dev 2021-07-08 22:09:51 +00:00
Evan Rosky
340471f9e6 Merge "Include shell+stage-split in legacy recents animations" into sc-v2-dev 2021-07-08 22:05:54 +00:00
Winson Chung
55c3d564df Merge "Fix crash when handling recents animation canceled" into sc-dev am: d489a4b6e9 am: ceedb94765
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15236027

Change-Id: I9d85dd1c5cd60b8aca01ca0db3d112b363072806
2021-07-08 21:49:41 +00:00
Winson Chung
5f306f97f2 Merge "Fix crash when handling recents animation canceled" into sc-dev am: d489a4b6e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15236027

Change-Id: If65c9b5f4822bed2dbb63f0aa9f34ae7e2e3a922
2021-07-08 21:35:57 +00:00
Winson Chung
d489a4b6e9 Merge "Fix crash when handling recents animation canceled" into sc-dev 2021-07-08 21:21:37 +00:00
Vinit Nayak
297d2cdd44 Re-try binding to TouchInteractionService if service is killed
For problem explanation, see b/190339338#comment26.
When the binding dies, this attempts to retry
binding to the service with a backoff duration of
(1000 * 2^N)ms where N is # of attempts.

Bug: 190339338
Test: Taskbar seems interactable more consistently.
Manually failed the binding a couple times to see
retry mechanism and verified by logging locally.

Change-Id: Ia76207d0b2ef30b425ee1d7c66d7dee453bca7d8
2021-07-08 13:05:38 -07:00
Alex Chau
c006d42e59 Merge "Add logs for debugging TaplTestQuickStep.testOverviewActions on cf_foldables" into sc-v2-dev am: 4b0ef07f7a am: 58a48a97e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15235230

Change-Id: Idc4449e71030ca5c7e98ab920807f2497f1fbc30
2021-07-08 19:37:14 +00:00
Alex Chau
4b0ef07f7a Merge "Add logs for debugging TaplTestQuickStep.testOverviewActions on cf_foldables" into sc-v2-dev 2021-07-08 19:11:53 +00:00
Evan Rosky
de53ba89ac Merge "Hook up split-launch to legacy transition system" into sc-v2-dev am: 5a7602f55c am: 4c02707848
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15150390

Change-Id: I46d2e5f0751797975bbb9d66c63e54677bdee5d1
2021-07-08 18:29:07 +00:00
Winson Chung
255fe1ea45 Fix crash when handling recents animation canceled
- If Launcher finishes the animation, that also cleans up the screenshot
    on the server side, so we can skip calling it

Fixes: 192684578
Test: N/a, adding a null check
Change-Id: I8bf1ad5089762469697d14842cc14c184055e925
2021-07-08 10:12:34 -07:00
Evan Rosky
ffa6652c25 Include shell+stage-split in legacy recents animations
This just builds the infrastructure and then, just as
an example/proof-of-concept, uses the infra to show/hide
the divider-bar when it makes sense.

Bug: 192292305
Test: enable SPLIT_SELECT, enter split, use recents and observe
      the divider bar appropriately showing/hiding
Change-Id: Iea0704b3f7821c3056a1675f11e671e81305831f
2021-07-08 09:03:18 -07:00
Evan Rosky
1abc73c587 Hook up split-launch to legacy transition system
Adds legacy versions of the animation logic.

Bug: 192279476
Test: use SPLIT_SELECT to launch 2 apps in split and observe
Change-Id: I5cbe7416819ba88d8c081fb413177fadac5b815d
2021-07-08 09:03:12 -07:00
Alex Chau
73202ec6b3 Add logs for debugging TaplTestQuickStep.testOverviewActions on cf_foldables
- The failure is not reproducible locally, thus requires adding logs and check ATP result

Bug: 193125090
Test: Manual
Change-Id: I3d2d37a43d4b89885214b72e48f45a9b6bc63f61
2021-07-08 15:29:28 +01:00
Ashish Gupta
8511d20778 Merge "NIU Actions: Add NIU Actions tooltip" into sc-dev am: 4e74ccb082 am: d5892fe778
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15126744

Change-Id: Ie50b7e962172162cae742568de2e3ceb319b9b5b
2021-07-08 07:58:51 +00:00
Ashish Gupta
277eb6fe59 Merge "NIU Actions: Add NIU Actions tooltip" into sc-dev am: 4e74ccb082
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15126744

Change-Id: I603a29767934ac22dc6200c3e63053d6278236d2
2021-07-08 07:42:16 +00:00
kumarashishg
88be649d21 NIU Actions: Add NIU Actions tooltip
These tooltips are added to educate the user about NIU buttons actions. We have added tooltips for Translate and Listen NIU actions buttons.

Bug: 186006700
Test: Manual
Change-Id: Ib076c2a44055b62f2daf06bddf45aca220a28756
2021-07-08 00:48:22 +00:00
Vinit Nayak
aecbda98ab Merge "Set correct divider dimension for task menu options" into sc-dev am: 7d0826f3d1 am: 0bed6a4173
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164589

Change-Id: I46a1cd7788dd4f8b88b3369ce8b96ea48c0c42d6
2021-07-07 20:22:29 +00:00
Vinit Nayak
9241fe62d1 Merge "Set correct divider dimension for task menu options" into sc-dev am: 7d0826f3d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164589

Change-Id: Ia48a1e6b2ebab8f94f374d0c4369bf4b62d13bea
2021-07-07 20:13:15 +00:00
Vinit Nayak
7d0826f3d1 Merge "Set correct divider dimension for task menu options" into sc-dev 2021-07-07 19:56:56 +00:00
Vinit Nayak
ac28d30ebb Merge "Show back and IME switcher for gesture nav (1/2)" into sc-v2-dev am: a102bd896f am: 38356b77e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15069670

Change-Id: Ifd4c73cfad3cee249669a0ffd1b930b451d96f3e
2021-07-07 18:25:30 +00:00
Winson Chung
da587fb7a6 Merge "Remove unused logs" into sc-dev 2021-07-07 18:02:53 +00:00
Vinit Nayak
a102bd896f Merge "Show back and IME switcher for gesture nav (1/2)" into sc-v2-dev 2021-07-07 18:02:17 +00:00
Alex Chau
790ce5bf28 Merge "Allow dragging outside TaskView on fallback recents" into sc-v2-dev am: 41655c3d4a am: 7386f5615f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15179053

Change-Id: I66928f0164d296fc32cf2ea82b381fb869d0d3d6
2021-07-05 15:03:35 +00:00
Alex Chau
41655c3d4a Merge "Allow dragging outside TaskView on fallback recents" into sc-v2-dev 2021-07-05 14:37:03 +00:00
Lucas Dupin
9f3ad05e6f Merge "Use launcher surface when removing launch target" into sc-dev am: e55878cedf am: 2327552bad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15193282

Change-Id: I6757587d671c2de1c6e8866b860331e72cdb1b8b
2021-07-03 17:46:51 +00:00
Lucas Dupin
1f5a4c9522 Merge "Use launcher surface when removing launch target" into sc-dev am: e55878cedf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15193282

Change-Id: If0f2f60cae7d7d00ab5cf386b32f00247af887d6
2021-07-03 17:29:49 +00:00
Lucas Dupin
e55878cedf Merge "Use launcher surface when removing launch target" into sc-dev 2021-07-03 17:14:32 +00:00
Winson Chung
a87e251a6b Merge "Fix crash when handling recents animation canceled" into sc-dev am: a82403ab09 am: 9b3c0a7ae8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15192339

Change-Id: I7e23e46f1f88650cf274be66dd3dc189e930996a
2021-07-03 03:59:16 +00:00
Winson Chung
3ab305e759 Merge "Fix crash when handling recents animation canceled" into sc-dev am: a82403ab09
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15192339

Change-Id: Id8f402766124ecbb648d81527124e41495e182b5
2021-07-03 03:43:07 +00:00
Winson Chung
a82403ab09 Merge "Fix crash when handling recents animation canceled" into sc-dev 2021-07-03 03:26:26 +00:00
Winson Chung
553d978012 Fix crash when handling recents animation canceled
- If Launcher finishes the animation, that also cleans up the screenshot
  on the server side, so we can skip calling it

Fixes: 192684578
Test: N/a, adding a null check
Change-Id: Ia6b99b4262e72f925e7d622ea8833d3c88252633
2021-07-03 03:26:16 +00:00
Lucas Dupin
20a13047ae Use launcher surface when removing launch target
Otherwise events won't be dispatched properly and window opacity will be
wrong.

Test: manual
Fixes: 191149025
Change-Id: Ice7ea86252282c7dc1cb5925dd1bdb8cade89c08
2021-07-02 17:39:10 -07:00
Tracy Zhou
ee5dc1149e Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-dev 2021-07-02 21:41:28 +00:00
Tracy Zhou
26f47c711a [DO NOT MERGE] Make the cutout slightly smaller
Temporary fix for S. Leaving the bug open for a proper fix in T.

Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
2021-07-02 13:35:50 -07:00
Sunny Goyal
b7477c97e5 Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 6348858734 am: e6704c17f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15137733

Change-Id: Ie31b8673cadabf99149665f9a7b1a9fb95d953a3
2021-07-02 18:57:51 +00:00
Tracy Zhou
ed5b2b3bab Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev am: fa72529b05 am: f3e9774ca6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184810

Change-Id: I32da1bf258c69d9c694465428e37ffbd110950f5
2021-07-02 18:56:35 +00:00
Sunny Goyal
535c4957e6 Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 6348858734
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15137733

Change-Id: I298c261a148e909d1f68926b6d865fa6f2b44825
2021-07-02 18:37:41 +00:00
Tracy Zhou
cd5ebbdaf4 Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev am: fa72529b05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184810

Change-Id: I9cb5e7e4ca2269c56ef835eee93bdc5b605583ac
2021-07-02 18:37:22 +00:00
Sunny Goyal
6348858734 Merge "Fix some touch issues during gesture nav transition" into sc-dev 2021-07-02 18:33:34 +00:00
Tracy Zhou
fa72529b05 Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev 2021-07-02 18:18:23 +00:00
Alex Chau
befa11295b Allow dragging outside TaskView on fallback recents
- Similar to LauncherRecentsView.onTouchEvent, don't allow touch to escape if overview UI is shown
- Add FLAG_OVERVIEW_UI to RecentsState

Fix: 192658511
Test: FallbackRecentsTest.testOverview on pixel_jumbojack
Change-Id: I80270da6c077e8302f75384edeb521cfa81266ec
2021-07-02 16:36:47 +01:00
Tracy Zhou
d2039614e0 Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp
Fixes: 192458435
Test: N/A
Change-Id: I3f0b828bf9fa9645bbd253612aa073f37b21e4b2
2021-07-01 23:52:34 -07:00
Tracy Zhou
ba5a129f32 Enable live tile in 3 button mode am: d09ebe660f am: 740b2381c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133050

Change-Id: Ie928474fe22f10bd3b246679ab47ab20a7052b7d
2021-07-02 05:30:11 +00:00
Tracy Zhou
1fe5fda3d8 Enable live tile in 3 button mode
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355

Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.

Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
Merged-In: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-02 05:19:32 +00:00
Tracy Zhou
d09ebe660f Enable live tile in 3 button mode
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355

Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.

Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-01 18:40:56 -07:00
Alex Chau
35d8b03a97 Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca am: 66b5af2ac2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270

Change-Id: I016cc95e7d86f145ef7dde642c811099c4049d1f
2021-07-01 22:36:55 +00:00