Commit Graph

493 Commits

Author SHA1 Message Date
Alex Chau
e13b1a22f9 Merge "Polish hotseat and taskbar with 3 buttons" into tm-qpr-dev am: 4537638dfd am: 0d5ca5fe6f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20533919

Change-Id: I37921b47514fc4823b2c6ee7d61fbf1ff6ca7c67
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-19 12:26:25 +00:00
Thales Lima
6a59006592 Polish hotseat and taskbar with 3 buttons
Change margin spaces and logic of how many items the hotseat and taskbar should show.

Fix: 246424857
Test: DeviceProfileDumpTest
Test: HotseatWidthCalculationTest
Change-Id: I8ec71c56a0aa362483c43d6400c762d12cf45f5b
2022-12-17 11:20:21 +00:00
Alex Chau
c92b91c579 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev am: 5c1eb61391 am: 881b7f2d55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20691430

Change-Id: I083054a14d61a8ebd212c1d1dde5ee210eb84fd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 18:12:34 +00:00
Alex Chau
be753137a2 Don't scale iconSize and textSize in non-default display size
- Cells should get extra space by reducing borderSpace. If that's still not enough, use 0 borderSpace and distribute the space

Fix: 256976071
Fix: 248348171
Test: manual
Change-Id: I067c1aaa553d7a84caeeb9ce21e80cfaf86a3bed
2022-12-13 16:30:14 +00:00
Sebastián Franco
bdee8e4313 Merge "Ignore all launcher3 flaky test so that they come back online" into tm-qpr-dev am: 878ae3fc85 am: 64d68ce0c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20647519

Change-Id: I255b21e3e06e93c90f7b718d265d166abc4b4e72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 20:50:40 +00:00
Sebastian Franco
150e572e05 Ignore all launcher3 flaky test so that they come back online
Test dashboard: https://android-build.googleplex.com/builds/tests/search?filter=mediumFailureRate&filter=highFailureRate&query=config%3Av2%2Fgnl-eng%2Funbundled%2Flauncher%2Flauncher3_test_platform+latest%3A4d&tab=tests

Test: dashboard should not show flaky tests
Bug: 256832045
Change-Id: I06e879dec2703455b7be728c7afd3500d2edd54a
2022-12-06 17:08:45 -08:00
Vinit Nayak
84c70ff18e Merge "Update test for change in calculation of split portrait clipping" into tm-qpr-dev am: 2cf7994908 am: 5d1bee3835
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20617554

Change-Id: Ib9db0563e56d4c49a522075e609c93740acd0add
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 20:46:36 +00:00
Vinit Nayak
190fa37647 Update test for change in calculation of split portrait clipping
* Updated code, wrote new test for new code
but forgot to update old test.

Fixes: 261110474
Test: FullscreenDrawParamsTest passes
Change-Id: I39a9029b69774f0ea7064da295c516f547bcbef2
2022-12-01 21:22:38 -08:00
Vinit Nayak
f8c0da187c Merge "Update for stashed taskbar animation" into tm-qpr-dev am: 18d5634176 am: a5bb63d39a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470413

Change-Id: Icd28b632d9df39cca246024e76ca232b16492428
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 02:47:06 +00:00
Vinit Nayak
3b1f5849ce Update for stashed taskbar animation
* Strangely if you swipe up with a split pair
and then tap on the live tile to go back to
fullscreen this animates fairly correctly.
However, if you drag the focused pair back to fullscreen
the bottom app does not unclip as expected

Bug: 219411750
Test: Swipe up w/ stashed taskbar in portrait.
Thumbnail cutout doesn't appear when dragging to
fullscreen

Change-Id: Ia6e7aae10389d9fefa4adbfce540171bbe0a9180
2022-11-30 11:56:40 -08:00
Vinit Nayak
8bb9fcc020 Merge "Update test for vertical split" into tm-qpr-dev am: 9de3256583 am: 53c66c4afe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20455918

Change-Id: I026a43de55b9e4d7badcf8674bb0a7226d9954ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 19:18:30 +00:00
Vinit Nayak
825ede3e92 Update test for vertical split
* Takes into account taskbar insets, not sure what
expected val should be so copied the same logic from code

Bug: 219411750
Test: Ran test, passes
Change-Id: I6230a3d043e41446c35c9b393abf4a2e0ea891af
2022-11-17 16:39:27 -08:00
Vinit Nayak
b8dcdbdd67 Merge "Add test for vertical and horizontal split apps" into tm-qpr-dev am: 03695ba0f2 am: 2af60c9c11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446857

Change-Id: I1906d92531855f6aa02d51b7b5f5f266b1149ac2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-16 21:28:05 +00:00
Vinit Nayak
03695ba0f2 Merge "Add test for vertical and horizontal split apps" into tm-qpr-dev 2022-11-16 20:45:01 +00:00
TreeHugger Robot
fd49872770 Merge "Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""" into tm-qpr-dev am: 87ccecb6fc am: 8c49ddde2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20425196

Change-Id: I826fbc5897fff22e932a4d790e76a7adee21298e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 23:40:37 +00:00
TreeHugger Robot
87ccecb6fc Merge "Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""" into tm-qpr-dev 2022-11-15 22:31:55 +00:00
Evan Rosky
8e8c78677e Merge "Revert^5 "Enable Shell Transitions"" 2022-11-15 19:50:13 +00:00
Vinit Nayak
7545f20268 Add test for vertical and horizontal split apps
* More work still needs to be done for portrait
split apps with stashed taskbar

Bug: 258714015
Test: Existing tests pass, visually saw slight
improvement in stashed portrait gesture clipping.

Change-Id: Id1b9bb28a1a2676a5da1b5e5824e0835290cb616
2022-11-15 11:23:38 -08:00
Evan Rosky
eaec408d1b Revert^5 "Enable Shell Transitions"
9ad16b317f

Change-Id: I4c8b2375ede32c2dc3ad0e2b7fa77b87580d73e9
2022-11-15 18:08:37 +00:00
Evan Rosky
eb31fcc888 Merge "Revert^4 "Enable Shell Transitions"" 2022-11-11 23:31:25 +00:00
Vinit Nayak
27d004d369 Merge "Improve Split portrait gesture animation" into tm-qpr-dev am: 2ca82f38e4 am: 4b6c05c2ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330754

Change-Id: Ib1e9cf31c70edb187f6bc8467f7a2d5ddaa9bb1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:18:10 +00:00
Jon Miranda
f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
2022-11-10 11:11:14 -08:00
TreeHugger Robot
195e9ef499 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2 am: b5c134d72c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: Ie5d094942e3e476a8be47de609a47cf52049e621
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 02:19:58 +00:00
Jon Miranda
e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00
Vinit Nayak
29e71bdd72 Improve Split portrait gesture animation
* Crop out taskbar from bottom thumbnail for vertical split
* TODO: Need to re-calculate thumbnail sizes if taskbar
 is stashed. There's also a very slight rounding error
 somewhere even in the unstashed case that needs to be
 revisited

Bug: 219411750
Test: Start gesture animation in split in potrait
Change-Id: I35f2415e13af7467e0735ac8865cee0e3e3d27f8
2022-11-08 11:33:08 -08:00
Jon Miranda
12cdc89c7e Merge "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." into tm-qpr-dev am: 881588bfb5 am: 416680d8f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391679

Change-Id: Ibcc62df1f17de580c3c6f2b18749d5ef6e3be933
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 17:10:33 +00:00
Evan Rosky
9ad16b317f Revert^4 "Enable Shell Transitions"
4de41de461

Change-Id: I60f7d713f037f5e2d37081568adf03b9d0e78104
2022-11-08 00:13:56 +00:00
Evan Rosky
d4a389038c Merge "Revert^3 "Enable Shell Transitions"" 2022-11-08 00:01:33 +00:00
Jon Miranda
d5a6b5f688 Add TaskbarModeSwitchRule to test both transient/persistent taskbar.
- Lays the foundation for transient taskbar tests.
- Does not add flags that would add ACTION_OUTSIDE in tests.
  We can address testing this functionality in a separate CL

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I44acc5e589b959e6d4bc93fdc369e503c54e7d87
2022-11-07 14:18:37 -08:00
Evan Rosky
4de41de461 Revert^3 "Enable Shell Transitions"
985f7de915

Change-Id: Ic98d3972ed5fd6d36e65bbd951619bf98031354a
2022-11-07 22:07:17 +00:00
Evan Rosky
c8ecbe2dda Merge "Revert^2 "Enable Shell Transitions"" 2022-11-07 19:13:21 +00:00
Sunny Goyal
4393a125a3 Merge "Updating widget prediction handling:" into tm-qpr-dev am: 04356a26c3 am: 69a7ad6097
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20312120

Change-Id: I62f3d68bdb369cc296003bad7a2b668b04427787
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 10:04:17 +00:00
Sunny Goyal
3c7054f0d2 Updating widget prediction handling:
When handling widget prediction, first match the full provider names
Only if no widgets are found, match any widget in the package

Bug: 256202399
Test: atest WidgetsPredicationUpdateTaskTest
Change-Id: I5337618d935f8b926803aeefede46059545de72d
2022-11-02 02:24:21 +00:00
Sunny Goyal
8a11443333 Removing unnecessary RemoteAnimationTargetCompat
Merged-In: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
Bug: 221961069
Test: Presubmit
Change-Id: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
2022-10-24 17:17:36 +00:00
Sunny Goyal
0d77cd7166 Merge "Removing unnecessary RemoteAnimationTargetCompat" 2022-10-24 17:16:49 +00:00
Riddle Hsu
7708b315e1 Merge "Attempt to reduce flakiness of testDisableRotationCheckForPhone" 2022-10-24 01:03:28 +00:00
Sunny Goyal
a18e285fe7 Removing unnecessary RemoteAnimationTargetCompat
Bug: 221961069
Test: Presubmit
Change-Id: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
2022-10-20 16:25:21 +00:00
Sunny Goyal
361da47493 Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev am: d79f84fffe am: cc6290d81f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20215466

Change-Id: Iee38fc975ce911b3a0fa3b43a97047dd094ce956
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 01:33:32 +00:00
Riddle Hsu
053f5910cb Attempt to reduce flakiness of testDisableRotationCheckForPhone
The request setOrientationLeft() is async that puts the target
rotation to setting. So the actual display rotation change may
happen when executing goHome(). Then the swipe gesture may be
interrupted that causes the test to fail.

Add a condition to wait for leaving natural orientation change
before calling goHome(). Also reorder and simplify the way to
start test activity to reduce execution time.

Bug: 253290379
Test: TaplTestsQuickstep#testDisableRotationCheckForPhone
Change-Id: I881d6f666c98fd3fe601b874adb0d14122bff2b7
2022-10-19 20:51:12 +08:00
Sunny Goyal
dd11f089cc Revert "Revert "Using Transaction directly instead of building s..."
Revert^2 "Removing unused surface transaction wrappers"

2460910c8c454bc2d3c9ae35bd32eeb590851788

Bug: 221961069
Test: Presubmit
Change-Id: I0028c9fe0de6fde6a77de84e4858fda14cd578dd
2022-10-18 16:30:26 +00:00
Vinit Nayak
d6c5147524 Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
Merged-In: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-17 13:59:18 -07:00
Vinit Nayak
391b79c084 Merge "Landscape 3 button nav on taskbar phone supported" 2022-10-17 20:14:36 +00:00
Vinit Nayak
831a4f0e1d Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-13 23:22:38 +00:00
Evan Rosky
985f7de915 Revert^2 "Enable Shell Transitions"
2be4e88eda

Change-Id: I8cd0d125ecaa8201bf5d9c8e087f1c5c901e1fa0
2022-10-12 21:06:38 +00:00
Yein Jo
632468dc00 Merge "Revert "Enable Shell Transitions"" 2022-10-12 21:00:05 +00:00
Yein Jo
2be4e88eda Revert "Enable Shell Transitions"
Revert "Enable Shell Transitions"

Revert "Enable Shell Transitions"

Revert "Enable Shell Transitions"

Revert submission 19199517-enable_shell_transit

Reason for revert: DroidMonitor-triggered revert due to breakage, bug b/253049434 b/253109117 b/253181889 b/253271977
Reverted Changes:
I85f9565b3:Enable Shell Transitions
I75d0fe964:Enable Shell Transitions
I0565e423a:Enable Shell Transitions
I98bf8f0aa:Enable Shell Transitions

Change-Id: I6ad85a8f8168cdd40cb66eb58b9ea6a936bc2315
2022-10-12 20:57:48 +00:00
Evan Rosky
3ecceb8680 Merge "Enable Shell Transitions" 2022-10-12 16:08:27 +00:00
Nick Chameyev
09241680a7 Merge "Extract PreviewPositionHelper to shared library" into tm-qpr-dev am: 3e7c611358 am: 40497595fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20034765

Change-Id: Iae3e4e2373ef9918f541bfade1654808fa2a1864
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 17:21:11 +00:00
Nick Chameyev
cbfb35edc7 Extract PreviewPositionHelper to shared library
Moves Launcher's PreviewPositionHelper to shared
library between SystemUI and Launcher to reuse
it in the future in the partial screensharing
recents selector.

There should be no functional changes in the
code itself.

Bug: 240924926
Test: presubmit
Change-Id: Ib38b6f9db91e63a2598bf81229e3cd3e1a49ca60
2022-10-05 10:23:54 +01:00
Ming-Shin Lu
cb4f9b8dc5 Merge "TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation" into tm-qpr-dev am: 8ff85dc733 am: 6013ab3776
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20064292

Change-Id: I6aaeb6efe4af83a5c8621cceb3154be4d53be58c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 07:47:04 +00:00