Commit Graph

13697 Commits

Author SHA1 Message Date
minch
b10cedd21c Handle AddDesktopButton's visibility in different launcher states
Introduce [ADD_DESK_BUTTON] in LauncherState and change the button's
visibility across different launcher states. E.g., the button
shouldn't be visible in the quick switch.

Bug: 389209338
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: 1. Swipe up from home, the button shown util in overview.
      2. Swipe up from the fullscreen app, the button is invisible
         util release the finger.
      3. The button is invisible in quick switch.
      4. All the above tested with NexusLauncher and Nova launcher,
         which is a 3rd launcher.
      5. Tested with gesture and 3-finger swipe on the touchpad.
      6. Both the ClearAllButton and AddDesktopButton are not
         visibile when in select mode.
Change-Id: I54e11d4d03401be68b5b67a6f591edd737c9ea30
2025-02-24 21:33:36 +00:00
Schneider Victor-tulias
6040a652a6 Merge "Respect accessibility animation guidelines in AllSetActivity" into main 2025-02-24 13:30:10 -08:00
Jagrut Desai
cf05d3ec0e Merge "Fix Taskbar Edu accessibility anmimation" into main 2025-02-24 13:27:53 -08:00
Saumya Prakash
b716d19362 Merge "Update gesture nav tutorial to new font style" into main 2025-02-24 10:37:22 -08:00
Alex Chau
31f32597dd Merge "Fix jump when dismissing last grid task View" into main 2025-02-24 10:35:14 -08:00
Schneider Victor-Tulias
de841f6092 Respect accessibility animation guidelines in AllSetActivity
- Disabling the background animation if the user has opted out
- Allow the user to pause/resume the animation

Flag: EXEMPT bug fix
Fixes: 386743741
Test: launched AllSetActivity with animations on/off; tapped screen in both cases
Change-Id: I2bdbef24d6c582b4229441149fffcb67ba488882
2025-02-24 10:00:32 -08:00
Jagrut Desai
e49214080f Fix Taskbar Edu accessibility anmimation
This cl include: Allows user to click on lottie animation views to play and pause animations. If user have choosen to remove animations we will honor it and not play the animation from begaining.

Test: Manual, Presubmit
Bug: 378980835
Flag: EXEMPT bugfix
Change-Id: Ieaaf771bc307837f042f6e59d8f02fefb2e8286a
2025-02-24 09:36:22 -08:00
Uwais Ashraf
5e3331dc6f Add missing bits of cleanup to TV recycle stage
Bug: 395331030
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual heap dump comparison
Change-Id: Ifa40d7bf874b0437fb0dc59a964748366ffe9986
2025-02-24 07:24:37 +00:00
Treehugger Robot
63de256dfe Merge "Add deskId to DesktopTask." into main 2025-02-21 18:33:52 -08:00
Xiaoqian (Daisy) Dai
9ca73dfa09 Merge "desktop-exploded-view: Implement the close button and its behavior" into main 2025-02-21 16:53:28 -08:00
Jeremy Sim
96da8fc3ec Merge "Refactor SplitBounds to always use creation-time measurements" into main 2025-02-21 15:26:02 -08:00
Xiaoqian Dai
6aca9bedd5 desktop-exploded-view: Implement the close button and its behavior
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual + newly added tapl tests in a following CL
Bug: 353965691

Change-Id: Iba4603b84928885b1d50f5551adbacbd31e98cc3
2025-02-21 22:23:41 +00:00
Treehugger Robot
a8b8c7c3eb Merge "Correct the page scrolls of the AddDesktopButton" into main 2025-02-21 12:59:52 -08:00
Saumya Prakash
1393d559c2 Update gesture nav tutorial to new font style
This change applies the new expressive font style if the expressive
theme is enabled. Screenshots are available in the bug

Fix: 393615349
Test: Check that the fonts change when the expressive theme is enabled
Flag: com.android.launcher3.expressive_theme_in_taskbar_and_navigation
Change-Id: Ib67e81edfd7aa125b9aa824946616c02e24c13e6
2025-02-21 10:57:08 -08:00
Treehugger Robot
2e759f359c Merge "Launcher: Make RecentTasksController.getRecentTasks() multi-desks aware" into main 2025-02-21 10:38:35 -08:00
Alex Chau
7d47679892 Fix jump when dismissing last grid task View
- Calcualte the scroll diff to bring large tile to middle of screen
- Additional compensate for scroll diff between last task and ClearAllButton if ClearAllButton is visible

Fix: 395883390
Test: manual, not adding e2e because animation jump cannot be caught by e2e test
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I6a506f2af46ded4daf21fe49329ab71b59e3f19d
2025-02-21 18:08:33 +00:00
Sunny Goyal
7629bc4dcd Merge "Converting LauncherAppState to Dagger" into main 2025-02-21 10:06:01 -08:00
Fengjiang Li
710bce6163 Merge "[Memory Leak] Fix leak of NexusLauncehrActivity via AbsSwipeUpHandler#mRecentsAnimationStartCallbacks -> SurfaceTransactionApplier" into main 2025-02-21 09:52:49 -08:00
Daniel Andersson
050e6eebb0 Merge "desktop-exploded-view: Explode desktops when swiping up from home" into main 2025-02-21 09:50:39 -08:00
Ahmed Fakhry
dafc2d4c42 Add deskId to DesktopTask.
Now that `GroupedTaskInfo` propagates the `deskId` from
Shell (see ag/31825217), we need to plumb this value in
Launcher through `DesktopTask`.

Future CLs will use this value in Overview.

Bug: 395911284
Test: m, modified existing tests.
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I396250e0cac761c4c5f7e8b2d6cddbe68e646217
2025-02-21 17:50:13 +00:00
minch
1c028b7ccb Correct the page scrolls of the AddDesktopButton
Do not apply the button's grid translation to its page scrolls if
it is not showing as a grid,otherwise the `mCurrentPage` may not be
set correctly while checking `ensureWithinScrollBounds`.

Bug: 396146789
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: m
Change-Id: Ia1378a997e681abda60fa1cb3c125660916df4c5
2025-02-21 09:06:53 -08:00
Treehugger Robot
b38ab564be Merge "Close gap between grid and clear all for expressive dismiss." into main 2025-02-21 04:01:11 -08:00
Treehugger Robot
feb96ff7d3 Merge "Launch app pair when one of them is in freeform." into main 2025-02-20 20:29:16 -08:00
Sunny Goyal
c9f697aeb5 Converting LauncherAppState to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I336a233d2703c23a7e9065474bde471786886144
2025-02-20 19:13:49 -08:00
Saumya Prakash
4e0e72e013 Merge "Add developer option to launch gesture nav tutorial" into main 2025-02-20 18:42:36 -08:00
Shamali Patwa
e532fc86b4 Merge "Update widgetsModel to return pickable vs all widgets separately." into main 2025-02-20 17:42:32 -08:00
Treehugger Robot
48fe315833 Merge "Update usage of flags to dev options." into main 2025-02-20 17:29:38 -08:00
Treehugger Robot
6787617f73 Merge "Log LPNH abandon times at least 200ms." into main 2025-02-20 17:16:15 -08:00
Treehugger Robot
ca88e0cc04 Merge "Log minimize CUJ in MinimizeAnimator" into main 2025-02-20 14:52:48 -08:00
Ahmed Fakhry
f7e64649a1 Launcher: Make RecentTasksController.getRecentTasks() multi-desks aware
This is the Launcher-side CL  of the companion CL ag/31825217.
This CL changes `GroupedTaskInfo` and `RecentTasksController.getRecentTasks()`
such that multiple desktops are supported.

Bug: 395911284
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I856768d03460054ccd7056f87e16dcb65ced47fb
2025-02-20 22:31:58 +00:00
Daniel Andersson
1422e89e92 desktop-exploded-view: Explode desktops when swiping up from home
This change makes it so that the explode animation only happens when
swiping up from the desk. In other cases, the desk is immediately set
to its exploded state.

The desk explode progress is now exposed as a FloatProperty in
RecentsViewUtils.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 367353392
Change-Id: I5adec7db1fdc933860dce7fcca0a47cec0672ee7
2025-02-20 14:30:47 -08:00
Randy Pfohl
4d9ce7c953 Merge changes I854de220,Ib5e380a3,I5acfa734 into main
* changes:
  Respond to configuration changes in RecentsWindowManager
  enabling animations to return to home
  Fixing crash, and  no touch input while mid animation
2025-02-20 14:15:00 -08:00
Andy Wickham
8fabc6d111 Log LPNH abandon times at least 200ms.
Restricting to 200ms+ to reduce the spamminess of these logs.

The idea is to log the latency of LPNH abandons to see the effect
of prewarming at x ms.

Bug: 397484410
Flag: EXEMPT logging
Test: Manual and updated NavHandleLongPressInputConsumerTest.
Change-Id: I93f94ed0757508b68fcb48d61bdd194564dcc573
2025-02-20 22:14:37 +00:00
Shamali P
f6efa25a49 Update widgetsModel to return pickable vs all widgets separately.
Earlier wallpaper preview was reading widgets that were eligible for
displaying in picker, which means widgets that are marked as hidden in
picker wouldn't show up in wallpaper preview.

This fix updates widgets model to maintain map of all widgets (instead of just pickable widgets like before), so that the existing `getWidgetsByComponentKey` function used by wallpaper preview can see all widgets. And, updates picker specific methods to use separate functions (suffixed `forPicker` that filter out picker ineligible widgets when read by picker code).

Bug: 385695615
Test: WidgetsModelTest, WidgetsPredictionUpdateTaskTest and demo
Flag: EXEMPT BUGFIX
Change-Id: I59efe38be0ce1f8a956ba4be42fb6e8b48b5d323
2025-02-20 14:13:16 -08:00
Saumya Prakash
57794d1025 Add developer option to launch gesture nav tutorial
This change allows you to start the full, continuous gesture navigation
tutorial by tapping the "Launch Full Gesture Tutorial" option in
launcher developer settings.

Fix: 398018882
Test: Go to developer settings and launch tutorial. It should be
continuous and automatically move on to each gesture.
Flag: EXEMPT bugfix

Change-Id: I5da176e13b4403e1748b9ccba74b24145dafed2c
2025-02-20 21:54:25 +00:00
Hongwei Wang
3e63b57f7d Merge "Switch to PictureInPictureParams#isSameAspectRatio" into main 2025-02-20 13:10:56 -08:00
Jeremy Sim
b392f61ced Refactor SplitBounds to always use creation-time measurements
In flexible split ratios like 90:10 and 10:90, we hide the Overview icon of the smaller app completely (ag/30949010). However, there was an unintentional side effect where one of the icons would disappear when rotating the display.

This happened (basically) because SplitBounds is not recalculated on device rotation, so fields like leftTaskPercent and topTaskPercent should not be used directly when the rotation state is not known. I added an API to SplitBounds that hopefully makes it harder to write bugs like this in the future.

Fixes: 395783367
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: Icons do not disappear on rotation. When app chip menus are enabled, the (existing) correct behavior is not changed.
Change-Id: I2c1b38f4bd9a76dfb127b7bbf230897d747d3c49
2025-02-20 12:45:33 -08:00
Treehugger Robot
3cd737db84 Merge "Add null checks to prevent NPE on ViewModel." into main 2025-02-20 11:03:26 -08:00
Treehugger Robot
e8a1719649 Merge "Copy drawable so that mutations don't affect other uses of the drawable" into main 2025-02-20 10:28:17 -08:00
Vania Desmonda
b8db0313bc Update usage of flags to dev options.
Bug: 361366053
Bug: 345296916
Bug: 381866902
Flag: EXEMPT refactoring flag
Test: presubmits
Change-Id: I7653ca4e7a2476402cfccbbc72194b14b10cb93f
2025-02-20 18:27:43 +00:00
Pat Manning
2caae623a6 Close gap between grid and clear all for expressive dismiss.
Fix: 397891454
Test: TaplTestsQuickstep#testDismissLastGridRow
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Id49447819c38f307f05cd4ecc3d501bd51766443
2025-02-20 18:06:52 +00:00
Vania Desmonda
c8ee653eef Launch app pair when one of them is in freeform.
Call launchAppPair when one of the tasks is in freeform to prevent only
launching one app to the side and choosing the DesktopWallpaperActivity
as the other app pair.

Fixes: 394917143
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: atest NexusLauncherRoboTests
Change-Id: I3967473fa648f2b245ac8b4f16e6112f6d8f077f
2025-02-20 18:01:42 +00:00
Treehugger Robot
9bacd7ce4a Merge "Send intent boradcast when AllSetActivity ends and reaches launcher" into main 2025-02-20 09:42:57 -08:00
Uwais Ashraf
91370114ea Add null checks to prevent NPE on ViewModel.
ViewModel can be null if onRecycle completes before coroutineJob is cancelled.

Fix: 395751707
Flag: Exempt - test fix
Test: OpenActivityEmbeddingPlaceholderSplitTest in postsubmit
Change-Id: I12e1f6e2e5951ae04264fc8ea9d45b6ac6d43308
2025-02-20 17:03:27 +00:00
Uwais Ashraf
19381579f1 Copy drawable so that mutations don't affect other uses of the drawable
Fix: 397770855
Flag: EXEMPT - test fix
Test: OverviewTaskSelectImageTest
Change-Id: I9e0fa179ab3c7de6edf566f50459c51c6efb4377
2025-02-20 08:28:28 -08:00
Treehugger Robot
6f7d05b2a5 Merge "Prevent high res callback from fetching when not needed." into main 2025-02-20 06:29:13 -08:00
Treehugger Robot
c6a24e4178 Merge "Use scale adjusted path to avoid warped rounded corners." into main 2025-02-20 05:29:15 -08:00
Alex Chau
0b584b0c98 Merge "Update Desktop tasks's corner radius to match Shell side" into main 2025-02-20 05:25:17 -08:00
Sergey Pinkevich
e97f4932fd Merge "Add logs for DesktopAppLaunchTransition when animation starts/no launch change" into main 2025-02-20 02:20:28 -08:00
Gustav Sennton
f275bd9bcc Log minimize CUJ in MinimizeAnimator
Flag: NONE refactor
Test: manual
Bug: 374206096

Change-Id: Id8ab050e5f2f519cccc460b690c2e8edd7c20561
2025-02-20 08:30:44 +00:00