Commit Graph

12092 Commits

Author SHA1 Message Date
Stevie Kideckel
d93feeba0a Fix corner radius for expanded widget picker list items
Also create the drawables at runtime to avoid all the permutations

Fix: 189329394
Test: verified locally
Change-Id: I0497759ff68bd4ae6b1635423cfd4713f06d349f
2021-06-04 13:04:04 +00:00
TreeHugger Robot
4d296cc3d8 Merge "Use a selector instead of loading resource for drop target." into sc-dev am: b1e51e2a3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817811

Change-Id: Ieb674f68802b1550eb2675b0c0a7ef5abf233779
2021-06-04 12:49:20 +00:00
TreeHugger Robot
b1e51e2a3f Merge "Use a selector instead of loading resource for drop target." into sc-dev 2021-06-04 12:29:22 +00:00
Stevie Kideckel
c5a9ffb31c Merge "Use scrollToPositionWithOffset in widget list and account for padding" into sc-dev am: 6d12fb29f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817820

Change-Id: I49ebce6c0d887e18b7087d9bfc46ca255e0fe912
2021-06-04 12:05:47 +00:00
Stevie Kideckel
6d12fb29f7 Merge "Use scrollToPositionWithOffset in widget list and account for padding" into sc-dev 2021-06-04 11:45:27 +00:00
Yogisha Dixit
2ff963b0c7 Use a selector instead of loading resource for drop target.
Test: manual
Bug: 187355401,187035471
Change-Id: I65fef2c810c791c3282bd4a087359f6cff774cc4
2021-06-04 12:10:06 +01:00
Hyunyoung Song
e3d32b543d Icon sizes/ keyline / font for AA+ results
Bug: 188946408
Bug: 189166362

Test: manual, screenshots on the bug
Change-Id: I40c77d8ea3cdcc9dcc33afb1026d1f75c21e9f05
2021-06-04 01:43:40 -07:00
Hyunyoung Song
2e747e2194 Remove APP_SEARCH_IMPROVEMENTS
Bug: 190104801
Test: manual, builds

Change-Id: Icd7f0f17bf79eda9fa8e10a6699be3852a34de67
2021-06-03 20:22:29 -07:00
Bill Lin
657a6da6fb Merge changes I7b9e6e7f,I9729cd40 into sc-dev am: 51b35256d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800258

Change-Id: I717b55f90426b21c05370a0aeb731b960fb64bee
2021-06-04 00:33:43 +00:00
Bill Lin
51b35256d2 Merge changes I7b9e6e7f,I9729cd40 into sc-dev
* changes:
  2/ Notify adjust touch slop when one handed mode activated
  1/ Provides feasibility to adjust touch slop in TouchController
2021-06-04 00:16:12 +00:00
Sunny Goyal
57b2279dcb Taskbar layout update
> Calculating the hotseat padding statically
> Animating taskbar views individually when animating to home
  instead of a layout animation
> Moving all navbar buttons to a separate layout/controller and independent
  of Launcher
> Fixing RTL layout for taskbar and nav bar

Bug: 187353581
Test: Manual
Change-Id: If21696f38beee328f553e467394776a8e8ed4c3e
2021-06-03 16:10:02 -07:00
Brian Isganitis
5980354d54 Show toolbar back button on subsettings pages am: 6afcfd7cbd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14741513

Change-Id: I5521e29757bb7bf7d0fb8d0774ae84776abb4ba7
2021-06-03 22:39:49 +00:00
Brian Isganitis
24cee4fbac Pad bottom of settings list view with bottom system insets am: ed49a7187d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14738959

Change-Id: I35d74ea75a87c39260e558457de63a0e8e742e19
2021-06-03 22:39:48 +00:00
Brian Isganitis
6afcfd7cbd Show toolbar back button on subsettings pages
Test: Back button displayed and functional on subsettings
Bug: 187732263
Change-Id: I6a3679de3a00480f5a0861f966d178be25f001d4
2021-06-03 17:04:33 -04:00
Brian Isganitis
ed49a7187d Pad bottom of settings list view with bottom system insets
This change allows for a transparent navigation bar in the settings Material next redesign.

Test: Bottom of settings not cut off by bottom navigation bar
Bug: 187732263
Change-Id: I237011003ca0c3760c0fbdbb2865ef90c19d7b81
2021-06-03 17:02:05 -04:00
Jonathan Miranda
73886f379f Merge "Only inset widgets if workspaceTopPadding is greater than the widget padding." into sc-dev am: 3ed65ede16
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14823934

Change-Id: Ica0d5b9d65dcaa32aae7978ffa36e3a63c172ce1
2021-06-03 20:43:24 +00:00
Jonathan Miranda
3ed65ede16 Merge "Only inset widgets if workspaceTopPadding is greater than the widget padding." into sc-dev 2021-06-03 20:23:18 +00:00
Alex Chau
f647016cce Merge "Make quick switch track finger 1:1" into sc-v2-dev 2021-06-03 19:44:55 +00:00
Bill Lin
a1221bcd53 2/ Notify adjust touch slop when one handed mode activated
When one handed mode activated, user swipe-up to exit usually
cross over the NavBar region, and then invoke TouchController
intercept touch event to trigger All Apps drawer on Home.

To enhanced the UX of gesture conflict of exit OHM & All Apps,
notify TouchController throught LauncherActivityInterface,
and Launcher dispatch onOneHandedModeStateChanged() event to
all mTouchControllers in DragLayer that touchController can
adjust the touch slop by it's SingleAxisSwipeDetector.

Test: manual trigger One handed mode and swipe-up to exit
Test: monitor minDisplacement of SingleAxisSwipeDetector
      OHM activated : touchSlop x multiplier
      OHM deactivated : touchSlop x 1
Test: check All Apps doesn't mis-trigger when exit one handed mode
Bug: 186235522
Change-Id: I7b9e6e7fa898231697d1866186a5f9b1717a9aa3
2021-06-04 01:44:51 +08:00
Bill Lin
945bb34b5e 1/ Provides feasibility to adjust touch slop in TouchController
There is a case when one handed mode triggered(Activated), all apps
drawer is very easy to trigger while user swipe up around NavBar
region to exit one handed mode. Since System Gesture monitor regsion
is small on screen bottom, swipe-up gesture usually cross over NavBar
monitor region and invoke launcher touch controller intercept touch
event and introduce unexpectedly trigger all apps drawer.

Adding onOneHandedModeStateChanged(boolean activated) for controller
be able to adjust the touch slop by multiplier, we can set a larger
multiplier when the visible window size translate become smaller
and make swipe gesture not too sensitive.

Test: manual swipe up to swich "home <-> all apps" and monitor
      minDisplacement of SingleAxisSwipeDetector
Test: Trigger one handed mode and swipe up to exit one handed mode
      check the minDisplacement of SingleAxisSwipeDetector
Bug: 186235522
Change-Id: I9729cd408d85b2b22582bf800e28d1471fc06980
2021-06-04 01:44:50 +08:00
Alex Chau
822acf4d25 Make quick switch track finger 1:1
- When calculating motion delta, it should consider the scale of pagedView
- Adjust significant threshold of tablet quick switch to 15% of page width (roughly 100dp)

Fixes: 188786242
Test: manual on quick switch
Change-Id: Idaa6c5b721decb573e97158c5fbcd67fa224f9d1
2021-06-03 18:07:52 +01:00
Jon Miranda
4981118478 Only inset widgets if workspaceTopPadding is greater than the widget padding.
This prevents widget from becoming too close to status bar.

Bug: 189724771
Test: manual
Change-Id: I86f83b6a35bd2802bdbdf175340a379b498f481d
2021-06-03 09:54:45 -07:00
Stevie Kideckel
d7dc5702f6 Use scrollToPositionWithOffset in widget list and account for padding
Also, scroll after collapsing as well to preserve the header position.
LinearLayoutManager seems to not count/double count the top padding of
the RecyclerView when scrolling to the position. Scrolling with the
offset and deducting the top padding works around the issue.

There's still some occasional weirdness that needs to be investigated,
but this works well...most of the time.

Bug: 183378651
Test: locally
Change-Id: I0ba85fb65411991ef781f08a69faaa993a7d7fd0
2021-06-03 16:18:32 +00:00
Stevie Kideckel
f94a93ad2c Merge "Scroll to the selected widget picker row after headers are clicked" into sc-dev am: f15214597e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800533

Change-Id: I1107db2070a28d7de9ae2450760c9ac38108ee59
2021-06-03 14:30:05 +00:00
Stevie Kideckel
f15214597e Merge "Scroll to the selected widget picker row after headers are clicked" into sc-dev 2021-06-03 14:15:00 +00:00
Stevie Kideckel
3256647b03 Merge "Use the LayoutManager as the source of truth for visible positions" into sc-dev am: 5cc44eb73e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800536

Change-Id: Ic11f1bc2afc3a7430967b103faf7af56257f5dcd
2021-06-03 11:08:22 +00:00
Alina Zaidi
e57ae67013 Merge "Update scrim in widget pickers." into sc-dev am: c599c90eaa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14776603

Change-Id: Idbdeab5c1af6a57b8779ed6a1ac7b8ab70b077ed
2021-06-03 11:08:18 +00:00
Stevie Kideckel
5cc44eb73e Merge "Use the LayoutManager as the source of truth for visible positions" into sc-dev 2021-06-03 11:00:32 +00:00
Pat Manning
de40c75730 Merge "Prevent clearing home between display size changes." into sc-v2-dev 2021-06-03 10:47:57 +00:00
Stevie Kideckel
eb367e471b Scroll to the selected widget picker row after headers are clicked
This keeps the row in view. Currently, this will scroll the row to the
centre-bottom of the screen due to the top padding being double counted,
but that will remedied in a future CL.

This also resolves the issue where the last row's widgets aren't visible
by handling that case specially

Fix: 188665456
Bug: 183378651
Test: verified locally
Change-Id: I9acb9087a8cdaf130ac5955c810c96462b368f36
2021-06-03 09:48:21 +00:00
Stevie Kideckel
abd33b38e2 Use the LayoutManager as the source of truth for visible positions
During animations, the view group child may not correspond to the
visible views that appear at the top.

The previous logic is kept in the case that the layout manager returns
null for any reason, which can happen before layout has occurred for the
position.

Fix: 189588014
Test: verified locally
Change-Id: Ie8b5dcef50287e9e90a21f86e30a1ebcbbcba30f
2021-06-03 09:36:22 +00:00
Alina Zaidi
8796707172 Update scrim in widget pickers.
Also adjust padding in pin widget bottom sheet.

Test: Tested manually
Bug: 189802334
Change-Id: Ic25547ab1519139afdbf07aaefeb9168cf3501ff
2021-06-02 20:39:28 +01:00
Pat Manning
67094bfdfb Prevent clearing home between display size changes.
Split display support was previously based on the sizes of supported device profiles. If a device supporting split display increased display size too much, it could trigger a grid migration (due to number of hotseat icons displayed vs in the DB changing as it was no longer seen as split display). The migration would not run however, as the grid had not actually changed, but would still have cleard the DB in preparation of the migration.

By counting the number of supported profiles instead, we can estimate the number of screens invariant of display size changes and avoid undesired grid migrations.

Test: manual
Fix: 187689871
Bug: 187689871
Change-Id: If740c501cab0e80ef6144356ec5618ee30134ed7
2021-06-02 16:18:55 +00:00
TreeHugger Robot
da91a85359 Merge "Revert "Add haptic feedback to Launcher recent apps scrolling"" into sc-dev am: f5af5ce11f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14793398

Change-Id: Ic5a7e1fc9f5ac07f84b10496b1f3ece2bf8e8b8f
2021-06-01 23:41:10 +00:00
TreeHugger Robot
f5af5ce11f Merge "Revert "Add haptic feedback to Launcher recent apps scrolling"" into sc-dev 2021-06-01 23:39:39 +00:00
Wale Ogunwale
0e25d2eba8 Revert "Add haptic feedback to Launcher recent apps scrolling"
This reverts commit b1ef5e5c55.

Reason for revert: b/182382085#comment4

Change-Id: I001944da64dc05324b14cc9dd3db5921faf8806c
Bug: 182382085
2021-06-01 22:10:18 +00:00
Steven Ng
8e74a1f2a7 Merge "Show app widget resize frame after launcher state change" into sc-dev am: c58b204926
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14733440

Change-Id: I347e1fae2221f478cc7cab478e3924ea8a131eb8
2021-06-01 21:31:34 +00:00
Steven Ng
6ed0112871 Merge "Fix add extra empty screen logic" into sc-dev am: a45ea6cf33
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14717704

Change-Id: I69033f2b4ca9f3508ed31125bb9b74a09dd32829
2021-06-01 21:31:30 +00:00
TreeHugger Robot
c3629c8e9c Merge "Cleanup state properly when interacting during gesture nav transition" into sc-dev am: b13200c6b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14735875

Change-Id: Icea54a23541cdd1791d9adc1c5dde67bbd6583c9
2021-06-01 21:31:25 +00:00
TreeHugger Robot
d46e3b0322 Merge "Fixing deadlock when surface creation is waiting on surface destroy" into sc-dev am: 9ccd3c5e12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14773075

Change-Id: Ifbfcb12c653035489552644e3afe4f524ee69c23
2021-06-01 21:31:20 +00:00
Steven Ng
c58b204926 Merge "Show app widget resize frame after launcher state change" into sc-dev 2021-06-01 21:11:01 +00:00
Steven Ng
a45ea6cf33 Merge "Fix add extra empty screen logic" into sc-dev 2021-06-01 21:04:55 +00:00
TreeHugger Robot
b13200c6b1 Merge "Cleanup state properly when interacting during gesture nav transition" into sc-dev 2021-06-01 21:02:29 +00:00
TreeHugger Robot
9ccd3c5e12 Merge "Fixing deadlock when surface creation is waiting on surface destroy" into sc-dev 2021-06-01 21:00:19 +00:00
Brian Isganitis
25bf26ff4d Merge "Create settings activity layout with explicit toolbar" into sc-dev am: d9463fbfdd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14738956

Change-Id: I26c09f9a1da137cc194a0215d085ffc4fa09a4f0
2021-06-01 20:36:26 +00:00
Brian Isganitis
d9463fbfdd Merge "Create settings activity layout with explicit toolbar" into sc-dev 2021-06-01 20:15:15 +00:00
Jonathan Miranda
1676ef9700 Merge "Turn off app close flag, Revert back to R implementation." into sc-dev am: d8035e1821
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14750661

Change-Id: Iee90e5897e98c8e06ea957c0b5f8418936c7d866
2021-06-01 19:52:01 +00:00
Jonathan Miranda
2abc3933ed Merge "Change folderFillColor to colorBackgroundFloating." into sc-dev am: dfde41cf1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14754919

Change-Id: I7d4b2b8f1dbd68032677134a20b09b2a28fdb2b5
2021-06-01 19:51:40 +00:00
Alina Zaidi
f14a4682b6 Merge "Add more education tips for widgets. (2/3)" into sc-dev am: 8a8c36cca9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14678271

Change-Id: I54f4236c54a56fa6c6945f2bd72f9530badccd00
2021-06-01 19:50:57 +00:00
Sunny Goyal
4c29af3a6d Fixing deadlock when surface creation is waiting on surface destroy
Bug: 189049869
Test: Manual
Change-Id: I0f92d3666dab81bc381163d93530119d45c4fdbd
2021-06-01 12:36:38 -07:00