Commit Graph

12092 Commits

Author SHA1 Message Date
Samuel Fufa
2c86122fa4 Resolve auto close on widget swipe
Bug: 172891360
Test: Manual
Change-Id: Icb384b6dc5ec9a29b6a9a7811b862a2d83ca11a7
(cherry picked from commit 5fa6f3ce503cde51687985ebc9dee6f163b9b1ea)
2020-11-17 18:34:46 +00:00
Sunny Goyal
54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
Schneider Victor-tulias
7bbec50031 Fix AllAppsSearchPlugin icon redrawing without special-casing.
Preventing icon animations in deep shortcuts fixed the icon redrawing issue in the all apps search page, however other icons could still be redrawn, yet could not be special-cased without removing icon update animations altogether. Added logic to only animate icon updates outside of the all apps search page.

Demo: https://drive.google.com/file/d/1ReT2O_1tV20terY0Jr1NJGxIxPblHCK4/view?usp=sharing

Change-Id: Ibe0b43801ec5340c3551125aef13170d569d2c55
2020-11-12 10:31:20 -05:00
TreeHugger Robot
c32e39f1db Merge "Fix OutOfBounds issue on getFocusedChild" into ub-launcher3-master 2020-11-11 21:56:54 +00:00
Pinyao Ting
af0391f9b2 Include more error logging for widget restore
Bug: 171774227
Test: manually tested complete backup & restore flow
Change-Id: Ieb4b39d80a24b4dff377ee74d24d9010acd0daca
(cherry picked from commit ae1997b9d5)
2020-11-11 19:36:09 +00:00
Samuel Fufa
437513d5ef Federate SliveLiveData for Search results
Instead of every slice result creating its own live data, we should manage a single SliceLiveData per url that SliceViews can observe.

Bug: 173022319
Test: Manual
Change-Id: Ieaf599aadfac40450be4f39657d3cefb70644e0c
2020-11-11 12:48:40 -06:00
Samuel Fufa
c25bc0335b Fix OutOfBounds issue on getFocusedChild
In cases where search only shows items that don't require focus highlighting,getFocusedChildIndex returns -1.

Bug: 13023194
Change-Id: I6145ae26e3953c5fc4fd1ed1696eb931017cac0f
2020-11-11 11:31:54 -06:00
Samuel Fufa
9ee4e86cf8 Merge "Search support for widgets with config activity" into ub-launcher3-master 2020-11-11 16:21:01 +00:00
Pinyao Ting
ae1997b9d5 Include more error logging for widget restore
Bug: 171774227
Test: manually tested complete backup & restore flow
Change-Id: Ieb4b39d80a24b4dff377ee74d24d9010acd0daca
2020-11-10 16:53:25 -08:00
Hyunyoung Song
f62b8a93c0 Merge "IME stability" into ub-launcher3-master 2020-11-10 18:45:00 +00:00
Samuel Fufa
ffd2b6d25e Search support for widgets with config activity
Shows widget preview in search if widget requires config.

preview: https://drive.google.com/file/d/1q1ROu7-OUGfskDMRxXPNQMdr3T-WMMkv/view?usp=sharing
Bug: 168321831
Test: Manual
Change-Id: I6c1c168ebac4ce33a4234e8a417eba789f664f43
2020-11-10 10:16:02 -06:00
Hyunyoung Song
90a43a5f00 IME stability
Bug: 170739594

Change-Id: Ib667c6dfb321411d59e728a1f34d4803f7293f05
2020-11-10 00:54:46 -08:00
TreeHugger Robot
bbaf9ff6f8 Merge "Fix NPE inside getFocusdChild" into ub-launcher3-master 2020-11-10 07:05:41 +00:00
Hyunyoung Song
3a4caed1f3 Fix NPE inside getFocusdChild
Bug: 172883035
Change-Id: Iea3e07165cdaa45031ee5bbc11add5c115cab366
2020-11-09 22:19:37 -08:00
Samuel Fufa
104463a1e2 Merge "Polish search result icons" into ub-launcher3-master 2020-11-10 03:10:56 +00:00
Samuel Fufa
81de07e405 Polish search result icons
SearchResultIconRow consumes a loaded ItemInfoWithIcon from its child SearchResult and updates other siblings with itemInfo.

preview: https://drive.google.com/file/d/1ijZsR5Q6M0DeZdlRJWpRb4AKmmTLBElY/view?usp=sharing
Change-Id: Ibb3fb697494749fd2e886dcdaa93241767a65944
2020-11-09 19:33:58 -06:00
TreeHugger Robot
d7f0ead7e5 Merge "Dismissing popup if the underlying icon no longer supports it" into ub-launcher3-master 2020-11-09 23:41:12 +00:00
TreeHugger Robot
06849da424 Merge "Resolve search scroll hightlight issue" into ub-launcher3-master 2020-11-09 23:30:22 +00:00
Samuel Fufa
3116dc918f Resolve search scroll hightlight issue
After getting the index of the first item that should be highlighted, Section decorator should not assume getChildAt(index) will return item at position. Instead use findViewHolderForAdapterPosition.

Bug: 170665892
Change-Id: Id81d021bde8868184013e8d51e49af7842b64125
2020-11-09 16:35:43 -06:00
Sunny Goyal
1818fb7a6e Dismissing popup if the underlying icon no longer supports it
Bug: 168641545
Change-Id: Ia4f44819af02397efaead935db3fc8e305e47ba7
2020-11-09 14:33:24 -08:00
Samuel Fufa
20d99c5229 Support drag/drop on live widget search results
Preview: https://drive.google.com/file/d/1p0BMoQTaatwcslzPWoD5W_ZWQms5GpSp/view?usp=sharing

Bug: 168321831
Test: Manual
Change-Id: I237546a884083372d5d1ca80f500504b9fd9ba86
2020-11-09 16:16:26 -06:00
Samuel Fufa
a204de7d12 Merge "Initial setup for widgets in Search" into ub-launcher3-master 2020-11-09 18:33:51 +00:00
Hyunyoung Song
003859cdd0 Show remote action's description in SearchResultIconRow
Validated against Pixel Tips corpus

Change-Id: I3c3f8eb69007a97e55e2ef08e7f4e0b800bfe247
2020-11-09 01:38:20 -08:00
Samuel Fufa
37432444fc Initial setup for widgets in Search
LiveSearchManager creates AppWidgetHost when user starts a new search session and destroys it when user returns to home. In addition, it also manages the creation and caching of PlaceholderSearchWidget which can be used to create AppWidgetHostViews.
Bug: 168321831
Test: Manual

Change-Id: I06a893028e55aa6e0702a4f1cd7a2edbb1f61671
2020-11-07 10:07:33 -06:00
Samuel Fufa
984e0d0a63 Show settings icon at start of settings results
Bug: 170792963
Test: Manual
Screenshot: https://screenshot.googleplex.com/MVBtDZGtQ3aChwU
Change-Id: I16a28a7bd9e3129b40102e020cd7c0111e6fe29b
2020-11-06 10:14:41 -06:00
thiruram
d15915f5fd Fixes invalid ids for UiEvents: LAUNCHER_FOLDER_CONVERTED_TO_ICON, LAUNCHER_HOTSEAT_PREDICTION_PINNED
Bug: 169100235

Change-Id: I1cae4e61b97947c5a7e56daeaccac0ece55f021c
2020-11-06 02:09:34 +00:00
Sunny Goyal
ff9e7d6aa9 Removing separate Cancel and End callbacks and using AnimationListener instead
This removes the additional step of invoking these callbacks separately

Change-Id: I0b60047a44f179ba725f15b1e791e336884869c9
2020-11-05 16:35:11 -08:00
Samuel Fufa
171ad424a7 Merge "Consolidate Hero search result with SearchResultIconRow" into ub-launcher3-master 2020-11-05 18:58:06 +00:00
Samuel Fufa
6e5efb0929 Consolidate Hero search result with SearchResultIconRow
With this, we can now show app title and support drag/drop for shortcut results.

Bug: 172245107
preview: https://drive.google.com/file/d/1A4eKKTDPht-MDbfA2VFI3OuAO36fc3AS/view?usp=sharing
Change-Id: Icf94a2d23b44bfe5527aea71e27178906e5deb3e
2020-11-05 11:57:35 -06:00
Tracy Zhou
ae567f96f6 Merging from ub-launcher3-master @ build 6952418
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6952418.html

Change-Id: Id8ec665ff7be486b794807f6524e385728ea7717
2020-11-04 12:33:10 -08:00
Tony Wickham
22a5a68464 Fix a couple notificaiton dot issues
Fixes: 172010602 by adding drawDotIfNecessary() back to BubbleTextView
Fixes: 167272638 by overriding drawDotIfNecessary() to do nothing in
DeepShortcutTextView

Change-Id: I0bfbbc6e27dedac73ae97c5a084412ce1aba11e4
2020-11-02 17:04:58 -08:00
TreeHugger Robot
a1733bceb7 Merge "fix the issue widget id can be wrong after restore" into ub-launcher3-master 2020-10-29 17:30:35 +00:00
TreeHugger Robot
90faddeff3 Merge "Quick fix from ag/12914139" into ub-launcher3-master 2020-10-29 06:38:13 +00:00
Tracy Zhou
991e8208cc Quick fix from ag/12914139
Test: N/A
Change-Id: I0b8274f8a912d091cfbbebafdee220b5e46ee74f
2020-10-28 22:34:23 -07:00
Pinyao Ting
f39f351a0d fix the issue widget id can be wrong after restore
Bug: 171774227
Test: manual testing
1. randomly add/remove widgets to workspace
2. create a backup (Settings > System > Backup)
3. reset the device
4. restore from the backup
5. verify all of the widgets are restored properly

Change-Id: Id65e474dd9349aca715d7e6b88f8d58bc63066ae
2020-10-28 22:04:35 -07:00
TreeHugger Robot
a90ddeea57 Merge "Settings/Play/Suggest layout polish" into ub-launcher3-master 2020-10-28 22:12:52 +00:00
TreeHugger Robot
8f48f23039 Merge "IME bounds after DOWN->UP Motion event sequence" into ub-launcher3-master 2020-10-28 21:22:51 +00:00
Hyunyoung Song
a34766a176 IME bounds after DOWN->UP Motion event sequence
Bug: 170739594

Change-Id: I1aa8dd2ced7c017e57d3c14c02d5b78900a46caa
2020-10-28 12:49:56 -07:00
Joshua Trask
b0f897cda8 Merging from ub-launcher3-master @ build 6934851
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6934851.html

Change-Id: Ie082cfabfc07e26db9d0bbb563376291b2b30491
2020-10-28 12:13:40 -04:00
TreeHugger Robot
426f6ac276 Merge "Use event time of app side for latency metrics" into ub-launcher3-master 2020-10-28 10:40:27 +00:00
Riddle Hsu
b30adcb232 Use event time of app side for latency metrics
There are 2 reasons not to use MotionEvent#getEventTime:
1. There is an existing TouchEventReported metric for touch latency.
2. In instrumentation test, the event time is set when creating
   the motion event for injection. It may cause the results to be
   5 times slower than the real case. That may lead to miss the
   cost from app to system.

Bug: 166614700
Test: Enable statsd log: "adb shell cmd stats print-logs"
      Touch gesture navigation bar or launch app from launcher.
      adb logcat | grep statsd | grep "(48)"
Change-Id: Ica5e7df685fe737bbc3ac60c3ec35bad15466726
2020-10-28 09:13:48 +00:00
Tracy Zhou
55940ecfc7 Render and track live tile position when launching another app from Overview
Fixes: 165394366
Fixes: 170338328
Test: Manual
Change-Id: Idfcd423cbe062af33564eaa9e83ec21fbac0cdf9
2020-10-27 15:45:01 -07:00
TreeHugger Robot
a48f6efbe1 Merge "Integrating snapshot logging in Launcher" into ub-launcher3-master 2020-10-27 19:08:01 +00:00
Sunny Goyal
b694a69f53 Integrating snapshot logging in Launcher
> Workspace snapshot is logged when the workspace loads (at most once a day)
> Removing unnecessary thread jumping when logging folders
> Preference snapshot is logged on process start and whenever something changes

Change-Id: I93767de89b11522d843c0e8300d1f108c78f6d90
2020-10-27 11:25:43 -07:00
Hyunyoung Song
9fc27da5f8 Settings/Play/Suggest layout polish
Bug: 170792963
Bug: 170750779
Change-Id: I69b09f5360e165c3b1b33e259cdd0f390ce6fa60
2020-10-27 16:45:54 +00:00
Schneider Victor-tulias
47dfc3a3ca Merge "Fix All Apps Search plugin shortcut icon redrawing issue." into ub-launcher3-master 2020-10-26 20:57:17 +00:00
TreeHugger Robot
f9317597ef Merge "Add a feature flag to expand smartspace to three rows" into ub-launcher3-master 2020-10-26 18:37:26 +00:00
Schneider Victor-tulias
3ee7018227 Fix All Apps Search plugin shortcut icon redrawing issue.
BubbleTextViews animate the update from their placeholder icons to their high res icons. Added a field to allow restricting what BubbleTextViews' icon updates should be animated. Updated SearchResultIconRow to store the icon Drawable rather than the resource id to prevent unecessary redrawing.

Fixes: 170966269

Demo: https://drive.google.com/file/d/1FBdEl11mHZk1SpCMRY4XZAGt5TVZ01W4/view?usp=sharing

Change-Id: Ib55dafdf5b5fed00d343af5f95f3dd3f08c4ee8e
2020-10-26 14:25:35 -04:00
TreeHugger Robot
bc3a5d516e Merge "[pixel-search] URGENT: bug fix for teamfood: fix crash when tapping on a screenshot result" into ub-launcher3-master 2020-10-23 23:23:52 +00:00
Hilary Huo
9c43bfa798 [pixel-search] URGENT: bug fix for teamfood: fix crash when tapping on a screenshot result
Bug: b/171596755
Change-Id: I125404dbe5a4e5f8e3bdc233e3a82db3dca48f42
2020-10-23 15:48:12 -07:00