Commit Graph

12092 Commits

Author SHA1 Message Date
Brian Isganitis
a905601cfd Merge "Use wallpaper colors for widgets in wallpaper change preview" into sc-v2-dev 2021-06-22 18:47:08 +00:00
Jon Miranda
fa1e14c4b8 Polish folder icon bugs.
- Fix bug where folders are misaligned.
- Fix bug when closing on 2nd page of large folder.

Bug: 184822585
Test: drag folder originally in hotseat to workspace, vice versa
      test on grid where isScalable=true and isScalable=false

Change-Id: I08a79b8d280df3e3974baaa07e80db6bc4165e58
2021-06-22 11:12:47 -07:00
Cyrus Boadway
db9d5cf3fd Merge "Suppress Splash Screen on widget reconfiguration activity start" into sc-dev am: 719be9a9e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15062774

Change-Id: Ia0ffb706d5cc9f9d5adc169b8308445f0accba9a
2021-06-22 12:49:55 +00:00
Cyrus Boadway
719be9a9e4 Merge "Suppress Splash Screen on widget reconfiguration activity start" into sc-dev 2021-06-22 12:30:23 +00:00
Steven Ng
8a46c403e0 Merge "Update all apps & widget pickers personal / work tabs" into sc-dev am: cec6edf78e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15027782

Change-Id: Ia69538b6b15cb6ab6ce5fa9a2f4f42b2d0664d58
2021-06-22 10:47:31 +00:00
Steven Ng
cec6edf78e Merge "Update all apps & widget pickers personal / work tabs" into sc-dev 2021-06-22 10:37:00 +00:00
Cyrus Boadway
263a00c738 Suppress Splash Screen on widget reconfiguration activity start
When a widget configuration activity is started, it's started from
the launcher. Under some circumstances the launcher's splash screen
would be shown, rather than the splash screen corresponding to the
tapped app.

To avoid confusion, we suppress the splash screen for configuration
starts.

Bug: 190153065
Test: manual
Change-Id: Ib18851f1bb50b64bc5d47b8aa5931490c969b54b
2021-06-22 09:22:33 +00:00
Sunny Goyal
49537a8942 Merge "Simplifying Launcher binding callbacks" into sc-v2-dev 2021-06-22 03:42:28 +00:00
Brian Isganitis
4a76315805 Use wallpaper colors for widgets in wallpaper change preview
Test: Widgets should adapt to new wallpaper colors in launcher preview.
Bug: 191499358
Change-Id: I3fb76b6036cb909771b789eac15742df78c2c742
2021-06-21 19:18:17 -04:00
Sunny Goyal
a29220f6b6 Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: I0361531f4ff2695d97b5e48c5abc0c40fe505112
2021-06-21 22:42:06 +00:00
Sunny Goyal
b3eafe97bb Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev 2021-06-21 22:32:23 +00:00
Steven Ng
50f1ff1808 Update all apps & widget pickers personal / work tabs
Test: Open all apps to confirm tab style match the mock in both dark &
      light mode.
      Open widgets picker to confirm tab style match the mock in both
      dark & light mode.
Bug: 191387242
Change-Id: Ie0111f65813128fef5befbdefd451cf0e9f01be9
2021-06-21 22:02:54 +01:00
Sunny Goyal
de644313b0 Fixing animation end not-called when cancelling state the animation recursively
Bug: 190856140
Test: Manual
Change-Id: I5d6a00c1d1c0e95e615b7f2115e3e4ebb56b987f
2021-06-21 13:47:49 -07:00
Brian Isganitis
96f496df03 Merge "Revert "Fix home settings landing page"" into sc-dev am: fe139cdf69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15030323

Change-Id: I7a9b72f099c4e8908615cc8a7b13aa69b72e0f41
2021-06-21 20:08:20 +00:00
Stevie Kideckel
f792c64c6a Merge "Add spacing between items as decorations instead of margins" into sc-dev am: e03784478d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15028527

Change-Id: Iccc9f7d9b3add624b47557350cd85567b17206b1
2021-06-21 19:59:36 +00:00
Steven Ng
99db0b2bd1 Merge "Copy minSpanX & minSpanY when copying from an existing ItemInfo" into sc-dev am: 95c969530c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15046761

Change-Id: Icb87afa869ba70652911b779ec8163fc12f2ba92
2021-06-21 19:58:41 +00:00
Brian Isganitis
fe139cdf69 Merge "Revert "Fix home settings landing page"" into sc-dev 2021-06-21 19:27:24 +00:00
Stevie Kideckel
e03784478d Merge "Add spacing between items as decorations instead of margins" into sc-dev 2021-06-21 16:47:30 +00:00
Steven Ng
95c969530c Merge "Copy minSpanX & minSpanY when copying from an existing ItemInfo" into sc-dev 2021-06-21 16:20:39 +00:00
Tony Wickham
0ac023196d Merge "Initial commit of taskbar stashing" into sc-v2-dev 2021-06-21 15:56:12 +00:00
Stevie Kideckel
ded80076db Add spacing between items as decorations instead of margins
There are bugs in the accounting for the margins if we manipulate the
view directly, causing the wrong top to be reported and the view to be
shifted when we call scrollToPosition. Item decorations ensure that the
layout system for the recycler view always has the right details about
the spacing.

Fix: 191642682
Test: verified locally
Change-Id: Ie80563757079e885c8178883ab16e314d01c5b32
2021-06-21 15:11:33 +00:00
Steven Ng
7b27e7d061 Copy minSpanX & minSpanY when copying from an existing ItemInfo
Test: Drop Gmail widget to home screen and configure it. Then, drop
      the widget to a home screen that doesn't have sufficient space
      to accommodate it. The gmail widget can't be dropped to that
      home page and is returned to its original position.
Fix: 190582606
Change-Id: I177c09562d059b658e835cbb7fdde0d7bc6565d2
2021-06-21 15:38:26 +01:00
Stevie Kideckel
222a315351 Merge "Fix bug in equals implementation for search headers" into sc-dev am: 61bc5c6c93
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15046752

Change-Id: I8ec156650e0ff98c2b32a5d5c96e8483558b97f6
2021-06-21 13:14:40 +00:00
Stevie Kideckel
e99f3c9666 Fix bug in equals implementation for search headers
Fix: 191626327
Test: verified locally
Change-Id: I8103059a2759a8533581ff86cb57b28913cf5731
2021-06-21 10:42:16 +00:00
Vinit Nayak
3fcc02b8dc Merge "Add IDs to buttons in 3 button nav for Taskbar" into sc-v2-dev 2021-06-19 05:51:57 +00:00
Jonathan Miranda
11a9b035f3 Merge "Update notification popup UI." into sc-dev am: 1bfd350ead
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15017911

Change-Id: I468cd0896be43857ce188186cfda9f3ae94c07fb
2021-06-19 04:11:19 +00:00
Jonathan Miranda
1bfd350ead Merge "Update notification popup UI." into sc-dev 2021-06-19 03:52:23 +00:00
Vinit Nayak
b974a86c8f Add IDs to buttons in 3 button nav for Taskbar
Bug: 191449914
Test: testSwitchToOverview passes
See bug for more details

Change-Id: I108bbe7607181680bca7cb5fad5e7289191edde6
2021-06-18 18:20:44 -07:00
Tony Wickham
3fd22847ac Initial commit of taskbar stashing
- Added StashedHandleViewController to provide properties such as ViewOutlineProvider to animate the handle that's shown in place of taskbar while it's stashed
- Added TaskbarStashController to coordinate the stashed state, including orchestrating the animation across taskbar controllers
- Added TaskbarStashInput consumer to detect long press in the nav region when taskbar is stashed

Behavior:
- Long pressing taskbar background animates to the stashed state by morphing the TaskbarView into the stashed handle view and offsetting the background offscreen
- We persist the stashed state across app launches and reboot; to unstash, long press the stashed handle
- We also visually unstash when going back home

Test: long press tasbkar background when in an app to stash it, long press the resulting stashed handle to unstash; while stashed, swipe up to home to also unstash until launching another app
Bug: 189503603
Change-Id: I698eff785388dff1ef717c76879719d6af236c2d
2021-06-18 17:51:39 -07:00
Brian Isganitis
aefcc5a300 Revert "Fix home settings landing page"
This reverts commit 96cc3c533c.

Reason for revert: Causes back to close sub-settings (b/191257243).

Change-Id: I3aa01bed1d73874176fc2568bac4ca714e9f2df7
Bug: 188565060
2021-06-18 23:46:20 +00:00
Stevie Kideckel
50820e1fb5 Merge "Load widget preview images before adding the rows to the adapter" into sc-dev am: dd19a24769
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14965044

Change-Id: If6b6e437f558922aa0f047c4ce01bb424a0045ae
2021-06-18 22:44:39 +00:00
Jonathan Miranda
c42dd630a5 Merge "Fix bug where ripple extends out of bounds in pop up container." into sc-dev am: 576179199a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15019204

Change-Id: Ibb09b7ed793f217425fac3c8c716dda9ec8c6515
2021-06-18 22:44:20 +00:00
Jon Miranda
313b2c2d28 Update notification popup UI.
- Update UI to match specs.
- Only shows one notification (removed footer, animation code)

Bug: 175329686
Bug: 190402054
Test: open popup, dismiss notification from shade,
      open popup, click on notification
      checked RTL

Change-Id: I92672f94233d986ae5b5c54979980967308cb156
2021-06-18 22:42:44 +00:00
Stevie Kideckel
dd19a24769 Merge "Load widget preview images before adding the rows to the adapter" into sc-dev 2021-06-18 22:37:32 +00:00
Jonathan Miranda
576179199a Merge "Fix bug where ripple extends out of bounds in pop up container." into sc-dev 2021-06-18 22:27:45 +00:00
Jon Miranda
f13ddbd333 Fix bug where ripple extends out of bounds in pop up container.
Bug: 186820908
Test: test apps with diff. pop up container arrangements
      test prefs in all apps

Change-Id: I4d3e26871416835ab2a851fcc6fe2c4f70235b62
2021-06-18 20:58:14 +00:00
Brian Isganitis
c79d577f18 Load widgets in wallpaper app launcher preview
Test: Widgets in wallpaper app launcher preview rendered
Bug: 185306338
Change-Id: I38569d2ff0b64ba55eb188afa42fba4100aae7ff
2021-06-18 15:47:56 -04:00
Stevie Kideckel
a093523299 Load widget preview images before adding the rows to the adapter
This allows for smooth animations as the items will have their full
height resolved

Bug: 190892517
Test: verified locally
Test: CachingWidgetPreviewLoaderTest
Change-Id: I86afc6951a4cc82ae45e63795791d259a3bb3cda
2021-06-18 19:18:29 +00:00
Samuel Fufa
485796e814 Merge "Allow AllApps to restore current selected tab on activity recreate" into sc-dev am: f44a9ca6f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15014304

Change-Id: Ifbedb11e2c42d66e04093f0ddc7dd983ab27c1b7
2021-06-18 18:12:59 +00:00
Samuel Fufa
f44a9ca6f0 Merge "Allow AllApps to restore current selected tab on activity recreate" into sc-dev 2021-06-18 17:57:08 +00:00
TreeHugger Robot
d352253c2d Merge "Revert "Deduct padding from widget size only if padding has been inset"" into sc-dev am: 2af9d27116
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15026671

Change-Id: Ifd10e8688d2f5e3c67be615b03e8a403de26a02d
2021-06-18 11:21:07 +00:00
TreeHugger Robot
2af9d27116 Merge "Revert "Deduct padding from widget size only if padding has been inset"" into sc-dev 2021-06-18 11:11:20 +00:00
Steven Ng
2c1fb29d26 Merge "Log widget dimensions before deleting a widget violating min size" into sc-dev am: 21780405ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15015050

Change-Id: I8e2b4160bef59aa17f131a384642975eb0bfbd2c
2021-06-18 10:38:35 +00:00
Steven Ng
21780405ac Merge "Log widget dimensions before deleting a widget violating min size" into sc-dev 2021-06-18 10:21:32 +00:00
Steven Ng
54b5424548 Revert "Deduct padding from widget size only if padding has been inset"
This reverts commit 71cefb593f.

Reason for revert: The default padding is added by the framework not the launcher. We really need to subtract padding from the size.

Bug: 190498032
Change-Id: If7f164da34aec3d8e022ef2c752b72292cca0489
2021-06-18 09:37:44 +00:00
Steven Ng
cbec62d33c Merge "Use relative bounds for app widget color extraction" into sc-dev am: be397e85e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15016211

Change-Id: I0aad84636553bd80252613c7df269448b094727e
2021-06-18 09:17:53 +00:00
Steven Ng
be397e85e8 Merge "Use relative bounds for app widget color extraction" into sc-dev 2021-06-18 09:01:25 +00:00
Steven Ng
058308098b Use relative bounds for app widget color extraction
Fix 2 bugs in this CL
1. Before this CL, getBoundsForViewInDragLayer returns absolute bounds
   for widgets. What we want is the bounds of a widget when it is
   visible in the drag layer. ViewGroupFocusHelper#viewToRect has
   taken PagedView into account. This makes it a prefect candidate to
   calculate relative bounds of a widget.
2. requestLayout at the end of endDrag is problematic due to the drop
   animation. If the drop animation is still in progress when onLayout
   is called, the bounds of the widget isn't final. Since the color of
   app widget right before is already the final color. We don't really
   need to update the color extraction.

Test: Set the wallpaper and clock widget according to the bug. Then,
      reboot the device. The clock widget color shown right after
      reboot is the expected color. Long pressing the widget doesn't
      cause a color change.
Fix: 191114337
Change-Id: I466c8102dba0e5b207b3768e0935472cbd523235
2021-06-17 23:25:57 +01:00
Sunny Goyal
4a48a988c8 Simplifying Launcher binding callbacks
> Making all methods as default
> Removing obsolete logic around synchronous binding
> Removing some UI dependencies from bind callbacks

Bug: 187353581
Test: Manual
Change-Id: I0d2bbb060af2cab7c64541d7695055629dfaf0b8
2021-06-17 15:21:01 -07:00
Samuel Fufa
e79b469986 Allow AllApps to restore current selected tab on activity recreate
This CL also fixes:

- Wrong tab selection on RTL
- Fixes header protection hydraulic scroll issue
- Work toggle button text background contrast

Bug: 186005219
Bug: 191250799
Bug: 191227662
Bug: 191349226
Test: Manual
Change-Id: I3777474c954ed0d542ac38ff552367904be147d3
2021-06-17 16:59:56 -05:00