Commit Graph

12092 Commits

Author SHA1 Message Date
TreeHugger Robot
46d420bf14 Merge "Add funtional animation for SplitSelect from Grid." into sc-dev 2021-05-05 19:03:47 +00:00
Jon Miranda
2955fa8f5c Add method to check if popup supports color extraction.
Bug: 187058092
Test: manual
Change-Id: I795cd3bfd04a7ab9b4730a2e7d7618830faae37e
2021-05-05 11:20:20 -07:00
Steven Ng
16d74e5d7f Merge "Fix class cast exception in a11y service for widget resize action" into sc-dev 2021-05-05 18:07:53 +00:00
Steven Ng
f8af753b6a Merge "Fix LayoutParams cast exception in drag-n-drop" into sc-dev 2021-05-05 18:07:32 +00:00
Vinit Nayak
bf51afd420 Merge "Set menu item to MATCH_PARENT for tap target" into sc-dev 2021-05-05 17:43:27 +00:00
Vinit Nayak
2dbdddb4ba Add funtional animation for SplitSelect from Grid.
Long ways to go to final UI - TODO(b/186800707)
Add comments to grid layout code,
no functional changes at all.

Bug: 181705607
Test: Enter split screen from overview task menu
in grid and carousel. Able to select all items
and enter split.

Change-Id: Ib62f1b286acf0781ec47862fa31b670e6ff1892a
2021-05-05 09:38:42 -07:00
Cyrus Boadway
aee5339869 Enable Quickstep widget launch and return animations
Turn on new widget animations by default.

Bug: 169042867
Test: manual
Change-Id: Ie35660c798731f5e3d341c8135adb8e2a7683eed
2021-05-05 16:11:48 +00:00
Steven Ng
ac05cb1343 Fix class cast exception in a11y service for widget resize action
Test: Enable talkback. Then navigate to a widget. Trigger talkback
      menu > actions > move. Able to move a widget without crash.
Bug: 186999201
Change-Id: Ic6a66fefd643443e3d5a8839e6f2fe10c946dab2
2021-05-05 15:38:28 +01:00
TreeHugger Robot
e80a0caa81 Merge "Don't crash on dialer app target search results" into sc-dev 2021-05-05 07:08:12 +00:00
Hyunyoung Song
67edf1654c Don't crash on dialer app target search results
Bug: 186412929
Test: manual
Change-Id: Ic1ab6e212d36ca1f711f51d047e4d62106bf0680
2021-05-04 22:29:33 -07:00
TreeHugger Robot
04b5003b2e Merge "All apps motion tuning [1/n]" into sc-dev 2021-05-05 02:58:48 +00:00
Vinit Nayak
1419d40f38 Set menu item to MATCH_PARENT for tap target
Fixes: 186922491
Test: portrait/landscape real and fake
Change-Id: If0247cf75b41374a489331d991a0c273aaf3efee
2021-05-04 19:36:05 -07:00
Hyunyoung Song
96d4ec4544 All apps motion tuning [1/n]
- reverse spring direction to enable overshoot
- change master interpolators for swipe / fling

Test: manual
Bug: 183001675
Bug: 186121789
Change-Id: I5869d84daab99594cc2a261cb8f5d28e0293afe1
2021-05-04 23:59:48 +00:00
Jonathan Miranda
433f5b4290 Merge changes from topic "extractor-utils" into sc-dev
* changes:
  Move color extraction utils to extractor class so each instance can have its own set of temp variables.
  Revert "Revert "Use color extraction for arrow popup.""
2021-05-04 23:09:34 +00:00
Sunny Goyal
c52c0782a7 Merge "Adding support for determining split layout for launcher." into sc-dev 2021-05-04 22:33:38 +00:00
Steven Ng
3e6b93cedb Merge "Add a flag to enable custom local filter for recommended widgets" into sc-dev 2021-05-04 22:02:25 +00:00
Steven Ng
79d76b5041 Fix LayoutParams cast exception in drag-n-drop
Test: Pick up a widget from home screen. Then drop it and immediately
      pick it up again before the resize frame is dismissed. No crash
      is observed.
Bug: 186663184
Change-Id: Ia40676fbbf5d6dc2e2043aa7acd6ae00f1fa4179
2021-05-04 18:46:51 +01:00
Cyrus Boadway
3c94052bb5 Merge "Change flag type to control Quickstep widget app launch" into sc-dev 2021-05-04 17:34:01 +00:00
Jon Miranda
88b7f6a0d5 Move color extraction utils to extractor class so each instance can
have its own set of temp variables.

- Pass in float[] param to not create new obj in each frame
  for dragging widget case.

Bug: 175329686
Bug: 187019711
Test: manual, verify
Change-Id: I4350fb7e66a80c73def5659fb41abc14d357e667
2021-05-04 09:00:01 -07:00
Jonathan Miranda
21930da9a2 Revert "Revert "Use color extraction for arrow popup.""
This reverts commit 17fda29bf3.

Reason for revert: Fixing the memory leak

Leak was detected in caused launcher tapl tests to fail.
For instructions on how to debug leaks, see go/launcher-testing.
Using AS memory profiler, the color extractor class is holding
onto a reference to launcher that has already been destroyed.
The fix is to set the listener to null when view is closed.

Bug: 175329686
Test: run profiler in AS, open and close popups, and verify no leaks

Change-Id: I2d4a87f0481cbc88f3587dce91278e85ca113545
2021-05-04 08:53:58 -07:00
Samuel Fufa
30ffc3f95c Merge changes Ice83b544,If0bc2a6d into sc-dev
* changes:
  [Search][Motion] Modify interpolator for AllApps background scrim
  Cleanup/consolidate normal<->all apps interpolators
2021-05-04 15:06:51 +00:00
Cyrus Boadway
197c909483 Change flag type to control Quickstep widget app launch
Previously we'd relied on a SystemProperties to control which
InteractionHandler was used by Quickstep for widget app launches.

This switches to a more conventional FeatureFlag.

Bug: 169042867
Test: manual
Change-Id: I7abf815c6e204daf996ac0a81b1a354c4e3d5cda
2021-05-04 12:04:36 +00:00
Samuel Fufa
3ab273da0c [Search][Motion] Modify interpolator for AllApps background scrim
Also rename ANIM_WORKSPACE_SCRIM_FADE to ANIM_SCRIM_FADE since
the scrim is shared between states now.

Bug: 183001675
Test: Manual in 3 button and 0 button modes
Change-Id: Ice83b54480bdf74155e8593c421b68d7186cf78a
2021-05-03 21:13:20 -07:00
Tony Wickham
154b1c928b Cleanup/consolidate normal<->all apps interpolators
We no longer need to have a different behavior for no button mode,
so make PortraitStatesTouchController the source of truth

Also remove unused ANIM_ALL_APPS_HEADER_FADE & RECENTS_FADE_THRESHOLD

Test: manually in 0 button and 3 button modes
Bug: 183001675
Bug: 175137718
Change-Id: If0bc2a6d6d3bf1649fad45226a4e6055f30e4880
2021-05-03 21:07:24 -07:00
Sunny Goyal
9ab43772ab Adding support for using themed icons on workspace
Bug: 183641907
Test: Manual

Change-Id: Ieda7e73b3ae4dfe3009e3f23754aff5f8826a967
2021-05-03 20:00:38 -07:00
Sunny Goyal
19ff728b92 Adding support for determining split layout for launcher.
> Simulating the windo wmanager API to get available device
  profiles until final API
> When a device has multiple internal displays, and with both
  tablet and phone possibilities, it uses a split workspace layout

Bug: 186160341
Bug: 175782275
Test: Manual
Change-Id: Ieff2329acac7cdd6b9abe6f96cd459cd45bd0efe
2021-05-03 14:48:28 -07:00
Adam Cohen
0a1b030bb3 Merge "Don't fade out active page outline during drag-and-drop" into sc-dev 2021-05-03 19:15:22 +00:00
TreeHugger Robot
f892756e62 Merge "Revert "Use color extraction for arrow popup."" into sc-dev 2021-05-03 18:27:53 +00:00
Vadim Tryshev
17fda29bf3 Revert "Use color extraction for arrow popup."
This reverts commit 242c805f82.

Reason for revert: Introduces a leak. I haven't seen a bug for it yet, but this CL is the only in the culprit list; the leak can block multiple teams presubmits, and the leak is via ArrowPopup. Enough evidence.
https://fusion2.corp.google.com/invocations/4b50db71-d598-4e52-9076-e91d42b65014/targets

Change-Id: I1700a9eea8705983598aee43c0a63e67c1d9cf71
Bug: 187075409
2021-05-03 18:27:41 +00:00
Sunny Goyal
ada0acd75c Merge "Fixing nullPointer exception when wallpaper colors is null" into sc-dev 2021-05-03 17:59:05 +00:00
Samuel Fufa
db9b483c02 [WorkProfile] Update work/personal tab to pills
Bug: 186857875
Test: Manual
Screenshot: https://screenshot.googleplex.com/89jD32tHqNkBUWb
Change-Id: Ia4bb91372896d8a53017e3eadbe985878ce7f0ec
2021-05-03 10:53:33 -05:00
Hyunyoung Song
e72dd4a859 Call windowInsetController.hide method when hiding keyboard
Bug: 186608200
Test: manual
Change-Id: I9a819aec217a91e8b6de58d074dbdb134dacaeb8
2021-05-02 23:20:55 -07:00
Hyunyoung Song
0c1901bddd Merge "Check IME visibility check before calling IMM.hide()" into sc-dev 2021-05-01 19:32:46 +00:00
Jonathan Miranda
8d7bc38c34 Merge "Use color extraction for arrow popup." into sc-dev 2021-05-01 14:00:41 +00:00
Hyunyoung Song
e25ee1ed98 Check IME visibility check before calling IMM.hide()
Bug: 183062683
Bug: 185558351

Test: manual
Change-Id: Ib3bee0f895cc03c6faeb662d078d013ac4d6e406
2021-05-01 01:50:19 -07:00
Jon Miranda
242c805f82 Use color extraction for arrow popup.
- Updated logic to accept any view that is a a child of draglayer
  (from being workspace dependent)
- Move color extraction logic from widget class to utility class.
- Initial CL, future CL will interpolate between colors
  and expand color extraction to other abstract floating views.

Bug: 175329686
Test: long press on colorful wallpaper and test colors are extracted
      test in multiwindow mode
Change-Id: I18a6bb5013de4eea7e9b45810401f5b9b3cd7302
2021-04-30 15:54:17 -07:00
Sunny Goyal
908e3d1312 Fixing nullPointer exception when wallpaper colors is null
Bug: 186722571
Test: Presubmit
Change-Id: Iee0d15d460de47cc20395cf9f3d92784aef6268e
2021-04-30 14:18:43 -07:00
Sunny Goyal
b745a2a9fd Fixing transition end not getting called if pagedView is not drawing
Bug: 186822776
Test: Manual
Change-Id: I60e9028d17f39a4ad95f9aa79f8b4be695b4ae65
2021-04-30 13:38:59 -07:00
TreeHugger Robot
f9f506ca7e Merge "Update drop target styling based for BC." into sc-dev 2021-04-30 16:46:53 +00:00
Alina Zaidi
b42513fbc5 Merge "Fix some bugs in widget pickers." into sc-dev 2021-04-30 09:19:07 +00:00
Alina Zaidi
2b5124ec41 Fix some bugs in widget pickers.
- Update color of Educational tip view contents. Background colorAccentSecondary
in NexusLauncher above S, colorAccent otherwise (b/185834169)
- Update widget picker search bar color and its text font and color. (b/186423026)
- Update button padding and text in pin widget picker. (b/182994384, b/183601584)

Bug: 185834169
Bug: 186423026
Bug: 182994384
Bug: 183601584
Test: Manually tested
Change-Id: I36cd3ed2285677d0c164db8f57f6c90a5f247982
2021-04-30 07:52:23 +01:00
TreeHugger Robot
3395d1de7a Merge "Arrow popup - adjust margin to account for RTL and LTR." into sc-dev 2021-04-30 00:05:27 +00:00
Adam Cohen
0c4d278ed2 Don't fade out active page outline during drag-and-drop
=> Keep page backgrounds stable and only slightly modify the alpha + add stroke for active page
=> Don't shrink cell outlines to be too small (issue in hotseat on some devices)
=> Reduce cell radius to 22dp

Bug: 185163323
Test: manual

Change-Id: Ic17999f5672a3355dceeb25af923f02e960389d9
2021-04-29 23:09:56 +00:00
Zak Cohen
284b6ed6a7 Arrow popup - adjust margin to account for RTL and LTR.
Bug: 185887218
Test: Local in ltr and rtl
Change-Id: I50d1e9dbc64dc02f31661d91a6c9a90e4383c5c7
2021-04-29 15:34:29 -07:00
TreeHugger Robot
44e6fb6ed4 Merge "Calling pageTransisionEnd only after edgeEffect finishes" into sc-dev 2021-04-29 22:15:41 +00:00
TreeHugger Robot
14e2070709 Merge "Replace conversations widget app icon" into sc-dev 2021-04-29 22:15:21 +00:00
Sunny Goyal
05b59c080f Calling pageTransisionEnd only after edgeEffect finishes
Bug: 186605795
Test: Presubmit
Change-Id: I2b46d0b0a47c68038f300e71ab89bd7e5a5e3895
2021-04-29 13:56:08 -07:00
Steven Ng
1140f84b6f Replace conversations widget app icon
Test: Open full widgets picker and observe the expected icon for
      the conversations category.
Bug: 184878454
Change-Id: I580b0148d39c8dd004113c8f966135b22165a329
2021-04-29 17:46:29 +01:00
Yogisha Dixit
a3a6f51b12 Update drop target styling based for BC.
Spec: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Demo: https://drive.google.com/file/d/1ZIa3Dgo85vdVkfPm7aGJDyctZQR_c8Xx/view?usp=sharing

Test: manual
Bug: 184713740
Change-Id: I17dbbf1f7bbc40939cfc0fedb506a35f39ecc2e3
2021-04-29 09:18:05 +00:00
TreeHugger Robot
e1a2ea769f Merge "Remove debugging logs from the full widgets picker" into sc-dev 2021-04-29 08:33:36 +00:00