Commit Graph

6193 Commits

Author SHA1 Message Date
Samuel Fufa
30ffc3f95c Merge changes Ice83b544,If0bc2a6d into sc-dev
* changes:
  [Search][Motion] Modify interpolator for AllApps background scrim
  Cleanup/consolidate normal<->all apps interpolators
2021-05-04 15:06:51 +00:00
Cyrus Boadway
197c909483 Change flag type to control Quickstep widget app launch
Previously we'd relied on a SystemProperties to control which
InteractionHandler was used by Quickstep for widget app launches.

This switches to a more conventional FeatureFlag.

Bug: 169042867
Test: manual
Change-Id: I7abf815c6e204daf996ac0a81b1a354c4e3d5cda
2021-05-04 12:04:36 +00:00
Alex Chau
90f587f350 Maintain TaskView's scroll invariant when swiping down
Fixes: 186881810
Test: Swipe down from task other than running task, snaps in proper position in fullscreen
Change-Id: If1a667246804ebff8432b295a0bb22d17feb5c31
2021-05-04 12:51:23 +01:00
TreeHugger Robot
cc65b07d44 Merge "Adding support for using themed icons on workspace" into sc-dev 2021-05-04 06:03:17 +00:00
Winson Chung
7fbc961933 Allow binder calls from creating recents orientated state for now
- Should probably remove if possible since this is on a hot path

Bug: 187074722
Test: Presubmit
Change-Id: I104e1175acba7b90cd9824b905ffe68089beed9e
2021-05-03 22:27:24 -07:00
Samuel Fufa
3ab273da0c [Search][Motion] Modify interpolator for AllApps background scrim
Also rename ANIM_WORKSPACE_SCRIM_FADE to ANIM_SCRIM_FADE since
the scrim is shared between states now.

Bug: 183001675
Test: Manual in 3 button and 0 button modes
Change-Id: Ice83b54480bdf74155e8593c421b68d7186cf78a
2021-05-03 21:13:20 -07:00
Tony Wickham
154b1c928b Cleanup/consolidate normal<->all apps interpolators
We no longer need to have a different behavior for no button mode,
so make PortraitStatesTouchController the source of truth

Also remove unused ANIM_ALL_APPS_HEADER_FADE & RECENTS_FADE_THRESHOLD

Test: manually in 0 button and 3 button modes
Bug: 183001675
Bug: 175137718
Change-Id: If0bc2a6d6d3bf1649fad45226a4e6055f30e4880
2021-05-03 21:07:24 -07:00
TreeHugger Robot
13e4618b57 Merge "Fade out empty Overview message." into sc-dev 2021-05-04 03:49:54 +00:00
Sunny Goyal
9ab43772ab Adding support for using themed icons on workspace
Bug: 183641907
Test: Manual

Change-Id: Ieda7e73b3ae4dfe3009e3f23754aff5f8826a967
2021-05-03 20:00:38 -07:00
Tony Wickham
b55372cea6 Merge "Check for memory leaks after tests in FallbackRecentsTest" into sc-dev 2021-05-04 02:19:06 +00:00
Zak Cohen
fed2a01fe4 Fade out empty Overview message.
When Overview is empty, fade out its contents on transitions.


Bug: 185447800
Test: Local build and test on P5
Change-Id: I9a0cd649f2f7353e4a7af21a93fb18be36f616a8
2021-05-03 16:47:35 -07:00
Tony Wickham
9b505e3148 Check for memory leaks after tests in FallbackRecentsTest
Test: e.g. goToOverviewFromApp()
Bug: 185806101
Change-Id: I6e618e850740afa69989f652321d4075d3cda13d
2021-05-03 16:46:16 -07:00
Sunny Goyal
19ff728b92 Adding support for determining split layout for launcher.
> Simulating the windo wmanager API to get available device
  profiles until final API
> When a device has multiple internal displays, and with both
  tablet and phone possibilities, it uses a split workspace layout

Bug: 186160341
Bug: 175782275
Test: Manual
Change-Id: Ieff2329acac7cdd6b9abe6f96cd459cd45bd0efe
2021-05-03 14:48:28 -07:00
Zak Cohen
daa3b8b9a3 AssistContentRequester-weaken references to system callback
The callback objects used to call into system server can
outlive the parent requester object. This can cause leaked
activities (on rotation for example). Use a weaker collection
of callback objects that aren't tied to the lifecycle of
the callback.

Bug: 186670923
Test: Ran TAPL tests to check for leaked activities
Change-Id: I33f556ad55b823652b06410d264f1473d3003320
2021-05-03 13:55:59 -07:00
Tracy Zhou
299de3f292 Merge "Revert "Revert "Finish recents animation upon home rotation""" into sc-dev 2021-05-03 18:08:37 +00:00
Tracy Zhou
ef7b4d5dae Revert "Revert "Finish recents animation upon home rotation""
This reverts commit 0f8787db80.

Reason for revert: Revert and fix the broken tapl test

Fixes: 184054813
Change-Id: Ib647e11bfa0a2dc79a5a815be56452bb07e04ddf
2021-05-03 18:08:31 +00:00
Zak Cohen
554cf58401 Merge "Overview - fade task icon instead of scaling it per new ux" into sc-dev 2021-05-03 17:52:46 +00:00
Cyrus Boadway
92af1bfe5b Merge "Create return-to-home app widget animation" into sc-dev 2021-05-03 17:51:45 +00:00
Zak Cohen
20d00faf72 Overview - fade task icon instead of scaling it per new ux
Bug: 186256286
Test: Local build and run on p5
Change-Id: I318b62ddbf9cb475736d2844489a7ed2d9a8a409
2021-05-01 22:41:08 +00:00
Winson Chung
7c53f5d907 Merge "Take screenshot on ui helper thread in live tile" into sc-dev 2021-05-01 20:47:26 +00:00
Cyrus Boadway
3bdfc3cd2d Create return-to-home app widget animation
If an app has been most recently launched from an app widget, when
swiped away, the app animates to the widget's position.

This is done by attributing the app launch to the widget through
the ActivityOptions's launch cookies, and using a FloatingWidgetView
throughout the animation.

Bug: 169042867
Test: manual
Change-Id: I24c2623b5b3407504a4768b076849c47f73cbae0
2021-04-30 09:37:53 +00:00
TreeHugger Robot
8a50f93f91 Merge "Fade overview actions on transition to Home." into sc-dev 2021-04-30 01:05:13 +00:00
Winson Chung
d2e91bace4 Take screenshot on ui helper thread in live tile
- Unify the live tile/non-live tile flow for taking a screenshot
  and post it to the ui helper thread

Bug: 186455799
Test: Test to verify that snapshots are still updated correctly
Change-Id: I26759419adf89c73602589da531bbc494b5c29e3
2021-04-29 16:23:58 -07:00
Zak Cohen
cf38c65dc4 Fade overview actions on transition to Home.
Bug: 184696445
Fixes: 184696445
Test: Local build and flash
Change-Id: I950a08b1528ba983157615f99c21f06de220d414
2021-04-29 16:17:10 -07:00
TreeHugger Robot
2aec5f2643 Merge "Fix a couple issues with tracking launch cookies" into sc-dev 2021-04-29 21:04:25 +00:00
TreeHugger Robot
ae95cd1cc1 Merge "Logging ItemInfo.attribute field for LauncherUiChanged atom." into sc-dev 2021-04-29 20:33:22 +00:00
Bill Yi
fdcf8103e0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ide1f0bfcb4a3a28bcdbc2d0ec830f77de864546f
2021-04-29 19:00:17 +00:00
Winson Chung
3c192b3f72 Fix a couple issues with tracking launch cookies
- Fix NPE when there is no running task
- Fix issue where we were defaulting to a prediction icon when
  there was no launch cookie
- Don't use a launch cookie when we are launching from a non-workspace
  item, just fallback to the package name matching in that case

Fixes: 186653036
Fixes: 186593373
Test: Swipe up from various apps launched from predictions, also
      launch an app from all apps and swipe up and ensure it
      doesn't match a prediction
Change-Id: Ie8f5da010c140a5056045ac268d082c80271ab68
2021-04-29 04:23:40 +00:00
thiruram
7350b0f47e Logging ItemInfo.attribute field for LauncherUiChanged atom.
Unlike LaucherStaticLayout, LauncherUiChanged atom does not have origin field to write into statsd. This workaround solution will pack attribute value into target_id field and provides backward compatibility too.

Bug: 186169419
Test: Manual
Change-Id: Ib5344fad08accdd0aac827700c3842b7f102b7dc
2021-04-28 17:35:20 -07:00
TreeHugger Robot
127714094a Merge "Change TaskIconMenu to lay out vertically" into sc-dev 2021-04-28 20:16:43 +00:00
Vinit Nayak
4cc0dbb552 Change TaskIconMenu to lay out vertically
Still lays out horizontally when in phone
landscape.
TODO(b/186583656), need to center view.
Also have all layout be dynamic instead of having
some cases be in XML and some in code.

Bug: 181704764
Test: Task menu visible with all options in
portrait/landscape tablet
portrait phone
fake/real landscape phone

Change-Id: I3632eeb174f3e4baf2c9d69d51c1815c3c512e59
2021-04-28 11:47:08 -07:00
Steven Ng
84298b3998 Add a flag to enable custom local filter for recommended widgets
Test: Run WidgetsPredictionUpdateTaskTest
Bug: 186648032
Change-Id: I2bd5e2c81f971e0a40a4b05c8cab2a7adb171f96
2021-04-28 18:47:33 +01:00
Winson Chung
4dd75b334f Merge "Prevent multiple calls to finish on the recents controller" into sc-dev 2021-04-28 17:22:19 +00:00
Winson Chung
bfb6274920 Merge "Invalidate when switching to new consumer" into sc-dev 2021-04-28 17:01:02 +00:00
Winson Chung
fb45e57ac1 Prevent multiple calls to finish on the recents controller
Bug: 186246362
Test: Verify from logs that we don't finish the controller
      multiple times
Change-Id: I8d40a756216133b8a278a28b822cf75c6e2a3046
2021-04-27 21:20:24 -07:00
Tony Wickham
9137946fd6 Merge "Don't setEnableDrawingLiveTile(true) unless end target is RECENTS" into sc-dev 2021-04-28 04:15:35 +00:00
TreeHugger Robot
69cb35a85a Merge "Some overview scrim and status bar color adjustments" into sc-dev 2021-04-28 03:23:13 +00:00
Bill Lin
0bcfe825fc Merge "Revert "Revert "2/ Resolve gesture one handed conflicts swipe up..."" into sc-dev 2021-04-28 03:14:30 +00:00
TreeHugger Robot
45167d6030 Merge "Removing dependency on wallpaper colors and using theme resources" into sc-dev 2021-04-28 03:00:17 +00:00
Winson Chung
4df3b23225 Invalidate when switching to new consumer
- When switching to a new consumer, also invalidate the handler to
  clean up references held by that handler
- Also make sure that we calculate the task index used for logging
  prior to starting the task view since the handler can be invalidated
  between starting the activity and the callback happening

Bug: 185909226
Test: Presubmit
Change-Id: I20e06b5a6b31a5e242c6fc840bf4f215797eb12c
2021-04-27 19:13:04 -07:00
Tony Wickham
b482188775 Some overview scrim and status bar color adjustments
- Replace UI_STATE_OVERVIEW with UI_STATE_FULLSCREEN_TASK. Overview no
  longer needs it's own status bar treatment as it's handled by
  ScrimView already. So remove instances of UI_STATE_OVERVIEW and
  replace some with UI_STATE_FULLSCREEN_TASK if a TaskView is behind
  the status bar.
- Add ScrimView to fallback recents activity.
- Remove scrim from Background state, don't fade it in until the
  gesture ends to RECENTS.

Test: watch scrim and status bar colors during the following
- Swipe up to home (no scrim, status bar matches task at first but
  then wallpaper once task isn't overlapping status bar)
- Swipe up to overview (no scrim until let go to overview, status
  bar matches task at first, then wallpaper after not overlapping,
  then scrim once it's 90% opacity)
- Quick switch from home (scrim fades in, status bar matches once
  it reaches 90% opacity)
- Quick switch from app (no scrim, status bar matches center task)
- Repeat above for 3P launcher and 2 button mode

Fixes: 185681676
Fixes: 185286870
Change-Id: I9e5c292cc734e714169b9cc8268e8dad4e868aca
2021-04-27 17:44:30 -07:00
Tony Wickham
e953739fd0 Don't setEnableDrawingLiveTile(true) unless end target is RECENTS
This addresses the case where the gesture ends before an end
target is calculated. Also technically live tile is only
supported in RECENTS anyway.

Test: Open calculator, tap the nav region, ensure we don't go home
(Same for 2 button mode, but tap outside of deferred region)

Fixes: 186197537
Change-Id: I05e288ae952f8c8ea0fa72d8c6e6aa2b6dbb0b1e
2021-04-27 17:34:04 -07:00
TreeHugger Robot
222b4757f5 Merge "Allow Workspace Scrim to be colored per state" into sc-dev 2021-04-28 00:10:26 +00:00
Sunny Goyal
4ed0fb5074 Removing dependency on wallpaper colors and using theme resources
Bug: 184676715
Test: Manual
Change-Id: Ie9a9a784c4a8a8cd484bfd8ea463deedcd4deed6
2021-04-27 16:29:08 -07:00
Winson Chung
df84326662 Add some logging for the app icon in overview
Bug: 186444448
Test: Presubmit
Change-Id: Iaa5aef39a461b8e37ec9f4e85d7a0d21233bf40f
2021-04-27 22:46:54 +00:00
Zak Cohen
4d35ac3020 Allow Workspace Scrim to be colored per state
Make it possible to set the color of workspace scrim to a different color
per state. Motivated by making Overview Scrim and All Apps scrims different
colors.

Bug: 186253733
Test: Local build and flash
Change-Id: Id7c38ce3c9173308eedfcb7592ececa7bd6bf220
2021-04-27 14:04:46 -07:00
TreeHugger Robot
8a38f39354 Merge "Initialize RotationTouchHelper with RecentsAnimationDeviceState ctor" into sc-dev 2021-04-27 20:49:37 +00:00
Alex Chau
8ac1a576f2 Apply TaskView's (non)fullscreenTranslation correctly in emulated landscape
PS4: Change approach to return a FloatProperty instead, as getPagedOrientationHandler() can throw NPE when called without a parent, as applyTranslationX/Y is called in onRecycle

Fixes: 186432016
Test: In small screen without home screen rotation, TaskView stay in position when rotating and icon is in displayed correct position after rotation. In quick switch, Task window also fill the screen.
Test: In large screen when dragging up from last task in quick switch, TaskView stays on screen when being dragged up
Change-Id: I54247e81066913e5cc072cf72543d780ff55ccaf
2021-04-27 19:18:48 +01:00
Alex Chau
129b001f29 Merge "Only show ActionsView when GestureEndTarget is RECENTS" into sc-dev 2021-04-27 13:36:49 +00:00
András Klöczl
d376b27d21 Merge "Add animation for all visible pages on home screen." into sc-dev 2021-04-27 12:07:29 +00:00