Commit Graph

796 Commits

Author SHA1 Message Date
Alina Zaidi
3237236f26 Merge "Prevent cropping of personal/work tabs in full screen widget picker." into sc-dev 2021-05-12 17:13:50 +00:00
Hyunyoung Song
15df06d05e Merge "Fix white text on light accent color issue for all apps and widgets drawer" into sc-dev 2021-05-12 16:42:09 +00:00
Jonathan Miranda
d95aa5a5d7 Merge "Remove color extraction from popup arrow, add shadows." into sc-dev 2021-05-12 15:47:43 +00:00
Alina Zaidi
071665c89b Prevent cropping of personal/work tabs in full screen widget picker.
Bug: 187632869
Test: Tested manually
Change-Id: I39a43ed1efae5802ffdd5d79ad3cb1a50af38d62
2021-05-12 14:57:42 +01:00
Hyunyoung Song
3af62c1e25 Fix white text on light accent color issue for all apps and widgets drawer
Bug: 187857897
Bug: 185211063

Test: manual, see screenshot on the bug
Change-Id: Ie7461ce4724c15dafda35a5c533d9539a34d68ab
2021-05-12 00:42:11 -07:00
Jon Miranda
35c5477d5c Remove color extraction from popup arrow, add shadows.
Bug: 175329686
Bug: 187014675
Test: manual

Change-Id: I84a3f23b7a9ceef004a2b1b66e5f8a10585bd113
2021-05-11 17:35:01 -07:00
Alina Zaidi
042249ff59 Update colors in pin widget dialog, to be similar to widget bottom sheet.
Bug: 187374499
Test: Visually tested. Also tested using accessibility scanner.
Change-Id: I3be84dc394d312d03b97fe66b7e8214c4d8bef71
2021-05-11 17:47:48 +01:00
Samuel Fufa
f94540b28a Merge "[WorkProfile] Update work/personal tab to pills" into sc-dev 2021-05-06 23:33:06 +00:00
Steven Ng
57347bd6b7 Only show collapse handle when the bottom widgets picker is scrollable
Test: Go to contact bottom widgets picker. No collapse handle is
      shown because the content isn't scrollable. Go to Google calendar
      bottom widget picker. Collapse handle is hown because the content
      is scrollable.
Bug: 185134663
Change-Id: Ic6109c055a072aa1cf3521f829833fd5f4cece0f
2021-05-06 17:39:49 +01:00
Steven Ng
edfec2fc0b Fix scrolling issue in the full widgets picker
Before this change, the widgets recommendation table handles all the
touch events. The table doesn't distinguish a touch event from a scroll
event. This change forwards the motion event to the active recycler view.
If the recycler view doesn't handle the event, it will then forward the
event back to the view hierarchy.

Test: Open the full widgets picker, then start scrolling on the
      recommended widgets UI. The full widgets picker scrolls perfectly.
      Drag-n-drop a recommended widget
Bug: 186567644
Change-Id: I89d473179796c516d2394332dd75f8e9a1d8b388
2021-05-05 23:19:09 +01:00
Samuel Fufa
db9b483c02 [WorkProfile] Update work/personal tab to pills
Bug: 186857875
Test: Manual
Screenshot: https://screenshot.googleplex.com/89jD32tHqNkBUWb
Change-Id: Ia4bb91372896d8a53017e3eadbe985878ce7f0ec
2021-05-03 10:53:33 -05:00
TreeHugger Robot
51991a7333 Merge "Fix few A11y/ UI bugs for widget pickers" into sc-dev 2021-04-30 19:09:53 +00:00
TreeHugger Robot
ed40c7735e Merge "Correct "cropping" of widget picker's search bar" into sc-dev 2021-04-30 15:00:32 +00:00
Pierre Barbier de Reuille
0e092292fb Correct "cropping" of widget picker's search bar
To corrent, I added 1dp of bottom margin. Not doing this, the framework
ignores the dropped shadow due to the elevation when some text is
entered in the box, leading to the observed cropping.

Fix: 186722040
Test: Manually
Change-Id: I746a8f014197552416ed9c40e9736baf22794c5f
2021-04-30 14:30:37 +01:00
Alina Zaidi
c16c281305 Fix few A11y/ UI bugs for widget pickers
- Add a subtext in pin widget dialog informing users how to add widget
manually. This is not important for accessibility, as drag and drop is through an
action item for visually impaired users.
- Update search bar text hint color so that it passes accessibility test.

Bug: 182994384
Bug: 182993604
Test: Manually Tested using accessibility scanner app and talkback
Change-Id: I5a49d0bc3e5973b76c41b2a178af509e96a3cdd7
2021-04-30 13:30:03 +01:00
Alina Zaidi
b42513fbc5 Merge "Fix some bugs in widget pickers." into sc-dev 2021-04-30 09:19:07 +00:00
Alina Zaidi
2b5124ec41 Fix some bugs in widget pickers.
- Update color of Educational tip view contents. Background colorAccentSecondary
in NexusLauncher above S, colorAccent otherwise (b/185834169)
- Update widget picker search bar color and its text font and color. (b/186423026)
- Update button padding and text in pin widget picker. (b/182994384, b/183601584)

Bug: 185834169
Bug: 186423026
Bug: 182994384
Bug: 183601584
Test: Manually tested
Change-Id: I36cd3ed2285677d0c164db8f57f6c90a5f247982
2021-04-30 07:52:23 +01:00
Steven Ng
1777a1be4f Use widget picker color surface for WidgetsBottomSheet
Test: Launch widgets bottom sheet, search popup to confirm the expected
      background color is applied.
Bug: 183601302
Change-Id: I300a364605e00a0d8046a907a40f4cb797ec161e
2021-04-29 12:44:31 +01:00
TreeHugger Robot
222b4757f5 Merge "Allow Workspace Scrim to be colored per state" into sc-dev 2021-04-28 00:10:26 +00:00
Zak Cohen
4d35ac3020 Allow Workspace Scrim to be colored per state
Make it possible to set the color of workspace scrim to a different color
per state. Motivated by making Overview Scrim and All Apps scrims different
colors.

Bug: 186253733
Test: Local build and flash
Change-Id: Id7c38ce3c9173308eedfcb7592ececa7bd6bf220
2021-04-27 14:04:46 -07:00
Steven Ng
f4bd91f0ab Merge "Add a11y action for expand / collapse items in WidgetsFullSheet" into sc-dev 2021-04-27 16:28:11 +00:00
Steven Ng
fd68f757c8 Add a11y action for expand / collapse items in WidgetsFullSheet
Test: Enable talkback. When focusing on a collapsed item, it announces
      Collapsed "App Name" "n widgets/shortcuts". Action available. Use
      tap with 3 fingers to view. 3 fingers tap > Action > Expand.
      Widgets are expanded.
      When focusing on an expanded item, it announces
      Expanded "App Name" "n widgets/shortcuts". Action available. Use
      tap with 3 fingers to view. 3 fingers tap > Action > Collapse.
      Widgets are collapsed.
Bug: 183120145
Change-Id: Ibbb6025b929c141aa9e2fd2c72dce314e8be837e
2021-04-27 16:28:00 +00:00
Cyrus Boadway
5f35ff021d Merge changes I65d2b1bc,I35bf9cb4 into sc-dev
* changes:
  Animate App Widget activity launch from Quickstep launchers
  Add a mechanism to temporarily defer App Widget updates
2021-04-27 10:17:00 +00:00
Cyrus Boadway
61110601f6 Animate App Widget activity launch from Quickstep launchers
Following the general pattern on icon launch animations, define a
'floating widget view' to represent the appearance of the app widget
through the launch animation.

The floating widget view separates the foreground and background
components of the LauncherAppWidgetHostView, which can be positioned
and animated separately.

The background (or placeholder if no background can be identified)
moves and grows from its original position and size to the launched
app's position and size.

The widget's foreground scales and moves to match, fading out to be
replaced with the app window.

Bug: 169042867
Test: manual
Change-Id: I65d2b1bc80275f9df460790720e13d1650093347
2021-04-27 08:31:49 +00:00
Steven Ng
c7d7410178 Include recommended widgets table vertical padding in the height estimation
Test: run AddWidgetTest, AddConfigWidgetTest
Bug: 186450511
Change-Id: If306b569058edb3edb3c741199e9c0d96a88f412
2021-04-26 22:19:58 +01:00
Alina Zaidi
b7f5ab04ad Fix few UI bugs in widget picker.
- Update colors for widget picker (b/184236316)
- Adjust padding according to mocks (b/184236316)
- Make sure view holders refresh corners in search mode. (b/185099541)
- Fix search bar shadow being cropped (b/183602001)

Bug: 184236316
Bug: 185099541
Bug: 183602001
Test: Manually tested
Change-Id: Ifa33e090cdf31c95db9c1145e623ef55c42dd52e
2021-04-26 16:48:14 +01:00
Alina Zaidi
df9582e559 Merge "Fix UI bugs for widget picker search." into sc-dev 2021-04-13 15:42:34 +00:00
Alina Zaidi
1ccd7efaf0 Fix UI bugs for widget picker search.
- Mirror search icon in RTL (b/184162989)
- Fix spacing between edit text and cancel button, to make it consistent
with space between search icon and edit text. (b/183602001)
- Scroll to top on every search result. (b/183602001)
- Fix keyboard overlap on orientation change. This is fixed by clearing
text on edit text differently (b/184048899)

Test: Manually tested
Bug: 184162989
Bug: 183602001
Bug: 184048899
Change-Id: I72ed51e1968a55a3105bd8b389d1bbd74d50d8af
2021-04-13 10:41:18 +01:00
Steven Ng
3691179041 Set width & height of app icons in all widgets tray to 48dp
Bug: 184877669
Test: Change the grid size and observe app icons in all widgets
      tray stay the same.
Change-Id: I856d5fada579474fffb6296d641fb686623ca2cc
2021-04-09 11:15:50 +01:00
Steven Ng
1b5e45acae Merge "Use a separate personal/work tabs layout for the widget picker" into sc-dev 2021-04-08 18:48:52 +00:00
Steven Ng
fd604ee7ae Use a separate personal/work tabs layout for the widget picker
1. Apps are feminine while widgets are masculine in some languages.
   We should use a different set of strings to ensure strings are
   translated with the right context.
2. We will be using a different theme for widget tabs. Let's keep
   the layout separate.

Bug: 184613311
Test: manual
Change-Id: I88df8ca6091e4b6ddf81f34f180a6ce2cada16e3
2021-04-08 11:14:24 +00:00
TreeHugger Robot
63c169561c Merge "Some cleanup in RecentsView" into sc-dev 2021-04-07 21:06:55 +00:00
Pierre Barbier de Reuille
ad41a56166 Stop trying to draw a view not attached to the view tree
The behavior of the framework when we try to do so is undefined. In our
case, it almost work, but no clipping is applied, which is a problem for
Android S (before that, widget couldn't use clipping in the first
place).

Instead of drawing the view through a drawable, this really add the view
and adds also a badge ImageView for badges instead of drawing them
indirectly.

Note that, temporarily, we have to re-allow drawing the view after it
has been attached, but the underlying framework bug being fixed, this
should be fine (I tested it and it really seems to be).

Bug: 183609936
Test: Using hand designed app (see bug)
Change-Id: I929ef8fc81c98c49406f2d940cd5efc28319886d
2021-04-07 15:51:43 +01:00
Sunny Goyal
c82916fecb Some cleanup in RecentsView
> Merging overview and all-apps scrims into a single View
> Decoupling TaskMenuView from taskView

Bug: 184676497
Test: Manual

Change-Id: I49f7249eaa2a800054385ab8e73a441d6a1b5e16
2021-04-06 15:47:33 -07:00
Alex Chau
dfde4d96ea Focus running task in overview grid
- calculateTaskSize now returns the Rect for focused task
- Introduced calculateGridTaskSize for non-focused task, and translate non-focused tasks to fit the grid
- As Task Rect is now vertically centered, removed ClearAllButton's grid vertical translation
- When ClearAllButton is not shown (e.g. quickswitch), make sure ClearAllButton's scroll won't be used when page snapping. This happens when page scrolls are translated so they're negative.
- Added back ActionsView when task is focused below the TaskView, which become invisible as you scroll
- In Modal state, move the ActionsView down so it won't cover the TaskView

Bug: 175939487
Test: manual
Change-Id: Idfa94a51f856418adc0503cf04211dcb4b1814fe
2021-04-01 14:52:25 +01:00
Samuel Fufa
c699c01812 Merge "[Search] Resolve work/personal tab overlap with A-Z list" into sc-dev 2021-03-25 13:34:17 +00:00
Yogisha Dixit
73c8a366a8 Add a button for reconfiguring widgets.
Test: manual
Bug: 183316993
Change-Id: I17bec121e3d07d65979c2b92c285e487a7d64d65
2021-03-24 13:34:29 +00:00
Alina Zaidi
305a44c935 Merge "Bug fixes for widget picker search (2/n)" into sc-dev 2021-03-24 09:47:26 +00:00
TreeHugger Robot
cb6dff62d9 Merge changes I6ce23251,I56fca1b7 into sc-dev
* changes:
  Update the resize frame to use the forced radius.
  Enforce rounded corners on App Widgets.
2021-03-24 00:39:17 +00:00
TreeHugger Robot
acb3cac938 Merge "Update Pin widget dialog UI according to mocks." into sc-dev 2021-03-24 00:29:41 +00:00
Jonathan Miranda
0fa5225d57 Merge "Updating deep shortcut container to new width." into sc-dev 2021-03-23 21:30:46 +00:00
Pierre Barbier de Reuille
452df2d5bb Update the resize frame to use the forced radius.
When forcing the rounded corners, the radius may be smaller than the
default one. When this happens, we should change how the frame is drawn
to only use that reduced radius, or this looks weird.

Bug: 183097166
Test: Manual tests with top 1P App Widgets
Change-Id: I6ce232515ce14059e1168e16735719ea2370132c
2021-03-23 20:57:33 +00:00
Tony Wickham
3629b93546 Merge "Add TaskbarView as a child of Hotseat" into sc-dev 2021-03-23 18:36:53 +00:00
Samuel Fufa
c6995f3eb2 [Search] Resolve work/personal tab overlap with A-Z list
This issue was caused due to launcher falling out of sync with DEVICE_SEARCH_FLAG. This change makes AllApps views agnostic of search input type when rendering layout.

Bug: 182591985
Test: local
Change-Id: Ic015b68e110eea9ab5184325f2a3633a5c7d15cc
2021-03-23 11:09:15 -05:00
Jon Miranda
e888b08b70 Updating deep shortcut container to new width.
Bug: 175329686
Test: manual, visual
Change-Id: I0487d240523ab3de4bf3e381ec359267eaa33a71
2021-03-23 12:00:38 -04:00
Alina Zaidi
6d97d893e0 Update Pin widget dialog UI according to mocks.
Test: Tested manually and RequestPinItemTest passed
Bug: 182982143
Bug: 182994819
Bug: 182929673
Change-Id: I905ea0c1860d28ee9fbb456ddf6abd728b65bac4
2021-03-23 13:36:48 +00:00
Alina Zaidi
76060eb11b Bug fixes for widget picker search (2/n)
- Dismiss keyboard when user starts to drag widget picker
- Add content description for cancel button

Test: Tested manually.
Bug: 183211445
Bug: 183106676
Change-Id: Ie620c3d50a49d8380f316d48e4ee8ebced6de5eb
2021-03-23 12:53:23 +00:00
Tony Wickham
9ce3b25ef6 Add TaskbarView as a child of Hotseat
Instead of keeping the Taskbar window showing above the home screen,
we now integrate a copy of TaskbarView directly into Launcher's view
hierarchy. Most TaskbarController calls apply to both TaskbarViews
(mTaskbarViewInApp and mTaskbarViewOnHome), except for calls related
to Hotseat, which only apply to mTasbkarViewInApp given the real
Hotseat will be showing with mTaskbarViewOnHome.

More cleanup will follow this change.

Test: All taskbar interactions (e.g. drag and drop) continue to work
Bug: 182512211
Bug: 171917176
Change-Id: I0f0b124f652daa85f866e1df8f9e2981540331a0
2021-03-22 15:26:01 -07:00
Steven Ng
867ff5f60c Update title of bottom widgets tray
Only use the "app name" instead of "app name widgets" as title
Remove "Touch & hold to move a widget" subtitle.

Test: manual

Bug: 179797520
Change-Id: I7a5954af73aa5b480096e93ade3520cef6c93f17
2021-03-22 22:23:46 +00:00
Steven Ng
e4c0e954d3 Exact common layout from widgets bottom sheet
Test: open widgets bottom sheet and drag and drop widgets & shortcuts.

Bug: 182305634
Change-Id: I82e3e584edf64177ffa6e677f5b3f487823d3e1b
2021-03-22 17:50:49 +00:00