Commit Graph

2602 Commits

Author SHA1 Message Date
Vadim Tryshev
f24ae74cd2 Merge "Extending the list of test owners" into ub-launcher3-qt-qpr1-dev
am: 1cbdcb2961

Change-Id: I5f01dc9b50cc33499bd9cb88913157802656cd52
2019-08-16 10:56:32 -07:00
Vadim Tryshev
1cbdcb2961 Merge "Extending the list of test owners" into ub-launcher3-qt-qpr1-dev 2019-08-16 17:36:54 +00:00
Hyunyoung Song
27df700f05 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev
am: 96eba3aea6

Change-Id: I738256f1623119a61197c03008e098b066161542
2019-08-15 16:03:32 -07:00
Hyunyoung Song
96eba3aea6 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev 2019-08-15 22:25:33 +00:00
Hyunyoung Song
d4204437de Make TogglableFlag backed by DeviceConfig for e2e testing
Bug: 138964490

TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.

Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.

Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
2019-08-15 14:02:28 -07:00
vadimt
a81be5003c Extending the list of test owners
Otherwise, changes in tests would require my-only approval.

Change-Id: Ia957a28a5a8e55dc2ee4efdf9a46c91511d3e611
2019-08-14 17:18:45 -07:00
TreeHugger Robot
46463f6a19 Merge "Adding support for storing keywords in iconCache" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
Felipe Leme
0940c487b1 Fixed PredictionAppTracker as service might not be available on device.
am: 7ca46ba2ee

Change-Id: Ib7eed879bdb25291cd5faefa5e2176aed0b32095
2019-08-14 15:53:49 -07:00
Sunny Goyal
934ebd087b Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
Merged-In: I1183e63a6556ebfb3eee5df23d149e09728193a9
(cherry picked from commit e529a86fbd)
2019-08-14 22:12:49 +00:00
Felipe Leme
7ca46ba2ee Fixed PredictionAppTracker as service might not be available on device.
Fixes: 139416391
Bug: 135218095

Test: echo 'in TreeHugger we trust'

Change-Id: Iea89b3d379792327657e01869c9494975e7b0306
(cherry picked from commit 214a45ee02)
2019-08-14 22:02:22 +00:00
Becky Qiu
1289197487 Merge "Log the event for swiping up to dismiss a task in Overview." into ub-launcher3-qt-qpr1-dev
am: 22edac9bf5

Change-Id: Iae05c668fecf84c79086cfb6821e9644ac08bb71
2019-08-14 13:09:14 -07:00
Becky Qiu
22edac9bf5 Merge "Log the event for swiping up to dismiss a task in Overview." into ub-launcher3-qt-qpr1-dev 2019-08-14 17:48:45 +00:00
Samuel Fufa
866ff00eb3 Add a "Dismiss" option for predicted apps in Launcher
Test: LongPress on a pridicted app to see dismiss options.
Bug:139020180
Change-Id: I877863c65def0d845c0ae2f0987fe7a4f6277565
2019-08-13 23:57:11 +00:00
Sunny Goyal
237441a2b4 Always go to home in case of fling-up am: a2cfc2d95e
am: f3dac0ef13

Change-Id: I3ff8759dcf2134d8d0bc991dff78af57880c137b
2019-08-13 15:08:00 -07:00
Sunny Goyal
f3dac0ef13 Always go to home in case of fling-up
am: a2cfc2d95e

Change-Id: I560fd690882998a9b503d5c30eda7f9397db138e
2019-08-13 14:58:45 -07:00
Sunny Goyal
a2cfc2d95e Always go to home in case of fling-up
Bug: 138881088
Change-Id: I86bf4c7a495805d5912b102470e72a51e843a222
2019-08-13 11:45:06 -07:00
Becky Qiu
90ea00b399 Log the event for swiping up to dismiss a task in Overview.
Test: manual
Bug: 137777105

Demo logging for dismissing a task:
  data {
    elapsed_timestamp_nanos: 70772067228810
    atom {
      launcher_event {
        action: DISMISS_TASK
        src_state: OVERVIEW
        dst_state: BACKGROUND
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I5569b80e2e1f35661bc5e9e343c6c298791a1ec1
2019-08-09 10:57:05 -07:00
Vinit Nayak
268e4ff95c Remove activityInfo from cache on package uninstall
We were keeping stale activityInfo objects from
package manager after an application got uninstalled.
We also were not removing task icons from the
cache after they were removed, which meant killing an
app and then re-opening would put 2 entries in the cache
since the two had unique process IDs.

fixes: 137731960
Test: Download app from play store, open it,
go to overview and observe that correct icon showing.
Uninstall it, download same app again, open it, and
in overview confirm that correct app icon is still showing

Change-Id: Icf482b0ad0ae66c10d52547582d8eeb2a544fb88
2019-08-08 11:11:03 -07:00
Sunny Goyal
e529a86fbd Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
2019-08-07 15:51:25 -07:00
Sunny Goyal
64a6fb063e Merge "Revert "Use new onTaskListUpdated() callback"" into ub-launcher3-master 2019-08-07 14:49:52 +00:00
Sunny Goyal
54bbbdfa61 Revert "Use new onTaskListUpdated() callback"
This reverts commit a04997b081.

Reason for revert: Platform master has API changes, and launcher-master should still map to qpr branch

Change-Id: Ib201c71b5557715d585d322ec2a1a528e352e61c
2019-08-07 13:49:41 +00:00
Vinit Nayak
0664d9ad09 Merge "Use new onTaskListUpdated() callback" into ub-launcher3-master 2019-08-06 22:40:23 +00:00
Pinyao Ting
e4061fc931 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
Merged-In: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 23:31:35 -07:00
Pinyao Ting
49a3e699f9 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 20:41:58 -07:00
Sunny Goyal
1217919981 Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev am: 6cf32a2e95
am: bafd62971a

Change-Id: I1b981e07329a0a6fc0667af58188c9ba047f068d
2019-08-05 17:39:42 -07:00
Sunny Goyal
bafd62971a Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev
am: 6cf32a2e95

Change-Id: I7313eb81291d3fbe353882446d7da39bba355ec9
2019-08-05 17:33:42 -07:00
TreeHugger Robot
6cf32a2e95 Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev 2019-08-06 00:21:01 +00:00
James O'Leary
d103d64f09 Merge "Fix inability to dismiss Assistant answer when launcher frontmost" into ub-launcher3-qt-r1-dev am: 290a9a814a
am: c714f1657b

Change-Id: I7c227379a4f429c8f73828782f64bfd89fb90eec
2019-08-05 15:26:45 -07:00
James O'Leary
c714f1657b Merge "Fix inability to dismiss Assistant answer when launcher frontmost" into ub-launcher3-qt-r1-dev
am: 290a9a814a

Change-Id: I128fb662ea38a00f3a14734aae9c5c1bbb849b09
2019-08-05 15:20:46 -07:00
Sunny Goyal
1eade2f947 Use task display id when starting split screen
Before starting split screen animation, we dismiss the task view, which
can detach the clicked view immediately, if animations are dissabled.
That will cause NPE as view.getDisplay will be null

Bug: 138793362
Change-Id: I611f6a824f756eceeed57aac5afdf38f421ff8d2
2019-08-05 11:24:43 -07:00
TreeHugger Robot
71b6d24964 Fix inability to dismiss Assistant answer when launcher frontmost
Bug: 136282913
Test: Verify Assistant answer card be dismissed from Home
Change-Id: I84d0a9bda333bc2f99161096299acfaa387ecf1e
2019-08-05 14:01:08 -04:00
Tracy Zhou
91e7a72217 Change RecentsAnimationListenerSet interface (Launcher)
am: bd7acf7665

Change-Id: I52b654212200962d3c2f1fe4376f2001736fcb0e
2019-08-01 21:54:14 -07:00
Tracy Zhou
bd7acf7665 Change RecentsAnimationListenerSet interface (Launcher)
Bug: 138683199
Test: N/A
Change-Id: Ic53ef92fe4d5b55ff1d105a250accdf6f6c0916b
(cherry picked from commit 8e8a36f673)
2019-08-02 03:44:37 +00:00
Tony Wickham
213dfabe3b Return mIconLastSetTextAlpha from TEXT_ALPHA property am: 8ed3b437b1
am: f489a71365

Change-Id: I255c795eef142699b97b46e46f61c4a054a93108
2019-08-01 16:01:28 -07:00
Becky Qiu
9c6cfb4e04 Fill the log container as hotseat or workspace based on position.
am: 84fa94e2fc

Change-Id: If9a5d88062addbd09909e04ef5c2c59e7e5488a7
2019-08-01 16:00:47 -07:00
Tony Wickham
f489a71365 Return mIconLastSetTextAlpha from TEXT_ALPHA property
am: 8ed3b437b1

Change-Id: I01cada1a1cca22e2e7792b019dd74221c0451cf3
2019-08-01 15:44:40 -07:00
Jon Miranda
3ff3991f48 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev am: 9da9a2bd21 am: f20a7d252c
am: 783717c0c6

Change-Id: I2c9738fa84d781cbfa9a6fbc071468a5247190ef
2019-08-01 15:31:05 -07:00
Tony
3a54ba9296 Don't end launcher components anim early even if it does nothing am: 03c548901f am: 1d7e474c69
am: 13bdbffe29

Change-Id: I1fdc0c3fff32c05da159d61b8a8a7b484b24f147
2019-08-01 15:30:42 -07:00
Becky Qiu
84fa94e2fc Fill the log container as hotseat or workspace based on position.
Test: manual
Bug: 137953006

Swipe from workspace:
07-30 15:15:44.031  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:44.031  9779  9779 D UserEvent:  Source child:WORKSPACE id=0 span(951,1313)	parent:WORKSPACE id=0
07-30 15:15:44.031  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:44.031  9779  9779 D UserEvent:  Elapsed container 826 ms, session 9361 ms, action 0 ms

Swipe from hotseat:
07-30 15:15:46.010  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:46.010  9779  9779 D UserEvent:  Source child:HOTSEAT id=0 span(786,1908)	parent:WORKSPACE id=0
07-30 15:15:46.010  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:46.010  9779  9779 D UserEvent:  Elapsed container 1139 ms, session 11339 ms, action 0 ms

Change-Id: I959528889fda778efc569bb59e7f44d3bd5b81bc
2019-08-01 22:24:44 +00:00
Tony Wickham
8ed3b437b1 Return mIconLastSetTextAlpha from TEXT_ALPHA property
This was supposed to go in the last CL but I forgot to commit...

Bug: 132455160
Change-Id: Ieb66b1f256d7b14c84bbd4d10af1aa8b073d5ac3
2019-08-01 15:20:03 -07:00
Jon Miranda
783717c0c6 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev am: 9da9a2bd21
am: f20a7d252c

Change-Id: I3fcfe4dc137756d5b4a049468632d111ca7fa4f6
2019-08-01 15:19:01 -07:00
Tony
13bdbffe29 Don't end launcher components anim early even if it does nothing am: 03c548901f
am: 1d7e474c69

Change-Id: I1f1f70c2791755535d1318b636e37a745e97d057
2019-08-01 15:18:36 -07:00
Jon Miranda
f20a7d252c Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev
am: 9da9a2bd21

Change-Id: Icae4fd3fef3ad221d45e8d9ecdcc018813d560f3
2019-08-01 15:05:00 -07:00
Tony
1d7e474c69 Don't end launcher components anim early even if it does nothing
am: 03c548901f

Change-Id: Ifb228b935659e971facfd8d6bb4c56ab54424e68
2019-08-01 15:04:36 -07:00
TreeHugger Robot
9da9a2bd21 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev 2019-08-01 21:47:47 +00:00
Tony
03c548901f Don't end launcher components anim early even if it does nothing
The janky animation that ends on the home screen with an invisible
task on top is caused by the following scenario (for example):
- Quick switch from task A to task B
- After landing on B, but before we get the callback that it was
  successfully launched, switch back to A (or you could go to C)

Now we are animating back to A, but we are still waiting to hear
whether B was successfully launched. If we hear that the launch
was indeed successful, we dutifully clean up after ourselves  by
returning launcher to its default state. Unfortunately, that
clobbers the current animation that is scrolling back to A, and
we end up in the bad state where we are showing the default
launcher state even though we just launched task B and were
about to launch task A.

Normally we avoid cleaning up the state animation if the user
is still controlling it. The reason we weren't doing that here
is because we ended the launcher animation early even though
the window animation was still running. Instead, we should keep
the launcher animation running for the full duration, so that
it prevents a cleanup from occurring in the middle.

Bug: 138620399
Change-Id: I959e62a52638a5b974ef9b406555078c928b91f1
2019-08-01 13:28:43 -07:00
Tony Wickham
dd53ba5065 Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev am: 1343f03e2e
am: 70f539cd45

Change-Id: Ifddcba1cd63950424f88ad1d8e01fa9a11f73a2e
2019-07-31 15:50:44 -07:00
Tony Wickham
70f539cd45 Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
am: 1343f03e2e

Change-Id: Ie3f4c2c15e331c84f0f048c6337ae4e58111ec56
2019-07-31 15:36:50 -07:00
Tony Wickham
1343f03e2e Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
* changes:
  Tie prediction text to all apps interpolator
  Add OverviewScrim to show below overview but above workspace
2019-07-31 22:12:54 +00:00
Tony Wickham
35a4e0eec9 Tie prediction text to all apps interpolator
Now floating headers get 2 interpolators: one for the header content
itselt, and one for the all apps content that follows. That way, they
can choose to intperolate part of their content as if it were part of
all apps instead of the header. Currently, we do this to animate
predicted icons quickly, followed by the all apps icons, predictions
text, all apps scrollbar, and all apps divider as you continue swiping.

Bug: 132455160
Change-Id: Ib3e373c291e174e1306a53854d0ad4dc29eb4b76
2019-07-31 14:45:18 -07:00