Commit Graph

4333 Commits

Author SHA1 Message Date
The Android Open Source Project
05a4c9e19a DO NOT MERGE - Merge RP1A.201005.006
Bug: 168212094
Merged-In: Idef112187f34a18feea7e6a0b77258626f9d0ed4
Change-Id: Ibab48c1925a0ab7a80ddcaba45a7b73219bb0b0a
2020-10-06 16:53:21 +00:00
Tony Wickham
c7c9e80d58 Store mHistoricTimes as longs intead of floats
The loss of precision was causing us to miscalculate the age of
events, and thus not detecting any pause due to denominator = 0.

Test: have a device that hasn't been rebooted for a certain
amount of time such that SystemClock#uptimeMillis can't be
accurately converted to a float, then try to swipe up and hold

Fixes: 160568387
Change-Id: Idef112187f34a18feea7e6a0b77258626f9d0ed4
(cherry picked from commit a145670969)
(cherry picked from commit 31ef24c934)
2020-08-19 02:19:24 +00:00
Sunny Goyal
15bcf24af6 Fixing wrong velocity state when there are too few samples
Bug: 160568387
Change-Id: I32b3b7ee1bff5595941fc0c0b37c9f5a28d1a1fa
(cherry picked from commit 48afb6b3b9)
(cherry picked from commit f58a2b9cd9)
2020-08-19 02:19:22 +00:00
Sunny Goyal
c3771e64d9 Fixing swiping up on home interrupting animation am: d481c5c58c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12152002

Change-Id: I62a4e0cb58d2159730295129724b05cbfdc11af4
2020-07-15 19:56:21 +00:00
Sunny Goyal
d481c5c58c Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
Merged-In: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
(cherry picked from commit 93188d61da)
2020-07-15 07:11:30 +00:00
Sunny Goyal
0ed6042555 Preventing disambiguation screen when swiping up am: f130c29882
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: I77b4149f114788606d1b249adf2e1bfe82de65af
2020-07-13 21:37:58 +00:00
Sunny Goyal
f130c29882 Preventing disambiguation screen when swiping up
Bug: 161052537
Change-Id: Ibeeba0841963dc5eb1b5a09847cafc26eb6e4adc
2020-07-13 19:03:56 +00:00
Sunny Goyal
e9bf882158 Import translations. DO NOT MERGE
Force snapping translations from unbundled branch
Bug: 159176821

Test: N/A
Change-Id: I2406edf7eef6aa683f99b2b5f897d16b8968a28d
2020-07-10 12:07:45 -07:00
TreeHugger Robot
7f1f8030db Merge "Persist prediction cache on every update" into rvc-dev 2020-07-08 18:35:26 +00:00
Sunny Goyal
52f2392405 Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
(cherry picked from commit 141c231d2f)
2020-07-08 00:24:29 +00:00
Sunny Goyal
f16456f686 Persist prediction cache on every update
Test: Manual
Bug: 160058750
Change-Id: Icb0b7322b7f9754d3f1c3012e1c98a760f83c787
2020-07-07 18:22:37 +00:00
Thiru Ramasamy
6f5d4bb8ab Merge "Fixes NPE with system shortcuts." into rvc-dev 2020-06-29 23:35:59 +00:00
thiruram
43bf883841 Fixes NPE with system shortcuts.
Bug: 160109140
Change-Id: I35c00fc1792fcf11fc61e1876f9184bd5fb309ce
(cherry picked from commit 53925ff9c6)
2020-06-29 19:44:28 +00:00
Zak Cohen
19797b419b Thumbnail Cache - check canceled status on the right thread.
The cache was checking the canceled status on the background
thread, but the cancel call was being made on the main thread.
This was leading to canceled requests still delivering this thumbnail
in some cases.

Bug: 159840851
Test: local build and non-repo of bug
Change-Id: I9a3556f6570eee1db39ebec202c115d58010d7f8
2020-06-29 04:11:04 +00:00
Samuel Fufa
0036b2b67a Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 20:10:01 +00:00
TreeHugger Robot
ccf588d36b Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev 2020-06-25 16:38:47 +00:00
Tony Wickham
9e84745e4b Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
(cherry picked from commit c6a56ef7a2)
2020-06-25 02:11:04 +00:00
Andy Wickham
d2731957ea Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
(cherry picked from commit 4b531b972d)
2020-06-24 22:32:14 +00:00
TreeHugger Robot
ca493d1426 Merge "Fixing NPE befre ActionsView first initialized." into rvc-dev 2020-06-24 06:52:16 +00:00
TreeHugger Robot
d6cd14d179 Merge "Remove hotseat edu flag" into rvc-dev 2020-06-24 04:43:52 +00:00
Sreyas
20024f4447 Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
(cherry picked from commit 88f1f2046c)
2020-06-24 04:11:05 +00:00
Zak Cohen
b2b0d4d478 Merge "Fixing TaskMenu positioning." into rvc-dev 2020-06-24 03:58:19 +00:00
Samuel Fufa
6293af5575 Remove hotseat edu flag
Launcher should not restrict user migration to a one time event if we want users to migrate their hotseat by enabling hotseat prediction from suggestion settings.

Test: Manual
Bug: 159731272
Change-Id: I0e42dd6b6cf6374928e5b399d121d17fe8024ae1
2020-06-24 02:01:07 +00:00
Sreyas
98ef53458d Fixing TaskMenu positioning.
Bug: 159728554
Change-Id: I4a666363f092b5416edecd0731a0f448916c8def
2020-06-24 00:14:21 +00:00
Sunny Goyal
315eb02012 Merging from ub-launcher3-rvc-dev @ build 6621659
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6621659.html

Change-Id: Id9689e3dfa641c0e004c9dc975e281358bed7ad7
2020-06-23 16:28:38 -07:00
TreeHugger Robot
359a28e934 Merge "Prevent premature resetting of quickswitch mode" into ub-launcher3-rvc-dev 2020-06-23 22:42:48 +00:00
Vinit Nayak
f2daafcdf8 Prevent premature resetting of quickswitch mode
Previously, whenever a user returned to the same
rotation that they had started quickswitch in,
we were sending sysui the reset flag(-1) indicating
that quickstep was complete instead of sending
the rotation of the device the user was in.

This was intentional and it worked, however we now
always send the active rotation while the user
is in a quickswitch session because sysui needs
to show the fake home handle for immersive apps,
which can occur in any rotation. This state is
distinct from not being in quickswitch at all, in
which no fake handles are shown.

Fixes: 158677967

Change-Id: I910324abf781b4b30fe981139712bcb5b653c318
2020-06-23 15:07:22 -07:00
Samuel Fufa
a44c09d6c9 Fix hotseat button alignment
Screenshot: https://screenshot.googleplex.com/Vr9FXe3oN2t
Bug: 159731214
Change-Id: I9e413f5d9bf0144edd413cc5995e7f1fda152f28
2020-06-23 12:46:30 -07:00
Tony Wickham
b47a99e3cc Store newGestureState before onConsumerAboutToBeSwitched clears it
Bug: 159659393
Change-Id: If98d54b7ca397ef56a5c6d50c0fd92f25a9494b4
(cherry picked from commit efb7e60edc)
2020-06-23 16:45:51 +00:00
Hyunyoung Song
85d90a16bc Merging from ub-launcher3-rvc-dev @ build 6617269
Bug: 150504032
Test: manual, presubmit on the source branch
https://android-launcher.teams.x20web.corp.google.com/merge/ub-launcher3-rvc-dev_rvc-dev_6617269.html

Change-Id: I7a13230553f9c42d5f67164234c33cf77efa9cf2
Merged-In: I2a168bfa8e3979ade26ab1d3cddbbae84cf79590
2020-06-23 05:11:31 +00:00
TreeHugger Robot
ea3edf1247 Merge "Log query_length & parent_container for actions on search results." into ub-launcher3-rvc-dev 2020-06-23 02:16:44 +00:00
TreeHugger Robot
7551b6191f Merge "Store newGestureState before onConsumerAboutToBeSwitched clears it" into ub-launcher3-rvc-dev 2020-06-23 01:33:55 +00:00
thiruram
dbd61d4026 Log query_length & parent_container for actions on search results.
Bug: 154717227
Change-Id: I8e7d725014f60a2fd9a7fe13fce705acbc7623ad
2020-06-22 18:14:12 -07:00
Tony Wickham
efb7e60edc Store newGestureState before onConsumerAboutToBeSwitched clears it
Bug: 159659393
Change-Id: If98d54b7ca397ef56a5c6d50c0fd92f25a9494b4
2020-06-22 17:37:07 -07:00
Thiru Ramasamy
51ece1847c Merge "Adds additional folder label states (UNLABELED & EMPTY_LABEL)" into ub-launcher3-rvc-dev 2020-06-22 21:04:12 +00:00
TreeHugger Robot
ceaad08f06 Merge "Fixing rotation watcher not enabled in landscape" into ub-launcher3-rvc-dev 2020-06-22 21:00:07 +00:00
thiruram
ec75cbd85a Adds additional folder label states (UNLABELED & EMPTY_LABEL)
UNLABELED -> title==null and EMPTY_LABEL -> title=="". When adding new items for the folder if the folder is in UNLABELED state, auto-labeling will be enabled.
This change also addresses auto-labeling issue due to false edit from UNLABELED to EMPTY.

Bug: 159164315

Change-Id: Ia17cd27b4afb60420dc15c544f544061fc46ad33
2020-06-22 13:24:07 -07:00
Hyunyoung Song
5c9a1ef5cd Merge "Log Launcher transitions to WW" into ub-launcher3-rvc-dev 2020-06-22 20:21:10 +00:00
Sunny Goyal
f67deb8e06 Fixing rotation watcher not enabled in landscape
Bug: 159636793
Change-Id: Ia7e5d90e9d441dfbe9877293957eff1ae7f69877
2020-06-22 13:02:53 -07:00
Hyunyoung Song
801f81fba5 Log Launcher transitions to WW
- ONRESUME / ONSTOP
- HOME_GESTURE
- OVERVIEW_GESTURE
- QUICKSWITCH
- SWIPELEFT/SWIPERIGHT

Bug: 156875719
Bug: 148822714
Bug: 137777105

Debug log: go/launcher-log-parity

Change-Id: I64a0deab4996b5be36320fbe0339f320891c53e0
2020-06-22 12:09:06 -07:00
TreeHugger Robot
ce629ff837 Merge "Handling Launcher configuration change between touchDown and Launcher.onStart" into ub-launcher3-rvc-dev 2020-06-22 18:04:14 +00:00
Samuel Fufa
6dac493218 Merge "Send app launch events from TaskSwitcher" into ub-launcher3-rvc-dev 2020-06-22 17:36:12 +00:00
TreeHugger Robot
845f135d17 Merge "Add depth animation when multiwindow mode changes." into ub-launcher3-rvc-dev 2020-06-22 17:31:35 +00:00
Sunny Goyal
6fe83da57c Handling Launcher configuration change between touchDown and Launcher.onStart
If activity rotation is allowed, Launcher/recents can rotate while swipe animation
is running leading to inconsistencies between deviceProfile and rotation
> Using activity configuration to determine the rotation instead of using display rotation
> Removing rotation watcher when rotation is enabled as it is not used anymore

Bug: 158781568
Change-Id: I107d856cae80af111c0514656fac7ab1fa0c21cb
2020-06-22 10:04:35 -07:00
Tony Wickham
698dfc03cb Merge "Don't reset GestureState when touching outside of swipe region" into ub-launcher3-rvc-dev 2020-06-22 16:20:22 +00:00
TreeHugger Robot
b22655f8e1 Merge "Revert "Allow shortcut predictions in hybrid hotseat"" into ub-launcher3-rvc-dev 2020-06-21 07:24:25 +00:00
Winson Chung
c46daa9572 Merge "Tweak quickswitch thresholds" into ub-launcher3-rvc-dev 2020-06-21 04:08:09 +00:00
Winson Chung
4941f65d52 Tweak quickswitch thresholds
- Reduce slop for gestural mode (and apply multiplier to slop
  at checktime)
- When quickswitch threshold is passed, reduce the total movement
  check and reduce the velocity needed to fling to the next page
  to accommodate short swipes
- Use touch slop to determine scrolling in paged view, and only
  use paging slop to determine flinging to the next page (when
  easy flings are disabled (which is the default))

Bug: 157165240
Test: Ensure the flings in normal overview/paged views don't change,
      check short flings from quickswitching
Change-Id: Idd04ce23f53c06759e84ac8ad73cf2cc6dff6975
2020-06-20 19:41:32 -07:00
TreeHugger Robot
5ec76de182 Merge "Deleting old cache images before saving new ones." into ub-launcher3-rvc-dev 2020-06-20 20:19:01 +00:00
Tony Wickham
61fa23ab3a Don't reset GestureState when touching outside of swipe region
We were setting mGestureState = DEFAULT_STATE when touching outside
of the swipe region. Instead, we should only set mGestureState when
starting a new gesture, and only set it to DEFAULT_STATE on reset.

This also makes it clearer that mGestureState always refers to the
current gesture state, rather than sometimes being the current
gesture and sometimes being the previous gesture depending on
where it was used. Now previousGestureState is passed when needed.

Bug: 159494933
Change-Id: Ib62278b7c591ca4c6b99b26e058a34772e6cec2a
2020-06-20 12:04:12 -05:00