Commit Graph

3683 Commits

Author SHA1 Message Date
Tony Wickham
5435eb27c1 Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 8db306f3c5 am: f8bfb7ab90
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081302

Change-Id: Ie85cb113acf36b1bb8f343d15aadb92a9e7f4d16
2021-06-24 01:32:04 +00:00
TreeHugger Robot
3a7d29e6c0 Merge "Ensure InputConsumer is non-null in remaining cases" into sc-dev am: 862224f913 am: 89d1c77669
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15084524

Change-Id: I9694ce0382950baed5e7237e936d41830e9364ce
2021-06-24 01:31:57 +00:00
Tony Wickham
8db306f3c5 Merge "Fix some touch issues during gesture nav transition" into sc-dev 2021-06-24 01:08:43 +00:00
TreeHugger Robot
862224f913 Merge "Ensure InputConsumer is non-null in remaining cases" into sc-dev 2021-06-24 01:04:18 +00:00
Tony Wickham
f64f9a14d8 Ensure InputConsumer is non-null in remaining cases
Anywhere that was using mResetGestureInputConsumer now uses getDefaultInputConsumer, which returns NO_OP if mResetGestureInputConsumer is null.

Test: none
Bug: 191684742
Change-Id: I1ae02b01a9629fa0830955dfe4d83c95a4759c14
2021-06-23 16:39:44 -07:00
Hilary Huo
04f50d616e Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev am: 08843d8e37 am: 1f306ec22a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15068624

Change-Id: Id90ce19c4ab2f03e654e18af44292887aca03e1e
2021-06-23 22:40:10 +00:00
Hilary Huo
08843d8e37 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev 2021-06-23 22:18:00 +00:00
Tony Wickham
1351c2214d Fix some touch issues during gesture nav transition
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
  - Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
  - Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.
- Don't recreateControllers() if orientation didn't change
  - Test: swipe up to go from an app to home, swipe up to all apps during the transition.
  - Previously, we were getting the following sequence:
    1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
    2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
  - Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.

Test: see above
Fixes: 189700453
Change-Id: Icfa5b6cdb32122adaf6ac8e8cb197b0c477dac60
2021-06-23 13:07:18 -07:00
Tracy Zhou
2f8342d791 Merge "Finish recents animation on task dismissal only if the task is a live tile task" into sc-dev 2021-06-23 19:40:15 +00:00
Lucas Dupin
4d86e17e9d Merge "Disable blurs when dev setting or battery saver" into sc-dev am: 697e51cd8c am: 4f22283658
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15069844

Change-Id: I56502e0a130e0ca202f4e0f806fd021afc7a43b8
2021-06-23 19:24:38 +00:00
Lucas Dupin
697e51cd8c Merge "Disable blurs when dev setting or battery saver" into sc-dev 2021-06-23 18:40:43 +00:00
Zak Cohen
7b711e5e59 Merge "Sets a simple locus id when Overview is enabled" into sc-dev am: e43edc74ef am: 4043a3d689
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15053498

Change-Id: I7af6c4ef50562b1c133b6da9c7a08d635a6df393
2021-06-23 17:56:31 +00:00
Schneider Victor-tulias
4213fc70f0 Merge "Update gesture nav tutorial back left and right videos" into sc-dev am: bef29071b5 am: de49434e13
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14969574

Change-Id: I8566132041b4bb48c46519a74f1e1bcb545dbce6
2021-06-23 17:55:59 +00:00
Tracy Zhou
a425d05df4 Finish recents animation on task dismissal only if the task is a live tile task am: 2591768d54 am: f7577df404
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15072976

Change-Id: Ie1d57dac2f6fd3d67f2afe80628ddc41ba17d492
2021-06-23 17:43:46 +00:00
Zak Cohen
e43edc74ef Merge "Sets a simple locus id when Overview is enabled" into sc-dev 2021-06-23 17:38:16 +00:00
Schneider Victor-tulias
bef29071b5 Merge "Update gesture nav tutorial back left and right videos" into sc-dev 2021-06-23 17:28:35 +00:00
Tracy Zhou
d537968b35 Finish recents animation on task dismissal only if the task is a live tile task
Fixes: 191831190
Test: manual
Change-Id: Ie1dd02a2e8cc401a613a0ed2199400712c6d5291
Merged-In: Ie1dd02a2e8cc401a613a0ed2199400712c6d5291
2021-06-23 17:18:00 +00:00
Hilary Huo
e83189593a [settings-pixel-search] Add ww logging to track slice fetching timeout
Test: https://paste.googleplex.com/6310936320147456
Bug: 191297465
Change-Id: I0a4a65295e7290b55dccdb63830ff60c6838fbb2
2021-06-23 10:16:21 -07:00
Lucas Dupin
b60fff3929 Disable blurs when dev setting or battery saver
Stop rendering blurs whenever a user:
- disables blurs on developer settings
- enables battery saver

Test: manual
Bug: 191814337
Change-Id: I8fd04796054d92171732c8db95b64cfa3ec469ec
2021-06-23 08:37:27 -07:00
Tracy Zhou
2591768d54 Finish recents animation on task dismissal only if the task is a live tile task
Fixes: 191831190
Test: manual
Change-Id: Ie1dd02a2e8cc401a613a0ed2199400712c6d5291
2021-06-23 05:31:09 +00:00
zakcohen
e2c4687e51 Sets a simple locus id when Overview is enabled
Bug: 189968849
Test: Ran with logcat to check correct locus is set
Change-Id: I5253d83b4cf5862e49c3183a843bf8f26dce149e
2021-06-22 16:46:30 -07:00
Winson Chung
5b50e92a65 Merge "Don't finish to home when launching a task from recents" into sc-dev am: d27f127b3a am: 87c7e0d963
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15057896

Change-Id: If53c0028ef6e15afca447df349ec0fab4cc4ebc8
2021-06-22 19:32:50 +00:00
Winson Chung
76d5158c66 Merge "Don't finish to home when launching a task from recents" into sc-dev am: d27f127b3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15057896

Change-Id: Iaa2522dca2785a3fa0094c75dc55f201cc000940
2021-06-22 19:10:08 +00:00
Winson Chung
d27f127b3a Merge "Don't finish to home when launching a task from recents" into sc-dev 2021-06-22 18:54:14 +00:00
Winson Chung
856cd1bd4d Don't finish to home when launching a task from recents
- When launching without a task view, we should also not be finishing
  to home (similar to composeRecentsLaunchAnimator) since it will
  clobber the newly launched task

Fixes: 191182965
Test: Open overview with live tile, try to open usb debugging settings
      page
Change-Id: If7464ebf155cee33e81205fbf4899e9ab49a52d0
2021-06-22 18:54:03 +00:00
Cyrus Boadway
05461df6c0 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev am: 9dd0351ed1 am: e995155f7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15062776

Change-Id: I3826fc194a75d3afc20cef9474d19b25f078f00f
2021-06-22 18:37:45 +00:00
Sunny Goyal
1bf8b7e9d0 Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev am: eb3367796a am: ed0d2c40f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032513

Change-Id: I30ba9bdbec9cd20e1b5691d40b183dbf274ced44
2021-06-22 18:37:40 +00:00
Cyrus Boadway
32f7517f19 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev am: 9dd0351ed1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15062776

Change-Id: I86e28dc686e769da4760959ec4343d659a4fd602
2021-06-22 18:20:50 +00:00
Sunny Goyal
9ffb0f803b Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev am: eb3367796a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032513

Change-Id: I0b76512550814f23fde9c95a59e90e50280e3dde
2021-06-22 18:20:46 +00:00
Cyrus Boadway
9dd0351ed1 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev 2021-06-22 18:13:52 +00:00
Sunny Goyal
eb3367796a Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev 2021-06-22 18:08:25 +00:00
Tracy Zhou
04f866bf1b Merge "Null check on target set before rendering task open animation" into sc-dev am: 578b45f919 am: af60e8e5b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14698046

Change-Id: I3ea98b76e73a047f831079a9e5f1ad03c7dcf2c5
2021-06-22 18:00:30 +00:00
Tracy Zhou
6b4c93b0dc Merge "Null check on target set before rendering task open animation" into sc-dev am: 578b45f919
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14698046

Change-Id: I12121c440cf1fb95347b01cd5704a28ac088c951
2021-06-22 17:45:22 +00:00
Zak Cohen
3ab08fd258 Merge "Fade overview action buttons faster in overview -> home" into sc-dev am: 049c2f578b am: 7663208d0d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15054721

Change-Id: I366a9998531c8e478ecfe048200d86dca2bda655
2021-06-22 17:29:00 +00:00
Matt Casey
37567c24f8 Merge "Send a zero for assist invocation on animation end" into sc-dev am: 3a65795298 am: d85152e484
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15065435

Change-Id: I0327d3932072b5e3829f9139f822defc17b50964
2021-06-22 17:28:36 +00:00
Tracy Zhou
578b45f919 Merge "Null check on target set before rendering task open animation" into sc-dev 2021-06-22 17:21:32 +00:00
Zak Cohen
a6dd5b49d7 Merge "Fade overview action buttons faster in overview -> home" into sc-dev am: 049c2f578b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15054721

Change-Id: I680d45f36df17c08936a29b502c8e09765df3f72
2021-06-22 17:03:20 +00:00
Matt Casey
f37285049a Merge "Send a zero for assist invocation on animation end" into sc-dev am: 3a65795298
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15065435

Change-Id: Ib5837248faef0c9ee2160b34dbd1e3adb40b0699
2021-06-22 17:02:36 +00:00
Zak Cohen
049c2f578b Merge "Fade overview action buttons faster in overview -> home" into sc-dev 2021-06-22 16:53:52 +00:00
Matt Casey
3a65795298 Merge "Send a zero for assist invocation on animation end" into sc-dev 2021-06-22 16:46:41 +00:00
Matt Casey
eeac1aba30 Send a zero for assist invocation on animation end
When a corner gesture doesn't complete, we animate the progress from its
current value back to 0. When it hits 0, sysui will perform some cleanup
e.g. removing the window. However, it's possible the animator won't
return exactly 0 and will complete, so we should send an explicit 0
whenever the animator completes.

Bug: 187768368
Test: We don't have a repro for the bug, but expect this should be more
      robust. Tested to validate it didn't regress.
Change-Id: Id65f94534363c326fc2c8d0a9114a3c036aa55e4
2021-06-22 10:46:10 -04:00
Cyrus Boadway
f158ec33d8 Use icon splash screen when starting activity from widget interaction
Set the flag to use the icon splash screen rather than the empty splash
screen when starting an activity from a widget interaction.

Bug: 191738655
Test: manual
Change-Id: Iff771a43648bbf6dfb88e2a6749c4526fd17da07
2021-06-22 10:14:06 +00:00
Tracy Zhou
8af0dd3e0c Null check on target set before rendering task open animation
Fixes: 190854921
Test: N/A
Change-Id: Iae7ef7cf3f4d2309223bfabe6d40f24b7e34439c
2021-06-21 21:33:28 -07:00
Lucas Dupin
9a6bde9234 Merge "Apply depth even when surface is null" into sc-dev am: 818ed4b794 am: 07b3fc2d2c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15055654

Change-Id: Ib7e69cdf0a320697510c87dd321de4390e05445c
2021-06-22 01:52:16 +00:00
Lucas Dupin
f87cd286d5 Merge "Apply depth even when surface is null" into sc-dev am: 818ed4b794
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15055654

Change-Id: I8ecba7fb05ad49dfadba39d849167b0b696304f3
2021-06-22 01:26:46 +00:00
Lucas Dupin
818ed4b794 Merge "Apply depth even when surface is null" into sc-dev 2021-06-22 01:10:23 +00:00
Lucas Dupin
a6c38be150 Apply depth even when surface is null
We need to update mDepth even when the surface is null, otherwise
events will be ignored and mDepth will have the wrong value when
waking up from screen-off.

Test: pull up app drawer, screen off, unlock
Test: go to overview, screen off, unlock
Test: launch app, observe blurs and zoom
Fixes: 191153501
Change-Id: I33f5d84a50e24f05a09769b1f7f3c27969f847cd
2021-06-21 16:27:11 -07:00
Sunny Goyal
6cc492941b Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb am: b6cdee307b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: I250b79241b12f23c0f53d1710887bf7327071cfb
2021-06-21 23:11:44 +00:00
Tony Wickham
10018d2191 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5 am: 4de1650940
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: I3943bc9286ae242dca9e9256ea34e65937463a10
2021-06-21 23:11:35 +00:00
Sunny Goyal
696c612964 Fixing TaskView.launchTask.onEndCallback is not called
Sometimes onAnimaitonCancelled can be called without onCreate. Calling
onEnd in this case so that the sate is cleared

Removing additional subclassing for the runner

Bug: 190856140
Test: Manual
Change-Id: If105cb343cab446a4eac90a45184ce50c6e4c485
2021-06-21 16:06:40 -07:00