Jagrut Desai
53d953ccd2
Taskbar All Apps Shortcut Menu Acccessibility Focus
...
Bug: 280657266
Test: manual
Flag: not needed
Change-Id: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
2023-06-28 14:48:54 -07:00
Winson Chung
7c500166b2
Reset the static preloaded icon result once launcher is hidden
...
- In the case where the system does not play the requested animation
we can still ensure that this doesn't result in a leak of the
activity by resetting the result when launcher is hidden (which
happens after the launch transition)
Bug: 285995223
Test: Presubmit
Test: Take heapdump after repro steps in b/285995223#comment6 and verify
there are no lingering static icon load results
Change-Id: I1d169df158cfaab64fbe1f4ce597d8f73d86a1c1
2023-06-14 19:39:58 +00:00
Jon Miranda
10b3e64d51
Merge "Update taskbar paddings/sizes to match spec." into udc-dev
2023-06-08 23:55:06 +00:00
Fengjiang Li
5d81dd2d77
Merge "Fix NPE where CellLayout is null when removing item out of folder" into udc-dev
2023-06-08 19:33:52 +00:00
Fengjiang Li
d29db8ea4d
Fix NPE where CellLayout is null when removing item out of folder
...
Fix: 282249989
Test: create a folder of 2 app icons, remove one icon out of folder, no crash
Change-Id: I3c132ec8833c7cb14066cc403c0641d089bab8ab
2023-06-07 15:36:54 -07:00
Treehugger Robot
ffdcac46b6
Merge "Log UserManager users and cached users each time users accessed" into udc-dev
2023-06-07 22:08:03 +00:00
Vinit Nayak
9377e56f47
Log UserManager users and cached users each time users accessed
...
Bug: 243688989
Change-Id: Ifa6eec39f9fc90a4871ac2ff010588c3a5cac531
2023-06-07 11:32:01 -07:00
Jon Miranda
95f4472ba9
Update taskbar paddings/sizes to match spec.
...
Bug: 282798528
Test: manual with screenshots
Change-Id: I00c646d9cd11a9015e14f8311ba2ff233d8321ac
2023-06-07 11:19:50 -07:00
Schneider Victor-tulias
bfa0fae851
Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev
2023-06-07 16:49:20 +00:00
Schneider Victor-tulias
ab51f2110a
Add null-check to findLastActiveTaskAndRunCallback
...
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys
Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
TreeHugger Robot
ed4695e37e
Merge "Enabled NOTIFY_CRASHES for teamfood" into udc-dev
2023-06-06 16:29:12 +00:00
Tony Wickham
670f17f560
Enabled NOTIFY_CRASHES for teamfood
...
Flag: NOTIFY_CRASHES
Test: none
Fixes: 285951384
Change-Id: I1f4905e0b797f4d0d7356cad0be4d98bfa09a3b7
2023-06-05 22:15:18 +00:00
Anushree Ganjam
f781ef81bf
Remove @WorkerThread annotation and Preconditions.assertWorkerThread check.
...
`BaseLauncherBinder.bindAllApps` and `BaseModelUpdateTask.bindApplicationsIfNeeded` can be called on both UI and Background thread.
Bug: 285711446
Test: Manual
Flags: NA
Change-Id: If6f6cce5f6e37fb21609aded8587afbdffda7545
2023-06-05 19:06:00 +00:00
Andrew Cole
f011d43325
Merge "Multi-line titles supporting RTL" into udc-dev
2023-06-02 19:04:50 +00:00
TreeHugger Robot
4ad5ffd0a1
Merge "Revert "Adding tracing for workspace loading that never finishes"" into udc-dev
2023-06-02 18:59:47 +00:00
Vadim Tryshev
d8b470cf2f
Revert "Adding tracing for workspace loading that never finishes"
...
This reverts commit 80bb8a12da .
Reason for revert: Cleanup after the bug is fixed. Tracing is not necessary anymore.
Change-Id: I1bb2bc59dd5debb51b094f14430cd18a203ed33c
2023-06-02 15:28:18 +00:00
Vinit Nayak
43c79d23b3
Merge "Add logs for launcher user cache" into udc-dev
2023-06-02 02:57:40 +00:00
Anushree Ganjam
9b4f62e681
Merge "Add UID in AppInfo." into udc-dev
2023-06-02 01:17:29 +00:00
Vinit Nayak
134e429189
Add logs for launcher user cache
...
Bug: 243688989
Flag: None
Change-Id: I6f6ea3f3326c1814c2a50863e9bfbcb7e4323ae8
2023-06-01 17:11:42 -07:00
Anushree Ganjam
97434eea53
Add UID in AppInfo.
...
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.
Log Uid in Impression Logging.
Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA
Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Andrew Cole
0aae6049e2
Multi-line titles supporting RTL
...
In order to support multi-line titles in an RTL configuration we have to override
the androidx preferences library and manually set the text direction of the list view to be locale
Bug: 279880739
Test: Manual
Change-Id: I1f837a14a289e2ced8f8f3655f5ce061b37baa74
2023-06-01 15:08:35 -07:00
Brandon Dayauon
052045907c
Merge "Fix "Pause work apps" button in strange location" into udc-dev
2023-06-01 19:00:27 +00:00
Sunny Goyal
6c8d57d8b5
Merge "Fixing icon cache thrashing due to an unsupported icon" into udc-dev
2023-06-01 01:31:26 +00:00
Vadim Tryshev
5fe61d4ff7
Merge "Fixing a flake when workspace loading never finishes." into udc-dev
2023-06-01 00:50:25 +00:00
Sunny Goyal
41737b3e8b
Fixing icon cache thrashing due to an unsupported icon
...
Bug: 284032965
Test: Verified by reproducing the use case
Flag: N/A
Change-Id: I835dd545a01eb2fd7990e0fd5ad51bac0e4b1f33
2023-05-31 23:21:13 +00:00
Schneider Victor-tulias
2b06cbc748
Merge "Fix flaky null pointer in LauncherWidgetHolder" into udc-dev
2023-05-31 22:07:57 +00:00
Jagrut Desai
e208e02aba
Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev
2023-05-31 20:45:37 +00:00
Brandon Dayauon
6a14189b07
Fix "Pause work apps" button in strange location
...
The issue why the button sticks up is because of the translation not resetting when closing
All apps.
- This CL resets ime insets and the position of the button to the original location.
bug: 278722407
test: manual - before:https://drive.google.com/file/d/1_L4ICHrt582KcVcpvQDK9HciC_n5eiEy/view?usp=sharing
after: https://drive.google.com/file/d/1_G8-Jd_wdUKjy7vFj6iQ1QmCx_7Qrogn/view?usp=sharing
Change-Id: Ib32b8ef950d03aa812f30c2393e3cad3201c08da
2023-05-31 20:23:26 +00:00
vadimt
9c102e5634
Fixing a flake when workspace loading never finishes.
...
The flake was caused by the fact that addOnDrawListener(), the redraw is not guaranteed. This ultimately results to the workspace loading never finishing.
Forcing the redraw.
Bug: 267200150
Test: atest Launcher3Tests:com.android.launcher3.celllayout.ReorderWidgets#simpleReorder --rerun-until-failure
Flag: N/A
Change-Id: I47683425150a07ab2632e2bebdeca4d304e30d1b
2023-05-31 10:59:25 -07:00
Jagrut Desai
84e959a72a
Fixing Toast Hiding behind Taskbar - Part 2
...
Test: Visual, Manual
Bug: 282964229
Flag: not needed
Change-Id: If2373d8f0bc44a555844c78d20877e9636a7e176
2023-05-31 10:41:16 -07:00
Nick Chameyev
0bb67d4c2c
Merge "[Unfold animation] Disable preemptive launcher animation" into udc-dev
2023-05-31 10:03:03 +00:00
TreeHugger Robot
f7d08912fa
Merge "Add LAUNCHER_APP_LAUNCH_PENDING_INTENT where an app is launched through pending intent." into udc-dev
2023-05-31 06:13:38 +00:00
TreeHugger Robot
7dabd57f2d
Merge "Possibly fix the widget restoration bug" into udc-dev
2023-05-31 01:32:53 +00:00
Anushree Ganjam
cfbbf8510c
Add LAUNCHER_APP_LAUNCH_PENDING_INTENT where an app is launched through
...
pending intent.
Bug: Bug: 282236269
Test: Manual
Flag: NA
Change-Id: I6fb15a77f32ce5914f9632f5fb77f340acd3cfda
Merged-In: I6fb15a77f32ce5914f9632f5fb77f340acd3cfda
2023-05-30 23:47:22 +00:00
Treehugger Robot
6c3c6b3ae6
Merge "Fix widget picker crash" into udc-dev
2023-05-30 22:53:34 +00:00
Sihua Ma
48465319f6
Possibly fix the widget restoration bug
...
The update will always be considered as failed because we always return 0 for all the commits.
Test: N/A
Bug: 234700507
Change-Id: I33ee8af996cef62dbc14349f9a7dd3cb72836ab6
2023-05-30 15:12:00 -07:00
Treehugger Robot
3b7f4eb675
Merge "Fix invalid outline after widget resizing" into udc-dev
2023-05-30 22:06:10 +00:00
Fengjiang Li
a640098439
Merge "Clip folder chidren during folder open/close animation" into udc-dev
2023-05-30 20:10:48 +00:00
Sihua Ma
734da5c1eb
Fix invalid outline after widget resizing
...
Fix: 283778989
Test: Manual
Change-Id: I8821658a1db333159684562ba79f30fd92291fad
2023-05-30 13:03:08 -07:00
fbaron
bbab64e00c
Fix widget picker crash
...
It looks like if shouldClearVisibleEntries() evaluates to true and we clear mVisibleEntries, we get an Inconsistency IndexOutOfBounds error, the same as the one reported in the crash.
Bug: 276766307
Test: Verify that with these changes the widgets still update correctly when changing languages
Change-Id: I9f92e61d967aab2c8297cfc2fb4b04193df67650
2023-05-30 18:46:55 +00:00
TreeHugger Robot
78b6e76486
Merge "Add logs to see if launcher model isn't loaded when work profile app is added" into udc-dev
2023-05-30 17:26:53 +00:00
Nick Chameyev
0873afd7fa
[Unfold animation] Disable preemptive launcher animation
...
Disables preemptive unfold animation by default.
Bug: 281821523
Test: unfold on launcher
Change-Id: I767f25cf0414a91c82a33cf86ca16db2e4dcfa22
2023-05-30 18:10:08 +01:00
Vinit Nayak
2c353f29a2
Add logs to see if launcher model isn't loaded when work profile app is added
...
* Add helper method to avoid checking sDebugTracing when
logging for tests
Bug: 243688989
Flag: None
Change-Id: Id6cc3b286171eb598e593c5a8aaea6f2466aad60
2023-05-26 15:45:42 -07:00
Schneider Victor-tulias
fb2affac5f
Fix flaky null pointer in LauncherWidgetHolder
...
- LauncherWidgetHolder.startListening is called before Launcher.setupView, so it's possible for getWorkspace() to be called as part of the appWidgetRemovedCallback. Reordered these calls to fix this null pointer
Flag: not needed
Fixes: 283850341
Test: Screenshot tests
Change-Id: Ied1f23647721fc4199eab2a5a79def1e306b00f3
2023-05-26 15:09:41 -07:00
Vadim Tryshev
8cf338148b
Merge "Adding tracing for workspace loading that never finishes" into udc-dev
2023-05-25 17:17:50 +00:00
Alex Chau
4f1602796a
Merge "Add additional logs when DisplayController detects unexpected bounds" into udc-dev
2023-05-25 12:30:50 +00:00
Brandon Dayauon
fe3d513650
Merge "Update work tab colors and fab background color" into udc-dev
2023-05-25 03:07:59 +00:00
vadimt
80bb8a12da
Adding tracing for workspace loading that never finishes
...
Test: presubmit
Bug: 267200150
Flag: N/A
Change-Id: I6cfe6be101412e9d8d9498fc06c70d1d14561441
2023-05-24 10:25:15 -07:00
Brandon Dayauon
adcc16cf56
Update work tab colors and fab background color
...
Spec: https://screenshot.googleplex.com/6mKVuFNNNQfXpbD
bug: 283120562
test:
manually Launcher3 build var:
worktab lt: https://screenshot.googleplex.com/B8v44jm77o5Jyc7
widgetpicker tab lt: https://screenshot.googleplex.com/48WjAB8fKpZSEQ7
sharesheet tab lt: https://screenshot.googleplex.com/9rfSBeNALXbG7NL
worktab dt: https://screenshot.googleplex.com/332jCxde9vDW7hd
widgetpicker tab dt: https://screenshot.googleplex.com/3PGtrvQ2jLhQD4k
sharesheet tab dt: https://screenshot.googleplex.com/3jr4GPzRc3rzMA6
NexusLauncher:
worktab lt: https://screenshot.googleplex.com/BH2SFMXfQ4dtBeh
sharesheet lt: https://screenshot.googleplex.com/5axg34QgTt87iSL
widget picker tab lt: https://screenshot.googleplex.com/928kWFJ5mTun9py
worktab dt: https://screenshot.googleplex.com/7KWKLH4kt6nJpXT
sharesheet dt: https://screenshot.googleplex.com/778UoyhYrhimSAz
widgetpicker tab dt: https://screenshot.googleplex.com/FFFxBLqsATNXj8v
Change-Id: I78f20b2863a04d23e8a8880fc1d6a3ac0cfeb82a
2023-05-24 09:10:03 -07:00
Alex Chau
ff2a8382fc
Add additional logs when DisplayController detects unexpected bounds
...
Bug: 283944974
Test: manual
Change-Id: I8f50c79e00be0a4be812634678e9e05a80343a07
Merged-In: I8f50c79e00be0a4be812634678e9e05a80343a07
2023-05-24 15:24:03 +00:00