Commit Graph

14922 Commits

Author SHA1 Message Date
Jagrut Desai
fa2a81844f Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev 2023-06-30 22:29:20 +00:00
Treehugger Robot
2c3c1e46c0 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev 2023-06-30 17:45:50 +00:00
Hongwei Wang
ca08d75e4a Merge "Polish home-key from split to pip transition" into udc-dev 2023-06-29 17:17:03 +00:00
Jon Miranda
3bad3ebaad Cleans up bad state when transient taskbar shows on home.
Bug: 279514548
Test: open transparent activity on top of launcher
      unstash taskbar
      go home

Change-Id: I13ab79b334e1f8feda441a82cc4d035c0142f513
2023-06-29 02:51:38 +00:00
Jagrut Desai
53d953ccd2 Taskbar All Apps Shortcut Menu Acccessibility Focus
Bug: 280657266
Test: manual
Flag: not needed
Change-Id: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
2023-06-28 14:48:54 -07:00
Winson Chung
0da5208bb3 Merge "Workaround for handling the restart of an already visible task" into udc-dev 2023-06-28 05:51:59 +00:00
Winson Chung
57c2a79e47 Workaround for handling the restart of an already visible task
- If a task is already visible, then startActivity is a no-op and the
  remote transition that launcher expects to run is not started. As a
  workaround (until restarts are an actual transition), listen for
  the case where a task is restarted and invoke the end callbacks

Fixes: 286016555
Test: Repro steps on the bug
Change-Id: Iec3ab97c8817a5e95399cec90f891d65f369d234
2023-06-28 05:51:54 +00:00
Jerry Chang
3651051182 Polish home-key from split to pip transition
Includes WINDOWING_MODE_MULTI_WINDOW closing target to the condition of
playing fallback animation. So the remaining splitting task won't be
play with iconview animation when home-key to auto-pip consumed another
splitting task in pip transition handler.

Bug: 281476331
Test: repro steps of the bug
Test: pass existing tests
Video: http://recall/-/fLARJNt42LVxc3tt86SneW/eelqATeE1REoOtOEDxeDVR
Change-Id: If05d8841a6a940e61f71683422ef1a3d4e3597c7
2023-06-28 02:10:34 +00:00
Jerry Chang
26d5493e69 Merge "Prevent exception when quick switching between two split pairs" into udc-dev 2023-06-27 17:42:42 +00:00
TreeHugger Robot
1f3c56af5b Merge "Restore strong reference to animation runner" into udc-dev 2023-06-27 02:13:00 +00:00
Winson Chung
6cfe2e6cbe Restore strong reference to animation runner
- The remote animation factory needs to be strongly referenced since
  the only other reference is a weakly held one from
  LauncherAnimationRunner, and if a gc happens in between starting
  the animation and the onAnimationStart() callback, then the
  animation will not play.

Fixes: 284106887
Test: Force a gc after creating a remote app launch animation and ensure
      that the runner still exists when the animation starts

Change-Id: I5f584451b41c666916801b8ea0cb470c7ab9fc51
2023-06-26 23:55:23 +00:00
Winson Chung
fa3434fc37 Merge "Fix NPE due to invalid RecentsView access" into udc-dev 2023-06-26 17:47:49 +00:00
Winson Chung
cdf410f134 Fix NPE due to invalid RecentsView access
Fixes: 288829919
Test: N/a, reorganizing code behind null check
Change-Id: I9efe48cab239b521f7e729af06706c352be2499c
2023-06-26 17:47:33 +00:00
Jerry Chang
97eb471f2e Prevent exception when quick switching between two split pairs
When switching in between two split pairs just quick enough, it is
possible to send the second entering split transition while it is
animating the first entering split transition which is merged to a
recents-during-split transition. The split parents might not be
collected into the second transition because the split parents are
already visible at that time, and there is no recents transition to
merge to. So updates to not throwing when there is no split parent when
composing a recents-to-split animation.

Bug: 236226779
Test: repro steps of the bug and the Launcher won't throw
Change-Id: I3a595722721186e8de7d60c9fb8c099ec799804a
2023-06-26 13:49:37 +00:00
Bill Yi
d6b0605005 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5696f163e91f140d9d0c941300098ed82ced9ca5
2023-06-22 18:51:47 -07:00
Jagrut Desai
9f566dec6b Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev 2023-06-22 18:06:23 +00:00
Vinit Nayak
8492177884 Merge "Add logs to RemoteTargetGluer for index exception" into udc-dev 2023-06-21 20:37:53 +00:00
Mateusz Cicheński
e338982c97 Reparent PiP overlay under task as soon as possible
For enter PiP animations started from Launcher, we send the signal to
WMShell to reparent the overlay under task as soon as possible.

This avoids flicker issue caused by race condition of cleaning up the
transition leash before the reparenting was done, which made the issue
of overlay being not attached to anything for few frames.

Bug: 281711939
Test: winscope trace from comment#28, leash follows task
Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ewrarENSYYOmUCa0b3fdtp

Change-Id: Ia16afd49a94d9ba8456287c2cdffb2a84e5a2bc7
Merged-In: Ia16afd49a94d9ba8456287c2cdffb2a84e5a2bc7
2023-06-21 16:51:36 +00:00
Winson Chung
d827387ffd Merge "Restore specific colors for floating rotation button" into udc-dev 2023-06-21 16:06:19 +00:00
Treehugger Robot
dcbe9583fb Merge "Add detailed exception for snappedIndex == -1 when dismissing tasks" into udc-dev 2023-06-21 11:00:20 +00:00
Bill Yi
5204db1fa2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5b7ded4d11a74593e2cfa3ddc54e564523c7546d
2023-06-20 20:23:19 -07:00
Winson Chung
c27a43ba30 Restore specific colors for floating rotation button
- The rotation button background does not change based on the current
  light/dark mode

Bug: 288126260
Test: Check rotation button color with dark mode enabled/disabled
Change-Id: If4d5edfd4b118e4f16b6d472f206587e7cd61f98
2023-06-20 22:45:25 +00:00
Alex Chau
8f19421a87 Add detailed exception for snappedIndex == -1 when dismissing tasks
Bug: 269956477
Test: manual
Change-Id: Ia95a3b2ffe5c677af34183639ba8a2742626c340
2023-06-20 19:04:55 +01:00
Randy Pfohl
6ec21cbe45 Merge "Aligning the intialization process with groupedtaskview to set content description Test: built locally, tested against tablet with bluetooth keyboard." into udc-dev 2023-06-16 23:18:02 +00:00
Jagrut Desai
68ca974330 Suspend immersive mode autohide while pending transient taskbar timeout
Test: open Youtube fullscreen video, swipe up on taskbar; ensure taskbar autostashes before immersive mode autohides
Fixes: 260765455
Flag: none
Change-Id: Ic579a20c60949e12ffc7f9548eded52fbdb06e0c
2023-06-16 15:42:57 -07:00
randypfohl
3c2ab1de45 Aligning the intialization process with groupedtaskview to set content description
Test: built locally, tested against tablet with bluetooth keyboard.

Bug: 287287064
Change-Id: I2be667b2a4b0a08f73c3233a05bbaf7eec08c0e4
2023-06-15 15:11:57 -07:00
Vinit Nayak
ae6beea07b Add logs to RemoteTargetGluer for index exception
Bug: 286144914
Change-Id: I16a8d22a281903574c282b08c06695e4f0e46168
2023-06-15 19:38:37 +00:00
Jon Miranda
613cc95c8a Merge "Fade in/out taskbar bg alpha when unstash/stashing." into udc-dev 2023-06-15 00:02:02 +00:00
Jon Miranda
d76713eb08 Fade in/out taskbar bg alpha when unstash/stashing.
This prevents the case where we are drawing both the taskbar bg
renderer and the stashed handle at the same time.

Fixes: 287245176
Test: go home/overview, open/close notif shade, stash/unstash in app
Change-Id: Ib025a0cf1ad5fd8a9afd079aa50210f3b2388d8e
2023-06-14 14:04:27 -07:00
Treehugger Robot
77110f977f Merge "Polish redesgined tutorial home and overview animations" into udc-dev 2023-06-14 18:35:21 +00:00
Treehugger Robot
1a8898f69b Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-06-14 03:32:14 +00:00
Jon Miranda
6352c9bc88 Merge "Revert "Suspend immersive mode autohide while pending transient taskbar timeout"" into udc-dev 2023-06-14 01:10:08 +00:00
Jon Miranda
a6653ae660 Revert "Suspend immersive mode autohide while pending transient taskbar timeout"
This reverts commit 0a074648c2.

Reason for revert: caused regression
Bug: 260765455
Fixes: 286808390

Change-Id: I0e017cf8e432f9c36b0ad34154c127c0dbe73504
2023-06-13 20:09:58 +00:00
Randy Pfohl
f5bec7dd30 Merge "switching animation to screenshot to avoid visual jank" into udc-dev 2023-06-13 05:43:21 +00:00
Saumya Prakash
cb5e2cfd3e Merge "Scale the gesture tutorial animation to work on smaller devices" into udc-dev 2023-06-13 05:38:01 +00:00
Saumya Prakash
0d87c4766e Merge "Update the strings in the gesture nav tutorial" into udc-dev 2023-06-13 03:39:38 +00:00
Bill Yi
0a1da5506f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iddfb9398d64d2d2f29b9db947d9ad52c4c6b476e
2023-06-12 20:13:04 -07:00
randypfohl
d3cc664391 switching animation to screenshot to avoid visual jank
Test: built locally, recorded, and slow replayed it to verify no jank/visual anomalies visible.

Bug: 245750127
Change-Id: If7e72512d3303222f4d006a9e2a1639b2f86b1af
2023-06-12 18:28:57 -07:00
Vadim Tryshev
af641a6e80 Merge "Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"" into udc-dev 2023-06-12 21:49:39 +00:00
Saumya Prakash
b932cf4b64 Update the strings in the gesture nav tutorial
Change the strings for the instructions and feedback for the gesture navigation tutorial to align with new UX changes.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 286547594
Test: Manually went through the redesigned tutorial and verified that
the new strings correctly show up. Also checked that the previous
tutorial remains unchanged.

Change-Id: I27a3e8c0f09e7755e6087ce5b004b687f229d153
2023-06-12 21:26:43 +00:00
Schneider Victor-tulias
7ebb54f24e Polish redesgined tutorial home and overview animations
- Added a 6th hotseat icon to the tablet and unfolded foldable
- not animating the previous task view when animating to hotseat from the home step
- updating the first hotseat icon's color and visibility at the correct times
- cross fading the animating task view and hotseat icon's color

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 283967613
Test: ran the tutorial on handheld, tablet and foldable with ENABLE_NEW_GESTURE_NAV_TUTORIAL true and false
Merged-In: I7a76646ca71502e924f45bba76d72be17d31249d
Change-Id: I7a76646ca71502e924f45bba76d72be17d31249d
2023-06-12 21:04:38 +00:00
Saumya Prakash
08a2708739 Scale the gesture tutorial animation to work on smaller devices
The lottie animations in the gesture navigation tutorial would get cut
off due to having to crop them to smaller devices. This change uses a
matrix to correctly scale the animation such that the aspect ratio is
maintained.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 283969417
Test: Went through the tutorial on devices of different sizes and aspect
ratios and ensured that the lottie animation isn't cut off.

Change-Id: I4b4cc9e11a68daef29fa31d6a89a1c9006041937
2023-06-12 17:55:00 +00:00
Vadim Tryshev
b5057c496a Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"
This reverts commit 1a2462914d.

Reason for revert: Likely culprit for b/286115393

Change-Id: I613ca9f62c5b9f43f2e3cd240e45bc1a0db0e661
2023-06-12 17:40:22 +00:00
Brian Isganitis
77a40999e1 Merge changes If4669756,Ide702745 into udc-dev
* changes:
  Make sure FLAG_IN_APP is set when launching apps from keyguard.
  Report unstashed content insets for notification panel.
2023-06-12 16:51:37 +00:00
Saumya Prakash
372de4f521 Merge "Enforce the correct orientation for the gesture navigation tutorial" into udc-dev 2023-06-11 22:24:13 +00:00
Jagrut Desai
2d5bb34b6b Merge "Set AccessibilityPaneTitle for taskbar view" into udc-dev 2023-06-09 22:26:39 +00:00
Randy Pfohl
5e1ccf2e96 Merge "Updating content description of taskview after latest update" into udc-dev 2023-06-09 22:06:41 +00:00
Saumya Prakash
e2711c254a Enforce the correct orientation for the gesture navigation tutorial
The lottie animations used for the gesture navigation tutorial are
designed for specific orientations depending on the device. This change
ensures that users are in the correct orientation for their device. For large screen users in portrait mode, we display a prompt to rotate the screen.

Flag: ENABLE_NEW_GESTURE_TUTORIAL
Fix: 277781713
Bug: 276515961
Test: Manually went through the tutorial starting from both
orientations on handheld, foldable, and tablet to ensure that the prompt
was shown and hidden correctly. Also ensured that gestures cannot be
completed in the background while the prompt is being shown.

Change-Id: I86ae566721f240264177ad4ec7fc12e58d1b95cd
2023-06-09 21:41:07 +00:00
randypfohl
62eb722726 Updating content description of taskview after latest update
Description: we wait for icon updates to receive the title of the task. However we still set the description immediately upon digitalwellbeingtoast creation.
this creates a null set for contentDescription resulting in incorrect talkbalk. This will listen for icon updates and will reiniitialize the toast ensuring
taskview is set properly.

Test: built and tested locally with talk back ensuring the titles are being set correctly

Bug: 280908761
Change-Id: I946e7190114cbdccb75883965b1fdf85ed6ad17a
2023-06-09 12:10:14 -07:00
Jagrut Desai
5e9203e737 Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev 2023-06-09 18:50:52 +00:00