Commit Graph

3016 Commits

Author SHA1 Message Date
Winson Chung
a8dee18ff1 Pass user id with call to get icon from task description
Bug: 145708947
Test: Manual
Change-Id: Ic7da3d36af490ea568481576e26c927020659eda
2019-12-09 11:08:11 -08:00
Hyunyoung Song
e2fe62eea8 Merging from ub-launcher3-master @ build 6048063
Test: manual, presubmit on the source branch
http://x20/teams/android-launcher/merge/ub-launcher3-master_6048063.html

Change-Id: Ieee38cc301364f96cf252b2387142b0aa1b75317
2019-12-04 00:42:32 -08:00
TreeHugger Robot
dbff60ff5e Merge "Fix Text shadow issue for predicted icons" into ub-launcher3-master 2019-12-04 05:32:22 +00:00
TreeHugger Robot
e1187e6d98 Merge "Dedupe Items on Workspace for hotseat prediction" into ub-launcher3-master 2019-12-04 02:39:36 +00:00
Samuel Fufa
425c60e65c Fix Text shadow issue for predicted icons
Bug:142753423
Test:Manual
Change-Id: Ib8ce43592421aa0507400eabd9324dd8c6950086
2019-12-03 17:41:29 -08:00
Samuel Fufa
2f0b2d3b4e Dedupe Items on Workspace for hotseat prediction
Bug:145236832
Test:Manual
Change-Id: I46da38998486c7f58aca829d33b42cbb04da515a
2019-12-03 14:39:12 -08:00
Zak Cohen
39a7760ec9 Merge "Make it possible to set a bottom margin on the task thumbnail view." into ub-launcher3-master 2019-12-03 19:43:29 +00:00
Zak Cohen
b053371672 Make it possible to set a bottom margin on the task thumbnail view.
Test: manual test

Change-Id: Idb18efeb5e2ee46f789488529513874e028532db
2019-12-02 15:56:57 -08:00
TreeHugger Robot
51a5bf15ab Merge "Hybrid hotseat predicted icon visuals" into ub-launcher3-master 2019-11-26 20:13:09 +00:00
Samuel Fufa
1e2d004dd5 Hybrid hotseat predicted icon visuals
Bug:142753423
Test: Manual
Change-Id: I6f056aaec905c8ca357b7cf78a657cdaac84e2f1
2019-11-25 17:35:05 -08:00
Tony Wickham
70a4ff9b9a Don't removePluginListener() unless user is unlocked
This just crashes since we can't access SharedPreferences, and we don't
addPluginListener until onUserUnlocked() anyway.

Bug: 145019350
Change-Id: I705498f859857a52a2cb5735201a652973b26d0b
(cherry picked from commit 435b11b95f)
2019-11-23 01:13:42 +00:00
TreeHugger Robot
41a39e3eb0 Merge "Don't removePluginListener() unless user is unlocked" into ub-launcher3-master 2019-11-23 00:48:43 +00:00
Tony Wickham
435b11b95f Don't removePluginListener() unless user is unlocked
This just crashes since we can't access SharedPreferences, and we don't
addPluginListener until onUserUnlocked() anyway.

Change-Id: I705498f859857a52a2cb5735201a652973b26d0b
2019-11-22 16:06:49 -08:00
Automerger Merge Worker
9d9a3f6293 Merge "Fix quick switch from home biased towards returning home" into ub-launcher3-qt-future-dev am: 75b7b9d35c
Change-Id: I9a8e859c876f311c0ce7df97ca6246238fe958cf
2019-11-22 22:00:01 +00:00
TreeHugger Robot
75b7b9d35c Merge "Fix quick switch from home biased towards returning home" into ub-launcher3-qt-future-dev 2019-11-22 21:45:32 +00:00
Jon Miranda
a3ea27de39 Fix bug where icon remains invisible after returning home.
- The bug is caused by cancelling of the RectFSpringAnim before the
  StaggeredWorkspaceAnim has started.
- Instead of having logic in StaggeredWorkspaceAnim control the visibility
  of the icon, we instead maintain all the visibility within the
  FloatingIconView class itself.

Bug: 142120338
Change-Id: I94f3a066d395f9c3b97dc6ee9fc836e9401650a5
Merged-In: I082291ca9b288f57701cc00d61a9b3a84da8b084
2019-11-21 22:16:36 +00:00
Jon Miranda
ad7e30f5d7 Fix bug where icon remains invisible after returning home.
- The bug is caused by cancelling of the RectFSpringAnim before the
  StaggeredWorkspaceAnim has started.
- Instead of having logic in StaggeredWorkspaceAnim control the visibility
  of the icon, we instead maintain all the visibility within the
  FloatingIconView class itself.

Bug: 142120338
Change-Id: I082291ca9b288f57701cc00d61a9b3a84da8b084
2019-11-20 13:17:51 -08:00
Tony Wickham
94fb4cd3fd Fix quick switch from home biased towards returning home
When flinging up and to the right, we previously always returned
home. Now, if the right velocity is stronger, we quick switch.

Bug: 126596417
Change-Id: I14fa0584399bb90f2e07e0b296fc5932d8224fbf
2019-11-20 13:08:44 -08:00
TreeHugger Robot
f3761296a1 Merge "Fix recents scale sometimes lagging behind window scale" into ub-launcher3-qt-future-dev 2019-11-20 19:02:45 +00:00
Tony Wickham
09c09bba1e Fix recents scale sometimes lagging behind window scale
We were previously offsetting the launcher animation progress based
on when we got onGestureStart, which meant it would lag behind if
onGestureStart came late. Now that we track the window instead of
the launcher shelf, and we don't show the launcher animation right
away in fully gestural mode anyway, we should remove this to ensure
the launcher part of the animation always lines up with the app
window.

We also reapply state whenever predictions are enabled, e.g. when
launcher starts after being force stopped, and previously this was
canceling the existing state animation. We don't want to do that
because predictions can be enabled at any point on a cold start,
and cancelling the existing state animation means that RecentsView
shows up in fullscreen and not attached to the app window for the
duration of the gesture.

Bug: 144454486
Change-Id: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
Merged-In: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
2019-11-20 18:05:06 +00:00
TreeHugger Robot
5a2db8c8d4 Merge "Removing a workaround to make NevigationModeSwitchRule pass on CF" into ub-launcher3-master 2019-11-20 18:00:58 +00:00
Tony Wickham
ff828d2f24 Merge "Fix recents scale sometimes lagging behind window scale" into ub-launcher3-master 2019-11-20 05:07:12 +00:00
vadimt
7410808085 Removing a workaround to make NevigationModeSwitchRule pass on CF
Change-Id: I7b7cabc098f17c99406032e186a4ee363273f0a9
2019-11-19 18:04:13 -08:00
Hyunyoung Song
73b84ce47f Merging from ub-launcher3-master @ build 6018909
Test: manual, presubmit on the source branch
http://x20/teams/android-launcher/merge/ub-launcher3-master_6018909.html

Change-Id: I8a1e20d0b175f03a1a05c81749f07ab5314e872a
2019-11-19 17:12:13 -08:00
Tony Wickham
603c20ad37 Merge "Improve quick switch from home by tracking both x and y motion" into ub-launcher3-master 2019-11-20 00:35:05 +00:00
Samuel Fufa
a9e9444070 Merge "Report app pin/unpin to AppPredictor" into ub-launcher3-master 2019-11-19 01:18:15 +00:00
Winson Chung
ea91205f66 Merge "Fix two small thumbnail leaks" into ub-launcher3-master 2019-11-18 18:41:49 +00:00
Samuel Fufa
7a8be030aa Report app pin/unpin to AppPredictor
Test: Manual
Bug: 142753423
Change-Id: I380e58f31ed508d812d0bf8dfc35905a752dc029
2019-11-18 10:14:53 -08:00
Tracy Zhou
897813aa34 Merge "Check if returned surface params are null before adding them for surface transform" into ub-launcher3-master 2019-11-15 21:45:25 +00:00
Tracy Zhou
fdf954a353 Check if returned surface params are null before adding them for surface transform
We call finish recents animation before app switch animation finishes. When we finish, the live tile params are not cleared up.

This change takes care of
- clean up recents animation targets when it's finished
- do a sanity check on live tile surface params before adding them to the surface transform array

Fixes: 143889142
Test: Swipe up to Overview in live tile mode, switch to a different task, and make sure it doesn't crash anymore
Change-Id: I089cf0a97744461d1fec4d0c97e0c3c6c1049ae3
2019-11-15 13:06:36 -08:00
Winson Chung
9b5f4aa48d Fix two small thumbnail leaks
- Even though the object wrapper is used within the same process, the
  call to start the fallback recents activity means that the system
  still ends up holding a reference to a copy of the intent and its
  extras, including the reference to the wrapper and the thumbnail it
  references, until the activity is destroyed (or next restarted).
  We need to clear the actual object strong ref after it's used when
  handling the new intent.
- The running task can have an associated thumbnail, so we should also
  clear the tmp running task ref when we leave overview.

Change-Id: Icdc0b1989b13927d112949797752615014856970
2019-11-15 11:31:15 -08:00
vadimt
cbc9bffd7e Disabling FallbackRecents tests
Even though they don't block presubmit, the fact that they are failing:
1. Causes sheriffs no not notice other issues;
2. Would block switching to 24hr fix-it policy and Quarterdeck.

Bug: 143488140
Change-Id: I95e3e15b69e0487946919f3f6889e286a1fae141
2019-11-14 17:23:52 -08:00
Tony Wickham
37a0970bf5 Improve quick switch from home by tracking both x and y motion
- Add NoButtonQuickSwitchTouchController which uses
  BothAxesSwipeDetector to track horizontal and vertical motion.
- Initially, we only detect swipe left to right to quick switch
  (like before), but then we allow swipe up to either go to
  overview (if you hold) or back home (if you don't hold).
- xDisplacement transitions non-overview components out (e.g. shelf
  and workspace), and translates overview in.
- yDisplacement translates overview up and scales it down

Bug: 126596417
Change-Id: Id679ad84c08246e205c667a78ed5df00d7276258
2019-11-14 15:50:18 -08:00
Tony Wickham
2785a5996c Improve quick switch from home by tracking both x and y motion
- Add NoButtonQuickSwitchTouchController which uses
  BothAxesSwipeDetector to track horizontal and vertical motion.
- Initially, we only detect swipe left to right to quick switch
  (like before), but then we allow swipe up to either go to
  overview (if you hold) or back home (if you don't hold).
- xDisplacement transitions non-overview components out (e.g. shelf
  and workspace), and translates overview in.
- yDisplacement translates overview up and scales it down

Bug: 126596417
Change-Id: Id679ad84c08246e205c667a78ed5df00d7276258
Merged-In: Id679ad84c08246e205c667a78ed5df00d7276258
2019-11-14 12:31:01 -08:00
Tony Wickham
42a9ef0e9f Move shelf peeking anim code to ShelfPeekAnim class
Bug: 126596417
Change-Id: I5ba501b04b3eaf12a20ba1312ef362f9734761c3
Merged-In: I5ba501b04b3eaf12a20ba1312ef362f9734761c3
2019-11-14 12:30:32 -08:00
Tony Wickham
4df42f85a4 Fix recents scale sometimes lagging behind window scale
We were previously offsetting the launcher animation progress based
on when we got onGestureStart, which meant it would lag behind if
onGestureStart came late. Now that we track the window instead of
the launcher shelf, and we don't show the launcher animation right
away in fully gestural mode anyway, we should remove this to ensure
the launcher part of the animation always lines up with the app
window.

We also reapply state whenever predictions are enabled, e.g. when
launcher starts after being force stopped, and previously this was
canceling the existing state animation. We don't want to do that
because predictions can be enabled at any point on a cold start,
and cancelling the existing state animation means that RecentsView
shows up in fullscreen and not attached to the app window for the
duration of the gesture.

Bug: 144454486
Change-Id: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
2019-11-13 16:37:32 -08:00
TreeHugger Robot
dc0c224030 Merge "Reattributing disabled tests to a more relevant bug" into ub-launcher3-master 2019-11-13 01:30:15 +00:00
Pinyao Ting
1397a42fc2 include predicted_rank in app launch logging
Test:
1. . build/envsetup.sh && tapas NexusLauncher
2. ccdebug && cclogcat
3. launch from workspace any app that is also in predicted apps
4. verify in terminal it has correct predicted_rank

Bug: 143855018
Change-Id: I07a62f07057537a6c09384cf944bbc5aa5888d22
Merged-In: I07a62f07057537a6c09384cf944bbc5aa5888d22
2019-11-13 01:15:37 +00:00
Pinyao Ting
2cf2871392 include predicted_rank in app launch logging
Test:
1. . build/envsetup.sh && tapas NexusLauncher
2. ccdebug && cclogcat
3. launch from workspace any app that is also in predicted apps
4. verify in terminal it has correct predicted_rank

Bug: 143855018
Change-Id: I07a62f07057537a6c09384cf944bbc5aa5888d22
2019-11-12 16:40:34 -08:00
Tracy Zhou
a318b75cbd Merge "Add live tile overlay only once across multiple LauncherSwipeHandler" into ub-launcher3-master 2019-11-12 22:03:32 +00:00
Tracy Zhou
054a86bffa Add live tile overlay only once across multiple LauncherSwipeHandler
- Use singleton on LiveTileOverlay to make sure we only have one LiveTileOverlay instance
- Clean up upon recents animation cancelation

Fixes: 140337263
Test: diligently swipe up and down
Change-Id: I8e0db3c5240135a6deb4f4d91493b8eede7c5ff1
2019-11-12 13:23:36 -08:00
Tracy Zhou
0493a1e250 Inform RecentsAnimationController when overview is reached.
Fixes: 142088072
Test: manual
Change-Id: I1211885d01535f8d39333c6fcb4a7ec7eefcdf78
2019-11-12 12:56:09 -08:00
Sreyas
d567b58810 RecentsExtraCard
Bug fixing / formatting

Change-Id: If36cd64986cc213682af1c7b4fd3281909812c15
2019-11-11 16:19:01 -08:00
vadimt
b0a14e96ae Removing temporary tweaks to make tests pass in presubmit
Now that we have a more reliable build of CF

Bug: 142828227
Change-Id: Ib385443048b6ccd9e1eb3372dc39947536f948bd
2019-11-11 09:23:28 -08:00
vadimt
3435f69d1a Reattributing disabled tests to a more relevant bug
Bug: 143488140
Change-Id: I8af35c66293517a3ba7cae583e5c3bff883865d7
2019-11-08 14:50:57 -08:00
TreeHugger Robot
f59803e708 Merge "Add visual indicator for predicted hotseat icons" into ub-launcher3-master 2019-11-08 15:45:22 +00:00
Tony Wickham
b13c14a228 Have LauncherActivityInterface#getCreatedActivity return BaseQuickstepLauncher
This gives access to quickstep-specific functionality such as ShelfPeekAnim.

Change-Id: I514baa45fe9404157de51f06e891eaea3fc86971
2019-11-07 20:35:37 -08:00
Tony Wickham
d0764c04c5 Merge "Move shelf peeking anim code to ShelfPeekAnim class" into ub-launcher3-master 2019-11-08 04:30:19 +00:00
Samuel Fufa
ba6b47fd8e Add visual indicator for predicted hotseat icons
Bug: 142753423
Test: Manual
Change-Id: Ie4325660fc5392358ec845ae58385bef279db60f
2019-11-07 16:49:24 -08:00
TreeHugger Robot
e49d31c846 Merge "Scaling down hotseat to match prediction row size when going to overview" into ub-launcher3-master 2019-11-07 23:35:15 +00:00