Commit Graph

786 Commits

Author SHA1 Message Date
Ats Jenk
a89365c2be Merge "Use desktop mode flag for split logic" into main 2023-10-13 18:00:53 +00:00
Ats Jenk
cd789874c3 Use desktop mode flag for split logic
Remove launcher specific split from desktop flag and use the desktop
windowing feature flag.

Bug: 305095670
Flag: persist.wm.debug.desktop_mode_2
Test: enable desktop mode flag, toggle split from a desktop task
Change-Id: I62b91de3deaa5bba3435faf3a268f5b58cda8276
2023-10-12 23:28:42 +00:00
Jeremy Sim
7dc3bdcd85 Migrate ENABLE_APP_PAIRS flag to aconfig
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
2023-10-12 15:06:32 -07:00
Alex Chau
6ae2c4d77d Merge "Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""" into main 2023-10-11 15:38:57 +00:00
Alex Chau
4989f4f36d Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""
This reverts commit 7b5472f986.

Reason for revert: aconfig/SetFlagsRule actually works with TAPL tests (http://ag/c/platform/packages/apps/Launcher3/+/24991890/comment/8303a3c6_030ae00b/)
Bug: 270397206

Change-Id: I7529a64c3197e4c2b4d5fb1e46fb29bdea1e52e9
2023-10-11 14:08:22 +00:00
Hyunyoung Song
e0a25fbd51 Merge "Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH" into main 2023-10-11 07:54:26 +00:00
Alex Chau
09d8e2ca57 Merge "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"" into main 2023-10-10 12:26:21 +00:00
Alex Chau
7b5472f986 Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"
This reverts commit 6f264a927b.

Reason for revert: Keeping old flag system so we can test in Tapl tests (b/283246928)
Bug: 270397206

Change-Id: I3e6364ebac8018facc3b22e510615735299a3dad
2023-10-10 10:38:04 +00:00
Andy Wickham
9fbc52f02d Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH
When this flag is enabled, new Developer Options appear which
allow you to customize the slop and timeout to invoke LPNH.

The slop is defined as a multiplier to the default edge slop
(which I discovered while looking into this - it appears to
be intended for touches along the device edge and is 50%
larger than the default touch slop; currently used by Back).

Timeout is defined in milliseconds, defaulting to 400, at least
on my device.

Bug: 301680992
Bug: 300955321
Flag: CUSTOM_LPNH_THRESHOLDS - should be no-op with default off
Test: Manual with flag on and adjusting sliders, and flag off
Change-Id: Iabc7b3706f4fdd6f0392c858b81a856e375ffd51
2023-10-06 15:06:13 -07:00
Federico Baron
97789c9c5e Merge "Add flag for smartspace removal toggle" into main 2023-10-06 20:35:14 +00:00
Stefan Andonian
9acb884c90 Merge "Permanently provide functionality for LauncherPref items that don't need to be migrated, but are boot aware." into main 2023-10-05 21:14:24 +00:00
Alex Chau
2ca7481b04 Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag" into main 2023-10-05 15:40:17 +00:00
Stefan Andonian
54495f3018 Permanently provide functionality for LauncherPref items that don't need
to be migrated, but are boot aware.

Bug: 251502424
Test: Tested that Migration works as expected, as well as shared
preference information that doesn't need to be migrated. Also sanity
tested phone in general.

Change-Id: Ie8460e360856cbe20a7770b1747f75c7154759ab
2023-10-04 23:32:58 +00:00
fbaron
f96f7fef4b Add flag for smartspace removal toggle
cherry-picked from udc-qpr CL

Bug: 303471576
Flag: no flag
Test: none
Change-Id: I0eefb229f0c9544b92d8e8db564129990ab7d65b
2023-10-04 19:27:31 +00:00
Federico Baron
48a9a3d198 Merge "Cleanup SHOW_DOT_PAGINATION flag" into main 2023-10-04 17:00:45 +00:00
Brian Isganitis
a9928faea8 Merge "Promote ENABLE_ALL_APPS_SEARCH_IN_TASKBAR to droidfood." into main 2023-10-03 22:05:15 +00:00
fbaron
80b0ce819c Cleanup SHOW_DOT_PAGINATION flag
Fix: 270395278
Flag: no flag
Test: verify everything still works the same
Change-Id: I803d9c22ac4c7040c47410b97cbdb2b11e33e8c9
2023-10-03 21:59:02 +00:00
Federico Baron
80c138f293 Merge "Add smartspace as a widget to first page (implementation 2)" into main 2023-10-03 21:57:54 +00:00
Brian Isganitis
26e1ff58ca Promote ENABLE_ALL_APPS_SEARCH_IN_TASKBAR to droidfood.
Test: Manual
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I02a492af320775404603d939b405764eff61d8a1
2023-10-03 14:12:19 -04:00
Federico Baron
769fa53481 Merge "Cleanup LARGE_SCREEN_WIDGET_PICKER flag" into main 2023-10-03 17:26:53 +00:00
Federico Baron
bf5757c334 Merge "Cleanup ENABLE_DOWNLOAD_APP_UX_V3 and ENABLE_DOWNLOAD_APP_UX_V2" into main 2023-10-03 17:25:55 +00:00
Alex Chau
6f264a927b Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag
Bug: 270397206
Test: OverviewActionsControllerTest
Flag: enableGridOnlyOverview
Change-Id: I1519e0e8d5b8a7e294d2d310c1614e8462649031
2023-10-03 12:58:18 +01:00
Pat Manning
1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
fbaron
e58aaf1802 Add smartspace as a widget to first page (implementation 2)
Flag: SMARTSPACE_AS_A_WIDGET
Test: verify that the smartspace gets replaced with a smartspace widget
Bug: 300140279
Change-Id: I42c170de5e2a9fd3d24d99bb8b09cf412c55e3a5
2023-09-29 18:16:09 +00:00
Sebastián Franco
015eda683f Merge "Make sure to not call DragOver when the drag is still under PreDrag" into main 2023-09-28 16:13:32 +00:00
fbaron
461a9aa1b1 Cleanup ENABLE_DOWNLOAD_APP_UX_V3 and ENABLE_DOWNLOAD_APP_UX_V2
Fix: 270395186
Fix: 270395134
Test: verify everything works as before
Flag: no flag
Change-Id: I838ed115c371cd157fe3bbe01a5385b8b3f8f918
2023-09-27 23:29:33 +00:00
fbaron
2553ec02b7 Cleanup LARGE_SCREEN_WIDGET_PICKER flag
Fix: 270395809
Flag: no flag
Test: WidgetPickerImageTest
Change-Id: I99734ae7f87b4c2c7b4e798d14cd12f473daac6e
2023-09-27 15:43:07 -07:00
Sebastian Franco
1be772df1d Make sure to not call DragOver when the drag is still under PreDrag
Adding a flag so we can turn off this behavior if it break a drag functionallity

Fix: 299748096
Test: most of dragging test will test this
Change-Id: I4f45faea4f19bd99a946a28372546e18ca5f6a2f
2023-09-27 15:05:47 -07:00
Schneider Victor-tulias
f055c25ec1 Merge "Clean up FeatureFlags.java" into main 2023-09-27 17:28:16 +00:00
Brandon Dayauon
cd460094ba Merge "Do a vertical check for two line text, if it clips dont show two line." into main 2023-09-26 22:16:37 +00:00
Schneider Victor-tulias
8d3d623bc7 Clean up FeatureFlags.java
Flag: not needed
Bug: 291651514
Test: not needed
Change-Id: I37d7ac39f5feddab303ccb3c3305e2e2b3b6bd3e
2023-09-26 17:25:33 -04:00
Brandon Dayauon
3cdb32cc1f Do a vertical check for two line text, if it clips dont show two line.
Added extra 16dp to the cell height in DeviceProfile as per spec: https://docs.google.com/presentation/d/1dSt-zY_wRrOmd9a9nsQG458CIK0RUqVJsHJxLHP_0Nc/edit#slide=id.g237e909075a_2_6
Updated tests andincluded vertical check to see if two line can be fully rendered without being clipped. Otherwise just show one line.
Since existing cell height is 104dp, we add 16dp to be up to spec (120dp)
- Clean up FeatureFlag ENABLE_TWOLINE_ALLAPPS and now use aconfig flag

bug: 270390937
Test: manually - photos
Regular font: https://screenshot.googleplex.com/ArUcgZgHqR4ZWBQ
Bigger font than regular that makes text to one line because it wouldve truncate: https://screenshot.googleplex.com/6s8EdMAbBLsYhLi
Bigger font than regular with predicted app row (twoline):
https://screenshot.googleplex.com/38TEQei5GvPiCc7
Super big font: https://screenshot.googleplex.com/3JUYYprJRQ32Hsq
big display and regular font: https://screenshot.googleplex.com/55rBKVQ8htSe9Vc
big display and bigger than regular font: https://screenshot.googleplex.com/3atzKzJUbfM7YQW
flag: is off

Change-Id: I6998ea5da35d3e00ac75327d16b5ca676fb11c1a
2023-09-26 02:38:16 +00:00
Thales Lima
8f58b0a63d Enable TEAMFOOD for ENABLE_RESPONSIVE_WORKSPACE flag
Bug: 299935275
Test: manual
Change-Id: If341730c3eb43ffb243b960ad76bc223058e426d
2023-09-25 16:27:21 -07:00
Thales Lima
ca31b6105e Migrate ENABLE_RESPONSIVE_WORKSPACE to aconfig
- Keeping FeatureFlags.ENABLE_RESPONSIVE_WORKSPACE for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_RESPONSIVE_WORKSPACE in tests as aconfig still can't be mocked

Bug: 299935275
Test: manual
Change-Id: I092df894a3624dca6b9d381d56ada71d807547b5
2023-09-25 16:25:15 -07:00
Andrew Cole
e81a3cef0c Merge "Unfolded Two Pane Widget Picker Prototype" into main 2023-09-25 19:59:30 +00:00
Andrew Cole
c19a618706 Unfolded Two Pane Widget Picker Prototype
As described, this is a small prototype to show what the current state of the two pane widget picker would look like in an unfolded foldable.

Bug: 301918659
Test: N/A
Flag: UNFOLDED_WIDGET_PICKER
Change-Id: Ia495de39a470f1dccf70ce53e59c7929525c4a00
2023-09-25 11:00:24 -07:00
Stefan Andonian
84230b2ea0 Merge "Move "Enable Boot Aware Startup data" to behind a FeatureFlag." into main 2023-09-25 17:06:12 +00:00
Stefan Andonian
dbc8ec530c Move "Enable Boot Aware Startup data" to behind a FeatureFlag.
Previously this was hard-coded to disabled, but that was before
FeatureFlags were made to be boot aware.

Bug: 251502424
Test: Verified that doing this doesn't break my device. Also tested the
Pre-loading feature itself and didn't see any errors in the logs.

Change-Id: I031e1756b985664a2e8d8ad26e16803ead874727
2023-09-21 19:10:22 +00:00
Pat Manning
349f101411 Merge "Migrate ENABLE_CURSOR_HOVER_STATES to aconfig" into main 2023-09-19 16:56:45 +00:00
Sebastián Franco
c468af4139 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev am: 216a765894 am: 07ce8fa893
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681787

Change-Id: I74496b2ce863dadce1fbe3889de242c133a75121
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 19:02:27 +00:00
Sebastián Franco
216a765894 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev 2023-09-14 17:50:54 +00:00
Pat Manning
c49d60b946 Migrate ENABLE_CURSOR_HOVER_STATES to aconfig
- Keeping FeatureFlags.ENABLE_CURSOR_HOVER_STATES for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_CURSOR_HOVER_STATES in tests as aconfig still can't be mocked

Bug: 300054410
Test: manual
Change-Id: Id385e8ee32ccf8b920b9b7f9cc620af32def589f
2023-09-14 11:08:02 +01:00
Alex Chau
2ddd019a4c Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig" into main 2023-09-13 20:57:51 +00:00
Alex Chau
e1955fe4b9 Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig
- Keeping FeatureFlags.ENABLE_GRID_ONLY_OVERVIEW for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_GRID_ONLY_OVERVIEW in tests as aconfig still can't be mocked

Bug: 270397206
Test: manual
Change-Id: I799e05311adc21184a6ad7ce92a3abdab3f25c25
2023-09-13 15:59:01 +01:00
Jagrut Desai
ff077335d1 Merge "Revert "ENABLE_TASKBAR_PINNING for TEAMFOOD"" into main 2023-09-12 23:37:59 +00:00
Jagrut Desai
62bbdcaa15 Revert "ENABLE_TASKBAR_PINNING for TEAMFOOD"
This reverts commit 1b9f4cc9e8.

Reason for revert: waiting to turn on until feature is complete. 

Change-Id: I362f2e86e0ff512934bf12360fbffbce43c0cdaa
2023-09-12 20:20:05 +00:00
Federico Baron
95090ebcc5 Merge "Add flag for smartspace as a widget implementation" into main 2023-09-12 18:43:58 +00:00
Sebastian Franco
f376613a5b Disable FOLDABLE_SINGLE_PAGE
ENABLE_TWO_PANEL_HOME is no longer used so I will also
remove it.

TwoPanelWorkspaceTest was expecting an icon on the hotseat
which no longer exist.

We will use the new flag system in main for this
feature.

Test: atest ReorderWidgets
Test: atest FoldableIntegrity
Bug: 270395274
Change-Id: I122a924a81ae989ff5636d8e276d6d31bbe0877d
2023-09-12 18:19:53 +00:00
Brian Isganitis
0d157469ae Merge "Promote ENABLE_ALL_APPS_SEARCH_IN_TASKBAR to TEAMFOOD." into main 2023-09-12 16:49:52 +00:00
Jagrut Desai
8f754a92c7 Merge "ENABLE_TASKBAR_PINNING for TEAMFOOD" into main 2023-09-12 16:15:55 +00:00