Commit Graph

2959 Commits

Author SHA1 Message Date
Sunny Goyal
94fa76fbeb Updating feature flags subclassing
> Preventing debug flags to get change listener on release device

Bug: 147913781
Change-Id: I2bd0456918c5d3224c714b153c4565b1ef41d7c0
2020-01-21 14:22:58 -08:00
Winson Chung
24ab40cebe Move remote animation definition runner to wrapped class
- Add call to unregister for remote animations from the system
  when the launcher activity is destroyed to prevent a lingering
  reference from the system to the old activity. But separately,
  to not have to wait for the system to GC before clearing the
  binder ref, we also wrap all runner implementations so that
  they can be cleaned up after a GC in our process only.

Bug: 139137636

Change-Id: Ib6276cac80b446440ec101fe00eae6ca41fdf32c
2020-01-17 21:34:54 +00:00
vadimt
d8827bad12 Verifying that Launcher didn't crash in TaplTestsQuickstep
TaplTestsLauncher3 already do this

Change-Id: I17fe638b81cbef4cf5230a6bd49b165e4f9e7855
2020-01-16 17:28:43 -08:00
Tony Wickham
0e4cc09738 Merge "If RecentsView is empty when starting quickswitch, listen for tasks to load" into ub-launcher3-master 2020-01-16 00:18:19 +00:00
TreeHugger Robot
a97958a22a Merge "Swipe up from nav bar in fallback recents to go home" into ub-launcher3-master 2020-01-15 22:56:41 +00:00
Vadim Tryshev
f7b2d40347 Merge "TAPL: Verifying some interactions with system" into ub-launcher3-master 2020-01-15 22:32:13 +00:00
vadimt
252d012ed0 TAPL: Verifying some interactions with system
Investigation of TAPL failures, especially flakes is complex, partially
because it’s hard to tell whether it’s Launcher who is wrong or the
system.

We need to introduce a framework that looks at Launcher interaction with
the system and reports when interactions deviate from the expected
course, and who made the first wrong step.

This is first, proof-of-concept CL.

It analyzes long-press events. We had multiple cases when long-presses
didn’t happen or happened unexpectedly.

Launcher registers the events, TAPL retrieves and compares against the
sequence of expected regular expressions. This diagnostic is used when
something fails and at the end of public methods.

Change-Id: I07aa3a027267c03422c99c73ccd8808445c55fe8
2020-01-15 13:31:18 -08:00
TreeHugger Robot
14bd192275 Merge "Track bottom of the app window when ENABLE_OVERVIEW_ACTIONS is true" into ub-launcher3-master 2020-01-14 23:33:02 +00:00
Tony Wickham
011439e353 If RecentsView is empty when starting quickswitch, listen for tasks to load
When first doing quick switch, RecentsView might be empty but tasks subsequently
load. In that case, we can update our animators to have the correct scale etc.

Test: From home, toggle dark theme or RTL from quick setting tiles,
then quick switch; ensure RecentsView comes in scaled up.

Bug: 126596417
Change-Id: I28d79455431b1da634372d6f31182406aa24cd06
2020-01-14 21:27:59 +00:00
Tony Wickham
107dd8dd66 Track bottom of the app window when ENABLE_OVERVIEW_ACTIONS is true
- Fix the shelf tracking distance since there's no shelf.
- Pullback against a swipe up from an app later

Bug: 143361609
Change-Id: I296fb9bcb20d7d45931006f20512f0dc4a54212b
2020-01-10 14:44:29 -08:00
Sunny Goyal
2000228dc0 Merge "Adding support for multiple Model clients" into ub-launcher3-master 2020-01-10 22:21:20 +00:00
Sunny Goyal
a7a5bf3101 Adding support for multiple Model clients
Bug: 137568159
Change-Id: Ia4db800b19cc80c695fcb9ea28e07709dfd08c6a
2020-01-10 12:23:27 -08:00
TreeHugger Robot
0e7a81ea0a Merge "Change hotseat edu strings" into ub-launcher3-master 2020-01-10 17:29:39 +00:00
TreeHugger Robot
c85ab32e88 Merge "Use same content description for Recent apps" into ub-launcher3-master 2020-01-10 17:08:54 +00:00
Samuel Fufa
3db240a134 Change hotseat edu strings
Bug: 142753423
Change-Id: I0de86073b75eb1866d827d9e3fc35236accc67a0
2020-01-10 08:34:49 -08:00
Tracy Zhou
4d7b244f3f Render user's actual workspace in ThemePicker preview (Part 2)
With this change, we can also render folders in preview. It's built on top of part 1.

Test: Go to grid options, choose a different grid option, and see user's workspace rendered in the preview
Bug: 144052839
Change-Id: Iaf6d8af6b909ece4147ea250d95dec3d2c0019d3
2020-01-08 15:42:58 -08:00
Jonathan Miranda
1b4ed6dd9b Merge "Enable working springs. Move unstable springs to a seperate feature flag." into ub-launcher3-master 2020-01-08 21:17:49 +00:00
Samuel Fufa
aed008de90 Hybrid hotseat user edu
Starts by showing a notification, which will open a dialog
with options for users to keep their hotseat layout or fully
migrate to hybrid hotseat

Bug:142753423
Test:Manual
Change-Id: I178de612837ec8551f6776fa7c6fb6111bc7431d
2020-01-07 12:02:26 -08:00
Jon Miranda
40f0eb2188 Enable working springs. Move unstable springs to a seperate feature flag.
Bug: 147302669
Change-Id: I7a1b9b0e68cc68ad943b5af2b8cf7f80b5680eaa
2020-01-07 11:25:22 -08:00
Pinyao Ting
72f9375ada Tips Gesture Navigation Tutorial [Part 2]
include actual implementation of gesture tutorial.

Bug: 146173041
Test: adb shell am start -a \
"com.android.quickstep.action.BACK_GESTURE_TUTORIAL"
Change-Id: Ic166f0a10d8efc22d9684f089142de164ca24c90
2020-01-06 16:33:55 -08:00
Pinyao Ting
993aef828a Tips Gesture Navigation Tutorial [Part 1]
import various resources from tips gesture tutorial

Bug: 146173041
Test: build and verify it passes
Change-Id: Iacea7ba1f2d15452e7442f2976633da7012fab35
2020-01-02 16:17:52 -08:00
TreeHugger Robot
f10903e601 Merge "Removing static reference of deep shortcut manager" into ub-launcher3-master 2020-01-02 20:54:05 +00:00
Sunny Goyal
fa39536570 Removing static reference of deep shortcut manager
Bug: 141376165
Change-Id: Ie60b82be63a8926825598c681d8b2a1b2ace6413
2020-01-02 20:13:12 +00:00
Samuel Fufa
2c96dbc46c Enable Dragging on predicted hybrid hotseat items
Bug: 142753423
Test: Manual
Change-Id: I2d54f82129d30bd289d05039e009a10543d55f34
2019-12-28 13:48:43 -08:00
James O'Leary
027cb32a96 Merge "Compose overscroll gesture updates" into ub-launcher3-master 2019-12-26 17:27:24 +00:00
James O'Leary
a9156a05c4 Compose overscroll gesture updates
Two changes for the latest Compose prototype:
1. Pass the identity of the underlying app to the Overscroll plugin.
2. Enable the Compose gesture over an app when there's a Recents extra
card plugin active (otherwise the current app won't count as the
rightmost one).

Some changes to the gesture:
- Angle decreased from 35° to 25° to remove overlap with
Assistant gesture
- Distance increased from 8 to 110 dp. 110 dp is 2x the Assistant
gesture and roughly the same as scrubbing into an app from Home.
- Fling detection added; uses same distance threshold, 110 dp.
- If a touch was recognized as another gesture, the touch will not be
reinterpreted as a Compose gesture, no matter what touch movement occurs
- Fixes issue where Assistant + Compose could both be triggered
- Fixes issue where scrubbing apps to the left, then back to the right,
would bring in Compose. i.e. if a touch down + touch movement starts
bringing in Assistant UI elements, then, the user moves their touch
below the Assistant angle, the Compose gesture will not start
being recognized
- Gesture length required for fling lowered from 110 dp to 40 dp, per
tuning with PM.

Bug: b/146508473
Change-Id: I414573d1a92684d1d992837a5f1df522346ec211
2019-12-23 10:59:30 -05:00
TreeHugger Robot
800aaa0d32 Merge "Not using SIDELOADED_LAUNCHER name" into ub-launcher3-master 2019-12-21 01:45:50 +00:00
Zak Cohen
2011efe0bb Merge "Overview actions - Add controller for actions." into ub-launcher3-master 2019-12-20 01:21:30 +00:00
Zak Cohen
1e58d99531 Overview actions - Add controller for actions.
Add the actions to the task overlay to simplify code sharing.

Test: added unit tests for controller

Change-Id: Ie497a717b189903cc1834685f4b7d0cb926a7f52
2019-12-19 15:24:10 -08:00
Andy Wickham
b8a56800e9 Fixes keyboard dismissal of current task.
Dismiss current task in Recents view by
pressing the Delete key.

Test: Manual
Change-Id: Ieff6c5e5153efdf1c2a491cdc6e91fb7e50879f8
2019-12-17 16:02:41 -08:00
TreeHugger Robot
158a0b9059 Merge "Defer resetting the animation controller and targets on cancel" into ub-launcher3-master 2019-12-17 01:15:33 +00:00
Tony Wickham
b31467f3ec Use same content description for Recent apps
There were two descriptions before, one saying Overview and the
other saying Recent apps. Now we always use Recent apps.

Bug: 145181858
Change-Id: I0d33fdccb30ad3eb56ebfb3d533ea01c2e7866c1
2019-12-16 16:49:19 -08:00
TreeHugger Robot
7d8901689c Merge "Improving navigation mode switch rule and around" into ub-launcher3-master 2019-12-16 22:36:42 +00:00
TreeHugger Robot
bdfa251d67 Merge "Add boolean to differentiate icons from workprofile" into ub-launcher3-master 2019-12-16 20:31:33 +00:00
vadimt
bd28a8ec0c Not using SIDELOADED_LAUNCHER name
It may imply something malicious, while we simply mean a third-party
launcher.

Bug: 79437767
Change-Id: I2e169fda9404ca7a042e40877ed6f4b7d2d723a1
2019-12-13 17:22:48 -08:00
Tony Wickham
9298aa92fd Swipe up from nav bar in fallback recents to go home
- Extract swipe-up-to-home logic from OverviewWithoutFocusInputConsumer
  to TriggerSwipeUpTouchTracker util class
- Add FallbackNavBarTouchController for fallback recents to trigger home

Bug: 140845330
Change-Id: I846f1afdaf36529f348b0d3c9c479f01053a463b
2019-12-12 16:31:14 -08:00
vadimt
2eb48498b4 Improving navigation mode switch rule and around
Logging assertion failures.
Modifying waits for condition to avoid timing out the whole test if the
iteration takes too long in favor of failing with an actionable diag.

Bug: 145985438
Change-Id: Ie32d93e1548ce6ec64c38449eb1be1287ff9cf56
2019-12-12 15:10:52 -08:00
Winson Chung
72c5f1f58f Defer resetting the animation controller and targets on cancel
- In the case where the recents animation is canceled while the running
  window animation is running, we invalidate the handler, and force end
  the window animation, which results in the end target being calculated
  and transitioned to.  Because the handlers can still reference the
  animation controller at this point (even though the calls will be
  no-ops since it was canceled), we should not reset the vars until the
  state has been updated.

Bug: 145641576

Change-Id: I5a660026fabb5beb0c45dffeeb4cb4feef5dec30
2019-12-11 17:00:06 -08:00
Sunny Goyal
73b5a27b14 Updating some non-final static objects
Updating various static objects to use a standard pattern so that
it is easier to track and cleanup those objects

Bug: 141376165
Change-Id: Ia539cbfa338d544dddad771c5027b6748762768b
2019-12-11 13:22:58 -08:00
TreeHugger Robot
4f37a5e268 Merge "Removing static instances of UserManagerCompat and AppWidgetManager" into ub-launcher3-master 2019-12-11 18:41:04 +00:00
Sunny Goyal
337c81f664 Removing static instances of UserManagerCompat and AppWidgetManager
> Changing the lifecycle to follow other static objects in Launcher
> Removing compat interface and inlining everything to helpers

Bug: 141376165
Change-Id: I82bd5db1969101de9a7eac77f32728d70195bb35
2019-12-11 10:03:19 -08:00
Samuel Fufa
78e7e5fcaa Add boolean to differentiate icons from workprofile
Bug:145825382
Test:Manual
Change-Id: I95e0cfe48b4a397eb54455374f11c7ea14c028f6
2019-12-10 13:33:37 -08:00
Winson Chung
1d8a582130 Pass user id with call to get icon from task description
Bug: 145708947
Test: Manual
Change-Id: Ic7da3d36af490ea568481576e26c927020659eda
(cherry picked from commit a8dee18ff1)
2019-12-10 19:55:37 +00:00
Tony Wickham
70f998471c Merge "Allow quick switch from 3P launcher home in 2 button mode" into ub-launcher3-master 2019-12-10 19:20:57 +00:00
TreeHugger Robot
dfa1a20591 Merge "Add logging for hybrid hotseat" into ub-launcher3-master 2019-12-10 18:54:22 +00:00
Zak Cohen
c98902af47 Merge "Overview actions - adds feature flag and base class for Overview Actions." into ub-launcher3-master 2019-12-10 18:13:41 +00:00
Tony Wickham
a06ad834d0 Allow quick switch from 3P launcher home in 2 button mode
Only the FallbackSwipeHandler supports quickswitch mode on the
home screen, but we only used that handler for fully gestural
mode. Now we also use that handler for 2-button mode if both
of these conditions are met:
- User is on the home screen
- User swipes right on the nav region (instead of up)

Also fix issues with continuous quick switch gestures by setting
the appropriate end target NEW_TASK instead of HOME.

Bug: 140467002
Change-Id: I8f327638b48cf4c0acb1ebe265b7846afac6759b
2019-12-09 19:11:09 -08:00
vadimt
165a507a35 Disabling fallback tests
Improving state events accounting hasn't completely solved flakiness.
I've noticed that swiping up in 0-button mode sometimes doesn't open
Overview.

Bug: 143488140
Change-Id: I660885ed556aa2953c17d491fde267734b95890b
2019-12-10 02:06:16 +00:00
Zak Cohen
e895869f47 Overview actions - adds feature flag and base class for Overview Actions.
Adds ENABLE_OVERVIEW_ACTIONS feature flag and base factory. Requires an
implementation in overlay to show any actions.

Test: run locally with flag on and off.
Bug: 145628186

Change-Id: I1c36330464cc01e1e987ebfea1a9f451067598a5
2019-12-09 16:43:54 -08:00
vadimt
bdaa179b92 Consistently checking state change messages
Checking for events whenever Launcher sends them.
Checking for correct events (final events, not for events from
intermediate state changes).

This should simplify diagnosing of bugs involving TAPL.
This is also supposed to fix Fallback overview tests.

Bug: 143488140
Change-Id: If053ed808ec71bf2b652ab680be5bdfe9ff8cbb9
2019-12-09 12:33:39 -08:00