Commit Graph

19314 Commits

Author SHA1 Message Date
Brian Isganitis
a76fcaf5b4 Add more tests for {request,hide}Window.
Flag: TEST_ONLY
Fix: 346394585
Test: TaskbarOverlayControllerTests
Change-Id: I59ed58d7f3a4d46bccfb34ef6923f1bf4f5bf2c1
2024-06-12 15:53:33 -04:00
Brian Isganitis
9eaae4b6a4 Initial TaskbarUnitTestRule with example overlay controller tests.
Flag: TEST_ONLY
Bug: 230027385
Test: TaskbarOverlayControllerTest
Change-Id: I858906ece7e67677962ec8b4432bfcca5ec30283
2024-06-11 23:48:13 -04:00
Treehugger Robot
d141b3094d Merge "Use animateClose in TaksMenuView even without animation" into main 2024-06-07 17:29:15 +00:00
Treehugger Robot
0b844a0f5b Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-06-07 17:04:35 +00:00
Alex Chau
7656f3c604 Merge "Reserve space for system bars in both orientations in fake orientation" into main 2024-06-07 17:03:03 +00:00
Alex Chau
4a70e1c023 Use animateClose in TaksMenuView even without animation
- animateClose uses ObjectAnimator which is able to skip animation automatically

Fix: 332685379
Test: OverviewMenuImageTest
Test: Remove animations in Settings, open and close the menu in handheld
Flag: EXEMPT bugfix
Change-Id: I5bfe835cffc77ff7f835ff3c41bbd64fc7121ed2
2024-06-07 16:59:31 +01:00
Alex Chau
f7c9466c8f Reserve space for system bars in both orientations in fake orientation
- In BaseContainerInterface.calculateTaskSize, combine both portrait and landscape/seascape insets to leave space for status bar/nav bar in either orientations.
- Rotate the paddings to portrait before applying
- Don't use getOverviewActionsClaimedSpace() in fake landscape/seascape

Bug: 344727200
Test: We can't currnetly autotest fake orientaiton
Test: With gesture/3-button, rotate Overview to portriat/landscape/seascape/fake-landscape/fake-seascape, launch task and enter overview
Flag: EXEMPT bugfix
Change-Id: Icda0f483781921cae78f1ea3ef003562b60ad75a
2024-06-07 16:28:19 +01:00
Treehugger Robot
4c0ce55f7c Merge "Fix TaskView.getThumbnailBounds not combining bounds correctly if relativeToDragLayer is true" into main 2024-06-07 10:27:23 +00:00
Alex Chau
3639fe4866 Merge "Handle uiMode changes in QuickstepLauncher" into main 2024-06-07 10:06:48 +00:00
Treehugger Robot
dcbd5e40c5 Merge "Use just the preview for drag and drop in the standalone activity" into main 2024-06-07 01:30:34 +00:00
Treehugger Robot
671d4e5384 Merge "Ensure starting position rect isn't empty in FloatingTaskView" into main 2024-06-07 00:28:31 +00:00
Shamali P
277a4f9d78 Use just the preview for drag and drop in the standalone activity
Bug: N/A
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I62c42b649e720826979123ae2ff6c5e238fe59dc
2024-06-07 00:00:31 +00:00
Shamali Patwa
fc4ff35e68 Merge "Ensure widgets from WidgetSections.xml are included in suggestions" into main 2024-06-07 00:00:03 +00:00
Treehugger Robot
c09cb9e345 Merge "Fix bubble visibility issue when collapsed" into main 2024-06-06 22:42:05 +00:00
Vinit Nayak
410681a955 Ensure starting position rect isn't empty in FloatingTaskView
* on rotation taskbar re-inflates it's hotseat views.
If we're already in split, then FloatingTaskView tries to do calculations
on the view's position in the window, but has a reference to the
old, pre-rotated view which is no longer in any window.
* This sets startingPosition to be an empty rect, which is used to
set LayoutParam values, which are used downstream in update() to calculate
scale, and thus we end up dividing by 0.
* TODO(b/345556328) figure out a better solution than checking for an
empty rect

Fixes: 342606096
Test: Repro steps don't cause crash
Flag: EXEMPT bugfix
Change-Id: Icb546a05d383d1997a92471fc1de3ffc37d06eca
2024-06-06 15:32:33 -07:00
Shamali P
d69e21f8fe Ensure widgets from WidgetSections.xml are included in suggestions
Additionally, let only prediction system provide suggestions, since the
UI surface has been there for a while, adding locally filtered widgets
from app package isn't required.

Bug: 345520128
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: Ia97f0743fefeae750e07a694bb19d24a5cc11ffe
2024-06-06 22:23:35 +00:00
Bill Yi
9f27418e26 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia31223d4855e3e922380932ee02414638c589526
2024-06-06 14:20:04 -07:00
Liran Binyamin
87e579ea2d Fix bubble visibility issue when collapsed
When the bubble bar collapses, explicitly set the alpha to 1
for bubbles that should not be hidden.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345283193
Test: manual
       - create 3 bubbles in the bar
       - tap to expand
       - select the last bubble
       - tap it again to collapse
       - observe it is visible
Change-Id: I1aed310b66433b88b08ccaf760fc8e82923b1b64
2024-06-06 16:35:22 -04:00
Himanshu Gupta
91988caf99 Merge "Re-enabling a failing Tapl test for Private Space." into main 2024-06-06 17:08:41 +00:00
Winson Chung
533893e898 Merge "Always report mandatory insets for button nav" into main 2024-06-06 04:28:38 +00:00
Winson Chung
762b3b4685 Always report mandatory insets for button nav
Fixes: 340134342
Fixes: 343817842
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Test: Verify mandatory insets vs window bounds in various
      orientations when folded/unfolded
Change-Id: I18d4f5d212d16c62d15d84b4842b3d20c0d8c5ae
2024-06-06 04:26:48 +00:00
Hongwei Wang
7584e28833 Merge "Crop the center when no source rect hint" into main 2024-06-06 00:15:05 +00:00
Saumya Prakash
d226042cb5 Merge "Update AllSetActivity animations for certain device types" into main 2024-06-05 21:26:33 +00:00
Ats Jenk
765cc415a3 Merge changes from topic "bubblebar-a11y" into main
* changes:
  Move bubble bar strings
  Add content description to bubble bar and bubbles
2024-06-05 19:04:22 +00:00
Ats Jenk
96396eea95 Move bubble bar strings
Move strings to quickstep as bubble bar is in that folder.

Bug: 344670947
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, check talkback on bubble bar and bubbles
Change-Id: I2da1f0c8fc6ec13f04b2c75c9eb1a27ec598d564
2024-06-05 10:13:27 -07:00
Ats Jenk
cd4c9d153d Add content description to bubble bar and bubbles
Set content description on the bubble bar when it is collapsed. Only
allow focus on the bar itself. In collapsed mode, bubbles in the bar
can't be focused.
Content description for the bar matches what we have in floating mode.
We include the text for the first bubble and then how many bubbles are
there more.

Set content description on bubbles in bubble bar. When bubble bar is
expanded, only the bubbles are focusable.
Bubble content description matches the floating bubbles content
description. Includes the notification title and app name.

Bug: 344670947
Flag: com.android.wm.shell.enable_bubble_bar
Test: enable talkback, focus on bubble bar when it is collapsed, check
  that only bubble bar receives focus
Test: enable talkback and expand bubble bar, check that only the bubbles
  receive focus
Change-Id: Id931f0360b9ebadd01dd16b05b75546fcc4df803
2024-06-05 10:13:22 -07:00
Treehugger Robot
6a69160999 Merge "Add debug logs to TopTaskTracker" into main 2024-06-05 16:17:19 +00:00
Treehugger Robot
02a187e84e Merge "Miscellaneous polish for new home animation." into main 2024-06-05 15:00:35 +00:00
Alex Chau
7779855ab4 Merge "Fix icon and DWB toast focus transition" into main 2024-06-05 14:58:52 +00:00
Himanshu Gupta
72297b7b81 Re-enabling a failing Tapl test for Private Space.
The test seemed to be failing due to animation issues
(settings cog and Lock text not visible)- b//339179262
Re-enabling the test as those issues are now fixed.

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: None TaplTest
Change-Id: I4053b9759cd97c721ea576965f57ef309fffaab3
2024-06-05 15:42:46 +01:00
Alex Chau
833639d8fa Fix TaskView.getThumbnailBounds not combining bounds correctly if relativeToDragLayer is true
- This was a coding error introduced in ag/27382735
- getThumbnailBounds is supposed to union all individual thumbnailBounds per TaskContainer, rather than overriding bounds over and over per TaskContainer

Bug: 339787250
Test: Swipe up to home from split apps
Flag: EXEMPT bugfix
Change-Id: I7a697620f4b4507df8f1860b4c2f9889e4be006b
2024-06-05 15:35:39 +01:00
Schneider Victor-tulias
86b9ad4ff7 Add debug logs to TopTaskTracker
Flag: NONE debug logs
Bug: 342247547
Test: checked TIS logs
Change-Id: I6c8440af122a0376ffd77df6c8c9b9aeb742d447
2024-06-05 10:34:15 -04:00
Luca Zuccarini
0f6668d011 Miscellaneous polish for new home animation.
1. Update the starting window velocity when coming from 3-button nav or
   predictive back

Before we used an arbitrary fixed velocity which goes down to basically
0 with the old implementation, but caused a noticeable jump up in the
new one when using predictive back. Now we just pass 0, since the
predictive back framework doesn't give us the actual velocity.

2. Add the scaling home reveal to the targetless (not going back to a
   specific app icon or widget) animation and 3-button nav

Bug: 298089923
Fix: 343143876
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Test: manually tested with flag on and off
Change-Id: Ied3630a51862731fad044b68f76a45dc87f2e17b
2024-06-05 13:21:46 +00:00
Alex Chau
481e3ae079 Fix icon and DWB toast focus transition
- icon and DWB toast now transition in with animation when swipe up from apps to Overview
- Refacotred focusTransition into MultiProperty, with separate control from fullScreenProgress and scaleAndDim, and get rid of "invert" parameter and iconScaleAnimStartProgress variable which is very confusing
- Added a SCALE_AND_DIM_OUT property for use with PendingAnmation during dismiss, as PendingAnimation does not support per animator interpolator
- Use height from resource in DWB toast when calcualting translation, so translation can be properly set before view is measured
- Always set bannerOffsetPercentage regardless if banner is added

Fix: 344786723
Fix: 315972057
Fix: 313644427
Flag: EXEMPT bugfix
Test: Quick switch from home, icon and DWB toast don't transition in until gesture release
Test: Quick switch from app, icon and DWB toast don't transition in until gesture release to Overview
Test: Dismiss focus task, icon and DWB toast transition in after transition settle
Test: Swipe down task, icon and DWB toast transition out with finger
Test: Launcher central task, icon and DWB toast transition out
Change-Id: Ie16a2ceff10967de38b5f66c52f4be00d0051c5f
2024-06-05 12:33:25 +01:00
Jordan Silva
b620e432c3 Merge "Fix split snapshot broken after rotating in fake orientation" into main 2024-06-04 22:00:10 +00:00
Saumya Prakash
5365f00127 Update AllSetActivity animations for certain device types
This change updates the background animation at the All Set page for
foldables of a certain dimension.

Fix: 326231525
Fix: 335057950
Test: Run All Set page in multiple device types and observe the
background animation
Flag: EXEMPT bugfix

Change-Id: I1197d689ab76f79a80d0be46ad96ada78666c214
2024-06-04 20:31:08 +00:00
Treehugger Robot
2e80918e75 Merge "Animate RecentsView when rotating in fake orientations" into main 2024-06-04 19:05:05 +00:00
Uwais Ashraf
5580144d6b Animate RecentsView when rotating in fake orientations
Test: Manual - animations
Bug: 336704871
Flag: EXEMPT bugfix
Change-Id: I80629128a0730ca85d0313d15af806ddf840e82b
2024-06-04 17:27:59 +00:00
Jagrut Desai
e263730c1e Merge "Make Taskbar Divider PopUp Menu Width Dynamic" into main 2024-06-04 17:13:36 +00:00
Alina Zaidi
c40cf8674b Merge "Add transition source for DesktopMode enter transition event originating from AppIcon press in overview" into main 2024-06-04 17:09:01 +00:00
Jordan Silva
a3b66f59c2 Fix split snapshot broken after rotating in fake orientation
This CL replaces the live tile with the snapshot after rotating in fake orientation. The animateRotation function was created to extract the rotation logic to guarantee that switchToScreenshot call will only happen when there is a running task.

Fix: 326410493
Flag: EXEMPT bug fix
Test: Manual. Instructions in the bug description.
Change-Id: I9d5e1b5ca803f8f8072702b37206a73b8d8a10ed
2024-06-04 17:48:07 +01:00
Alina Zaidi
f895a7b0bd Add transition source for DesktopMode enter transition event originating
from AppIcon press in overview

Test: Updated unit tests
Flag: EXEMPT not a major feature/ user visible change
Bug: b/326231756

Change-Id: I9e53cd3ec41dd2475ba90ea8fab2fb7a90f5e158
2024-06-04 13:12:04 +00:00
Jordan Silva
bf5e19fcb1 Merge "Adding logs to monitor OverviewCommandHelper" into main 2024-06-04 12:49:12 +00:00
Jordan Silva
11afae1bc9 Adding logs to monitor OverviewCommandHelper
This CL adds some logs to help analyzing why recents button with 3 button navigation sometimes don't open Overview.

Bug: 337954957
Test: NONE
Flag: EXEMPT Adding logs to debug issue
Change-Id: I44a799319eca667b04d4e78a38ade796fc3b69fb
2024-06-04 11:16:01 +01:00
Fengjiang Li
018074351c Animate -1 to recents
Fix: 343770316
Test: manual - record a video
Flag: com.android.launcher3.use_activity_overlay
Change-Id: I74346f060ea93dbc8fc0a1c3290d4996d89ec062
2024-06-03 12:59:48 -07:00
Liran Binyamin
ba732a77a1 Merge "Fix bubble bar and handle visibility on first bubble" into main 2024-06-03 19:49:26 +00:00
Ats Jenk
1507a2c59e Merge "Fix bubble position when dragged to dismiss view" into main 2024-06-03 18:30:59 +00:00
Liran Binyamin
273f9ec487 Fix bubble bar and handle visibility on first bubble
When the animation of the first bubble is suppressed, immediately
stash or show the bubble bar to make sure it has been initialized
correctly.

Also we no longer automatically update the bubble bar visibility
based on its alpha value, since we're managing alpha and visibility
ourselves.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 343505267
Fixes: 343502240
Test: manually verified state for the following scenarios for the first bubble
       - in app when keyboard is open
       - in app -> open shade
       - in app -> lock device
       - on home -> open shade
       - on home -> lock device
       - in overview -> open shade
Test: manually sanity tested to make sure animations for more bubbles still work
Test: manual
       - Open test bubble app
       - Open keyboard and send a bubble
       - The bubble should animate using a HUN since the keyboard is open
       - Swipe back to hide the keyboard
       - Observe that the bubble bar no longer shows to stash into the handle
Change-Id: I754a5a9c8e961af0cdd5ccadf83d3081d4414c7e
2024-06-03 13:27:48 -04:00
Jagrut Desai
38478e74f9 Make Taskbar Divider PopUp Menu Width Dynamic
Test: Manual
Bug: 327647761
Flag: com.android.launcher3.enable_taskbar_pinning
Change-Id: Ib5c13324afee46b45b2c71e3af86c15a6384a278
2024-06-03 10:26:41 -07:00
Alex Chau
5e102e4994 Handle uiMode changes in QuickstepLauncher
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity and RecentsActivity
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is affected when driving mode changes, so a recreation is ujnnecessary
- Light/dark mode changes still causes Launcher to create as expected

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly
Flag: EXEMPT bugfix
Change-Id: I3d52f0625b580a5b5a1ddbbb487c271a4bb0152b
2024-06-03 12:24:30 +01:00